| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2019-01-09 | |||
| 16:40:21 | gibi | dansmith: sure. I just didn't thought that having the doc patch up is a prerequisit to approve the bp | |
| 16:40:24 | kashyap` | Yeap | |
| 16:40:35 | dansmith | gibi: that was the original answer, IIRC :) | |
| 16:40:44 | dansmith | note that tomorrow is the early meeting so I won't be around anyway | |
| 16:41:18 | kashyap` | dansmith: If it soothes your nerves, FWIW, Martin Schuppert from TripleO independently tested this patch and showed me evidence | |
| 16:41:22 | kashyap` | (Which matches mine.) | |
| 16:41:55 | dansmith | kashyap`: nope, all I want to see is docs :) | |
| 16:42:02 | gibi | dansmith: :) | |
| 16:42:46 | kashyap` | dansmith: Sure. It's already there :-) Getting it polished a bit | |
| 16:43:21 | melwitt | ah right, tomorrow's meeting is at 6am for us so I won't be around yet either | |
| 16:43:28 | kashyap` | The high-level thing is: (a) Installer needs to setup all the TLS env; (b) Only _then_ this feature makes sense. | |
| 16:44:02 | dansmith | melwitt: yeah, so let's just see the docs rendered in a patch, and then we can sign off on the blueprint, independent of the meeting | |
| 16:44:24 | melwitt | dansmith: sure, sounds like a plan | |
| 16:45:26 | melwitt | gibi ^ | |
| 16:46:02 | melwitt | thanks for helping to get this sorted out | |
| 16:46:13 | gibi | melwitt: works for me | |
| 16:46:24 | gibi | melwitt: I've reviewed the implementation too and looks good to me | |
| 16:46:49 | melwitt | great, thanks for that | |
| 16:49:55 | melwitt | gibi: a note on the bandwidth aware scheduling hangout meeting, I think mriedem had said he'd rather not have the meeting on the 14th, his first day back, if that is possible | |
| 16:50:16 | gibi | melwitt: sure, I can move that to Tuesday if that is better | |
| 16:50:39 | gibi | melwitt: what do you think, 17:00 UTC would work for the team? | |
| 16:51:39 | melwitt | gibi: he didn't mention specific favorable days, but I expect tuesday should be better. and I expect 1700 UTC should work | |
| 16:52:01 | gibi | melwitt: thanks, I will send and update to the ML | |
| 16:52:07 | melwitt | ok, thanks | |
| 16:53:32 | kashyap` | Thanks, folks! | |
| 16:54:02 | kashyap` | I'll get some dinner, and then get the rendering going. I'm writing some Nova-specific context. Because most people would use installer tools to take care of all the CA setup | |
| 16:54:37 | melwitt | ok, thanks kashyap` | |
| 17:31:45 | openstackgerrit | sean mooney proposed openstack/nova master: [WIP] libvirt: auto detach/attach sriov ports on migration https://review.openstack.org/629589 | |
| 17:41:54 | openstackgerrit | Stephen Finucane proposed openstack/nova stable/queens: Fail to live migration if instance has a NUMA topology https://review.openstack.org/629597 | |
| 18:11:47 | sean-k-mooney | adrianc: by the way this https://review.openstack.org/#/c/609166/4 is not needed an i can abandon it right | |
| 18:14:03 | adrianc | sean-k-mooney: yep, you can abandon | |
| 18:14:17 | sean-k-mooney | cool its replaced by the code in https://review.openstack.org/#/c/619929/7 | |
| 18:15:29 | kashyap | Any rST gurus here, what is wrong here? | |
| 18:15:58 | kashyap | Assuming a doc called 'live-migration-usage.rst' exists, if I do: "Refer to the :doc:`live-migration-usage`" from another .rst doc, it should Just Work? | |
| 18:16:02 | sean-k-mooney | kashyap: i just ask stephenfin | |
| 18:16:30 | sean-k-mooney | kashyap: im not sure if you need to use a relivie path | |
| 18:16:33 | stephenfin | kashyap: the path is relative, so if it's in the same directory, yes | |
| 18:16:39 | stephenfin | otherwise get those dots out | |
| 18:16:47 | adrianc | sean-k-mooney: yes, also noticed you added a commit for the direct mode, ill take a look tomorrow | |
| 18:16:57 | stephenfin | adrianc: been reviewing all those. On the last one | |
| 18:17:10 | stephenfin | adrianc: Mostly +2 except for minor changes, mostly nits | |
| 18:17:13 | stephenfin | just fyi :) | |
| 18:17:18 | kashyap | stephenfin: You mean get those colons out, if it's (it is) in the same dir? | |
| 18:17:36 | sean-k-mooney | adrianc: ya its still a work in progress ill need to test it properly tomorrow and then add unit tests and a release note | |
| 18:17:43 | adrianc | stephenfin: :) great! | |
| 18:17:47 | kashyap | - Refer to the :doc:`live-migration-usage` | |
| 18:17:47 | kashyap | Is this the `diff`? | |
| 18:17:48 | kashyap | + Refer to the doc`live-migration-usage` | |
| 18:17:48 | stephenfin | kashyap: heh, no. :doc:`../live-migration-usage` (if not same directory) | |
| 18:18:03 | kashyap | It _is_ in the same dir | |
| 18:18:03 | stephenfin | :doc:`path` is correct | |
| 18:18:07 | stephenfin | then you're good | |
| 18:18:49 | kashyap | secure-live-migration-with-qemu-native-tls.rst:138: (ERROR/3) Unknown interpreted text role "doc". | |
| 18:18:49 | kashyap | $> rst2html secure-live-migration-with-qemu-native-tls.rst foo.html | |
| 18:18:49 | kashyap | stephenfin: Hmm, but look: | |
| 18:19:01 | kashyap | That's the _only_ error between me and dinner. | |
| 18:19:11 | stephenfin | doc8? | |
| 18:19:17 | stephenfin | Ignore it, if so | |
| 18:19:35 | stephenfin | doc8 uses docutils, which doesn't know about doctrees and therefore doesn't have a doc role | |
| 18:19:48 | stephenfin | doctrees are a purely Sphinx thing | |
| 18:20:33 | kashyap | Aah, so it should be fine. | |
| 18:20:48 | stephenfin | yup, all good | |
| 18:21:25 | kashyap | Thanks! | |
| 18:43:49 | openstackgerrit | Kashyap Chamarthy proposed openstack/nova master: docs: Secure live migration with QEMU-native TLS https://review.openstack.org/629627 | |
| 18:45:48 | kashyap | melwitt: dansmith ^ First cut | |
| 18:45:59 | dansmith | cool | |
| 18:46:21 | melwitt | kashyap: thanks | |
| 18:46:31 | dansmith | I expect a review from stephenfin on that too | |
| 18:46:46 | dansmith | which will yield a $number_of_lines count of nit changes | |
| 18:47:19 | dansmith | I found an issue in the first line already :P | |
| 18:47:22 | kashyap | Haha, yeah. Happy to get stephenfin's rST eyes | |
| 18:47:35 | kashyap | dansmith: What is it? | |
| 18:47:46 | dansmith | kashyap: you have to wait :) | |
| 18:48:00 | kashyap | Nerves are wracking, dammit. I go better eat | |
| 19:23:52 | openstackgerrit | Inbar Stolberg proposed openstack/nova master: Author: Inbar Stolberg https://review.openstack.org/629646 | |
| 19:42:54 | dansmith | kashyap fails the build | |
| 19:43:00 | dansmith | some index thing, I'm sure stephenfin knows | |
| 19:54:11 | melwitt | sean-k-mooney: I'm pretty sure anything that needs to add a flavor extra spec needs a spec https://blueprints.launchpad.net/nova/+spec/libvirt-disable-pmu-for-realtime-guests | |
| 19:54:39 | melwitt | any other opinions? | |
| 21:56:31 | openstackgerrit | Inbar Stolberg proposed openstack/nova master: Author: Inbar Stolberg https://review.openstack.org/629646 | |
| 22:33:35 | openstackgerrit | Jack Ding proposed openstack/nova master: [WIP] Flavor extra spec and image properties validation https://review.openstack.org/620706 | |
| 22:41:56 | openstackgerrit | Yongli He proposed openstack/nova-specs master: add spec "show-server-numa-topology" https://review.openstack.org/612256 | |
| 22:59:26 | openstackgerrit | Jack Ding proposed openstack/nova master: [WIP] Flavor extra spec and image properties validation https://review.openstack.org/620706 | |
| 23:03:24 | openstackgerrit | Inbar Stolberg proposed openstack/nova master: Fixes server rebuild if NumaTopologyFilter is used with CPU pinning https://review.openstack.org/629646 | |
| 23:03:38 | openstackgerrit | Jack Ding proposed openstack/nova master: [WIP] Flavor extra spec and image properties validation https://review.openstack.org/620706 | |
| #openstack-nova - 2019-01-10 | |||
| 00:28:37 | yonglihe | https://review.openstack.org/#/c/612255/12 | |
| 00:28:37 | yonglihe | alex_xu, small spec 'server group' is reviewed rounds, i worry it might need few more, we are so close to feature freeze, it's quite small. please put it on your work list | |
| 01:59:47 | openstackgerrit | Jie Li proposed openstack/nova master: Support volume-backed server rebuild in compute https://review.openstack.org/625893 | |
| 02:20:27 | openstackgerrit | Merged openstack/nova-specs master: add spec "show-server-numa-topology" https://review.openstack.org/612256 | |
| 02:22:59 | yonglihe | Thanks, Jay, alex_xu, i know this might be too pushy, it's run out of time, i wonder the server-group spec may also close enough. i'm here, could response quickly. | |
| 02:32:35 | openstackgerrit | Merged openstack/nova-specs master: Propose counting quota usage from placement and API database https://review.openstack.org/509042 | |
| 04:04:41 | openstackgerrit | Jack Ding proposed openstack/nova master: [WIP] Flavor extra spec and image properties validation https://review.openstack.org/620706 | |
| 05:47:29 | openstackgerrit | Hesam Chobanlou proposed openstack/nova master: nova.exception._clean_dict should use oslo_utils.strutils https://review.openstack.org/629769 | |
| 05:55:23 | openstackgerrit | Merged openstack/nova-specs master: Per-instance serial number (spec) https://review.openstack.org/612531 | |
| 08:13:30 | jangutter | ; | |
| 08:15:06 | jangutter | bauzas: thanks for the review on https://review.openstack.org/567148 - did I address your query, or should I amend the spec to explicitly state "no impact in this case"? | |
| 08:36:38 | openstackgerrit | Jie Li proposed openstack/nova master: Change compute api microversion to support for volume-backed server rebuild https://review.openstack.org/627518 | |
| 08:54:09 | kashyap | dansmith: Thanks for the review! | |
| 08:54:20 | kashyap | dansmith: Yeah, forgot the index thingie; will fix. | |
| 09:06:35 | openstackgerrit | Jie Li proposed openstack/nova master: Change compute api microversion to support for volume-backed server rebuild https://review.openstack.org/627518 | |