Earlier  
Later
New Search
Posted Nick Remark
#openstack-nova - 2018-08-10
15:17:36 leakypipes SteelyDan: which perf patch are we referring to? the "use simple code paths when possible" one?
15:17:51 SteelyDan leakypipes: the one that fried_rice put on the rc etherpad
15:17:55 SteelyDan I've since closed it
15:19:08 sean-k-mooney leakypipes: this one https://review.openstack.org/#/c/590388/
15:20:56 leakypipes sean-k-mooney: ack. I'm not going to get into the conversation about what should go in RC/stable/whatevs. That patch reduces the scheduling time for a common request for CPU, RAM and disk by around 300%. I think it's good as is but I've given up arguing about releases and RCs and whatnot.
15:21:49 leakypipes sean-k-mooney: I'm more than comfortable if it goes in to an RC or if it doesn't. really won't bother me either way.
15:22:34 sean-k-mooney leakypipes: o really just looking at it now.
15:23:01 sean-k-mooney i take it its just avoiding a lot of work id did not need to do in the simple cases
15:24:01 leakypipes sean-k-mooney: correct.
15:26:03 sean-k-mooney cool well im going to switch to my other laptop and see if i can get triplo to finish deploying in vms...
15:26:19 sean-k-mooney o/
15:30:31 leakypipes sean-k-mooney: sorry, it's technically a 70% decrease in runtime.
15:30:49 mriedem hey party people
15:31:01 leakypipes sean-k-mooney: 3.69 seconds vs 1.10 seconds to perform the allocation candidates search for 1000 providers having inventory of CPU, RAM and disk
15:31:57 openstackgerrit Chris Dent proposed openstack/nova master: placement: ignore policy scope check failures if not enforcing scope https://review.openstack.org/590445
15:32:32 sean-k-mooney leakypipes: clearly you should repeat the calulation 2 more times just to be sure .
15:32:51 sean-k-mooney you would still finish faster :)
15:32:56 leakypipes heh
15:33:19 fried_rice mriedem: O hey mon, we took over ---^ because we thought you were out til at least Monday
15:34:02 mriedem where is dan?
15:34:09 leakypipes I was thinking of ((1.10-3.69)/1.10)*100 which would be ~235% increase in time. But the percentage decrease from 3.69 -> 1.10 is ((3.69-1.10)/3.69)*100 is ~70% decrease in time
15:34:17 melwitt mriedem: SteelyDan
15:34:53 mriedem oh
15:35:01 mriedem SteelyDan: got that vif plug timeout to 30 seconds, hit it here http://logs.openstack.org/08/553608/11/check/neutron-tempest-linuxbridge/992de45/logs/screen-n-cpu.txt.gz#_Aug_10_13_45_47_903132
15:35:09 mriedem that's a timeout before the guest transfer completed
15:35:34 openstackgerrit Merged openstack/nova master: block_device: Rollback volumes to in-use on DeviceDetachFailed https://review.openstack.org/590439
15:35:35 mriedem but it still completes http://logs.openstack.org/08/553608/11/check/neutron-tempest-linuxbridge/992de45/logs/screen-n-cpu.txt.gz#_Aug_10_13_46_13_027466
15:35:43 openstackgerrit Merged openstack/nova master: Nix 'new in 1.19' from 1.19 sections for rp aggs https://review.openstack.org/590389
15:35:55 SteelyDan yeah I saw all the comments
15:36:13 mriedem this time was a bit different, more realistic but yeah
15:36:20 mriedem either way it validates what we expected to happen
15:36:27 SteelyDan yup
15:36:28 mriedem lyaaaaaarwood: are you going to push backports for https://review.openstack.org/#/c/590439/ ?
15:36:36 mriedem SteelyDan: you going to touch up that reno?
15:36:44 mriedem or are we waiting for sahid yet? he's on PTO
15:36:46 SteelyDan mriedem: oh yeah, forgot but I can
15:36:57 mriedem lemme -1 stat pad quick
15:37:15 SteelyDan personally I'd rather see this go in so we have soak on the changes to the driver, even though we won't exercise the waiting code
15:37:17 lyaaaaaarwood mriedem: yup will do
15:37:27 openstackgerrit Lee Yarwood proposed openstack/nova stable/rocky: block_device: Rollback volumes to in-use on DeviceDetachFailed https://review.openstack.org/590801
15:38:26 mriedem melwitt: now that we have a stable/rocky branch you get to create the stein series https://bugs.launchpad.net/nova
15:38:40 openstackgerrit Lee Yarwood proposed openstack/nova stable/queens: block_device: Rollback volumes to in-use on DeviceDetachFailed https://review.openstack.org/590803
15:38:41 melwitt ok
15:39:28 openstackgerrit Lee Yarwood proposed openstack/nova stable/pike: block_device: Rollback volumes to in-use on DeviceDetachFailed https://review.openstack.org/590804
15:39:44 melwitt mriedem: were you thinking of the DeviceDetachFailed one for rc2? from what I understand, we release rc2 from stable/rocky so we hold non-rc2 things until after the final rocky release deadline
15:40:55 mriedem melwitt: we can, but it's also extremely low risk
15:41:00 mriedem and we'll backport it anyway
15:41:13 melwitt ok, just making sure I understood
15:42:01 SteelyDan that one is a regression so it makes sense anyway right?
15:42:17 melwitt mriedem: I thought we already have a stein series? https://launchpad.net/nova/stein
15:42:38 mriedem SteelyDan: yes it is, and we also backported it to queens and pike
15:42:41 mriedem so it's going back either way
15:43:02 SteelyDan yeah
15:43:11 mriedem melwitt: hmm, bugs marked against rocky are marked as fixed even though these 2 aren't yet
15:43:16 mriedem might be the dev focus setting
15:43:23 melwitt \:|
15:43:57 mriedem melwitt: change stein status to active dev
15:44:02 mriedem and rocky to current stable or whatever
15:44:19 melwitt oh I see
15:44:24 mriedem and dev focus = stein
15:44:52 mriedem we can also mark r3 and rc1 as released in https://launchpad.net/nova/rocky and add a nrc2
15:44:53 melwitt got the dev focus. looking for the current stable setting
15:45:04 mriedem that's on the rocky one
15:45:07 mriedem change the status
15:45:29 melwitt oh thanks. got it
15:46:01 mriedem eventually you'll want to register milestones for stein as well
15:46:11 mriedem based on the stein release schedule
15:46:16 melwitt ok
15:46:29 mriedem i don't think any of this is written down anywhere,
15:46:42 mriedem i never bothered to since it's once every 6 months and it's pretty straight-forward
15:48:58 melwitt hm, looks like I need to update the release notes link for rocky in openstack/releases
15:49:05 mriedem in other news, the guy in the row in front of me ate, i'm pretty sure, at least 4 mcdonalds breakfast sandwiches and now the entire back half of the plane smells like greasy sausage and biscuit
15:49:20 mriedem melwitt: yup - you can do that once we cut stable/rocky
15:49:38 melwitt stable/rocky has been cut automatically because of rc1
15:49:43 mriedem right
15:49:47 melwitt oh
15:49:59 mriedem *you can do that now
15:50:07 mriedem i always 2-stepped that
15:50:25 melwitt what's the benefit of 2-stepping it?
15:50:27 mriedem because i don't think the docs link exists until after the branch is created
15:50:33 melwitt ah, ok
15:50:46 mriedem you could also work in smcginnis' marketing speak edits on the highlights
15:50:51 openstackgerrit Dan Smith proposed openstack/nova master: Revert "libvirt: slow live-migration to ensure network is ready" https://review.openstack.org/590538
15:51:18 melwitt k
15:53:28 mriedem SteelyDan: +2
16:00:44 melwitt mriedem: release note link and marketing speak proposed https://review.openstack.org/590812
16:02:43 melwitt I set queens from "current stable release" => "supported" also
16:05:39 mriedem yeah good idea
16:07:32 openstackgerrit Eric Fried proposed openstack/nova master: Adds a test for _get_provider_ids_matching() https://review.openstack.org/590150
16:07:33 openstackgerrit Eric Fried proposed openstack/nova master: placement: use simple code paths when possible https://review.openstack.org/590388
16:07:34 openstackgerrit Eric Fried proposed openstack/nova master: split gigantor SQL placement query into multiple https://review.openstack.org/590041
16:08:01 mdb007h Just reviewing https://review.openstack.org/#/c/504885/8 . Do we run the db migration check functional tests against a real mysql db in any CI job?
16:14:43 mriedem melwitt: commnts on that release patch
16:15:08 melwitt ok
16:18:44 melwitt I had thought I needed to make that change to *create* the docs at the rocky link. how wrong I was
16:23:37 openstackgerrit Matt Riedemann proposed openstack/nova master: Revert "libvirt: add method to configure migration speed" https://review.openstack.org/590814
16:24:14 mriedem might want to ask clarkb when those get generated from stable
16:24:17 mriedem or doug
16:24:43 melwitt ok
16:24:51 mriedem i bet we're missing a patch https://github.com/openstack/nova/blob/master/releasenotes/source/index.rst

Earlier   Later