Earlier  
Later
New Search
Posted Nick Remark
#openstack-nova - 2018-04-25
14:58:12 stephenfin dansmith: Any hints about why this could be happening? http://paste.openstack.org/show/719928/
14:58:22 kashyap s/snids/snide/
14:58:35 stephenfin It seems to be caused by this line in o.vo https://github.com/openstack/oslo.versionedobjects/blob/master/oslo_versionedobjects/base.py#L65-L66
14:58:47 dansmith stephenfin: well, it means you don't have a context on that object
14:58:58 dansmith and you're trying to lazy-load .network_requests
14:59:15 stephenfin dansmith: But it doesn't happen for the numa_topology object which is defined the exact same way
14:59:55 dansmith stephenfin: I dunno what to say.. that ^ is the exact reason
15:00:15 dansmith either give it a context if it needs to be able to lazy-load, or make sure .network_requests is set to something
15:01:18 stephenfin Oh, that latter would do it. numa_topology is defined to something https://github.com/openstack/nova/blob/master/nova/tests/unit/compute/test_resource_tracker.py#L1853
15:01:29 openstackgerrit Aditya Vaja proposed openstack/nova master: remove IVS plug/unplug as they're moved to separate plugin https://review.openstack.org/534371
15:04:19 stephenfin dansmith: Yup, 'instance.network_requests = None' did the job. Thanks :)
15:04:26 dansmith stephenfin: cool
15:06:41 kashyap When someone gets a moment, is there a better / effficient way to test a config in Gate than this DevStack patch: http://paste.openstack.org/show/719929/
15:13:57 kashyap So the above should work; the fine folks on #openstack-qa confirmed
15:14:44 openstackgerrit sahid proposed openstack/nova-specs master: fix blueprint related to the spec overhead-pin-set https://review.openstack.org/561916
15:15:23 openstackgerrit Simon Dodsley proposed openstack/nova master: Add enhanced KVM storage QoS quotas https://review.openstack.org/558530
15:24:02 dansmith tssurya: mriedem melwitt: do we need a cells meeting today?
15:25:59 mriedem i don't
15:26:07 melwitt I don't have anything for today
15:26:12 tssurya belmoreira : ^
15:27:13 belmoreira we are upgrading to cellsV2 today... tomorrow I will have some info about it
15:27:22 tssurya dansmith: yea its okay to skip today then
15:27:42 dansmith wow, that's .. quite a statement :)
15:35:25 openstackgerrit Chris Dent proposed openstack/nova master: Make accept-language tests work with webob 1.8.x https://review.openstack.org/564255
15:37:04 openstackgerrit Sylvain Bauza proposed openstack/nova master: libvirt: fix hard reboot issue with mdevs https://review.openstack.org/564257
15:40:23 cdent melwitt: ^^ is the short term fix to the webob issues. should keep us for a while, but I've noted in the commit and on the bug that there's a long term need too
15:41:40 melwitt cdent: okay, thanks
15:43:57 melwitt reminder for the cells subteam, review would be appreciated on this fix for anti/affinity with multiple cells https://review.openstack.org/540258
15:45:12 melwitt cdent: curiosity question, why does q=1.1 not work if q=0.5 works? https://review.openstack.org/#/c/564255/1/nova/tests/unit/api/openstack/test_wsgi.py@102
15:45:45 cdent melwitt: oh sorry, the change of 1.1 to 1 was not supposed to be committed
15:45:46 cdent will tidy that
15:46:00 melwitt ah k
15:46:09 cdent that was part of several different loops around the problem
15:46:26 cdent the fact that the new invalid header class exists now really makes stuff a lot harder to debug :(
15:47:18 melwitt oh, I see. so it makes everything do an AttributeError instead of complaining about the invalid things
15:47:32 bauzas dansmith: mriedem: stephenfin: others: because of me, hard reboot no longer accepts to recreate a libvirt guest, but I fixed that by https://review.openstack.org/564257
15:47:37 melwitt (in the test situation)
15:47:50 bauzas throw me tomatoes if you wish
15:48:06 cdent melwitt: the tests all end up getting None instead of the desire result
15:48:07 bauzas dansmith: mriedem: stephenfin: others: it'll also be a backport for Queens
15:48:27 cdent an invalid header operates as basically a header with no values
15:48:44 melwitt okay. I thought the lack of 'best_match' might have been because an invalid header was created. ignore me
15:48:58 cdent melwitt: ah, also: 1.1 is invalid too
15:49:10 cdent the valid range is 0 to 1
15:49:17 melwitt oh, I had no idea
15:49:31 cdent I can update the commit message to make that more clear?
15:49:51 melwitt meh it's fine. I was just curious when I saw it
15:49:58 cdent ✔
16:06:46 jaypipes mriedem, cdent: for the api-ref, what's the process for changing the documentation for a particular qstring parameter when that parameter was added in a prior microversion?
16:07:32 jaypipes mriedem, cdent: ref this patch: https://review.openstack.org/#/c/561315/
16:08:11 efried jaypipes: In this case, I would add to the existing parameter entry. Let me find an example...
16:08:37 jaypipes mriedem, cdent: I see existing things in the api-ref like resource_provider_generation_1_19, etc. but is there a magic incantation to show a different description for a parameter once a specific microversion is reached?
16:08:55 cdent min_version
16:08:56 efried jaypipes: What do you mean "reached"?
16:09:23 jaypipes efried: sorry, I'm having trouble explaining this..
16:09:24 efried jaypipes: But you're talking about member_of behaving differently at version Y than version X
16:09:29 cdent but what efried is saying is generally true for cases where the parameter is already around: add to the description "in microversion x you can do y"
16:09:33 efried https://developer.openstack.org/api-ref/placement/#list-allocation-candidates - see the `required` option.
16:09:37 jaypipes efried, cdent: yeah, what you just said eric :)
16:10:14 efried jaypipes: `required` uses both min_version (1.17) and an inline note about the additional functionality in 1.22.
16:10:39 efried jaypipes: So member_of will be similar. min_version 1.3, then new functionality in 1.2x
16:10:56 jaypipes efried: gotcha. inline note in the description field, then?
16:11:07 efried jaypipes: Yup
16:12:07 jaypipes efried: ok, thank you.
16:12:45 mriedem i've seen it both ways,
16:13:10 mriedem but yeah usually if the type doesn't change, we'd just add something to the parameter description saying, "starting with x, you can do foobars"
16:13:34 efried jaypipes: allocation_candidates_required and resource_provider_required_query are the ones cdent updated for forbidden traits.
16:13:46 mriedem in 2.53 we changed the id field in os-services and os-hypervisors from an integer to a string (uuid) so in that case we have 2 parameters in the table, one capped at 2.52 and one new for 2.53
16:13:55 openstackgerrit Sylvain Bauza proposed openstack/nova master: libvirt: fix hard reboot issue with mdevs https://review.openstack.org/564257
16:14:04 mriedem https://developer.openstack.org/api-ref/compute/#id377
16:15:25 bauzas mriedem: thanks for the quick review on https://review.openstack.org/564257, new patch is up
16:16:28 mriedem bauzas: i just -1ed it again :)
16:17:14 mriedem i'm going to crack down on your usage of "that"
16:17:20 mriedem it's gotten out of hand
16:17:31 jaypipes mriedem: that is indeed that case.
16:17:46 jaypipes mriedem: and thx for the example on the api-ref. appreciated!
16:23:06 openstackgerrit Chris Dent proposed openstack/nova master: WIP: Ensure that os-traits sync is attempted only at start of process https://review.openstack.org/553857
16:35:49 openstackgerrit Eric Fried proposed openstack/nova master: Bump pypowervm minimum to 1.1.15 https://review.openstack.org/564276
16:37:10 efried edmondsw, esberglu: ^
16:41:07 openstackgerrit Merged openstack/nova-specs master: fix blueprint related to the spec overhead-pin-set https://review.openstack.org/561916
16:46:54 openstackgerrit Jay Pipes proposed openstack/nova master: support multiple member_of qparams https://review.openstack.org/561315
17:01:10 openstackgerrit Merged openstack/nova master: Fix invalid UUIDs in test https://review.openstack.org/564190
17:05:04 openstackgerrit Matt Riedemann proposed openstack/nova master: Wait for network-vif-plugged before starting live migration https://review.openstack.org/558001
17:05:05 openstackgerrit Matt Riedemann proposed openstack/nova master: Add check if neutron "binding-extended" extension is available https://review.openstack.org/523548
17:05:06 openstackgerrit Matt Riedemann proposed openstack/nova master: Add "bind_ports_to_host" neutron API method https://review.openstack.org/523604
17:05:07 openstackgerrit Matt Riedemann proposed openstack/nova master: Add "delete_port_binding" network API method https://review.openstack.org/552170
17:05:08 openstackgerrit Matt Riedemann proposed openstack/nova master: Add "activate_port_binding" neutron API method https://review.openstack.org/555947
17:05:09 openstackgerrit Matt Riedemann proposed openstack/nova master: Delete port bindings in setup_networks_on_host if teardown=True https://review.openstack.org/556333
17:05:10 openstackgerrit Matt Riedemann proposed openstack/nova master: Implement migrate_instance_start method for neutron https://review.openstack.org/556334
17:05:11 openstackgerrit Matt Riedemann proposed openstack/nova master: Add VIFMigrateData object for live migration https://review.openstack.org/515423
17:05:12 openstackgerrit Matt Riedemann proposed openstack/nova master: libvirt: use dest host vif migrate details for live migration https://review.openstack.org/551370
17:05:13 openstackgerrit Matt Riedemann proposed openstack/nova master: WIP: compute: use port binding extended API during live migration https://review.openstack.org/551371
17:05:14 openstackgerrit Matt Riedemann proposed openstack/nova master: Port binding based on events during live migration https://review.openstack.org/434870
17:05:15 openstackgerrit Matt Riedemann proposed openstack/nova master: conductor: use port binding extended API in during live migrate https://review.openstack.org/522537
17:06:11 openstackgerrit Matt Riedemann proposed openstack/nova master: libvirt: fix hard reboot issue with mdevs https://review.openstack.org/564257
17:28:50 openstackgerrit Balazs Gibizer proposed openstack/nova master: Transform missing delete notifications https://review.openstack.org/410297
17:28:51 openstackgerrit Balazs Gibizer proposed openstack/nova master: Send soft_delete from context manager https://review.openstack.org/476459
17:43:39 openstackgerrit Merged openstack/nova master: Address issues raised in adding member_of to GET /a-c https://review.openstack.org/554357
17:49:09 esberglu mriedem: Was working with efried an we aren't sure how this is working for the ironic driver
17:49:11 esberglu https://review.openstack.org/#/c/526094/46/nova/virt/powervm/driver.py@545

Earlier   Later