Earlier  
Posted Nick Remark
#openstack-nova - 2018-01-30
10:28:10 openstackgerrit Stephen Finucane proposed openstack/nova master: Ensure emulator threads are always calculated https://review.openstack.org/537363
10:28:11 openstackgerrit Stephen Finucane proposed openstack/nova master: Add unit tests for EmulatorThreadsTestCase https://review.openstack.org/538699
10:28:11 openstackgerrit Stephen Finucane proposed openstack/nova master: trivialfix: cleanup _pack_instance_onto_cores() https://review.openstack.org/538698
10:28:12 openstackgerrit Stephen Finucane proposed openstack/nova master: Not use thread alloc policy for emulator thread https://review.openstack.org/538700
10:37:20 openstackgerrit Kashyap Chamarthy proposed openstack/nova master: [WIP] libvirt: Allow to specify granular CPU feature flags https://review.openstack.org/534384
10:39:16 Spazmotic thanks bauzas :D
10:39:44 bauzas Spazmotic: not a firm -1, just general advice for maintenability
10:39:52 bauzas I need to disappear now
10:39:57 Spazmotic Understandable, i'll get it fixed soon
10:40:08 bauzas cool
10:43:54 Spazmotic super appreciate it and great advice, thanks again bauzas. Doesn't sound harsh at all, great ideas.
10:44:02 Spazmotic Enjoy your disappearing
11:05:04 openstackgerrit Naichuan Sun proposed openstack/nova master: VGPU: Modify the example of vgpu white_list set https://review.openstack.org/539183
11:18:55 openstackgerrit Tetsuro Nakamura proposed openstack/nova master: [libvirt] Add _get_vcpu_realtime_scheduler() https://review.openstack.org/527630
11:18:56 openstackgerrit Tetsuro Nakamura proposed openstack/nova master: [libvirt] Add _get_numa_memnode() https://review.openstack.org/529906
11:18:56 openstackgerrit Tetsuro Nakamura proposed openstack/nova master: [libvirt] Add _get_XXXpin_cpuset() https://review.openstack.org/527631
11:18:57 openstackgerrit Tetsuro Nakamura proposed openstack/nova master: Add NumaTopology support for libvirt/qemu driver https://review.openstack.org/530451
11:18:57 openstackgerrit Tetsuro Nakamura proposed openstack/nova master: disable cpu pinning with libvirt/qemu driver https://review.openstack.org/531049
11:48:55 openstackgerrit Tetsuro Nakamura proposed openstack/nova master: [libvirt] Filter hypervisor_type by virt_type https://review.openstack.org/531347
11:48:55 openstackgerrit Tetsuro Nakamura proposed openstack/nova master: Fix hypervisor_type in /os-hypervisors/details https://review.openstack.org/531328
12:27:31 gibi seem that the novnc package is broken on the gate: http://logstash.openstack.org/#dashboard/file/logstash.json?query=message%3A%5C%22Unable%20to%20correct%20problems%2C%20you%20have%20held%20broken%20packages%3A%5C%22
12:27:50 gibi http://logs.openstack.org/53/512553/5/check/tempest-full/ac042d5/job-output.txt.gz#_2018-01-30_09_50_23_127790
12:28:46 gibi infra knows about the problem
12:32:08 cdent infra is the all seeing eye
13:06:18 jaypipes good morning supernovas
13:09:03 jaypipes stephenfin: mornin, mate.
13:10:19 gibi jaypipes: good morning
13:10:41 jaypipes stephenfin: I'm presuming the many failures in functional test jobs in https://review.openstack.org/#/c/537361/ are actually not related to that patch..
13:10:47 jaypipes gibi: mornin :)
13:18:27 gibi jaypipes: the failures in ^^ are caused by a broken package: http://logs.openstack.org/61/537361/4/check/tempest-full/13f575b/job-output.txt.gz#_2018-01-30_11_20_19_108323
13:20:13 gibi jaypipes: infra knows about it http://eavesdrop.openstack.org/irclogs/%23openstack-infra/%23openstack-infra.2018-01-30.log.html#t2018-01-30T12:36:43
13:20:26 jaypipes gibi: got it. thank you sir.
13:31:41 stephenfin jaypipes: That would sounds correct, yes
13:31:54 stephenfin Wow, the gate is not happy
13:33:26 stephenfin jaypipes: Thanks for reviewing those too (y)
13:39:14 jaypipes stephenfin: no problemo.
13:46:42 izombie does running nova from virtual environment needs extra steps? few services aren't starting because nova-rootwrap is in virtualenv scope.
13:47:33 Spazmotic bauzas, was relaxing on the couch with the fiancee and think I realized what you wanted in your comments.. very elegant if my mind is correct here.. will commit it within the next few hours.
13:51:14 Spazmotic I'm concerned with utilizing the current iS_booted method but i definately do understand the desire not to double up on methodws. My plans was to follow the commitg with a deprecation of that and use the new one.. but instead can just change its name
14:06:16 ameeda jaypipes: can you please check this https://review.openstack.org/#/c/526900/, it has a lot of zuul failures , I think that is something wrong with zuul ?
14:07:03 bauzas Spazmotic: okay, no worries
14:07:20 Spazmotic exciting, I love your logic.. wanna go steady? :p
14:07:52 gibi ameeda: gate is broken
14:08:07 gibi ameeda: infra is working on it
14:08:39 Spazmotic Is there an infra channel btw?
14:10:20 gibi Spazmotic: #openstack-infra
14:10:26 Spazmotic Thank ya sir
14:11:39 ameeda gibi: thank you !
14:11:59 ameeda gibi: can you please review this for me ? https://review.openstack.org/#/c/528385/
14:19:01 Kvisle is it normal for nova-compute to use the public endpoint of the placement api, and not the internal one?
14:24:17 openstackgerrit Radoslav Gerganov proposed openstack/nova master: ProviderTree.new_child: parent is either uuid or name https://review.openstack.org/538264
14:25:23 cdent Kvisle: that's the default (for historical reasons) but you can configure it.
14:27:20 cdent Kvisle: os_interface is the old way, valid_interfaces is the new way
14:27:53 bauzas Spazmotic: also, I haven't commented on that, but you know that with Python you can't recursively call more than 30 times the same method by default, right ?
14:28:20 ameeda mriedem: please check my comment here https://review.openstack.org/#/c/528385/10
14:29:47 Kvisle cdent: thanks (starting queens I see)
14:29:55 ameeda mriedem: if you have questions please let me know
14:32:46 bauzas Spazmotic: oops, my bad, by default, it's 999 times
14:33:27 bauzas Spazmotic: http://paste.openstack.org/show/658017/
14:37:34 efried Kvisle: Yes; the old way is deprecated but will still work in Q.
14:41:18 openstackgerrit Ruby Loo proposed openstack/os-traits master: Add code hosting URL https://review.openstack.org/539224
14:48:27 openstackgerrit Takashi NATSUME proposed openstack/nova master: Transform live_migration_post_dest notification https://review.openstack.org/469784
14:50:15 mriedem ameeda: replied
14:53:23 efried jaypipes: Looks like I've got a unit test tweak to make, but otherwise the update_provider_tree series is now done and ready for review.
14:53:51 efried jaypipes: Realizing of course that it waits for Rocky; but we could land it early if it's already had a looksee.
14:55:00 rgerganov efried, which part of the series is for Rocky?
14:55:22 efried rgerganov: Well, that depends whether the six currently-approved patches ever make it through the gate.
14:56:01 efried https://review.openstack.org/#/c/533808/ is the current bottom of the whole series; it and the next five are approved and just waiting for zuul to stop being a dick.
14:56:46 efried Then starting with https://review.openstack.org/#/c/537648/ is what we would land early in Rocky.
14:57:10 efried rgerganov: Notably the piece that ties everything together and makes it so update_provider_tree is actually used.
14:57:27 efried Which is this one: https://review.openstack.org/#/c/520246/
14:57:27 rgerganov efried, so there is no chance to use this stuff in queens
14:57:39 mriedem we won't be merging anything probably until https://review.openstack.org/#/c/537933/ can merge
14:57:48 efried rgerganov: No. Not sure there was a chance of that anyway, considering we're past FF.
14:57:59 bauzas hold your breath, starting to look at the 47 new bugs
14:58:15 bauzas since the gate is super late, I won't review changes unless it's prioritary
14:58:18 mriedem bauzas: did you put up a patch for the vgpu feature support matrix change?
14:58:23 bauzas mriedem: not yet
14:58:33 bauzas mriedem: I can do it super quickly
14:58:45 bauzas but I was distracted by the infra issues
14:59:01 bauzas mriedem: I guess you're also planning to write a prelude ?
14:59:07 mriedem yes
14:59:20 bauzas cool
14:59:32 mriedem probably not this week
14:59:40 bauzas since I wasn't really present during Queens, the floor is yours
14:59:48 mriedem how gracious of you :)
14:59:58 bauzas I'm French
15:00:07 bauzas all French people are gracious and kind
15:00:13 mriedem ha
15:00:39 ameeda mriedem: replied
15:01:19 ameeda bauzas: you're right :)
15:02:28 bauzas I wish I would :)
15:06:20 Spaz-Work ugh I wish I saw this solution
15:06:25 Spaz-Work it's so much more elegant
15:06:56 Spaz-Work bauzas: can you clarity what the "unnecessary" comment was for?
15:09:28 bauzas Spaz-Work: you mean about the recursion limit ?
15:09:59 bauzas Spaz-Work: I was confused, I thought it was 30 times, so I was a bit concerned to see us looping over more than 30 devices
15:10:29 jaypipes efried: ack
15:10:37 bauzas but since it's 999 times by default, I think it's harmless unless the instance has crazy 999 volumes attached to it
15:12:55 Spaz-Work Ah I see.. I don't want to rewrite the method entirely too much and blow the scope of this commit.. but there's so man ythings in this driver that need attention paid to them

Earlier   Later