Earlier  
Later
New Search
Posted Nick Remark
#openstack-nova - 2017-08-08
18:57:43 jaypipes dansmith: still consuming resources on the node and that's acceptable.
18:58:03 dansmith jaypipes: yeah okay re-reading my scenario, I see that update would have excluded anything we in those states _and_ things we don't have running on our host I guess, the latter being the critical point
18:58:17 jaypipes right. I was just adding some log statements in there...
18:59:16 dansmith I'm not sure it's less confusing the way you have it written, but don't change it now
18:59:29 openstackgerrit Matt Riedemann proposed openstack/nova master: Add track_instance_changes note in disable_group_policy_check_upcall https://review.openstack.org/490627
18:59:30 openstackgerrit Matt Riedemann proposed openstack/nova master: doc: considerations before deploying multiple cells https://review.openstack.org/491885
19:00:50 cdent melwitt: you might take a look at gibi’s tests where he’s messing with resize to same host. that’s where a lot of the fiddling and discussion about make tests happy has happened: around ps4 on https://review.openstack.org/#/c/491529/
19:00:51 mriedem dansmith: posed a question in my own patch ^ for https://review.openstack.org/#/c/491885/ to how we'd best like to communicate the online data migrations not being multi-cell aware
19:01:26 melwitt thanks cdent
19:02:04 dansmith mriedem: I was thinking about this after you brought it up, but people can't have multiple cells worth of things needing migration, so I'm not sure we need to even say anything, right?
19:02:35 mriedem dansmith: because a new cell would be empty and we couldn't fallback to it anyway?
19:02:38 mriedem and new things would be in the api db
19:02:44 dansmith yeah
19:03:09 mriedem not for pike i suppose
19:03:30 mriedem the mention in the code review guide is probably legit though right? https://review.openstack.org/#/c/491885/1/doc/source/contributor/code-review.rst
19:04:21 dansmith mriedem: well, any data migration at all needs to consider multiple cells.. I guess that means we should make the runner thing arrange to run it against all cells
19:04:22 dansmith mriedem: but yeah
19:04:24 mriedem like say you deploy multiple cells in pike, start populating them, and then in queens we have some data migration to move something to the api db
19:04:38 dansmith mriedem: hopefully we're done with that pattern, but yeah
19:04:54 mriedem but i still have to move the bandwidth_usage table to the api db!
19:05:13 dansmith mriedem: redirect to trash can
19:05:47 openstackgerrit Merged openstack/nova master: Create reference subpage https://review.openstack.org/490994
19:05:47 mriedem ok i'll drop the thing in the layout page
19:06:38 openstackgerrit Merged openstack/nova master: doc: Add additional content to admin guide https://review.openstack.org/490952
19:08:24 openstackgerrit Matt Riedemann proposed openstack/nova master: doc: code review considerations for online data migrations https://review.openstack.org/491885
19:09:24 openstackgerrit Jay Pipes proposed openstack/nova master: remove provider allocs in confirm/revert resize https://review.openstack.org/488510
19:09:24 openstackgerrit Jay Pipes proposed openstack/nova master: placement: refactor healing of allocations in RT https://review.openstack.org/491850
19:09:25 openstackgerrit Jay Pipes proposed openstack/nova master: Resource tracker compatibility with Ocata and Pike https://review.openstack.org/491012
19:09:33 jaypipes dansmith, mriedem: k. ^^
19:10:26 toabctl oomichi, hey. could you have a look at https://review.openstack.org/#/c/398308/ please?
19:16:47 openstackgerrit Sean Dague proposed openstack/nova master: Create For End Users index section https://review.openstack.org/491785
19:20:37 openstackgerrit melanie witt proposed openstack/nova master: Claim and report zero root disk for boot-from-volume instances https://review.openstack.org/428505
19:20:37 openstackgerrit melanie witt proposed openstack/nova master: Request zero root disk for boot-from-volume instances https://review.openstack.org/428481
19:22:06 openstackgerrit Sean Dague proposed openstack/nova master: Create For End Users index section https://review.openstack.org/491785
19:22:16 openstackgerrit Sean Dague proposed openstack/nova master: Create For End Users index section https://review.openstack.org/491785
19:22:16 openstackgerrit Sean Dague proposed openstack/nova master: rework index intro to describe nova https://review.openstack.org/491834
19:22:17 openstackgerrit Sean Dague proposed openstack/nova master: Add For Operators section to front page https://review.openstack.org/491815
19:22:50 sdague well that was an interesting gerrit edge case
19:26:43 melwitt what happened
19:27:41 openstackgerrit Jackie Truong proposed openstack/nova master: Add trusted_certs to Instance object https://review.openstack.org/489408
19:32:20 melwitt mriedem: it looks like this is why we shouldn't need to call update_available_resource directly https://github.com/openstack/nova/blob/master/nova/compute/manager.py#L1138-L1144
19:33:31 mriedem melwitt: but you didn't stop the compute service, you just disabled it
19:33:35 mriedem and then re-enabled it
19:33:40 mriedem honestly i'm not even sure how that test is passing...
19:34:08 melwitt oh, right
19:34:16 melwitt it's magic!
19:34:33 mriedem i probably led you down a dark path
19:35:18 melwitt the path of dark magic
19:35:34 mriedem i'm a 10th level drow elf on the weekends
19:35:41 melwitt lol
19:37:10 openstackgerrit Eric Fried proposed openstack/nova master: Get auth from context for glance endpoint https://review.openstack.org/490057
19:37:40 melwitt I'm gonna check what happens with this test if I don't re-enable the service. if it doesn't fail then, something has changed
19:40:00 melwitt huh. I think something is afoot here
19:41:09 melwitt disabling the service must not be doing what I think it is
19:41:31 dansmith ?
19:41:31 dansmith it does very little.. what do you think it does
19:41:53 melwitt well, mriedem suggesting doing it to force a local delete. to make the "service.is_up()" return False
19:41:59 melwitt but it seems to be still considered up
19:42:09 dansmith that won't do it
19:42:15 melwitt *suggested. why do I keep using the wrong tense of every word
19:42:29 melwitt well hells bells
19:42:31 dansmith disabled is only checked by a scheduler filter to exclude hosts
19:42:56 melwitt is there a better way other than setting the update interval really low and sleeping? that's what I was doing before and that kinda sucks
19:43:14 dansmith yeah, that's not reasonable, IMHO
19:43:27 dansmith stop the service and tweak the updated_at on it
19:43:27 mriedem melwitt: i said force-down
19:43:28 mriedem not disable
19:43:43 mriedem force-down is what the api will check for is_up
19:43:44 dansmith will force down trigger a local delete?
19:43:45 melwitt but the code you linked to was doing a disable
19:43:52 melwitt gah
19:44:07 melwitt okay, lemme look at force-down then
19:44:54 dansmith ah yeah it will work
19:45:01 dansmith service_is_up() checks it and that's what api is using
19:45:18 dansmith you should kill the service first though,
19:45:25 melwitt sweet
19:45:26 dansmith to make sure you're not running periodics I think
19:45:34 melwitt thanks yall
19:45:53 mriedem let me -1 quick
19:45:54 mriedem for points
19:46:08 melwitt and to mess up jaypipes stats
19:48:27 mriedem melwitt: https://review.openstack.org/#/c/470578/3/nova/tests/functional/regressions/test_bug_1679750.py@31 was confusing
19:48:36 mriedem i said force down and then linked to gibi's thing which was disable
19:48:41 mriedem i guess i meant the same PUT /os-services API
19:48:47 mriedem it was an exercise for the reader
19:49:18 melwitt yeah, I got too excited about it and didn't put two and two together
19:49:34 mriedem well this is exciting stuff
19:50:10 melwitt yeah it is
19:50:34 mriedem ok here comes the placement scheduler interaction thingy
19:50:38 openstackgerrit Matt Riedemann proposed openstack/nova master: Mark max microversion for Pike in history doc https://review.openstack.org/491581
19:50:39 openstackgerrit Matt Riedemann proposed openstack/nova master: Add a prelude section for Pike https://review.openstack.org/491424
19:50:39 openstackgerrit Matt Riedemann proposed openstack/nova master: Add release note for shared storage known issue https://review.openstack.org/491582
19:50:40 openstackgerrit Matt Riedemann proposed openstack/nova master: doc: provide more details on scheduling with placement https://review.openstack.org/491900
20:00:24 openstackgerrit melanie witt proposed openstack/nova master: Add functional test for local delete allocations https://review.openstack.org/470578
20:00:50 melwitt gdi left a commented out line
20:01:55 openstackgerrit melanie witt proposed openstack/nova master: Add functional test for local delete allocations https://review.openstack.org/470578
20:05:38 openstackgerrit Eric Fried proposed openstack/nova master: Get auth from context for glance endpoint https://review.openstack.org/490057
20:06:43 openstackgerrit Matt Riedemann proposed openstack/nova master: Add release note for shared storage known issue https://review.openstack.org/491582
20:06:43 openstackgerrit Matt Riedemann proposed openstack/nova master: Mark max microversion for Pike in history doc https://review.openstack.org/491581
20:06:44 openstackgerrit Matt Riedemann proposed openstack/nova master: Add a prelude section for Pike https://review.openstack.org/491424

Earlier   Later