| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2017-06-30 | |||
| 03:05:05 | openstackgerrit | Chason Chan proposed openstack/python-novaclient master: switch to openstackdocstheme https://review.openstack.org/477757 | |
| 03:06:03 | openstackgerrit | Ghanshyam Mann proposed openstack/nova master: Add api-ref for os-quota-class-set APIs https://review.openstack.org/467938 | |
| 03:06:13 | gmann | alex_xu, sfinucan finally able to enable the network quota in sample file ^^ | |
| 03:06:59 | openstackgerrit | Ghanshyam Mann proposed openstack/nova master: Add api-ref for os-quota-class-set APIs https://review.openstack.org/467938 | |
| 03:11:44 | openstackgerrit | Ghanshyam Mann proposed openstack/nova master: Fix to return server groups quota in quota class set https://review.openstack.org/467999 | |
| 03:14:33 | openstackgerrit | Gao Yuan proposed openstack/nova master: Remove mox from nova.tests.unit.virt.test_block_device https://review.openstack.org/477904 | |
| 03:16:54 | openstackgerrit | Gao Yuan proposed openstack/nova master: Remove mox from nova.tests.unit.virt.test_block_device https://review.openstack.org/477904 | |
| 03:41:22 | openstackgerrit | Artom Lifshitz proposed openstack/nova master: DNM - testing devstack-version fix https://review.openstack.org/479127 | |
| 03:53:38 | openstackgerrit | Artom Lifshitz proposed openstack/nova master: DNM - testing devstack-version special chars ' " / \ [ ] { } $ https://review.openstack.org/479131 | |
| 04:17:39 | openstackgerrit | Artom Lifshitz proposed openstack/nova master: DNM - testing devstack-version fix / [ ] { } $ ' " \ https://review.openstack.org/479127 | |
| 04:56:12 | openstackgerrit | Artom Lifshitz proposed openstack/nova master: DNM - testing devstack-version fix / [ ] { } $ ' " \ https://review.openstack.org/479127 | |
| 04:56:19 | openstackgerrit | Gao Yuan proposed openstack/nova master: Remove mox from nova.tests.unit.virt.test_block_device https://review.openstack.org/477904 | |
| 05:08:49 | openstackgerrit | Naichuan Sun proposed openstack/nova master: xenapi: Exception Error logs shown in Citrix XenServer CI https://review.openstack.org/478437 | |
| 05:10:36 | openstackgerrit | Naichuan Sun proposed openstack/nova master: xenapi: Exception Error logs shown in Citrix XenServer CI https://review.openstack.org/478437 | |
| 05:55:16 | openstackgerrit | Artom Lifshitz proposed openstack/nova master: API support for tagged device attachment https://review.openstack.org/376021 | |
| 06:06:37 | openstackgerrit | Artom Lifshitz proposed openstack/nova master: API support for tagged device attachment https://review.openstack.org/376021 | |
| 06:31:48 | openstackgerrit | Alex Xu proposed openstack/nova master: Ensure the JSON-Schema covers the legacy v2 API https://review.openstack.org/479170 | |
| 06:35:42 | alex_xu | gmann: ^ found another bug | |
| 06:36:31 | alex_xu | I'm not sure how to test it | |
| 06:38:10 | artom | alex_xu, similar to how I've proposed https://review.openstack.org/#/c/430352/ to run api-samples against 2.latest, run them against 2.0 ^_^ | |
| 06:38:14 | artom | (only half-serious) | |
| 06:41:21 | alex_xu | artom: ah | |
| 06:42:16 | alex_xu | artom: currently we already running 2.0 on the api-samples test https://github.com/openstack/nova/blob/master/nova/tests/functional/api_sample_tests/api_sample_base.py#L69 | |
| 06:42:32 | alex_xu | but that didn't catch that bug | |
| 06:43:26 | alex_xu | one way is ensure the min_version is always start from the 2.0, but the current schema validation implementation didn't store the min/max version into anywhere, just pass into a inner function | |
| 06:46:34 | openstackgerrit | Jeremy Liu proposed openstack/python-novaclient master: Nova client should retry with Retry-After value https://review.openstack.org/447766 | |
| 06:48:29 | alex_xu | gmann: for https://review.openstack.org/#/c/461480/, actually it still works when ironic enabled, so I think the current way is right | |
| 06:50:35 | gmann | alex_xu, ohh, decorator ignore those validation for 2.0 ? | |
| 06:51:56 | alex_xu | gmann: yea, https://github.com/openstack/nova/blob/68bbddd8aea8f8b2d671e0d675524a1e568eb773/nova/api/validation/__init__.py#L68 | |
| 06:53:19 | gmann | alex_xu, humm :( but do not we have negative unit tests? and running for v2.0 | |
| 06:53:34 | gmann | alex_xu, i think we do not run unit tests for legacy_v2 right | |
| 06:53:52 | alex_xu | gmann: yes, we don't have unit tests for legacy v2 | |
| 06:54:10 | gmann | alex_xu, how you catch those? | |
| 06:54:43 | gmann | alex_xu, how about running complete unit tests for legacy_v2 also like we run sample function tests for v2.0_comp and v2.1 | |
| 06:55:06 | alex_xu | gmann: when review this https://review.openstack.org/#/c/376021/76/nova/api/openstack/compute/attach_interfaces.py@102, thanks to matt pointed that out in early review, otherwise I'm still missing that... | |
| 06:55:23 | alex_xu | gmann: that sounds a huge work | |
| 06:55:36 | gmann | alex_xu, oh nice catch. | |
| 06:56:22 | alex_xu | gmann: for sample tests, we add scenario for v2.0, that is easy. | |
| 06:56:31 | gmann | alex_xu, may be with ddt or testsscenario ? i can check the possibility otherwise hard to find those with manual review etc | |
| 06:56:40 | alex_xu | for unittests, I guess that needs us to modify every API tests? | |
| 06:57:22 | alex_xu | gmann: i'm thinking if we can merge this fix and back-port, then in next release, we change the implement for json-schema validation | |
| 06:57:52 | gmann | alex_xu, yea, fix anyhow will merge but backport till newton ? | |
| 06:59:32 | alex_xu | gmann: yea, then we can do some test like this https://github.com/openstack/nova/blob/68bbddd8aea8f8b2d671e0d675524a1e568eb773/nova/api/openstack/wsgi.py#L947 | |
| 06:59:37 | gmann | alex_xu, because bug is since Mitaka (2.14) | |
| 06:59:54 | alex_xu | gmann: yea... | |
| 07:01:40 | alex_xu | mitaka is eol...hope I can found that early | |
| 07:09:58 | gmann | alex_xu, query schema is from v2.1 and we do not need those for v2.0 right | |
| 07:10:04 | gmann | alex_xu, https://github.com/openstack/nova/blob/0ca64a8690ac9de720131b522d29dcaed824eb8d/nova/api/openstack/compute/servers.py#L160 | |
| 07:11:27 | alex_xu | gmann: yea, I think yes | |
| 07:13:00 | alex_xu | gmann: at least we didn't talk about legacy v2 in the spec http://specs.openstack.org/openstack/nova-specs/specs/ocata/implemented/add-whitelist-for-server-list-filter-sort-parameters.html | |
| 07:15:06 | gmann | alex_xu, yea. | |
| 07:16:17 | gmann | also we can get ack from sdague and mriedem | |
| 07:16:26 | alex_xu | gmann: yea | |
| 07:25:08 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Ensure the JSON-Schema covers the legacy v2 API https://review.openstack.org/479170 | |
| 07:30:42 | openstackgerrit | Balazs Gibizer proposed openstack/nova master: Add BDM to InstancePayload https://review.openstack.org/448779 | |
| 07:32:23 | gibi | sfinucan: hi! I answered your latest comment about the extra decorators in the BDM patch https://review.openstack.org/#/c/448779/ | |
| 07:40:42 | openstackgerrit | Naichuan Sun proposed openstack/nova master: xenapi: Exception Error logs shown in Citrix XenServer CI https://review.openstack.org/478437 | |
| 07:42:17 | openstackgerrit | Balazs Gibizer proposed openstack/nova master: explain payload inheritance in notification devref https://review.openstack.org/453667 | |
| 07:42:18 | openstackgerrit | Balazs Gibizer proposed openstack/nova master: Add snapshot id to the snapshot notifications https://review.openstack.org/453077 | |
| 07:44:56 | openstack | Launchpad bug 1701211 in OpenStack Compute (nova) "The network related quotas aren't deprecated in quota-class API" [Undecided,Confirmed] - Assigned to Ghanshyam Mann (ghanshyammann) | |
| 07:44:56 | gmann | alex_xu, on quota class bug, actually we cannot fix confg controlled things now - https://bugs.launchpad.net/nova/+bug/1701211 | |
| 07:45:00 | gmann | alex_xu, i replied to that bug | |
| 07:45:29 | alex_xu | gmann: checking | |
| 07:48:16 | alex_xu | gmann: looks like nothing break when expose network quota in the old microversion even the configuration disable the network quota | |
| 07:50:50 | gmann | alex_xu, yea. indirectly return values in resp are controlled by config options via QUOTA.resource where network quota will be registered only if config is true | |
| 07:51:27 | gmann | alex_xu, but update request allow it (does not matter we ignore or consider that) as of now | |
| 07:57:47 | alex_xu | gmann: yea, I think you are right | |
| 08:03:03 | openstackgerrit | Merged openstack/nova master: Sanitize instance in InstanceMetadata to avoid un-pickleable context https://review.openstack.org/478991 | |
| 08:06:22 | gmann | alex_xu, on this - https://review.openstack.org/#/c/461480/2 | |
| 08:06:43 | gmann | alex_xu, actually its 400 for all baremetal APIs except GET | |
| 08:07:03 | gmann | alex_xu, i need to find if we can return 400 from router itself | |
| 08:07:35 | alex_xu | gmann: ah...i see | |
| 08:10:23 | alex_xu | gmann: maybe can create a BadRequestController | |
| 08:10:37 | alex_xu | but I guess that is not simple as sdage expected | |
| 08:11:20 | gmann | alex_xu, yea that is one way, and we can make that version rich and return all proxy APIs from there itself in future | |
| 08:12:00 | gmann | oh version is dynamic cannot work here | |
| 08:13:13 | gmann | alex_xu, with BadRequestController also it is same as going to baremetal controller | |
| 08:13:58 | alex_xu | gmann: or folow the placement to support a simple method https://github.com/openstack/nova/blob/master/nova/api/openstack/placement/handler.py#L73 | |
| 08:15:48 | alex_xu | but the Resource class handle more things than a simple method https://github.com/openstack/nova/blob/0ca64a8690ac9de720131b522d29dcaed824eb8d/nova/api/openstack/wsgi.py#L424 | |
| 08:15:48 | gmann | alex_xu, like handle_405() ? | |
| 08:16:23 | alex_xu | gmann: yea | |
| 08:17:02 | gmann | we can direct configure mapper.connect with return 400 | |
| 08:17:31 | alex_xu | gmann: but there is microversion in the baremetal API https://github.com/openstack/nova/blob/0ca64a8690ac9de720131b522d29dcaed824eb8d/nova/api/openstack/compute/baremetal_nodes.py#L136 | |
| 08:18:21 | alex_xu | that version is vary from different API, so there can't be generic way | |
| 08:18:35 | openstackgerrit | Luis Pigueiras proposed openstack/nova master: Handle keypair not found from metadata server using cells https://review.openstack.org/476122 | |
| 08:19:23 | alex_xu | gmann: just a method like handle_405(), then there is no way to handle microversion | |
| 08:19:35 | alex_xu | gmann: I feel we should keep the current way | |
| 08:19:46 | gmann | alex_xu, oh, it is 400 till 2.35 and then 404 | |
| 08:20:49 | alex_xu | gmann: yea... | |
| 08:21:39 | gmann | alex_xu, yea, we have to go till controller then | |
| 08:23:16 | gmann | alex_xu, its becoming large patch now as quota set want networks quota in sample file - https://review.openstack.org/#/c/467938/11 | |
| 08:24:12 | gmann | alex_xu, i can add in same patch if you would not mind or can separate the networks quota things for sample files | |
| 08:25:27 | alex_xu | gmann: I think https://review.openstack.org/#/c/467938/11 is right | |
| 08:27:16 | gmann | alex_xu, you mean to fix quota set sample files in same patch? | |
| 08:28:59 | alex_xu | gmann: sorry, the separated patch is better | |
| 08:29:19 | gmann | alex_xu, ok | |
| 08:29:24 | alex_xu | gmann: https://review.openstack.org/#/c/467938 already have a lot of change in the api ref | |
| 08:30:10 | gmann | alex_xu, yes, so i will leave the sample files changes on this and just api-ref for quota class | |
| 08:33:22 | alex_xu | gmann: that is also good choice | |
| 08:43:45 | openstackgerrit | Merged openstack/nova master: Delete disk metadata when detaching volume https://review.openstack.org/435082 | |