| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2017-03-07 | |||
| 13:22:47 | mnaser | we had a lot of problems with upgrades re this: https://review.openstack.org/#/c/408725/ -- we manually worked around it but it would be nice to not have to | |
| 13:28:35 | openstackgerrit | Ildiko Vancsa proposed openstack/nova master: Use Cinder API v3 as default https://review.openstack.org/420201 | |
| 13:52:15 | Dinesh_Bhor | Vek: Hi, Could you please take a look at it? https://review.openstack.org/#/c/441750/ | |
| 13:55:44 | openstackgerrit | Ed Leafe proposed openstack/nova master: Add test for inventory with invalid ResourceClass https://review.openstack.org/442498 | |
| 13:59:11 | tdurakov | paul-carlton2 eliqiao shaohe_feng pkoniszewski yuntongjin mdbooth kashyap kmartin claudiub tobasco tdurakov abhishekk mrhillsman raj_singh wznoinsk siva_krishnan live migration subteam meeting in 2 minutes on #openstack-meeting-3 | |
| 14:09:07 | cdent | edleafe gets the pedant of the day award | |
| 14:09:38 | edleafe | cdent: After all, I used to head the Department of Redundancy Department | |
| 14:10:31 | cdent | You sure you weren't the head chairperson? | |
| 14:10:49 | sfinucan | sdague: Could I ask you to take a look at this patch and dependencies? There are some merge conflicts in later patches and I don't want to push a 15 patch series rebase again https://review.openstack.org/#/c/431022 | |
| 14:11:16 | sfinucan | it's focused on deprecating remaining nova-net options (of which there are many) | |
| 14:12:14 | sdague | sfinucan: ok, I guess I wonder why it's in 8 patches? | |
| 14:12:38 | sfinucan | sdague: I figured that it would be easier to review in chunks. I can combine if not | |
| 14:14:36 | markus_z | Anyone here has a vagrant multinode setup with Ubuntu1604 and likes to share it? | |
| 14:15:00 | sdague | honestly, I think that all the deprecations in nova/conf/network.py as one patch might make it simpler | |
| 14:15:16 | sfinucan | sdague: Sure thing. Gimme two | |
| 14:15:38 | sdague | I also threw a quick comment in here - https://review.openstack.org/#/c/430914/3 | |
| 14:15:53 | sdague | just took me a second to realize how that could be not used any more | |
| 14:21:17 | sfinucan | sdague: Ah, I remember why I broke it up. The options were used by different components of nova-network and I gave that reason in the commit message (to avoid forcing people to go root that out themselves) | |
| 14:21:37 | sdague | sfinucan: ok, well it could just be a long commit message | |
| 14:21:45 | sdague | I'm fine with long commit messages | |
| 14:21:49 | sfinucan | Aye, that's what I'll do now :) | |
| 14:32:44 | johnthetubaguy | lyarwood mdbooth: thanks for you great comments on this one, would be awesome if you could take another peak at that cinder API spec: https://review.openstack.org/#/c/373203/ | |
| 14:32:58 | mdbooth | johnthetubaguy: Will do | |
| 14:33:20 | lyarwood | johnthetubaguy: ack will try to later today | |
| 14:35:06 | mriedem | edleafe: on https://review.openstack.org/#/c/442254/ i'm not using nova/tests/functional/api/openstack/placement | |
| 14:35:09 | johnthetubaguy | lyarwood: mdbooth: awesome, thank you | |
| 14:35:12 | mriedem | i'm testing the scheduler report client | |
| 14:35:44 | mriedem | well the gabbits anyway | |
| 14:37:21 | mriedem | edleafe: your test is testing the placement API directly, which is good, but the functional test i added is testing the report client, which is needed for the logic in there, as noted here https://review.openstack.org/#/c/441543/2/nova/tests/unit/scheduler/client/test_report.py@1242 | |
| 14:37:35 | cdent | mriedem, edleafe yeah seems we need both | |
| 14:37:44 | cdent | s/need/should have/ | |
| 14:42:16 | openstackgerrit | Rafael Folco proposed openstack/nova-specs master: DELETE all inventories for a resource provider https://review.openstack.org/415885 | |
| 14:44:03 | mriedem | sfinucan: we need to get this backported to ocata - breaks people using libvirt+xen that upgrade to ocata if they have new enough libvirt/qemu for virtlogd https://review.openstack.org/#/c/442209/ | |
| 14:44:14 | openstackgerrit | Stephen Finucane proposed openstack/nova master: conf: Fix indentation in conf/netconf https://review.openstack.org/430717 | |
| 14:44:15 | openstackgerrit | Stephen Finucane proposed openstack/nova master: conf: Deprecate 'use_ipv6' https://review.openstack.org/430911 | |
| 14:44:15 | openstackgerrit | Stephen Finucane proposed openstack/nova master: netutils: Ignore 'use_ipv6' for network templates https://review.openstack.org/430910 | |
| 14:44:16 | openstackgerrit | Stephen Finucane proposed openstack/nova master: conf: Deprecate 'allow_same_net_traffic' https://review.openstack.org/430913 | |
| 14:44:16 | openstackgerrit | Stephen Finucane proposed openstack/nova master: libvirt: Ignore 'use_ipv6' for port filters https://review.openstack.org/430909 | |
| 14:44:17 | openstackgerrit | Stephen Finucane proposed openstack/nova master: libvirt: Ignore 'allow_same_net_traffic' for port filters https://review.openstack.org/430912 | |
| 14:44:17 | openstackgerrit | Stephen Finucane proposed openstack/nova master: conf: Final cleanups in conf/network https://review.openstack.org/431023 | |
| 14:44:18 | openstackgerrit | Stephen Finucane proposed openstack/nova master: conf: Deprecate most 'network' option https://review.openstack.org/430914 | |
| 14:44:25 | mdbooth | kaboom! | |
| 14:44:27 | mriedem | i'd like to get that backported to ocata and released before a lot of people start upgrading | |
| 14:44:38 | sfinucan | sdague: ^^^ | |
| 14:44:44 | sfinucan | mriedem: Sure. I'll take a look now | |
| 14:46:08 | edleafe | mriedem: not sure I follow. The test you added is in ova/tests/functional/api/openstack/placement/test_report_client.py | |
| 14:46:32 | mriedem | edleafe: yeah which is a functional test on the scheduler report client | |
| 14:46:34 | mriedem | which is what we need | |
| 14:47:06 | mriedem | edleafe: as noted in the review, the functional test is testing the entire report client stack for that negative scenario, rather than just piecemeal unit tests - which are removed in that same change | |
| 14:47:10 | mriedem | because the unit tests can lie | |
| 14:49:04 | mriedem | bauzas: i plan on backport https://review.openstack.org/#/c/442035/ to ocata, do you have any issue with that? | |
| 14:49:09 | mriedem | *backporting | |
| 14:49:46 | ildikov | smcginnis: FYI, I added a few extra characters and whitespaces to that reno and now the test seems happy... :) | |
| 14:50:13 | smcginnis | ildikov: Oh good. I should take a look at how you did that. I wasn't able to get it to work. | |
| 14:50:24 | smcginnis | (and was too lazy to really figure it out) :) | |
| 14:50:59 | mriedem | smcginnis: you need the | for rst formatting | |
| 14:51:00 | sfinucan | mriedem: Yeah, that fix makes sense. Done | |
| 14:51:10 | mriedem | sfinucan: thanks | |
| 14:51:24 | mriedem | smcginnis: https://docs.openstack.org/developer/reno/usage.html#note-file-syntax | |
| 14:51:26 | mdbooth | mriedem: Speaking of backports, you had a W-1 on this Newton backport until the Ocata backport merged, which it now has: https://review.openstack.org/#/c/431540/ | |
| 14:51:31 | ildikov | mriedem: smcginnis: that was my guess too, but wasn't 100% sure | |
| 14:51:36 | smcginnis | ildikov, mriedem: So use a | and guve a little extra indent. | |
| 14:51:37 | sfinucan | mriedem: Someone should probably submit a patch to reno to use '|' in the default templates | |
| 14:51:49 | mriedem | sfinucan: go for it | |
| 14:51:51 | mriedem | i always use | | |
| 14:51:57 | mriedem | regardless of whether i need it or not | |
| 14:52:03 | ildikov | smcginnis: I think the extra indent wasn't necessary | |
| 14:52:15 | ildikov | mriedem: +1 | |
| 14:52:32 | smcginnis | ildikov: That link helps. I know I've read it before, but must have missed that detail. | |
| 14:52:55 | ildikov | smcginnis: it's a pretty easy one to miss like how I did yesterday | |
| 14:53:09 | smcginnis | ildikov: Definitely. | |
| 14:53:14 | ildikov | smcginnis: but the tests look good for that patch overall, so I'm optimistic about v3 :) | |
| 14:53:39 | sfinucan | mriedem: Ah, someone already has. Good to know | |
| 14:54:00 | smcginnis | ildikov: It looked pretty good other than the reno failure last ime. | |
| 14:54:42 | ildikov | smcginnis: yep, so the base v3 should be there any minute and then we can figure out the microversion part | |
| 14:55:02 | mdbooth | sfinucan: Thanks for the re-review of the nfs patch. It's now on top of this one, btw: https://review.openstack.org/#/c/438970/ | |
| 14:55:05 | smcginnis | ildikov: Great first step to build off of. | |
| 14:55:09 | ildikov | smcginnis: and will need a new cinderclient for that too IIRC | |
| 14:55:30 | mdbooth | This had a bit of discussion last week in the context of the Cinder v3 stuff. | |
| 14:55:36 | smcginnis | ildikov: I'm still waiting on one final fix before a new release. I'll try to push on that one. | |
| 14:55:40 | sfinucan | mdbooth: Ah - missed that. I'll take a look at that too shortly | |
| 14:55:45 | mdbooth | sfinucan: Thanks | |
| 14:55:52 | ildikov | smcginnis: cool, tnx | |
| 15:00:31 | mriedem | mdbooth: lyarwood: on https://review.openstack.org/#/c/431540/ | |
| 15:00:38 | mriedem | so you've got this nice tempest test https://review.openstack.org/#/c/427808/ | |
| 15:00:43 | mriedem | but the problem is that doesn't run on stable/newton | |
| 15:00:49 | mriedem | because devstack on newton doesn't enable swap volume testing | |
| 15:01:01 | mriedem | i think that's because we needed that other pivot patch | |
| 15:01:07 | mriedem | but i think that's merged | |
| 15:02:15 | lyarwood | mriedem: true, so I need to backport the devstack change to stable/newton before this lands right? | |
| 15:02:18 | mriedem | this one https://review.openstack.org/#/c/427290/ | |
| 15:02:28 | mriedem | ^ is what we needed to fix swap volume right? | |
| 15:02:40 | lyarwood | mriedem: yeah | |
| 15:04:08 | mriedem | ok hold up there were actually 2 changes in devstack | |
| 15:05:15 | mdbooth | mriedem: You're an encyclopaedia(sp?) of CI knowledge | |
| 15:05:41 | mriedem | i will take that as a compliment | |
| 15:06:09 | lyarwood | mriedem: are you cp'ing them back to newton? | |
| 15:06:15 | lyarwood | mriedem: happy to if you don't have time | |
| 15:06:50 | mriedem | lyarwood: https://review.openstack.org/#/c/442548/ | |
| 15:07:10 | lyarwood | mriedem: thanks | |