Earlier  
Posted Nick Remark
#openstack-cyborg - 2026-07-28
14:35:22 sean-k-mooney so we dotn end up with 2 driver that cant work at the end of the cycle
14:35:40 sean-k-mooney by the way im not that worreid we have time
14:35:48 sean-k-mooney just trying to level set
14:36:04 melwitt are they all on the same gerrit topic? I find that helpful for not missing things personally
14:36:16 melwitt yeah, all good
14:36:52 sean-k-mooney the cybrog ones are the nova oens are on a diffent topic
14:36:52 chandankumar we have two topics https://review.opendev.org/q/topic:%22generic-mdev-driver%22 and https://review.opendev.org/q/topic:%22cyborg-vgpu-support%22
14:36:55 sean-k-mooney we coudl use the same for both
14:37:09 sean-k-mooney but technially the bluepritn names are diffent
14:37:13 sean-k-mooney so two topic
14:37:43 melwitt we don't have to, was just saying I like using it to tie together patches for the same effort that are across multiple projects. just a personal thing I like to do helps me keep track of all together
14:38:16 melwitt https://review.opendev.org/q/topic:%22ipv6-multinode%22 is a good example haha
14:39:15 melwitt ok, matching blueprint names, no problem. ignore me :)
14:39:31 sean-k-mooney ya i like to do that too
14:39:45 sean-k-mooney its only an issue if you have 2 difefnt blurpints for it
14:39:58 sean-k-mooney then you have to chosoe wihc to use or use the hastag feature
14:40:13 melwitt yeah, I see
14:40:54 chandankumar https://review.opendev.org/q/topic:%22cyborg-vgpu-support%22+OR+topic:%22generic-mdev-driver%22
14:41:10 sean-k-mooney that worsk as well :)
14:41:55 chandankumar any more questions on this review series
14:41:57 sean-k-mooney unles there are other queston on this we can likely move on
14:42:10 jgilaber yes, I think we can move one, thanks
14:42:13 sean-k-mooney ill try to review the nova parts in the next day or two
14:42:23 chandankumar Under Improvement section, we have guest reboot we already talked about that
14:42:24 melwitt that doesn't fit how I use it fwiw, bc I click on the topic from one of the patches to discover the others. but the link is helpful nonetheless :)
14:42:29 chandankumar Now jumping to bug
14:42:38 chandankumar #topic Bugs
14:42:56 chandankumar #link Devstack doesn't enable port_device_profile ML2 extension driver for Cyborg: https://bugs.launchpad.net/openstack-cyborg/+bug/2161365
14:43:20 chandankumar It was opened by melwitt
14:43:23 melwitt I got some feedback on my patch for this, apparently not really a bug. so not sure if I should be thinking to close it?
14:43:36 sean-k-mooney whishlist is fine
14:43:43 melwitt ok
14:43:44 jgilaber +1 seems fine as is
14:43:48 chandankumar sean-k-mooney: chnaged it to wishlist
14:43:51 sean-k-mooney ist a mini enhancment
14:43:53 melwitt thanks
14:44:04 sean-k-mooney melwitt: since we are on this topic
14:44:04 chandankumar it is already triaged, thank you
14:44:24 sean-k-mooney i ased for some enhacned docs in teh review i left
14:44:42 sean-k-mooney but i was also thinking maybe we shoudl clean up https://github.com/openstack/cyborg/blob/master/cyborg.conf.intelnic.sample
14:45:04 sean-k-mooney its really weird to have a random config example at the root of the repo
14:45:16 melwitt ok sure
14:45:55 sean-k-mooney my prefence woudl be to add a local.conf exmaple instead https://github.com/openstack/cyborg/blob/master/devstack/local-conf.pci-sim.sample
14:46:03 sean-k-mooney but ya that basiclly what i said in the review
14:46:25 sean-k-mooney i am fine with adding a speicif driver doc later
14:46:29 melwitt I thhink that would make sense
14:46:34 melwitt *think
14:46:42 sean-k-mooney so im not really asking for fully docs just capture the impaont parts form the gist you rote
14:47:30 melwitt ok, can do
14:47:33 sean-k-mooney i.e. if your automating the cofniguration with devstack add a small devstack local.conf samepel adn a littel prose to descibe how to set it up.
14:47:35 sean-k-mooney cool
14:47:50 melwitt thanks
14:47:58 sean-k-mooney by the way the reaon i said its not entirly a bug
14:48:08 sean-k-mooney is until this cycle
14:48:19 sean-k-mooney there really wast any devstack automation for any fo the drivers
14:48:54 sean-k-mooney im fine with filign wishlist bugs as tracker but we are missing devstack supprot for most of the rest of the drivrs as well
14:49:12 sean-k-mooney and i dont thnk fixing that when we have time shoudl need a lot of paper work
14:49:34 melwitt yeah I mean for this, it's the general device_profile extension so seems required for any cyborg use no?
14:49:54 sean-k-mooney only if using cyborg with neutron ports
14:50:03 melwitt yeah, it's good we have Wishlist
14:50:07 melwitt ah right. ok
14:50:23 sean-k-mooney that why i was debting if this shoudl only be enabled if you enable the intel driver
14:50:36 sean-k-mooney or sriov nic agent but its harmless to alwasy enabel
14:50:52 sean-k-mooney neutron will ignore it if your usign ovn af far as im aware
14:51:14 melwitt yeah. I think a guard would make sense. I guess intel is the only nic driver under nic/? I forgot already
14:51:26 sean-k-mooney currently yes
14:51:46 sean-k-mooney https://github.com/openstack/cyborg/blob/master/pyproject.toml#L52-L63
14:51:49 sean-k-mooney at least in tree
14:52:05 melwitt ok cool. bc really it would be if any nic driver enabled but if we only have the one, then yeah
14:52:13 sean-k-mooney its technically a stevador entriy point i think but i woudl have to check
14:53:17 chandankumar we have one more bug to discuss, then we can talk more about that after meeting
14:53:37 sean-k-mooney cool
14:53:52 chandankumar #link
14:53:52 chandankumar [cyborg-tempest-plugin] Cyborg tempest tests fail in role manager does not exist https://bugs.launchpad.net/openstack-cyborg/+bug/2161909
14:54:06 chandankumar amoralej: opened it.
14:54:13 sean-k-mooney melwitt: https://github.com/openstack/cyborg/blob/master/cyborg/agent/resource_tracker.py#L53-L57
14:54:19 chandankumar It comes only when manager role does not exist in the environment
14:54:29 sean-k-mooney chandankumar: ya so i dug into this a bit
14:54:53 sean-k-mooney the reaosn this fails downtram is we are using keystone form antelope 2023.1
14:55:06 sean-k-mooney and the manager rule is created by default in bobcat 2023.2
14:55:20 sean-k-mooney so for all suprpoted branches we can unconditonly rely on it existing
14:56:21 sean-k-mooney it would not be hardd to add supprot for older release but those are technially not supproted on master
14:56:31 chandankumar for upstream stable branches, It does not seems to be a bug then
14:56:46 sean-k-mooney right its not
14:57:02 sean-k-mooney it just a question of do we wnat to add one off support for older branches
14:57:10 sean-k-mooney in generall we should not try to supprot antelope
14:57:39 sean-k-mooney but we coudl supprot it in this case if we choose too
14:58:03 jgilaber how extensive would the changes be?
14:58:14 sean-k-mooney like an if or two
14:58:39 sean-k-mooney https://github.com/openstack/cyborg-tempest-plugin/blob/master/cyborg_tempest_plugin/tests/api/base.py#L73-L107
14:59:02 sean-k-mooney the fix is to only create the role specific client if we are using the new defaults
14:59:29 sean-k-mooney so move
14:59:31 sean-k-mooney https://github.com/openstack/cyborg-tempest-plugin/blob/master/cyborg_tempest_plugin/tests/api/base.py#L82-L94
14:59:42 sean-k-mooney under the if branches
14:59:44 sean-k-mooney https://github.com/openstack/cyborg-tempest-plugin/blob/master/cyborg_tempest_plugin/tests/api/base.py#L100-L107
14:59:47 jgilaber ok, I think that is acceptable
15:00:03 chandankumar ok
15:00:19 chandankumar coming to bug importance to low?
15:00:24 sean-k-mooney whishlist
15:00:31 sean-k-mooney again its for an unsuprpoted release

Earlier   Later