| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-cyborg - 2026-06-30 | |||
| 14:03:57 | sean-k-mooney | jgilaber: i just left comments on yours +1 with minor change im happy to merge it | |
| 14:04:06 | sean-k-mooney | chandankumar: yours is next on my list | |
| 14:04:09 | sean-k-mooney | for after the meeting | |
| 14:04:19 | jgilaber | ack thanks sean-k-mooney I'll look after the meeting | |
| 14:04:23 | chandankumar | thank you! | |
| 14:04:47 | jgilaber | looks like we're in good shape, anything else on this topic? | |
| 14:05:30 | jgilaber | ok, next topic | |
| 14:05:33 | jgilaber | #topic Freezing python-cyborgclient improvements | |
| 14:05:45 | jgilaber | this one if from rlandy I believe | |
| 14:05:51 | jgilaber | #link https://review.opendev.org/c/openstack/python-cyborgclient/+/994696 | |
| 14:05:54 | rlandy | yes... | |
| 14:06:18 | rlandy | this change started with bug: https://bugs.launchpad.net/python-cyborgclient/+bug/2146351 | |
| 14:06:39 | rlandy | which requires removing the old v1 API | |
| 14:06:48 | rlandy | from cyborgclient | |
| 14:07:09 | rlandy | but there is also the piece of sdk accelerator v2 support | |
| 14:07:44 | rlandy | looking at the description, the bug now contains many parts | |
| 14:08:02 | rlandy | and we need to rethink the approach here | |
| 14:08:15 | rlandy | as initially the plan was the keep using the openstacksdk | |
| 14:08:36 | rlandy | so chandankumar and I are bringing this to the team to establish a direction | |
| 14:08:47 | rlandy | because this is probably bigger than one bug | |
| 14:09:08 | rlandy | and we need to decide what should be addressed immediately vs taking a longer design | |
| 14:09:36 | jgilaber | problem 3 in the bug report seems backwards to me | |
| 14:09:56 | jgilaber | I don't think we want to move the accelerator proxy to the client | |
| 14:10:10 | chandankumar | yes, that needs to be fixed | |
| 14:10:15 | sean-k-mooney | rlandy: so the python-cybrogclient | |
| 14:10:19 | sean-k-mooney | alrady uses the sdk | |
| 14:10:22 | sean-k-mooney | for v2 | |
| 14:10:34 | sean-k-mooney | so this was orgianly intened to track only the v1 removal | |
| 14:10:50 | melwitt | yeah what's in the description there looks like specless blueprint material | |
| 14:11:08 | rlandy | ok - so that is possibly the right direction - to make the bug just cover v1 removal | |
| 14:11:23 | sean-k-mooney | yes | |
| 14:11:23 | rlandy | and move the rest to some spec/blueprint etc. | |
| 14:11:37 | sean-k-mooney | we did dicss this in the ptg | |
| 14:11:49 | sean-k-mooney | so the propsoal was to remove v1 this cycle and deprecate teh shell | |
| 14:12:00 | rlandy | so I would propose to abandon this change - and it complicates things | |
| 14:12:10 | rlandy | and just start over with the v1 removal | |
| 14:12:12 | sean-k-mooney | by shell i mean cybrog command | |
| 14:12:19 | rlandy | taking the rest to PTG? | |
| 14:12:30 | sean-k-mooney | sure we can do that | |
| 14:12:44 | rlandy | ok - chandankumar - you in agreement here? | |
| 14:12:55 | sean-k-mooney | my hope was to deprecate the python-cybrogclient repo next cycle entirly if we end up upstreamign ti to osc | |
| 14:13:00 | chandankumar | But for this release, Do we want to fix existing interface and not add any coverage there | |
| 14:13:15 | sean-k-mooney | and if not resuding it down to only the osc plugin in 2027.2 | |
| 14:13:16 | chandankumar | with v1 removal | |
| 14:13:27 | rlandy | the issue is there is a lot in common | |
| 14:13:38 | sean-k-mooney | chandankumar: which interface? | |
| 14:13:52 | chandankumar | I mean device enable /disable interface | |
| 14:14:27 | sean-k-mooney | oh that is a sperate bug | |
| 14:14:31 | chandankumar | https://bugs.launchpad.net/python-cyborgclient/+bug/2151792 | |
| 14:14:35 | sean-k-mooney | we shoudl fix that but not as part of this | |
| 14:14:50 | sean-k-mooney | we shoudl fix htat by preposoing the sdk change | |
| 14:15:17 | jgilaber | it looks to me that with the v1 removal https://bugs.launchpad.net/python-cyborgclient/+bug/2146351 should be done | |
| 14:15:51 | chandankumar | ok | |
| 14:16:20 | sean-k-mooney | so proeblem 1 and 2 are really the scope of this i think | |
| 14:16:35 | sean-k-mooney | "Problem 3: Migrate accelerator proxy from openstacksdk into cyborgclient" wans never intended to be done | |
| 14:16:36 | chandankumar | sounds good to me drop v1 from cyborgclient and rest of enahncement/fixes goes to sdk change | |
| 14:16:44 | sean-k-mooney | so i think that where the confustion came form | |
| 14:16:49 | jgilaber | +1 sean-k-mooney | |
| 14:17:03 | chandankumar | srry that is Add support from accelerator proxy from openstacksdk into cyborgclient | |
| 14:17:15 | sean-k-mooney | yes | |
| 14:17:50 | sean-k-mooney | we do not want to "Migrate the SDK accelerator proxy into cyborgclient" | |
| 14:18:12 | chandankumar | yup | |
| 14:18:26 | sean-k-mooney | so are folk ok if i update teh bug to just remove problem 3 | |
| 14:18:27 | chandankumar | I will drop that section from the bug and keep it to v1 removal to clear confson | |
| 14:18:30 | sean-k-mooney | then i htink we are good | |
| 14:18:37 | sean-k-mooney | ack | |
| 14:18:40 | sean-k-mooney | works for me | |
| 14:18:41 | rlandy | ok- thank you | |
| 14:19:07 | rlandy | I will submit a new change for the 1 and 2 and abandon the current change | |
| 14:19:21 | rlandy | jgilaber, thank you - I think we are ok here | |
| 14:19:32 | jgilaber | ack, thanks | |
| 14:19:42 | jgilaber | #topics Reviews | |
| 14:19:48 | jgilaber | we don't have anything listed | |
| 14:19:56 | jgilaber | is there any patch that anyone wants to call out? | |
| 14:20:16 | melwitt | think you need #topic without a s (sorry) | |
| 14:20:31 | jgilaber | oh right, thanks melwitt | |
| 14:20:37 | jgilaber | #topic Reviews | |
| 14:20:59 | jgilaber | anything? otherwise we can move to bug triage | |
| 14:21:01 | melwitt | I wanted to mention about, I have a API test samples patch I tried out here if anyone wants to take a look and see what they think https://review.opendev.org/c/openstack/cyborg/+/994830 | |
| 14:21:07 | sean-k-mooney | nothing urgent just an fyi takashi has proposed some cleanup of nova code in cybrog https://review.opendev.org/c/openstack/cyborg/+/995195/4 | |
| 14:21:24 | sean-k-mooney | melwitt: oh you removed the WIP :) | |
| 14:21:56 | melwitt | yeah just now :) seems ... pretty ok so ready for some scrutiny | |
| 14:22:00 | chandankumar | will take a look at those this week. | |
| 14:22:05 | sean-k-mooney | i approved the irrelevent files change this morning https://review.opendev.org/c/openstack/cyborg/+/994816/1 | |
| 14:22:17 | melwitt | ah thanks | |
| 14:23:12 | jgilaber | thanks, I'll add them to my review list as well | |
| 14:23:22 | jgilaber | let's move on | |
| 14:23:28 | jgilaber | #topic Bugs | |
| 14:23:36 | jgilaber | I saw we have two untriaged | |
| 14:23:44 | jgilaber | #link https://bugs.launchpad.net/openstack-cyborg/+bug/2158058 | |
| 14:24:41 | chandankumar | we discussed about this one in last meeting | |
| 14:24:52 | chandankumar | [cyborg-tempest-plugin][fake driver]Improve the scenario test coverage for instance operation in fake driver | |
| 14:25:26 | chandankumar | sean-k-mooney proposed https://review.opendev.org/c/openstack/cyborg-tempest-plugin/+/994580 pci driver based instance lifecycle test | |
| 14:25:33 | chandankumar | we will reuse the same format | |
| 14:25:46 | chandankumar | for this one, can we mark them as a wishlist? | |
| 14:25:57 | jgilaber | does that patch completely address the bug report or will we need more? | |
| 14:26:45 | chandankumar | nono, we need to duplicate the same tests for fake driver based on above patch | |
| 14:26:59 | jgilaber | ah ok, I see | |
| 14:27:15 | jgilaber | wishlist/medium seems good to me | |
| 14:27:17 | sean-k-mooney | so it kind of superceed it | |