| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-cyborg - 2026-06-30 | |||
| 14:18:12 | chandankumar | yup | |
| 14:18:26 | sean-k-mooney | so are folk ok if i update teh bug to just remove problem 3 | |
| 14:18:27 | chandankumar | I will drop that section from the bug and keep it to v1 removal to clear confson | |
| 14:18:30 | sean-k-mooney | then i htink we are good | |
| 14:18:37 | sean-k-mooney | ack | |
| 14:18:40 | sean-k-mooney | works for me | |
| 14:18:41 | rlandy | ok- thank you | |
| 14:19:07 | rlandy | I will submit a new change for the 1 and 2 and abandon the current change | |
| 14:19:21 | rlandy | jgilaber, thank you - I think we are ok here | |
| 14:19:32 | jgilaber | ack, thanks | |
| 14:19:42 | jgilaber | #topics Reviews | |
| 14:19:48 | jgilaber | we don't have anything listed | |
| 14:19:56 | jgilaber | is there any patch that anyone wants to call out? | |
| 14:20:16 | melwitt | think you need #topic without a s (sorry) | |
| 14:20:31 | jgilaber | oh right, thanks melwitt | |
| 14:20:37 | jgilaber | #topic Reviews | |
| 14:20:59 | jgilaber | anything? otherwise we can move to bug triage | |
| 14:21:01 | melwitt | I wanted to mention about, I have a API test samples patch I tried out here if anyone wants to take a look and see what they think https://review.opendev.org/c/openstack/cyborg/+/994830 | |
| 14:21:07 | sean-k-mooney | nothing urgent just an fyi takashi has proposed some cleanup of nova code in cybrog https://review.opendev.org/c/openstack/cyborg/+/995195/4 | |
| 14:21:24 | sean-k-mooney | melwitt: oh you removed the WIP :) | |
| 14:21:56 | melwitt | yeah just now :) seems ... pretty ok so ready for some scrutiny | |
| 14:22:00 | chandankumar | will take a look at those this week. | |
| 14:22:05 | sean-k-mooney | i approved the irrelevent files change this morning https://review.opendev.org/c/openstack/cyborg/+/994816/1 | |
| 14:22:17 | melwitt | ah thanks | |
| 14:23:12 | jgilaber | thanks, I'll add them to my review list as well | |
| 14:23:22 | jgilaber | let's move on | |
| 14:23:28 | jgilaber | #topic Bugs | |
| 14:23:36 | jgilaber | I saw we have two untriaged | |
| 14:23:44 | jgilaber | #link https://bugs.launchpad.net/openstack-cyborg/+bug/2158058 | |
| 14:24:41 | chandankumar | we discussed about this one in last meeting | |
| 14:24:52 | chandankumar | [cyborg-tempest-plugin][fake driver]Improve the scenario test coverage for instance operation in fake driver | |
| 14:25:26 | chandankumar | sean-k-mooney proposed https://review.opendev.org/c/openstack/cyborg-tempest-plugin/+/994580 pci driver based instance lifecycle test | |
| 14:25:33 | chandankumar | we will reuse the same format | |
| 14:25:46 | chandankumar | for this one, can we mark them as a wishlist? | |
| 14:25:57 | jgilaber | does that patch completely address the bug report or will we need more? | |
| 14:26:45 | chandankumar | nono, we need to duplicate the same tests for fake driver based on above patch | |
| 14:26:59 | jgilaber | ah ok, I see | |
| 14:27:15 | jgilaber | wishlist/medium seems good to me | |
| 14:27:17 | sean-k-mooney | so it kind of superceed it | |
| 14:27:39 | sean-k-mooney | i actully think there is very littel point in useing the fake driver for the majoryit of the lifecycle operations | |
| 14:27:53 | sean-k-mooney | because the only thing that tests is the arq creation | |
| 14:28:02 | sean-k-mooney | on the nova side we entirly drop the arq info | |
| 14:28:29 | melwitt | yeah I kind of wondered about that ... how helpful is the fake driver for lifecycle testing | |
| 14:28:32 | sean-k-mooney | so i woudl prefer to only test program and create with the fake driver | |
| 14:28:46 | sean-k-mooney | and test the rest with pci/mdev/nvme drivers | |
| 14:29:04 | chandankumar | for program I have awip patch https://review.opendev.org/c/openstack/cyborg-tempest-plugin/+/994580 | |
| 14:29:21 | sean-k-mooney | chandankumar: so we have a exsitng boot test with the fake driver | |
| 14:29:28 | sean-k-mooney | once we merge your program tests | |
| 14:29:34 | sean-k-mooney | i woudl close https://bugs.launchpad.net/openstack-cyborg/+bug/2158058 | |
| 14:29:57 | jgilaber | close after the patch merges or close it now? | |
| 14:30:27 | sean-k-mooney | well i guess it depend on if we add Close-Bug to oen of them :) | |
| 14:30:46 | sean-k-mooney | or related bug | |
| 14:30:46 | chandankumar | I can add closes -bug , then it will automatically closes | |
| 14:30:57 | sean-k-mooney | cool those that work for others? | |
| 14:31:09 | melwitt | probably want to add a comment to it about not doing lifecycle tests as part of it. or edit the description | |
| 14:31:16 | jgilaber | ack, so in the meantime we set it as wishlist and low/medium? | |
| 14:32:05 | chandankumar | I will add a comment to the bug | |
| 14:32:13 | chandankumar | low/medium +1 | |
| 14:32:42 | chandankumar | low | |
| 14:33:02 | jgilaber | ack set then | |
| 14:33:39 | jgilaber | next one | |
| 14:33:43 | opendevreview | Merged openstack/cyborg master: Add api-ref/ to irrelevant-files in Zuul config https://review.opendev.org/c/openstack/cyborg/+/994816 | |
| 14:33:43 | jgilaber | #link https://bugs.launchpad.net/openstack-cyborg/+bug/2158147 | |
| 14:34:11 | melwitt | oh, that's the one in flight patch approved from earlier | |
| 14:34:43 | melwitt | so it will get closed when the patch merges | |
| 14:34:45 | jgilaber | ok, so that seems valid and is in progress, only missing the importnace | |
| 14:34:53 | jgilaber | medium? | |
| 14:35:11 | sean-k-mooney | ya it has no end user impact directly | |
| 14:35:20 | melwitt | oh wait sorry. I misread that it's after the api-ref thing | |
| 14:35:22 | sean-k-mooney | but melwitt has already fixed some incorrect examples | |
| 14:35:24 | melwitt | anyway. yeah not high importance | |
| 14:35:39 | jgilaber | ack thanks melwitt | |
| 14:35:58 | jgilaber | that was the last one | |
| 14:36:07 | jgilaber | #topic Open discussion | |
| 14:36:16 | jgilaber | any last minute topic to raise? | |
| 14:36:42 | sean-k-mooney | maybe we coudl chat abouy https://github.com/adamchainz/flake8-logging/pull/187 quickly | |
| 14:36:50 | jgilaber | looking | |
| 14:37:08 | sean-k-mooney | melwitt: so we have moved away form using flake8 in general to using ruff for linting | |
| 14:37:22 | sean-k-mooney | we coudl run that check via the hacking env | |
| 14:37:30 | sean-k-mooney | since it uses flake internally | |
| 14:37:34 | melwitt | ok that's good to know | |
| 14:37:44 | sean-k-mooney | but woudl it be better to just have a local hacking check instead | |
| 14:38:24 | melwitt | I don't know a lot about it so I wasn't aware we could make local checks. if that's an option then seems like a nice idea? | |
| 14:39:03 | sean-k-mooney | so there are 2 ways we coudl do this | |
| 14:39:13 | melwitt | I'm skeptical my PR will go anywhere but I tried it anyway | |
| 14:39:14 | sean-k-mooney | a pre-commit hook or a local hackign check | |
| 14:39:19 | sean-k-mooney | the later is proably simpler | |
| 14:39:37 | sean-k-mooney | this might be genericlly usefully enough to put in hacking propper as well | |
| 14:40:54 | melwitt | ok, I will look into that then, thanks | |
| 14:41:47 | sean-k-mooney | ah right | |
| 14:41:49 | sean-k-mooney | https://github.com/openstack/cyborg/commit/8eb3a5a4b2a8fa0fc969290ceace9f574715d027 | |
| 14:42:16 | sean-k-mooney | i delete our hacking plugin | |
| 14:42:20 | sean-k-mooney | but we can add one back | |
| 14:42:25 | melwitt | :) | |
| 14:42:42 | sean-k-mooney | i deleted it because i didnt like the preior rules it used in general | |
| 14:43:05 | sean-k-mooney | well or the were duplicats of other checks | |
| 14:43:10 | melwitt | oh ok | |
| 14:43:51 | sean-k-mooney | nova has a bunch of hackign plugin examples too for what its worth | |
| 14:44:14 | sean-k-mooney | anyway i think we can chat about that outside the meeting | |
| 14:44:23 | sean-k-mooney | any other topics or questions on this topic? | |