| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-sdks - 2025-03-19 | |||
| 11:03:01 | opendevreview | Stephen Finucane proposed openstack/python-openstackclient master: docs: Remove irrelevant TODO https://review.opendev.org/c/openstack/python-openstackclient/+/944866 | |
| 11:46:20 | opendevreview | Stephen Finucane proposed openstack/openstacksdk master: Indicate providers that are dead/unresponsive https://review.opendev.org/c/openstack/openstacksdk/+/944988 | |
| 11:57:20 | opendevreview | Stephen Finucane proposed openstack/python-openstackclient stable/2025.1: Add libpcre3-dev in bindep.txt for pcre.h https://review.opendev.org/c/openstack/python-openstackclient/+/944990 | |
| 11:57:20 | opendevreview | Stephen Finucane proposed openstack/python-openstackclient stable/2025.1: identity: Fix 'trust' commands to work with SDK https://review.opendev.org/c/openstack/python-openstackclient/+/944991 | |
| 12:33:35 | opendevreview | Stephen Finucane proposed openstack/python-openstackclient master: Prepare for ruff bump https://review.opendev.org/c/openstack/python-openstackclient/+/942274 | |
| 12:33:35 | opendevreview | Stephen Finucane proposed openstack/python-openstackclient master: pre-commit: Bump versions https://review.opendev.org/c/openstack/python-openstackclient/+/942275 | |
| 12:33:36 | opendevreview | Stephen Finucane proposed openstack/python-openstackclient master: typing: Indicate tuples to be extended https://review.opendev.org/c/openstack/python-openstackclient/+/942276 | |
| 12:33:36 | opendevreview | Stephen Finucane proposed openstack/python-openstackclient master: typing: Add types for empty dicts, tuples https://review.opendev.org/c/openstack/python-openstackclient/+/942277 | |
| 12:33:37 | opendevreview | Stephen Finucane proposed openstack/python-openstackclient master: typing: Use consistent types https://review.opendev.org/c/openstack/python-openstackclient/+/942278 | |
| 12:33:37 | opendevreview | Stephen Finucane proposed openstack/python-openstackclient master: typing: Remove use of optional imports https://review.opendev.org/c/openstack/python-openstackclient/+/942279 | |
| 12:33:38 | opendevreview | Stephen Finucane proposed openstack/python-openstackclient master: typing: Correct type for missing attributes https://review.opendev.org/c/openstack/python-openstackclient/+/942280 | |
| 12:33:38 | opendevreview | Stephen Finucane proposed openstack/python-openstackclient master: typing: Correct type for missing attributes https://review.opendev.org/c/openstack/python-openstackclient/+/942281 | |
| 12:33:39 | opendevreview | Stephen Finucane proposed openstack/python-openstackclient master: typing: Resolve incompatible operand issues https://review.opendev.org/c/openstack/python-openstackclient/+/942282 | |
| 12:33:40 | opendevreview | Stephen Finucane proposed openstack/python-openstackclient master: pre-commit: Enable mypy https://review.opendev.org/c/openstack/python-openstackclient/+/942283 | |
| 12:33:40 | opendevreview | Stephen Finucane proposed openstack/python-openstackclient master: pre-commit: Add cliff, osc-lib to mypy deps https://review.opendev.org/c/openstack/python-openstackclient/+/944995 | |
| 12:34:06 | opendevreview | Stephen Finucane proposed openstack/python-openstackclient master: Remove tags from README https://review.opendev.org/c/openstack/python-openstackclient/+/944996 | |
| 12:34:31 | opendevreview | Stephen Finucane proposed openstack/osc-lib master: typing: Fix initial typing issues https://review.opendev.org/c/openstack/osc-lib/+/942259 | |
| 12:34:31 | opendevreview | Stephen Finucane proposed openstack/osc-lib master: pre-commit: Enable mypy https://review.opendev.org/c/openstack/osc-lib/+/942260 | |
| 12:34:32 | opendevreview | Stephen Finucane proposed openstack/osc-lib master: typing: Add typing to osc_lib.exceptions https://review.opendev.org/c/openstack/osc-lib/+/942261 | |
| 12:34:32 | opendevreview | Stephen Finucane proposed openstack/osc-lib master: typing: Add typing to osc_lib.api https://review.opendev.org/c/openstack/osc-lib/+/942262 | |
| 12:34:33 | opendevreview | Stephen Finucane proposed openstack/osc-lib master: api: Deprecate BaseAPI https://review.opendev.org/c/openstack/osc-lib/+/942263 | |
| 12:34:33 | opendevreview | Stephen Finucane proposed openstack/osc-lib master: typing: Add typing to osc_lib.cli https://review.opendev.org/c/openstack/osc-lib/+/942264 | |
| 12:34:34 | opendevreview | Stephen Finucane proposed openstack/osc-lib master: typing: Add typing to osc_lib.logs, osc_lib.i18n https://review.opendev.org/c/openstack/osc-lib/+/942265 | |
| 12:34:34 | opendevreview | Stephen Finucane proposed openstack/osc-lib master: typing: Add typing to osc_lib.shell https://review.opendev.org/c/openstack/osc-lib/+/942266 | |
| 12:34:35 | opendevreview | Stephen Finucane proposed openstack/osc-lib master: typing: Add typing to osc_lib.clientmanager https://review.opendev.org/c/openstack/osc-lib/+/942267 | |
| 12:34:36 | opendevreview | Stephen Finucane proposed openstack/osc-lib master: clientmanager: Deprecate ClientCache https://review.opendev.org/c/openstack/osc-lib/+/942268 | |
| 12:34:36 | opendevreview | Stephen Finucane proposed openstack/osc-lib master: typing: Add typing to osc_lib.command https://review.opendev.org/c/openstack/osc-lib/+/942269 | |
| 12:34:38 | opendevreview | Stephen Finucane proposed openstack/osc-lib master: typing: Add typing to osc_lib.utils https://review.opendev.org/c/openstack/osc-lib/+/942270 | |
| 12:34:38 | opendevreview | Stephen Finucane proposed openstack/osc-lib master: utils: Remove support for legacy format functions https://review.opendev.org/c/openstack/osc-lib/+/942271 | |
| 12:34:40 | opendevreview | Stephen Finucane proposed openstack/osc-lib master: utils: Deprecate legacy client-specific helpers https://review.opendev.org/c/openstack/osc-lib/+/942272 | |
| 12:34:40 | opendevreview | Stephen Finucane proposed openstack/osc-lib master: tests: Resolve TODO https://review.opendev.org/c/openstack/osc-lib/+/942273 | |
| 12:50:36 | opendevreview | Stephen Finucane proposed openstack/osc-lib master: typing: Fix initial typing issues https://review.opendev.org/c/openstack/osc-lib/+/942259 | |
| 12:50:36 | opendevreview | Stephen Finucane proposed openstack/osc-lib master: pre-commit: Enable mypy https://review.opendev.org/c/openstack/osc-lib/+/942260 | |
| 12:50:37 | opendevreview | Stephen Finucane proposed openstack/osc-lib master: typing: Add typing to osc_lib.exceptions https://review.opendev.org/c/openstack/osc-lib/+/942261 | |
| 12:50:37 | opendevreview | Stephen Finucane proposed openstack/osc-lib master: typing: Add typing to osc_lib.api https://review.opendev.org/c/openstack/osc-lib/+/942262 | |
| 12:50:38 | opendevreview | Stephen Finucane proposed openstack/osc-lib master: api: Deprecate BaseAPI https://review.opendev.org/c/openstack/osc-lib/+/942263 | |
| 12:50:38 | opendevreview | Stephen Finucane proposed openstack/osc-lib master: typing: Add typing to osc_lib.cli https://review.opendev.org/c/openstack/osc-lib/+/942264 | |
| 12:50:39 | opendevreview | Stephen Finucane proposed openstack/osc-lib master: typing: Add typing to osc_lib.logs, osc_lib.i18n https://review.opendev.org/c/openstack/osc-lib/+/942265 | |
| 12:50:40 | opendevreview | Stephen Finucane proposed openstack/osc-lib master: typing: Add typing to osc_lib.shell https://review.opendev.org/c/openstack/osc-lib/+/942266 | |
| 12:50:40 | opendevreview | Stephen Finucane proposed openstack/osc-lib master: typing: Add typing to osc_lib.clientmanager https://review.opendev.org/c/openstack/osc-lib/+/942267 | |
| 12:50:42 | opendevreview | Stephen Finucane proposed openstack/osc-lib master: clientmanager: Deprecate ClientCache https://review.opendev.org/c/openstack/osc-lib/+/942268 | |
| 12:50:42 | opendevreview | Stephen Finucane proposed openstack/osc-lib master: typing: Add typing to osc_lib.command https://review.opendev.org/c/openstack/osc-lib/+/942269 | |
| 12:50:44 | opendevreview | Stephen Finucane proposed openstack/osc-lib master: typing: Add typing to osc_lib.utils https://review.opendev.org/c/openstack/osc-lib/+/942270 | |
| 12:50:44 | opendevreview | Stephen Finucane proposed openstack/osc-lib master: typing: Enable disallow_subclassing_any https://review.opendev.org/c/openstack/osc-lib/+/945000 | |
| 12:55:10 | opendevreview | Stephen Finucane proposed openstack/osc-lib master: Remove unused docs Makefile https://review.opendev.org/c/openstack/osc-lib/+/945002 | |
| 12:55:43 | opendevreview | Stephen Finucane proposed openstack/osc-lib master: utils: Remove support for legacy format functions https://review.opendev.org/c/openstack/osc-lib/+/942271 | |
| 12:55:45 | opendevreview | Stephen Finucane proposed openstack/osc-lib master: utils: Deprecate legacy client-specific helpers https://review.opendev.org/c/openstack/osc-lib/+/942272 | |
| 12:55:48 | opendevreview | Stephen Finucane proposed openstack/osc-lib master: tests: Resolve TODO https://review.opendev.org/c/openstack/osc-lib/+/942273 | |
| 13:06:38 | opendevreview | Merged openstack/python-openstackclient master: Fix image import --disallow-failure flag https://review.opendev.org/c/openstack/python-openstackclient/+/940381 | |
| 13:06:40 | opendevreview | Merged openstack/python-openstackclient master: Update README for use python3 https://review.opendev.org/c/openstack/python-openstackclient/+/939769 | |
| 13:11:46 | opendevreview | Merged openstack/python-openstackclient master: Fix missing space in help messages https://review.opendev.org/c/openstack/python-openstackclient/+/943398 | |
| 13:11:48 | opendevreview | Merged openstack/python-openstackclient stable/2025.1: Add libpcre3-dev in bindep.txt for pcre.h https://review.opendev.org/c/openstack/python-openstackclient/+/944990 | |
| 14:51:38 | opendevreview | Artem Goncharov proposed openstack/codegenerator master: [DNM] Replace wrong simplification of vec of vec of strings https://review.opendev.org/c/openstack/codegenerator/+/945015 | |
| 15:37:24 | opendevreview | Slawek Kaplonski proposed openstack/python-openstackclient master: Fix networking quota usage show https://review.opendev.org/c/openstack/python-openstackclient/+/944782 | |
| 16:01:49 | opendevreview | Artem Goncharov proposed openstack/codegenerator master: Replace imported protocol schema https://review.opendev.org/c/openstack/codegenerator/+/945020 | |
| #openstack-sdks - 2025-03-20 | |||
| 02:12:30 | adamcarthur5 | Hi stephenfin, I wanted to give you an update on your validation work in Ironic. JayF and I decided to first work on getting a test suite made to test the microversion side of things, as that was not tested (https://review.opendev.org/c/openstack/ironic-tempest-plugin/+/943086). My plan is to go through and implement the equivalent of | |
| 02:12:30 | adamcarthur5 | https://review.opendev.org/c/openstack/ironic/+/928919/7 for all the API components. I wanted to clarify next steps though. Based on what you have done, there is "schema validation", and then I think there is more to do for some components. | |
| 02:13:38 | adamcarthur5 | I wanted to check exactly what that extra work is. You have a PR for allocations up (https://review.opendev.org/c/openstack/ironic/+/928921/5). Can you clarify what stage of the process this is (i.e does it include just the changes you did for shards, but in one PR, and for allocations, and is there anymore work to do?) | |
| 02:14:01 | adamcarthur5 | And also, do you know if the schema types are currently tested in tempest, or is that something else I should think about? | |
| 02:14:45 | adamcarthur5 | Thanks, I know this is a long message :^). If you would rather do it by email or a call let me know, you can get me at adam.mcarthur#gr-oss.io | |
| 09:46:13 | opendevreview | Artem Goncharov proposed openstack/codegenerator master: Replace wrong simplification of vec of vec of strings https://review.opendev.org/c/openstack/codegenerator/+/945015 | |
| 10:58:41 | opendevreview | Merged openstack/codegenerator master: Replace imported protocol schema https://review.opendev.org/c/openstack/codegenerator/+/945020 | |
| 11:16:15 | opendevreview | Artem Goncharov proposed openstack/codegenerator master: Replace wrong simplification of vec of vec of strings https://review.opendev.org/c/openstack/codegenerator/+/945015 | |
| 12:01:29 | opendevreview | Pavlo Shchelokovskyy proposed openstack/os-client-config master: Fix unit tests to pass locally https://review.opendev.org/c/openstack/os-client-config/+/945086 | |
| 12:01:29 | opendevreview | Pavlo Shchelokovskyy proposed openstack/os-client-config master: Stop using private SDK methods in config unit tests https://review.opendev.org/c/openstack/os-client-config/+/945087 | |
| 12:02:33 | opendevreview | Pavlo Shchelokovskyy proposed openstack/openstacksdk master: Refactor loader magic fixes https://review.opendev.org/c/openstack/openstacksdk/+/944123 | |
| 16:05:47 | opendevreview | Slawek Kaplonski proposed openstack/python-openstackclient master: Fix networking quota usage show https://review.opendev.org/c/openstack/python-openstackclient/+/944782 | |
| 16:54:40 | opendevreview | Merged openstack/codegenerator master: Replace wrong simplification of vec of vec of strings https://review.opendev.org/c/openstack/codegenerator/+/945015 | |
| 17:11:02 | stephenfin | adamcarthur5: Sorry, didn't get to that today. I'll respond first thing in the morning! | |
| 17:12:02 | adamcarthur5 | Of course, no problem, thank you! | |
| 18:59:46 | opendevreview | Merged openstack/os-client-config master: Fix unit tests to pass locally https://review.opendev.org/c/openstack/os-client-config/+/945086 | |
| 19:28:45 | opendevreview | Merged openstack/os-client-config master: Stop using private SDK methods in config unit tests https://review.opendev.org/c/openstack/os-client-config/+/945087 | |
| 19:59:27 | opendevreview | Merged openstack/openstacksdk master: Refactor and expand loader backward compat tests https://review.opendev.org/c/openstack/openstacksdk/+/944122 | |
| #openstack-sdks - 2025-03-21 | |||
| 08:56:46 | opendevreview | Dmitriy Chubinidze proposed openstack/python-openstackclient master: WIP: note for setting project https://review.opendev.org/c/openstack/python-openstackclient/+/945193 | |
| 09:37:35 | opendevreview | Merged openstack/python-openstackclient stable/2025.1: identity: Fix 'trust' commands to work with SDK https://review.opendev.org/c/openstack/python-openstackclient/+/944991 | |
| 10:32:12 | opendevreview | Rodolfo Alonso proposed openstack/python-openstackclient master: [Neutron] Add "qos-policy" parameter to router creation command https://review.opendev.org/c/openstack/python-openstackclient/+/945200 | |
| 11:08:27 | opendevreview | Merged openstack/keystoneauth stable/2025.1: Update .gitreview for stable/2025.1 https://review.opendev.org/c/openstack/keystoneauth/+/943704 | |
| 11:17:22 | opendevreview | Merged openstack/keystoneauth stable/2025.1: Update TOX_CONSTRAINTS_FILE for stable/2025.1 https://review.opendev.org/c/openstack/keystoneauth/+/943705 | |
| 11:57:13 | opendevreview | Rodolfo Alonso proposed openstack/openstacksdk master: Add QoS packet rate limit rule object and CRUD operations https://review.opendev.org/c/openstack/openstacksdk/+/945202 | |
| 12:06:07 | opendevreview | Rodolfo Alonso proposed openstack/openstacksdk master: Define the correct QoS rules deletion method https://review.opendev.org/c/openstack/openstacksdk/+/945205 | |
| 12:10:10 | opendevreview | Rodolfo Alonso proposed openstack/python-openstackclient master: Add QoS packet rate limit rule https://review.opendev.org/c/openstack/python-openstackclient/+/944784 | |
| 13:39:25 | opendevreview | Pavlo Shchelokovskyy proposed openstack/openstacksdk master: Refactor loader magic fixes https://review.opendev.org/c/openstack/openstacksdk/+/944123 | |
| 14:13:15 | opendevreview | Dmitriy Chubinidze proposed openstack/python-openstackclient master: Specifying project-domain for project https://review.opendev.org/c/openstack/python-openstackclient/+/945193 | |
| 14:33:58 | stephenfin | adamcarthur5: o/ I spent this morning splitting https://review.opendev.org/c/openstack/ironic/+/928921/5 up into smaller parts so the following explanation would make sense | |
| 14:35:43 | stephenfin | We want to get to the point that we can inspect controller functions, which map to a given route, and extra (a) the min/max microversion and the schemas for path, query string, request body and response body parameters | |
| 14:38:05 | stephenfin | ironic is starting from a slightly different place than other projects we've worked on (nova, cinder, keystone) since you're not doing things that are common across those, namely using jsonschema for request validation, using decorators for versioning, and using webob/routes. It's all solveable though | |
| 14:39:12 | stephenfin | So as I noted, I've broken https://review.opendev.org/c/openstack/ironic/+/928921/5 up to address those three things: | |
| 14:40:04 | stephenfin | The first moves API versioning to a decorator | |
| 14:40:06 | stephenfin | The second reworks request path, query string and body parameter validation to use JSONSchema instead of the homegrown stuff ironic has | |
| 14:40:32 | stephenfin | The third adds request body parameter validation, since that doesn't exist (at least at runtime) yet | |
| 14:42:07 | stephenfin | We will need to do those same 3 step for all APIs. Some will be more difficult than others, however, I was able to do all of the nova API (significantly larger) is down time, so it's far from insurmountable :) | |
| 14:43:13 | stephenfin | As for your other question: to the best of my knowledge, Tempest currently only has response body schemas for Nova and Cinder, and neither are comprehensive (Cinder particularly). I think these will go away once all the schemas have been added to Nova. | |
| 14:44:08 | stephenfin | for above message @ :35 : s/and extra (a)/and extract (b)/ | |
| 15:03:52 | opendevreview | Stephen Finucane proposed openstack/python-openstackclient master: zuul: Make image job non-voting https://review.opendev.org/c/openstack/python-openstackclient/+/945226 | |
| 15:04:24 | stephenfin | gtema: That keeps popping up ^ I think we'll end up removing it before long, but making it non-voting should do for now? | |
| 15:07:12 | gtema | agreed stephenfin. This job is afaik anyway only required by infra folks | |
| 15:07:28 | stephenfin | Sweet. I've sent it on its way | |
| 15:11:45 | opendevreview | Stephen Finucane proposed openstack/python-openstackclient stable/2025.1: zuul: Make image job non-voting https://review.opendev.org/c/openstack/python-openstackclient/+/945227 | |
| 15:18:39 | opendevreview | Merged openstack/python-openstackclient master: Update master for stable/2025.1 https://review.opendev.org/c/openstack/python-openstackclient/+/944835 | |
| 16:12:49 | opendevreview | Dmitriy Chubinidze proposed openstack/python-openstackclient master: Specifying project-domain for project https://review.opendev.org/c/openstack/python-openstackclient/+/945193 | |