| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-sdks - 2025-02-25 | |||
| 18:16:32 | stephenfin | Assuming you are running tests like e.g. 'tox -e functional-py39', you will need to install openstacksdk manually into the test environment in order to pick up your fix | |
| 18:17:20 | stephenfin | So e.g. 'source .tox/functional-py39/bin/activate; pip install -e $path_to_openstacksdk_repo_with_patches; deactivate; tox -e functional-py39' | |
| 18:17:28 | stephenfin | obviously you can sub 'py39' for 'py310' etc. | |
| 18:17:31 | M0weng[m] | Yeah I am seeing the install line where it installs from my local instead of the upstream. I'm using tox -e functional-tips and it re-installs every time. | |
| 18:17:37 | stephenfin | ah | |
| 18:17:46 | M0weng[m] | I edited tox.ini to point to my local version | |
| 18:18:04 | stephenfin | and your local version: you're on the correct branch with the fixes applied? | |
| 18:19:34 | M0weng[m] | Yep, it all seems to be there | |
| 18:21:13 | stephenfin | Very strange. I can't reproduce locally using `master` https://paste.opendev.org/show/byefSAYfIXTuuYWRgy1G/ | |
| 18:22:12 | stephenfin | You might just need to tidy up the PR and push it as a draft so, so one of us can take a look. I can't blame sdk quite yet | |
| 18:27:07 | M0weng[m] | Ok, will do when my next shift starts 👍️ | |
| 18:30:24 | opendevreview | Tim Burke proposed openstack/python-openstackclient master: Fix credential creation https://review.opendev.org/c/openstack/python-openstackclient/+/942721 | |
| 18:40:22 | timburke | FYI, ^^^ is needed to fix Swift's gate | |
| 19:06:50 | opendevreview | Merged openstack/codegenerator master: Increase openapi job timeout https://review.opendev.org/c/openstack/codegenerator/+/942676 | |
| 19:57:49 | opendevreview | Douglas Viroel proposed openstack/openstacksdk master: Bump compute max microversion to 2.100 https://review.opendev.org/c/openstack/openstacksdk/+/938833 | |
| 19:58:11 | opendevreview | Douglas Viroel proposed openstack/python-openstackclient master: Add support for showing scheduler_hints in server details https://review.opendev.org/c/openstack/python-openstackclient/+/938834 | |
| 21:19:05 | opendevreview | Merged openstack/python-openstackclient master: Fix credential creation https://review.opendev.org/c/openstack/python-openstackclient/+/942721 | |
| 21:31:34 | opendevreview | Oria Weng proposed openstack/python-openstackclient master: [DNM] Identity: Migrate 'registered limit' commands to SDK https://review.opendev.org/c/openstack/python-openstackclient/+/942735 | |
| 21:31:59 | M0weng[m] | stephenfin / gtema : New patch for registered limits: https://review.opendev.org/c/openstack/python-openstackclient/+/942735 | |
| 21:31:59 | M0weng[m] | The limits patch has been around for a while already (waiting on deprecation for `--region 'None'` behavior in six months): https://review.opendev.org/c/openstack/python-openstackclient/+/936279 | |
| 22:05:58 | opendevreview | Oria Weng proposed openstack/python-openstackclient master: [DNM] Identity: Migrate 'limit' commands to SDK https://review.opendev.org/c/openstack/python-openstackclient/+/936279 | |
| 22:06:29 | opendevreview | Oria Weng proposed openstack/python-openstackclient master: [DNM] Identity: Migrate 'limit' commands to SDK https://review.opendev.org/c/openstack/python-openstackclient/+/936279 | |
| 22:08:46 | opendevreview | Oria Weng proposed openstack/python-openstackclient master: [DNM] Identity: Migrate 'limit' commands to SDK https://review.opendev.org/c/openstack/python-openstackclient/+/936279 | |
| 22:10:31 | opendevreview | Oria Weng proposed openstack/python-openstackclient master: [DNM] Identity: Migrate 'limit' commands to SDK https://review.opendev.org/c/openstack/python-openstackclient/+/936279 | |
| 22:15:24 | opendevreview | Oria Weng proposed openstack/python-openstackclient master: [DNM] Identity: Migrate 'limit' commands to SDK https://review.opendev.org/c/openstack/python-openstackclient/+/936279 | |
| 22:48:45 | opendevreview | Merged openstack/python-openstackclient master: handle 'router create --flavor' option https://review.opendev.org/c/openstack/python-openstackclient/+/940595 | |
| 23:11:24 | opendevreview | Oria Weng proposed openstack/python-openstackclient master: [DNM] Identity: Migrate 'registered limit' commands to SDK https://review.opendev.org/c/openstack/python-openstackclient/+/942735 | |
| #openstack-sdks - 2025-02-26 | |||
| 00:25:36 | opendevreview | Oria Weng proposed openstack/python-openstackclient master: [DNM] Identity: Migrate 'registered limit' commands to SDK https://review.opendev.org/c/openstack/python-openstackclient/+/942735 | |
| 00:28:50 | opendevreview | Oria Weng proposed openstack/python-openstackclient master: [DNM] Identity: Migrate 'registered limit' commands to SDK https://review.opendev.org/c/openstack/python-openstackclient/+/942735 | |
| 00:29:26 | opendevreview | Oria Weng proposed openstack/python-openstackclient master: [DNM] Identity: Migrate 'registered limit' commands to SDK https://review.opendev.org/c/openstack/python-openstackclient/+/942735 | |
| 02:00:44 | opendevreview | Manuel Osorio proposed openstack/openstacksdk master: Add share transfer to shared file system https://review.opendev.org/c/openstack/openstacksdk/+/925653 | |
| 02:23:57 | Yanks | Hello team! I've got this streaming image download support PR: https://review.opendev.org/c/openstack/openstacksdk/+/927778 I've resolved all the comments as well, may I know if this could be merged? :) | |
| 07:54:13 | opendevreview | Artem Goncharov proposed openstack/codegenerator master: Ensure BS responses have some properties marked as required https://review.opendev.org/c/openstack/codegenerator/+/942631 | |
| 10:05:19 | opendevreview | Rajesh Tailor proposed openstack/openstacksdk master: Add support for image properties in server show https://review.opendev.org/c/openstack/openstacksdk/+/940798 | |
| 10:36:44 | opendevreview | Rajesh Tailor proposed openstack/python-openstackclient master: Add support for image properties in server show https://review.opendev.org/c/openstack/python-openstackclient/+/940799 | |
| 11:26:26 | opendevreview | Stephen Finucane proposed openstack/openstacksdk master: proxy: Remove '_check_resource' decorator https://review.opendev.org/c/openstack/openstacksdk/+/942597 | |
| 11:26:26 | opendevreview | Stephen Finucane proposed openstack/openstacksdk master: typing: Annotate openstack.proxy https://review.opendev.org/c/openstack/openstacksdk/+/942598 | |
| 11:26:27 | opendevreview | Stephen Finucane proposed openstack/openstacksdk master: typing: Annotate openstack.connection https://review.opendev.org/c/openstack/openstacksdk/+/942599 | |
| 11:26:27 | opendevreview | Stephen Finucane proposed openstack/openstacksdk master: WIP: typing: Annotate openstack.service_description https://review.opendev.org/c/openstack/openstacksdk/+/942600 | |
| 11:26:28 | opendevreview | Stephen Finucane proposed openstack/openstacksdk master: typing: Add (more) missing proxy arguments https://review.opendev.org/c/openstack/openstacksdk/+/942782 | |
| 11:34:20 | opendevreview | Artem Goncharov proposed openstack/codegenerator master: Ensure BS responses have some properties marked as required https://review.opendev.org/c/openstack/codegenerator/+/942631 | |
| 11:45:39 | opendevreview | Merged openstack/openstacksdk master: typing: Don't abuse Proxy._update https://review.opendev.org/c/openstack/openstacksdk/+/942685 | |
| 11:55:47 | opendevreview | Merged openstack/openstacksdk master: typing: Remove duplicate TypeVar https://review.opendev.org/c/openstack/openstacksdk/+/942596 | |
| 14:10:50 | opendevreview | Merged openstack/codegenerator master: Ensure BS responses have some properties marked as required https://review.opendev.org/c/openstack/codegenerator/+/942631 | |
| 15:33:57 | opendevreview | Stephen Finucane proposed openstack/openstacksdk master: identity: Fix limit, registered limit creation https://review.opendev.org/c/openstack/openstacksdk/+/942818 | |
| 15:33:58 | opendevreview | Stephen Finucane proposed openstack/openstacksdk master: identity: Add functional tests for limits, registered limits https://review.opendev.org/c/openstack/openstacksdk/+/942819 | |
| 15:33:58 | opendevreview | Stephen Finucane proposed openstack/openstacksdk master: WIP: tests: Add reference to system admin credentials https://review.opendev.org/c/openstack/openstacksdk/+/942820 | |
| 15:34:29 | stephenfin | M0weng[m]: mea culpa: looks like I broke you. 👆 should fix things | |
| 15:44:08 | opendevreview | Merged openstack/codegenerator master: Add barbican secret schemas https://review.opendev.org/c/openstack/codegenerator/+/941234 | |
| 15:56:18 | opendevreview | Stephen Finucane proposed openstack/openstacksdk master: typing: Add (more) missing proxy arguments https://review.opendev.org/c/openstack/openstacksdk/+/942782 | |
| 15:56:19 | opendevreview | Stephen Finucane proposed openstack/openstacksdk master: proxy: Remove '_check_resource' decorator https://review.opendev.org/c/openstack/openstacksdk/+/942597 | |
| 15:56:19 | opendevreview | Stephen Finucane proposed openstack/openstacksdk master: typing: Annotate openstack.proxy https://review.opendev.org/c/openstack/openstacksdk/+/942598 | |
| 15:56:20 | opendevreview | Stephen Finucane proposed openstack/openstacksdk master: typing: Annotate openstack.connection https://review.opendev.org/c/openstack/openstacksdk/+/942599 | |
| 15:56:20 | opendevreview | Stephen Finucane proposed openstack/openstacksdk master: WIP: typing: Annotate openstack.service_description https://review.opendev.org/c/openstack/openstacksdk/+/942600 | |
| 16:22:30 | opendevreview | Stephen Finucane proposed openstack/openstacksdk master: typing: Annotate openstack.proxy https://review.opendev.org/c/openstack/openstacksdk/+/942598 | |
| 16:22:31 | opendevreview | Stephen Finucane proposed openstack/openstacksdk master: typing: Annotate openstack.connection https://review.opendev.org/c/openstack/openstacksdk/+/942599 | |
| 16:22:31 | opendevreview | Stephen Finucane proposed openstack/openstacksdk master: WIP: typing: Annotate openstack.service_description https://review.opendev.org/c/openstack/openstacksdk/+/942600 | |
| 17:06:15 | stephenfin | gtema: If I run 'openstack --os-cloud devstack-system-admin registered limit list', I get the following error | |
| 17:06:25 | stephenfin | xpecting to find domain in user. The server could not comply with the request since it is either malformed or otherwise incorrect. The client is assumed to be in error. (HTTP 400) | |
| 17:06:48 | stephenfin | Is that expected? How does one do system-scoped operations otherwise? | |
| 17:07:32 | gtema | stephenfin - it works for me on devstack now | |
| 17:07:46 | gtema | at least with 7.2.1 as I see now | |
| 17:08:11 | gtema | potentially we broke it with some of the changes recently | |
| 17:08:28 | stephenfin | I'm seeing it fail on dtantsur's change here https://zuul.opendev.org/t/openstack/build/e745767e1b0d4e6d86a0dee43238478a | |
| 17:09:34 | stephenfin | is that OSC in a virtualenv? could you share your `pip freeze` output? | |
| 17:09:38 | gtema | hmm, even with 7.3.2 on devstack it works | |
| 17:10:07 | gtema | https://paste.openstack.org/show/bHixZI149prOY0IyMEW7/ | |
| 17:10:25 | stephenfin | it could be my devstack, but as I said I also see it on Dmitry's patch | |
| 17:10:29 | gtema | it's a pure osc venv | |
| 17:10:57 | gtema | I just reinstalled devstack today, so it should be fresh | |
| 17:13:18 | stephenfin | okay, and if you create a wholly new venv and just install OSC from pypi, it works? | |
| 17:14:34 | gtema | yupp, still works | |
| 17:14:40 | stephenfin | that's the log I see https://paste.opendev.org/show/b410BGwb97j6BUXKicSE/ though this is an old devstack from last october | |
| 17:14:41 | stephenfin | weird | |
| 17:14:53 | stephenfin | okay, something with my devstack so | |
| 17:15:22 | gtema | this just states that user_domain_id is missing in the clouds.yaml | |
| 17:16:25 | stephenfin | right, but it's system-scoped: there's no domain | |
| 17:17:13 | stephenfin | this is the clouds.yaml entry I'm using. I don't think I modified it since devstack generated it https://paste.opendev.org/show/bcvFHACtwhUadXDv1mHK/ | |
| 17:19:52 | gtema | no domain for the scope, but not for the user | |
| 17:20:07 | gtema | user_domain_id has nothing to do with the scope - it is info about user's home | |
| 17:20:52 | gtema | ok, in my clouds.yaml it is also missing | |
| 17:21:28 | stephenfin | Fair. You said you just deployed devstack: does your devstack-system-admin entry have a user_domain_id field? | |
| 17:21:46 | stephenfin | Looking at tools/update_clouds_yaml.py and I can't see how that would get set | |
| 17:22:16 | stephenfin | (tools/update_clouds_yaml.py in the devstack repo) | |
| 17:23:41 | gtema | nope, as just said it doesn't | |
| 17:24:10 | gtema | do you have fresh keystone log? | |
| 17:24:40 | stephenfin | sorry, missed that message | |
| 17:25:00 | stephenfin | yes, I just pulled from master and restarted the devstack@keystone service | |
| 17:27:40 | stephenfin | ...but it's also an issue on 24.0.0 from 1.5 years ago | |
| 17:30:07 | gtema | with hacking keystone a bit to add debug I see that it tries to validate {'user': {'password': 'secret', 'name': 'admin', 'domain': {'id': 'default'}}} as input | |
| 17:31:37 | gtema | totally weird is that osc debug log also states: Using auth plugin: password Using parameters {'auth_url': 'http://192.168.1.3/identity', 'system_scope': 'all', 'project_domain_id': 'default', 'username': 'admin', 'user_domain_id': 'default', 'password': '***'} | |
| 17:32:19 | stephenfin | Okay, something is regressed here so. I see: | |
| 17:32:20 | stephenfin | Using parameters {'auth_url': 'http://10.0.110.125/identity', 'system_scope': 'all', 'username': 'admin', 'password': '***'} | |
| 17:32:44 | stephenfin | no project_domain_id or user_domain_id fields | |
| 17:32:55 | stephenfin | and openstackclient on the devstack host works just fine | |
| 17:33:39 | gtema | yeah, this is how I test it now - osc directly on the devstack host | |
| 17:42:13 | gtema | stephenfin, at least in the osc-lib I see setting of the default_domain | |
| 17:43:04 | gtema | https://opendev.org/openstack/osc-lib/src/branch/master/osc_lib/shell.py#L44 | |
| 17:55:42 | stephenfin | gtema: Got to the bottom of it :( My local copy was missing the `identity_api_version: '3'` line | |
| 17:55:59 | gtema | he, very weird | |