| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-sdks - 2025-02-14 | |||
| 07:08:42 | opendevreview | Yanks proposed openstack/openstacksdk master: pass stream value https://review.opendev.org/c/openstack/openstacksdk/+/927778 | |
| 07:26:23 | opendevreview | Yaguang Tang proposed openstack/keystoneauth master: fix: correct oidc request error handling logic https://review.opendev.org/c/openstack/keystoneauth/+/941203 | |
| 07:41:49 | opendevreview | Yaguang Tang proposed openstack/keystoneauth master: fix: correct oidc request error handling logic https://review.opendev.org/c/openstack/keystoneauth/+/941203 | |
| 09:35:27 | Uggla | stephenfin, gtema, could you please have a look at 880056: Add shares API to compute | https://review.opendev.org/c/openstack/openstacksdk/+/880056 and 881540: Add share commands to compute | https://review.opendev.org/c/openstack/python-openstackclient/+/881540 | |
| 11:09:32 | stephenfin | gtema: Thoughts on merging OSC into SDK early in E? | |
| 11:09:49 | stephenfin | ...and making OSC a meta package | |
| 11:10:47 | stephenfin | or at least the compute, image, network and object storage parts of it since those are pure SDK now | |
| 11:10:55 | gtema | generally - ok. What I am concerned with is that at some stage everything is being splitted, later again re-merged. It is not about sdk/cli in particular, just an observation. | |
| 11:11:16 | gtema | are we now talking about merging into single repo while still having different pypi packages? | |
| 11:12:20 | stephenfin | At least in the short term, to avoid breaking workflows | |
| 11:12:27 | stephenfin | I think we can do one of two things | |
| 11:13:41 | stephenfin | Either (a) we do a wholesale import of everything from OSC into SDK but put it behind an extra in setup.cfg, and then have OSC literally have a requirements.txt e.g. 'openstacksdk[cli]' | |
| 11:14:13 | stephenfin | (a.k.a. similar to what the openstackclient meta-package is currently doing https://github.com/openstack/openstackclient/blob/master/requirements.txt) | |
| 11:15:13 | stephenfin | Or (b) we only import the actual service commands (i.e. 'openstackclient.compute', 'openstackclient.network') and add a 'openstack.cli.base' entry to our 'setup.cfg' | |
| 11:15:49 | stephenfin | I think (b) is conceptually nicer since that is using the same machinery that e.g. python-manilaclient is using to provide their OSC commands | |
| 11:16:49 | stephenfin | On your meta point of things being split out and remerged, I think that's a consequence of (a) tooling and (b) latterly the decreasing size of the community | |
| 11:17:31 | stephenfin | There was all this focus on various "lib" packages to share code between projects, mainly because Python doesn't historically make it easy to export multiple packages from a single repo | |
| 11:17:38 | gtema | (b) makes sense but then we still have 2 different repos and perhaps a mess questioning yourself: where the heck is x.y.z now coming from | |
| 11:18:37 | stephenfin | Plus Gerrit doesn't have anything like the k8s OWNER file thing: someone either has commit rights to the entire repo or they don't. You can't grant it for part of the repo. At least not natively. | |
| 11:18:39 | gtema | i am now often confused where is the actual implementation of the identity stuff that is somehow split between multiple different places | |
| 11:19:14 | stephenfin | The source of the CLI implementations is always shown if you do '--help' | |
| 11:19:22 | gtema | fyi: OWNER is not a k8s specific stuff, it is suported by git hosters | |
| 11:19:50 | gtema | I mean the code itself which is chaining pieces from different places and different repos | |
| 11:19:56 | gtema | not finding the entry point | |
| 11:20:19 | stephenfin | Gotcha. If we do (b) then I'm only proposing moving the services that are 100% SDK right now | |
| 11:20:32 | stephenfin | so there should be no novaclient, no swiftclient etc. | |
| 11:20:57 | gtema | ok, lets discuss more details during ptg | |
| 11:21:46 | stephenfin | OSC will take the shell utility stuff from osc-lib and cliff, and it will take the actual commands from either OSC itself (identity, block storage), SDK (compute, image, network and object storage), or one of the python-*client packages (shared filesystems, clustering etc.) | |
| 11:22:28 | gtema | we can meaybe also discuss merging osc-lib into osc itself. I do not understand why it is now a separate repo | |
| 11:23:33 | stephenfin | neither do I, so I'm onboard with that | |
| 11:23:52 | stephenfin | lemme draft up a PoC to demo what I'm thinking | |
| 11:24:04 | stephenfin | only a PoC since I'd like to find a way to preserve history if possible | |
| 11:25:24 | gtema | sure | |
| 12:43:04 | opendevreview | Stephen Finucane proposed openstack/python-openstackclient master: Permit use of tuple API_VERSIONS https://review.opendev.org/c/openstack/python-openstackclient/+/941636 | |
| 12:50:06 | opendevreview | Stephen Finucane proposed openstack/openstacksdk master: WIP: Add compute, image, network and object storage CLIs https://review.opendev.org/c/openstack/openstacksdk/+/941637 | |
| 12:52:30 | opendevreview | Stephen Finucane proposed openstack/python-openstackclient master: WIP: Remove compute, image, network and object storage CLIs https://review.opendev.org/c/openstack/python-openstackclient/+/941638 | |
| 12:57:40 | opendevreview | Stephen Finucane proposed openstack/python-openstackclient master: WIP: Remove compute, image, network and object storage CLIs https://review.opendev.org/c/openstack/python-openstackclient/+/941638 | |
| 12:57:44 | stephenfin | gtema: ^ | |
| 12:57:59 | stephenfin | That's going to fail so hard but that's the general idea | |
| 12:58:09 | gtema | cool, will look later today. Thanks | |
| 13:23:41 | opendevreview | Merged openstack/python-openstackclient master: Temporary ignore "is_vlan_qinq" column in the output https://review.opendev.org/c/openstack/python-openstackclient/+/940111 | |
| 13:23:43 | opendevreview | Merged openstack/openstacksdk master: Add "vlan_qinq" attribute to the "network" resource https://review.opendev.org/c/openstack/openstacksdk/+/939703 | |
| 13:23:45 | opendevreview | Merged openstack/python-openstackclient master: Add "qinq-vlan" and "no-qinq-vlan" params to the "network create" cmd https://review.opendev.org/c/openstack/python-openstackclient/+/939706 | |
| 14:13:26 | opendevreview | Rodolfo Alonso proposed openstack/python-openstackclient master: [Neutron] "uplink-status-propagation" enabled by default https://review.opendev.org/c/openstack/python-openstackclient/+/941552 | |
| 14:25:26 | opendevreview | Rodolfo Alonso proposed openstack/python-openstackclient master: [Neutron] Support ``uplink-status-propagation-updatable`` extension https://review.opendev.org/c/openstack/python-openstackclient/+/941555 | |
| 16:29:22 | opendevreview | Merged openstack/keystoneauth master: typing: Deprecate use of AuthConstructor https://review.opendev.org/c/openstack/keystoneauth/+/935770 | |
| 20:48:31 | opendevreview | Merged openstack/keystoneauth master: typing: Removing additional unused kwargs (1/2) https://review.opendev.org/c/openstack/keystoneauth/+/935771 | |
| 21:18:39 | opendevreview | Merged openstack/keystoneauth master: typing: Removing additional unused kwargs (2/2) https://review.opendev.org/c/openstack/keystoneauth/+/941242 | |
| 21:18:40 | opendevreview | Merged openstack/keystoneauth master: pre-commit: Bump versions https://review.opendev.org/c/openstack/keystoneauth/+/941253 | |
| #openstack-sdks - 2025-02-15 | |||
| 06:53:27 | opendevreview | Doug Goldstein proposed openstack/python-openstackclient master: handle 'router create --flavor' option https://review.opendev.org/c/openstack/python-openstackclient/+/940595 | |
| 14:38:15 | opendevreview | Merged openstack/os-api-ref master: Bump pre-commit config https://review.opendev.org/c/openstack/os-api-ref/+/941102 | |
| 18:14:54 | opendevreview | Doug Goldstein proposed openstack/python-openstackclient master: handle 'router create --flavor' option https://review.opendev.org/c/openstack/python-openstackclient/+/940595 | |
| 18:16:29 | opendevreview | Doug Goldstein proposed openstack/python-openstackclient master: handle 'router create --flavor' option https://review.opendev.org/c/openstack/python-openstackclient/+/940595 | |
| 20:04:37 | opendevreview | Doug Goldstein proposed openstack/python-openstackclient master: handle 'router create --flavor' option https://review.opendev.org/c/openstack/python-openstackclient/+/940595 | |
| #openstack-sdks - 2025-02-17 | |||
| 13:29:07 | opendevreview | Niklas Schwarz proposed openstack/openstacksdk master: Add listing of groups for a user https://review.opendev.org/c/openstack/openstacksdk/+/941540 | |
| #openstack-sdks - 2025-02-18 | |||
| 12:09:04 | ralonsoh | stephenfin, hello! if you have some minutes, please check these two patches | |
| 12:09:05 | ralonsoh | https://review.opendev.org/c/openstack/python-openstackclient/+/941552 | |
| 12:09:11 | ralonsoh | https://review.opendev.org/c/openstack/python-openstackclient/+/941555 | |
| 12:09:16 | ralonsoh | thanks in advance! | |
| 12:09:38 | opendevreview | Rodolfo Alonso proposed openstack/python-openstackclient master: [Neutron] Support ``uplink-status-propagation-updatable`` extension https://review.opendev.org/c/openstack/python-openstackclient/+/941555 | |
| 13:57:41 | opendevreview | Jan Ueberacker proposed openstack/python-openstackclient master: Allow filtering for enabled/disabled projects and users https://review.opendev.org/c/openstack/python-openstackclient/+/942103 | |
| 14:49:22 | opendevreview | Stephen Finucane proposed openstack/keystoneauth master: typing: Move py.typed to correct location https://review.opendev.org/c/openstack/keystoneauth/+/942108 | |
| 15:15:41 | mblue_ | Hi gtema, can you please review this? I need openstackclient bump for whitebox-neutron-tempest-plugin tests | |
| 15:15:46 | mblue_ | 942104: Release python-openstackclient 8.0.0 branch for epoxy | https://review.opendev.org/c/openstack/releases/+/942104 | |
| 15:16:14 | gtema | sure, I was just confused with 2 releases proposed within 1 day | |
| 15:23:04 | mblue_ | gtema, stephenfin: thank you for reviewing, changed to 7.3.0 | |
| 15:27:37 | gtema | mblue_ you should also fix the change title | |
| 15:29:07 | mblue_ | gtema, missed that! done, thanks | |
| 17:27:48 | opendevreview | Merged openstack/keystoneauth master: typing: Move py.typed to correct location https://review.opendev.org/c/openstack/keystoneauth/+/942108 | |
| 18:24:51 | opendevreview | Merged openstack/osc-lib master: reno: Update master for unmaintained/2023.1 https://review.opendev.org/c/openstack/osc-lib/+/935071 | |
| #openstack-sdks - 2025-02-19 | |||
| 03:18:11 | opendevreview | Yanks proposed openstack/openstacksdk master: Support streaming download of the image https://review.opendev.org/c/openstack/openstacksdk/+/927778 | |
| 07:38:29 | opendevreview | Rajesh Tailor proposed openstack/python-openstackclient master: Add support for image properties in server show https://review.opendev.org/c/openstack/python-openstackclient/+/940799 | |
| 08:02:32 | mblue | Hi gtema, stephenfin, depends-on doesn't work to include this patch for test patch. | |
| 08:02:34 | mblue | Can we get this merged? is there anything else needed? | |
| 08:02:41 | mblue | 942104: Release python-openstackclient 7.3.0 branch for epoxy | https://review.opendev.org/c/openstack/releases/+/942104 | |
| 08:09:24 | gtema | mbue, release team is responsible for that, we can't do anything. It typically takes around a week | |
| 08:09:33 | gtema | mblue ^^ | |
| 08:11:47 | mblue | gtema, ack, thank you, I will WA it in specific jobs configurations | |
| 09:19:04 | opendevreview | Yaguang Tang proposed openstack/keystoneauth master: fix logic issue for getting IDP data with HTTP 400 response https://review.opendev.org/c/openstack/keystoneauth/+/942171 | |
| 11:08:07 | opendevreview | Rodolfo Alonso proposed openstack/python-openstackclient master: Add four new network agent types to the list command filter https://review.opendev.org/c/openstack/python-openstackclient/+/942175 | |
| 12:50:49 | opendevreview | Stephen Finucane proposed openstack/openstacksdk master: pre-commit: Bump versions https://review.opendev.org/c/openstack/openstacksdk/+/941280 | |
| 12:50:49 | opendevreview | Stephen Finucane proposed openstack/openstacksdk master: cloud: Remove object container cache https://review.opendev.org/c/openstack/openstacksdk/+/941264 | |
| 12:50:50 | opendevreview | Stephen Finucane proposed openstack/openstacksdk master: mypy: Move configuration to pyproject.toml https://review.opendev.org/c/openstack/openstacksdk/+/941266 | |
| 12:50:50 | opendevreview | Stephen Finucane proposed openstack/openstacksdk master: mypy: Add keystoneauth1 as dependency https://review.opendev.org/c/openstack/openstacksdk/+/941265 | |
| 12:50:51 | opendevreview | Stephen Finucane proposed openstack/openstacksdk master: mypy: Enable stricter mode https://review.opendev.org/c/openstack/openstacksdk/+/941267 | |
| 12:50:51 | opendevreview | Stephen Finucane proposed openstack/openstacksdk master: mypy: Enable disallow_incomplete_defs https://review.opendev.org/c/openstack/openstacksdk/+/941268 | |
| 12:50:52 | opendevreview | Stephen Finucane proposed openstack/openstacksdk master: typing: Annotate Resource.wait_for_* utils https://review.opendev.org/c/openstack/openstacksdk/+/941269 | |
| 12:50:53 | opendevreview | Stephen Finucane proposed openstack/openstacksdk master: proxy: Add 'wait_for_*' helpers to all proxy APIs https://review.opendev.org/c/openstack/openstacksdk/+/941270 | |
| 12:50:53 | opendevreview | Stephen Finucane proposed openstack/openstacksdk master: resource: Rework fields https://review.opendev.org/c/openstack/openstacksdk/+/941271 | |
| 12:50:55 | opendevreview | Stephen Finucane proposed openstack/openstacksdk master: fields: Tweak _convert_type https://review.opendev.org/c/openstack/openstacksdk/+/941272 | |
| 12:50:55 | opendevreview | Stephen Finucane proposed openstack/openstacksdk master: fields: Be more explicit in our conversion https://review.opendev.org/c/openstack/openstacksdk/+/941273 | |
| 12:50:57 | opendevreview | Stephen Finucane proposed openstack/openstacksdk master: typing: Annotate openstack.format https://review.opendev.org/c/openstack/openstacksdk/+/941274 | |
| 12:50:57 | opendevreview | Stephen Finucane proposed openstack/openstacksdk master: typing: Annotate openstack.fields (1/2) https://review.opendev.org/c/openstack/openstacksdk/+/941275 | |
| 12:50:59 | opendevreview | Stephen Finucane proposed openstack/openstacksdk master: typing: Don't rely on kwargs for _translate_response https://review.opendev.org/c/openstack/openstacksdk/+/941277 | |
| 12:50:59 | opendevreview | Stephen Finucane proposed openstack/openstacksdk master: typing: Annotate openstack.fields (2/2) https://review.opendev.org/c/openstack/openstacksdk/+/941276 | |
| 12:51:01 | opendevreview | Stephen Finucane proposed openstack/openstacksdk master: network: Set If-Match header properly https://review.opendev.org/c/openstack/openstacksdk/+/941278 | |
| 12:51:01 | opendevreview | Stephen Finucane proposed openstack/openstacksdk master: pre-commit: Prepare for bump https://review.opendev.org/c/openstack/openstacksdk/+/942184 | |
| 12:51:03 | opendevreview | Stephen Finucane proposed openstack/openstacksdk master: typing: Annotate openstack.exceptions https://review.opendev.org/c/openstack/openstacksdk/+/942185 | |
| 12:51:03 | opendevreview | Stephen Finucane proposed openstack/openstacksdk master: typing: Annotate openstack.utils https://review.opendev.org/c/openstack/openstacksdk/+/942186 | |
| 12:51:05 | opendevreview | Stephen Finucane proposed openstack/openstacksdk master: volume: Remove _base_proxy module https://review.opendev.org/c/openstack/openstacksdk/+/942187 | |