| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-sdks - 2024-09-12 | |||
| 13:40:15 | opendevreview | Pavlo Shchelokovskyy proposed openstack/openstacksdk master: Followup to I0e5ac1288c0d0423fa3a7a4e63173675b78aae79 https://review.opendev.org/c/openstack/openstacksdk/+/929090 | |
| 13:43:18 | opendevreview | Stephen Finucane proposed openstack/python-openstackclient master: Removed the emit_duplicated_warning() funtion. https://review.opendev.org/c/openstack/python-openstackclient/+/927743 | |
| 13:53:05 | opendevreview | Merged openstack/cliff stable/2024.2: Update .gitreview for stable/2024.2 https://review.opendev.org/c/openstack/cliff/+/928140 | |
| 13:53:06 | opendevreview | Merged openstack/cliff stable/2024.2: Update TOX_CONSTRAINTS_FILE for stable/2024.2 https://review.opendev.org/c/openstack/cliff/+/928141 | |
| 14:26:43 | opendevreview | Merged openstack/osc-lib master: Fix log level, remove unnecessary debug https://review.opendev.org/c/openstack/osc-lib/+/914971 | |
| 14:41:10 | opendevreview | KyeongNa Park proposed openstack/openstacksdk master: Add create, delete, find, list and UPDATE example connect code https://review.opendev.org/c/openstack/openstacksdk/+/928129 | |
| 16:18:21 | opendevreview | Stephen Finucane proposed openstack/openstacksdk master: Add timeline for removal of deprecated features https://review.opendev.org/c/openstack/openstacksdk/+/929015 | |
| 16:18:22 | opendevreview | Stephen Finucane proposed openstack/openstacksdk master: Deprecate unnecessary options, aliases https://review.opendev.org/c/openstack/openstacksdk/+/929016 | |
| 16:18:22 | opendevreview | Stephen Finucane proposed openstack/openstacksdk master: exceptions: Deprecate http_status, request_id params https://review.opendev.org/c/openstack/openstacksdk/+/929017 | |
| 16:28:24 | opendevreview | Merged openstack/python-openstackclient master: Drop support for Python 3.8 https://review.opendev.org/c/openstack/python-openstackclient/+/924493 | |
| 16:41:00 | opendevreview | Stephen Finucane proposed openstack/cliff master: Migrate to ruff, ruff-format https://review.opendev.org/c/openstack/cliff/+/929157 | |
| 16:41:00 | opendevreview | Stephen Finucane proposed openstack/cliff master: ruff: Enable pyupgrade rules https://review.opendev.org/c/openstack/cliff/+/929158 | |
| 16:41:01 | opendevreview | Stephen Finucane proposed openstack/cliff master: Remove unnecessary shebangs https://review.opendev.org/c/openstack/cliff/+/929159 | |
| 16:51:17 | opendevreview | Stephen Finucane proposed openstack/openstacksdk master: pre-commit: Migrate pyupgrade to ruff-format https://review.opendev.org/c/openstack/openstacksdk/+/929160 | |
| 16:55:20 | opendevreview | Stephen Finucane proposed openstack/osc-lib master: ruff: Enable pyupgrade rules https://review.opendev.org/c/openstack/osc-lib/+/929161 | |
| 17:08:31 | opendevreview | Stephen Finucane proposed openstack/python-openstackclient master: pre-commit: Migrate bandit to ruff https://review.opendev.org/c/openstack/python-openstackclient/+/929163 | |
| 17:08:32 | opendevreview | Stephen Finucane proposed openstack/python-openstackclient master: pre-commit: Migrate pyupgrade to ruff https://review.opendev.org/c/openstack/python-openstackclient/+/929164 | |
| 17:09:18 | JayF | stephenfin: <3 I have an item on Ironic's PTG to purse similar | |
| 17:09:24 | JayF | re: pre-commit/ruff | |
| 17:09:47 | stephenfin | we were discussing it in #openstack-keystone yesterday. It's a kick-ass tool | |
| 17:10:23 | stephenfin | we're migrating/have migrated all sdk deps to it (we were already using black in many places) | |
| 17:11:35 | JayF | Only real issue last time I looked at it is that it wasn't packaged everywhere | |
| 17:11:42 | JayF | but I think in the intervening months that's changed a lot | |
| 17:12:33 | stephenfin | We run it via pre-commit (including when called via tox) and don't include it in our requirements.txt, so as long as the user can access git to pull the pre-built binaries, they're good | |
| 17:13:58 | JayF | I think I'd want distro packages on most common development distros (latest ubuntu; fedora) so that it wouldn't be an issue for users behind a firewall or some kind of security policy. | |
| 17:17:28 | stephenfin | fair | |
| 17:19:19 | opendevreview | Merged openstack/osc-lib master: parseactions: Use ArgumentError, not ArgumentTypeError https://review.opendev.org/c/openstack/osc-lib/+/836204 | |
| 17:21:41 | opendevreview | Merged openstack/osc-lib master: pre-commit: Migrate from flake8 to ruff https://review.opendev.org/c/openstack/osc-lib/+/929052 | |
| 17:21:42 | opendevreview | Merged openstack/osc-lib master: pre-commit: Migrate from black to ruff format https://review.opendev.org/c/openstack/osc-lib/+/929053 | |
| 18:37:15 | opendevreview | Merged openstack/python-openstackclient master: compute: Fix --host in server list for new openstacksdk https://review.opendev.org/c/openstack/python-openstackclient/+/926193 | |
| 18:46:39 | opendevreview | Merged openstack/osc-lib master: Exclude tests directory from coverage calculation https://review.opendev.org/c/openstack/osc-lib/+/906664 | |
| 18:46:40 | opendevreview | Merged openstack/osc-lib master: ruff: Enable pyupgrade rules https://review.opendev.org/c/openstack/osc-lib/+/929161 | |
| 19:19:46 | opendevreview | Merged openstack/openstacksdk master: Do not create a class in runtime on a potentially hot path https://review.opendev.org/c/openstack/openstacksdk/+/920541 | |
| 19:19:48 | opendevreview | Merged openstack/python-openstackclient master: Removed the emit_duplicated_warning() funtion. https://review.opendev.org/c/openstack/python-openstackclient/+/927743 | |
| 22:25:33 | opendevreview | Merged openstack/openstacksdk master: pre-commit: Bump mypy https://review.opendev.org/c/openstack/openstacksdk/+/927517 | |
| 22:25:36 | opendevreview | Merged openstack/openstacksdk master: Drop support for Python 3.8 https://review.opendev.org/c/openstack/openstacksdk/+/923662 | |
| 22:25:38 | opendevreview | Merged openstack/openstacksdk master: mypy: Run under minimum Python version https://review.opendev.org/c/openstack/openstacksdk/+/923663 | |
| 22:25:40 | opendevreview | Merged openstack/openstacksdk master: Remove redundant code https://review.opendev.org/c/openstack/openstacksdk/+/923664 | |
| #openstack-sdks - 2024-09-13 | |||
| 05:08:47 | opendevreview | Yoonho Hann proposed openstack/openstacksdk master: Add getting the status of the services in designate system https://review.opendev.org/c/openstack/openstacksdk/+/927673 | |
| 05:36:39 | opendevreview | Yoonho Hann proposed openstack/openstacksdk master: Add getting the status of the services in designate system https://review.opendev.org/c/openstack/openstacksdk/+/927673 | |
| 06:00:57 | tkajinam | "BadRequestException: 400: Client Error for url: http://127.0.0.1/identity/v3/users, Invalid input for field 'domain_id': None is not of type 'string'" | |
| 06:01:24 | tkajinam | This is now seen in response to 'openstack user create' without any domain options. Probably is something related to recent schema validation work ? | |
| 06:01:33 | tkajinam | (probably I should have asked this in keystone | |
| 06:01:52 | frickler | tkajinam: is this with osc? we made a new release yesterday | |
| 06:02:05 | frickler | and I was just about to mention another regression https://zuul.opendev.org/t/openstack/build/54d612aa4622478d87cd8c42eacc9daa | |
| 06:02:26 | frickler | ah, you said "user create" | |
| 06:02:39 | tkajinam | https://zuul.opendev.org/t/openstack/build/4165b7790b7e4fa19a1837b9e08e2d76/log/job-output.txt#10797-10806 | |
| 06:03:30 | tkajinam | Ugh. it turned out we don't capture keystone log in storlets CI... I'll look into it | |
| 06:04:00 | tkajinam | but I suspect that the failure is triggered by https://github.com/openstack/storlets/blob/master/devstack/plugin.sh#L113 | |
| 06:06:35 | frickler | it looks like you do "export OS_USER_DOMAIN_ID=default", maybe this isn't picked up properly, let me try to test this locally | |
| 06:06:44 | tkajinam | frickler, the bump is only done in master, right ? It's strange that the failure appears in 2024.1 | |
| 06:06:50 | tkajinam | s/2024.1/2024.2 | |
| 06:08:07 | tkajinam | I've pushed the debug change which adds --debug to see details of these commands. | |
| 06:13:00 | frickler | tkajinam: 2024.2 is using master constraints since reqs are not branched yet | |
| 06:13:13 | tkajinam | ah, ok | |
| 06:13:15 | frickler | I can confirm that this is another regression with osc >= 7 | |
| 06:13:27 | frickler | can you open a bug report on launchpad? | |
| 06:14:45 | frickler | essentially it looks like the issue is making "--domain" a required option for "user create" (and likely others), instead of using "default" by default | |
| 06:16:47 | frickler | tkajinam: so the workaround would be to add "--domain $STORLETS_DEFAULT_USER_DOMAIN_ID" to your call | |
| 06:17:00 | frickler | gtema: ^^ fyi | |
| 06:52:34 | tkajinam | frickler, ack. will create a bug. thx | |
| 06:57:54 | tkajinam | https://bugs.launchpad.net/python-openstackclient/+bug/2080600 | |
| 08:13:10 | opendevreview | 이현규 proposed openstack/openstacksdk master: ADD DNS Zone Blacklist CRUD https://review.opendev.org/c/openstack/openstacksdk/+/927824 | |
| 08:44:52 | opendevreview | Stephen Finucane proposed openstack/cliff master: Drop support for Python 3.8, add Python 3.12 https://review.opendev.org/c/openstack/cliff/+/929224 | |
| 08:49:28 | opendevreview | Stephen Finucane proposed openstack/cliff master: Migrate to ruff, ruff-format https://review.opendev.org/c/openstack/cliff/+/929157 | |
| 08:49:34 | opendevreview | Stephen Finucane proposed openstack/cliff master: ruff: Enable pyupgrade rules https://review.opendev.org/c/openstack/cliff/+/929158 | |
| 08:49:37 | opendevreview | Stephen Finucane proposed openstack/cliff master: Remove unnecessary shebangs https://review.opendev.org/c/openstack/cliff/+/929159 | |
| 09:00:27 | opendevreview | Stephen Finucane proposed openstack/openstacksdk master: Return payload as text only for text/plain secrets https://review.opendev.org/c/openstack/openstacksdk/+/928151 | |
| 09:00:27 | opendevreview | Stephen Finucane proposed openstack/openstacksdk master: Followup to I0e5ac1288c0d0423fa3a7a4e63173675b78aae79 https://review.opendev.org/c/openstack/openstacksdk/+/929090 | |
| 09:18:52 | opendevreview | KyeongNa Park proposed openstack/openstacksdk master: Add create, delete, find, list and UPDATE example connect code https://review.opendev.org/c/openstack/openstacksdk/+/928129 | |
| 10:21:16 | opendevreview | KyeongNa Park proposed openstack/openstacksdk master: Add create, delete, find, list and UPDATE example connect code https://review.opendev.org/c/openstack/openstacksdk/+/928129 | |
| 10:27:41 | opendevreview | Stephen Finucane proposed openstack/openstacksdk master: compute: Add support for targeting host during migrate https://review.opendev.org/c/openstack/openstacksdk/+/920948 | |
| 10:34:34 | opendevreview | Stephen Finucane proposed openstack/python-openstackclient master: Handle NotFoundException when listing floating IPs https://review.opendev.org/c/openstack/python-openstackclient/+/694571 | |
| 10:35:41 | opendevreview | Rodolfo Alonso proposed openstack/openstacksdk master: Add method to create network resource tags https://review.opendev.org/c/openstack/openstacksdk/+/927779 | |
| 10:38:15 | opendevreview | Stephen Finucane proposed openstack/python-openstackclient master: Add --relay-state-prefix option to Service Provider https://review.opendev.org/c/openstack/python-openstackclient/+/657089 | |
| 10:41:07 | opendevreview | Jens Harbott proposed openstack/python-openstackclient master: evacuate: Only pass password parameter if set https://review.opendev.org/c/openstack/python-openstackclient/+/929236 | |
| 10:50:03 | opendevreview | Merged openstack/openstacksdk master: Cast all header values to string https://review.opendev.org/c/openstack/openstacksdk/+/924301 | |
| 11:23:01 | opendevreview | Jens Harbott proposed openstack/python-openstackclient master: evacuate: Fix password parameter name for SDK https://review.opendev.org/c/openstack/python-openstackclient/+/929236 | |
| 11:24:01 | frickler | stephenfin: gtema: ^^ that'll be needed to unblock nova iiuc | |
| 11:26:49 | opendevreview | Merged openstack/openstacksdk master: Return payload as text only for text/plain secrets https://review.opendev.org/c/openstack/openstacksdk/+/928151 | |
| 12:05:14 | frickler | this looks like another thing that's broken on noble, if someone wants to take a look we might want to avoid having to pin the job to jammy https://zuul.opendev.org/t/openstack/builds?job_name=openstackclient-check-plugins&project=openstack/python-openstackclient | |
| 12:36:48 | opendevreview | Merged openstack/python-openstackclient master: Remove TestServer base class https://review.opendev.org/c/openstack/python-openstackclient/+/919893 | |
| 12:36:50 | opendevreview | Merged openstack/python-openstackclient master: tests: Remove aliasing from extensions test https://review.opendev.org/c/openstack/python-openstackclient/+/924403 | |
| 13:45:29 | opendevreview | Yoonho Hann proposed openstack/openstacksdk master: Add getting the status of the services in designate system https://review.opendev.org/c/openstack/openstacksdk/+/927673 | |
| 14:33:05 | gtema | frickler, you mean https://review.opendev.org/c/openstack/python-openstackclient/+/929236? | |
| 15:28:08 | frickler | gtema: yes, sean is verifying now with https://review.opendev.org/c/openstack/nova/+/929187 but I also tested locally | |
| 15:29:00 | frickler | gtema: then there's also the regression discovered by tkajinam, I didn't look into how to fix that yet and likely won't have time to in the near future | |
| 15:31:49 | tkajinam | so it seems migration to sdk made 'user create' require --domain... To "fix" it we may need to let osc/sdk to accept no domain id which sounds like a bit tricky | |
| 15:32:32 | tkajinam | if 'user create' without --domain was explicitly deprecated then we can document the change in a release note ? Though I've never seen any explicit message (by osc at least) | |
| 15:33:01 | tkajinam | gtema, this is the one https://bugs.launchpad.net/python-openstackclient/+bug/2080600 | |
| 15:46:23 | JayF | that is a very unfortunate behavior change | |
| 15:46:35 | JayF | there are huge numbers of openstack deployers who don't use domain, or even have a mental model of it | |
| 15:46:49 | JayF | I anticipate this being an extremely breaking change | |
| 16:05:11 | gtema | what relates to me I moved from the believe of sdk/cli being able to negotiate all corner cases (and OpenStack is full of those) saying: if the service is doing it this way - blame the service and not the sdk/cli team | |
| 16:12:32 | JayF | To be clear: my comment is not meant to point blame; just indicate from a high level this will likely be messy if released this way. | |
| 16:19:44 | gtema | I do get it JayF, it is just extremely frustrating that people want improvements and extensions on one side and immediately crying on any logical interface change. It is impossible to maintain cli/sdk reasonably. | |
| 16:21:05 | JayF | Yes, I entirely understand. When we wrote the recent Ironic security fix, we specifically ensured to make a path for people to be secured even if they didn't update IPA | |
| 17:08:09 | opendevreview | Stephen Finucane proposed openstack/python-openstackclient master: Add status filtering options to port list https://review.opendev.org/c/openstack/python-openstackclient/+/444810 | |
| 17:09:32 | opendevreview | Merged openstack/keystoneauth master: Drop support for Python 3.8 https://review.opendev.org/c/openstack/keystoneauth/+/928833 | |
| 17:21:02 | opendevreview | Merged openstack/cliff master: Drop support for Python 3.8, add Python 3.12 https://review.opendev.org/c/openstack/cliff/+/929224 | |