| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-sdks - 2024-07-10 | |||
| 14:50:51 | opendevreview | Antonia Gaete proposed openstack/python-openstackclient master: identity: Migrate 'domain' commands to SDK https://review.opendev.org/c/openstack/python-openstackclient/+/923785 | |
| 15:01:56 | opendevreview | Stephen Finucane proposed openstack/openstacksdk master: compute: Correct base path for default, detailed quotas https://review.opendev.org/c/openstack/openstacksdk/+/923863 | |
| 15:01:56 | opendevreview | Stephen Finucane proposed openstack/openstacksdk master: compute, volume: Improve 'update_quota_set' https://review.opendev.org/c/openstack/openstacksdk/+/923864 | |
| 15:11:01 | opendevreview | Stephen Finucane proposed openstack/python-openstackclient master: quota: Migrate 'quota *' to SDK https://review.opendev.org/c/openstack/python-openstackclient/+/919891 | |
| 15:11:02 | opendevreview | Stephen Finucane proposed openstack/python-openstackclient master: Remove python-novaclient https://review.opendev.org/c/openstack/python-openstackclient/+/918803 | |
| 15:11:02 | opendevreview | Stephen Finucane proposed openstack/python-openstackclient master: Remove TestServer base class https://review.opendev.org/c/openstack/python-openstackclient/+/919893 | |
| 15:11:03 | opendevreview | Stephen Finucane proposed openstack/python-openstackclient master: quota: Move nova-network-related quota https://review.opendev.org/c/openstack/python-openstackclient/+/923866 | |
| 15:11:03 | opendevreview | Stephen Finucane proposed openstack/python-openstackclient master: quota: Remove deprecated quota options https://review.opendev.org/c/openstack/python-openstackclient/+/923867 | |
| 15:11:04 | opendevreview | Stephen Finucane proposed openstack/python-openstackclient master: quota: Default network quotas to not force https://review.opendev.org/c/openstack/python-openstackclient/+/923868 | |
| 15:11:04 | opendevreview | Stephen Finucane proposed openstack/python-openstackclient master: quota: Split up 'quota list' command https://review.opendev.org/c/openstack/python-openstackclient/+/923869 | |
| 16:37:45 | opendevreview | Merged openstack/keystoneauth master: Remove old excludes https://review.opendev.org/c/openstack/keystoneauth/+/917598 | |
| 17:49:50 | opendevreview | Antonia Gaete proposed openstack/python-openstackclient master: identity: Migrate 'credential' commands to SDK https://review.opendev.org/c/openstack/python-openstackclient/+/923674 | |
| #openstack-sdks - 2024-07-11 | |||
| 07:26:58 | opendevreview | Maximilian Sesterhenn proposed openstack/ansible-collections-openstack master: Add address_group, address_scope and subnetpool to Neutron RBAC https://review.opendev.org/c/openstack/ansible-collections-openstack/+/923839 | |
| 10:08:02 | opendevreview | Salman Hajizada proposed openstack/openstacksdk master: baremetal: Enhance VIF attachment with port and portgroup UUIDs https://review.opendev.org/c/openstack/openstacksdk/+/921890 | |
| 12:01:59 | opendevreview | Stephen Finucane proposed openstack/openstacksdk master: compute, volume: Improve 'update_quota_set' https://review.opendev.org/c/openstack/openstacksdk/+/923864 | |
| 12:02:09 | opendevreview | Stephen Finucane proposed openstack/python-openstackclient master: quota: Remove deprecated quota options https://review.opendev.org/c/openstack/python-openstackclient/+/923867 | |
| 12:02:10 | opendevreview | Stephen Finucane proposed openstack/python-openstackclient master: quota: Default network quotas to not force https://review.opendev.org/c/openstack/python-openstackclient/+/923868 | |
| 12:02:10 | opendevreview | Stephen Finucane proposed openstack/python-openstackclient master: quota: Split up 'quota list' command https://review.opendev.org/c/openstack/python-openstackclient/+/923869 | |
| 12:02:11 | opendevreview | Stephen Finucane proposed openstack/python-openstackclient master: quota: Migrate 'quota *' to SDK https://review.opendev.org/c/openstack/python-openstackclient/+/919891 | |
| 12:02:11 | opendevreview | Stephen Finucane proposed openstack/python-openstackclient master: Remove python-novaclient https://review.opendev.org/c/openstack/python-openstackclient/+/918803 | |
| 12:02:12 | opendevreview | Stephen Finucane proposed openstack/python-openstackclient master: Remove TestServer base class https://review.opendev.org/c/openstack/python-openstackclient/+/919893 | |
| 12:02:12 | opendevreview | Stephen Finucane proposed openstack/python-openstackclient master: quota: Add 'quota set --default' option https://review.opendev.org/c/openstack/python-openstackclient/+/923949 | |
| 14:35:40 | ganso | stephenfin, frickler, diablo_rojo, fungi: would you kindly review the following patch when you have a minute? Thanks in advance! https://review.opendev.org/c/openstack/openstacksdk/+/922965 | |
| 14:54:14 | opendevreview | Mohamed Waiel Shikfa proposed openstack/openstacksdk master: Add virtual media attachment and detachment support https://review.opendev.org/c/openstack/openstacksdk/+/921957 | |
| 15:18:42 | iurygregory | stephenfin, since Dmitry is out can you look at https://review.opendev.org/c/openstack/openstacksdk/+/921890 ? based on the last comment from Dmitry I think it's ready. Tks! | |
| #openstack-sdks - 2024-07-12 | |||
| 08:41:40 | stephenfin | gtema: o/ FYI the novaclient removal series is _finally_ working all the way the top. It just needs us to cut a new SDK release with https://review.opendev.org/c/openstack/openstacksdk/+/923864/ included | |
| 08:42:07 | gtema | awesome | |
| 08:43:07 | stephenfin | Would you be able to review that SDK patch? It's a little more complicated than I'd like to maintain SDK compatibility, but I'm introducing a new deprecation mechanism so that we can start removing these shims a little more reliably. The remaining novaclient removal series starts here then https://review.opendev.org/c/openstack/python-openstackclient/+/888673/10 | |
| 08:43:16 | gtema | doing that right now | |
| 08:43:26 | stephenfin | ty 🙏 | |
| 08:58:40 | stephenfin | iurygregory: A few comments left on that patch. On a somewhat related matter, you're in ironic-core, yes? You should have +2 (though not +W) if so | |
| 09:19:52 | iurygregory | stephenfin, thank you! yes I'm an ironic-core, but I only saw +1 there | |
| 09:23:48 | frickler | seems a lot of other core groups were added, but not ironic | |
| 09:25:19 | stephenfin | iurygregory: frickler: gtema: https://review.opendev.org/c/openstack/project-config/+/924048 | |
| 09:25:25 | stephenfin | or nova | |
| 09:26:06 | gtema | hmm, interesting that we lost those | |
| 09:26:14 | gtema | s/lost/missed/ | |
| 09:27:44 | iurygregory | ack | |
| 09:32:33 | opendevreview | Stephen Finucane proposed openstack/openstacksdk master: block_storage: Add support for project_id in Limits https://review.opendev.org/c/openstack/openstacksdk/+/922965 | |
| 11:20:40 | opendevreview | Merged openstack/openstacksdk master: compute: Correct base path for default, detailed quotas https://review.opendev.org/c/openstack/openstacksdk/+/923863 | |
| 11:20:42 | opendevreview | Merged openstack/openstacksdk master: compute, volume: Improve 'update_quota_set' https://review.opendev.org/c/openstack/openstacksdk/+/923864 | |
| 13:54:41 | opendevreview | Merged openstack/python-openstackclient master: identity: Migrate 'application credential' commands to SDK https://review.opendev.org/c/openstack/python-openstackclient/+/922843 | |
| 14:07:23 | opendevreview | Merged openstack/python-openstackclient master: identity: Migrate 'service' commands to SDK https://review.opendev.org/c/openstack/python-openstackclient/+/906395 | |
| #openstack-sdks - 2024-07-15 | |||
| 09:30:06 | opendevreview | Stephen Finucane proposed openstack/python-openstackclient master: Add Python 3.12 classifier https://review.opendev.org/c/openstack/python-openstackclient/+/924135 | |
| 09:31:14 | opendevreview | Stephen Finucane proposed openstack/openstacksdk master: Add Python 3.12 classifier https://review.opendev.org/c/openstack/openstacksdk/+/924136 | |
| 09:32:57 | stephenfin | gtema: Could you hit https://review.opendev.org/c/openstack/python-openstackclient/+/888673/ again today to unstick the 3 patches above it? | |
| 09:33:35 | gtema | Ack, looking | |
| 09:35:22 | stephenfin | thanks 🙏 | |
| 11:27:03 | opendevreview | Salman Hajizada proposed openstack/openstacksdk master: baremetal: Enhance VIF attachment with port and portgroup UUIDs https://review.opendev.org/c/openstack/openstacksdk/+/921890 | |
| 11:34:51 | opendevreview | Salman Hajizada proposed openstack/openstacksdk master: Add virtual media attachment and detachment support https://review.opendev.org/c/openstack/openstacksdk/+/921957 | |
| 11:43:21 | opendevreview | Abdulrahman Al-Taweel proposed openstack/openstacksdk master: baremetal: Adds list node history and get history event https://review.opendev.org/c/openstack/openstacksdk/+/922610 | |
| 11:44:50 | opendevreview | Abdulrahman Al-Taweel proposed openstack/openstacksdk master: baremetal: Adds list node history and get history event https://review.opendev.org/c/openstack/openstacksdk/+/922610 | |
| 12:46:12 | opendevreview | Merged openstack/python-openstackclient master: docs: Fix indentation https://review.opendev.org/c/openstack/python-openstackclient/+/923150 | |
| 12:59:53 | opendevreview | Merged openstack/python-openstackclient master: common: Migrate 'limits show' to SDK https://review.opendev.org/c/openstack/python-openstackclient/+/888673 | |
| 12:59:55 | opendevreview | Merged openstack/python-openstackclient master: compute: Migrate 'server add/remove security group' to SDK https://review.opendev.org/c/openstack/python-openstackclient/+/918794 | |
| 12:59:58 | opendevreview | Merged openstack/python-openstackclient master: compute: Migrate 'server migrate' to SDK https://review.opendev.org/c/openstack/python-openstackclient/+/918795 | |
| 13:00:02 | opendevreview | Merged openstack/python-openstackclient master: compute: Migrate 'server set', 'server unset' commands https://review.opendev.org/c/openstack/python-openstackclient/+/918796 | |
| 13:00:07 | opendevreview | Merged openstack/python-openstackclient master: compute: Always use SDK client to display server https://review.opendev.org/c/openstack/python-openstackclient/+/918797 | |
| 13:00:11 | opendevreview | Merged openstack/python-openstackclient master: compute: Avoid third API call during 'server show' https://review.opendev.org/c/openstack/python-openstackclient/+/918800 | |
| 13:04:57 | opendevreview | Merged openstack/python-openstackclient master: compute: Migrate 'server rebuild' to SDK https://review.opendev.org/c/openstack/python-openstackclient/+/918798 | |
| 13:04:59 | opendevreview | Merged openstack/python-openstackclient master: compute: Migrate remaining server actions to SDK https://review.opendev.org/c/openstack/python-openstackclient/+/918799 | |
| 13:05:01 | opendevreview | Merged openstack/python-openstackclient master: compute: Migrate 'server evacuate' to SDK https://review.opendev.org/c/openstack/python-openstackclient/+/918801 | |
| 13:13:06 | opendevreview | Merged openstack/python-openstackclient master: compute: Prevent use of conflicting v*-fixed-ip for 'server create --nic' https://review.opendev.org/c/openstack/python-openstackclient/+/923766 | |
| 15:01:16 | opendevreview | Merged openstack/python-openstackclient master: compute: Migrate 'server create' to SDK https://review.opendev.org/c/openstack/python-openstackclient/+/918802 | |
| 15:01:18 | opendevreview | Merged openstack/python-openstackclient master: network: Replace use of in-tree API client https://review.opendev.org/c/openstack/python-openstackclient/+/919890 | |
| 15:15:04 | opendevreview | Merged openstack/python-openstackclient master: tests: Remove references to novaclient methods https://review.opendev.org/c/openstack/python-openstackclient/+/919892 | |
| 15:40:02 | opendevreview | Artem Goncharov proposed openstack/codegenerator master: fix network.fip.port_XXX schemas https://review.opendev.org/c/openstack/codegenerator/+/924164 | |
| 16:02:25 | opendevreview | Merged openstack/python-openstackclient master: quota: Move nova-network-related quota https://review.opendev.org/c/openstack/python-openstackclient/+/923866 | |
| 16:11:57 | opendevreview | Antonia Gaete proposed openstack/python-openstackclient master: identity: Migrate 'credential' commands to SDK https://review.opendev.org/c/openstack/python-openstackclient/+/923674 | |
| 16:17:48 | opendevreview | Merged openstack/python-openstackclient master: quota: Remove deprecated quota options https://review.opendev.org/c/openstack/python-openstackclient/+/923867 | |
| 17:21:10 | opendevreview | Stephen Finucane proposed openstack/python-openstackclient master: quota: Migrate 'quota *' to SDK https://review.opendev.org/c/openstack/python-openstackclient/+/919891 | |
| 17:21:10 | opendevreview | Stephen Finucane proposed openstack/python-openstackclient master: Remove python-novaclient https://review.opendev.org/c/openstack/python-openstackclient/+/918803 | |
| 17:21:11 | opendevreview | Stephen Finucane proposed openstack/python-openstackclient master: Remove TestServer base class https://review.opendev.org/c/openstack/python-openstackclient/+/919893 | |
| 18:03:32 | opendevreview | Antonia Gaete proposed openstack/python-openstackclient master: identity: Migrate 'domain' commands to SDK https://review.opendev.org/c/openstack/python-openstackclient/+/923785 | |
| #openstack-sdks - 2024-07-16 | |||
| 01:38:31 | diablo_rojo | When you get some time, can you circle back to reviewing this one stephenfin https://review.opendev.org/c/openstack/openstacksdk/+/921890? | |
| 07:22:55 | opendevreview | Merged openstack/codegenerator master: fix network.fip.port_XXX schemas https://review.opendev.org/c/openstack/codegenerator/+/924164 | |
| 09:58:25 | opendevreview | mbu proposed openstack/openstacksdk master: Allow to override _max_microversion for Volume._action function https://review.opendev.org/c/openstack/openstacksdk/+/924206 | |
| 10:17:42 | opendevreview | mbu proposed openstack/openstacksdk master: Allow to override _max_microversion for Volume._action function https://review.opendev.org/c/openstack/openstacksdk/+/924206 | |
| 10:35:39 | edmbold | hi, everyone, sorry if I am on the wrong channel to ask support/report a possible bug: | |
| 10:36:01 | edmbold | in openstacksdk 3.2.0 python module, I am getting this error: | |
| 10:36:11 | edmbold | AttributeError: 'Connection' object has no attribute '_floating_network_by_router'. | |
| 10:36:50 | edmbold | it looks that the _find_floating_network_by_router method in the _floating_ip.py line 307, referring to this not existing _floating_network_by_router method | |
| 10:38:05 | edmbold | I am using the "create_server()" method in the openstackclient connection object, that was working fine, until it was using openstacksdk 3.0.0, but now it looks broken | |
| 10:42:00 | edmbold | ok, I'll try the bug tracker linked here. .https://storyboard.openstack.org/ | |
| 11:23:00 | frickler | edmbold: that issues seems new to me, also better use https://bugs.launchpad.net/openstacksdk/ | |
| 11:25:10 | edmbold | thanks frickler! | |
| 11:31:00 | opendevreview | Stephen Finucane proposed openstack/openstacksdk master: baremetal: Enhance VIF attachment with port and portgroup UUIDs https://review.opendev.org/c/openstack/openstacksdk/+/921890 | |
| 11:46:44 | opendevreview | mbu proposed openstack/openstacksdk master: Allow to override _max_microversion for Volume._action function https://review.opendev.org/c/openstack/openstacksdk/+/924206 | |
| 11:58:23 | opendevreview | mbu proposed openstack/openstacksdk master: Allow to override _max_microversion for Volume._action function https://review.opendev.org/c/openstack/openstacksdk/+/924206 | |
| 13:44:52 | opendevreview | mbu proposed openstack/openstacksdk master: Allow to override _max_microversion for Volume._action function https://review.opendev.org/c/openstack/openstacksdk/+/924206 | |
| 14:17:14 | opendevreview | Salman Hajizada proposed openstack/openstacksdk master: Add virtual media attachment and detachment support https://review.opendev.org/c/openstack/openstacksdk/+/921957 | |
| #openstack-sdks - 2024-07-17 | |||
| 07:49:07 | opendevreview | Jake Yip proposed openstack/openstacksdk master: Cast all header values to string https://review.opendev.org/c/openstack/openstacksdk/+/924301 | |
| 14:02:33 | ganso | hi stephenfin ! thanks for the improvements in https://review.opendev.org/c/openstack/openstacksdk/+/922965 ! I left you a question regarding the changes. If you have a minute could you please take a look? I am sure the question will be trivial to you as you are more familiar with it | |
| 15:49:57 | stephenfin | ganso: It's a fair point. I don't have a good answer for how to resolve that, unfortunately. Personally, I tend to ignore the `location` field entirely but that's just me | |
| 15:56:21 | stephenfin | ganso: As I understand it, that the location attribute is either inferred by the auth information or provided explicitly from a `project_id` attribute of a given resource. Unfortunately cinder's '/limits do not expose this attribute | |
| 16:05:37 | ganso | stephenfin: yea I had the same impression as well, that the location attribute is completely unrelated to the resource but more to who is performing the request, as it is in attribute that is included by the framework. I would be fine with that if you're fine with it, I just wanted to raise awareness just to confirm that's the behavior we want | |
| #openstack-sdks - 2024-07-18 | |||
| 10:16:37 | opendevreview | Lajos Katona proposed openstack/openstacksdk master: BGP: return list for get_dragents and get_bgp_speakers_hosted_by_dragent https://review.opendev.org/c/openstack/openstacksdk/+/920670 | |
| 10:27:32 | stephenfin | gtema: Waiting on CI results, SDK 3.3.0 is out and included in upper-constraints so I think the last of the novaclient removal series can finally go in \o/ https://review.opendev.org/c/openstack/python-openstackclient/+/923949/ | |
| 10:28:32 | gtema | right, it was too much to be reviewed in one day and then other things popped up | |
| 10:28:36 | gtema | on it after lunch | |