| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-sdks - 2023-01-30 | |||
| 11:13:06 | opendevreview | Artem Goncharov proposed openstack/openstacksdk master: Prepare release note for R1.0 https://review.opendev.org/c/openstack/openstacksdk/+/872030 | |
| 11:22:50 | opendevreview | Artem Goncharov proposed openstack/openstacksdk master: Do not create prometheus_client registry by default https://review.opendev.org/c/openstack/openstacksdk/+/872075 | |
| 13:05:45 | opendevreview | Jakob Meng proposed openstack/ansible-collections-openstack master: Publish 2.0.0 release https://review.opendev.org/c/openstack/ansible-collections-openstack/+/872077 | |
| 13:32:27 | gtema | stephenfin: another look at https://review.opendev.org/c/openstack/openstacksdk/+/872030? | |
| 13:33:10 | opendevreview | Jakob Meng proposed openstack/ansible-collections-openstack master: Publish 2.0.0 release https://review.opendev.org/c/openstack/ansible-collections-openstack/+/872077 | |
| 15:33:25 | stephenfin | gtema: one small typo there but otherwise good (y) | |
| 15:33:43 | stephenfin | gtema: Unrelated: are you happy to backport https://review.opendev.org/c/openstack/python-openstackclient/+/869832/ ? | |
| 15:33:50 | gtema | another typo (facepalm) | |
| 15:35:18 | opendevreview | Artem Goncharov proposed openstack/openstacksdk master: Prepare release note for R1.0 https://review.opendev.org/c/openstack/openstacksdk/+/872030 | |
| 15:36:04 | gtema | fixed. I seem to make lot of typos in a hurry to make this happen | |
| 15:37:05 | stephenfin | ta, +2 | |
| 15:37:26 | gtema | stephenfin, your opinion on https://review.opendev.org/c/openstack/openstacksdk/+/872075 is also welcome. Would be nice to get it into R1.0 since it can be treated as backward incompatible | |
| 15:38:50 | stephenfin | looking | |
| 15:47:38 | stephenfin | gtema: I prefer Vasyl's approach, personally, though I think we should do it for all collectors (i.e. statsd and InfluxDB too) | |
| 15:47:52 | stephenfin | but I can be swayed either way | |
| 15:48:04 | gtema | hmmm | |
| 15:48:54 | gtema | adding "enabled: true" to them feel real awkward for me. Either section is present (which means we gather metrics) or absent - means not | |
| 15:54:20 | stephenfin | I'll defer to you then. At least what you've done is backwards compatible. Could we improve documentation around this, beyond the release note? | |
| 15:55:00 | stephenfin | i.e. add a worked example to doc/source/user/guides/stats.rst | |
| 16:02:15 | gtema | in my eyes this is matching currently to https://docs.openstack.org/openstacksdk/latest/user/guides/stats.html | |
| 16:35:55 | opendevreview | Merged openstack/python-openstackclient stable/wallaby: volume: Allow more versions https://review.opendev.org/c/openstack/python-openstackclient/+/869832 | |
| 18:29:30 | opendevreview | Merged openstack/openstacksdk master: Prepare release note for R1.0 https://review.opendev.org/c/openstack/openstacksdk/+/872030 | |
| 18:43:18 | opendevreview | Jakob Meng proposed openstack/ansible-collections-openstack master: Publish 2.0.0 release https://review.opendev.org/c/openstack/ansible-collections-openstack/+/872077 | |
| 18:55:53 | opendevreview | Jakob Meng proposed openstack/ansible-collections-openstack master: Publish 2.0.0 release https://review.opendev.org/c/openstack/ansible-collections-openstack/+/872077 | |
| #openstack-sdks - 2023-01-31 | |||
| 08:18:55 | lajoskatona | gtema, stephenfin: Hi, if you have some free time could you please review this one for Neutron trunks: https://review.opendev.org/c/openstack/python-openstackclient/+/869447 , thanks in advance | |
| 08:19:00 | lajoskatona | gtema, stephenfin: if it is merged we can delete the trunk command related code from neutronclient :-) | |
| 08:19:23 | gtema | great. Looking now | |
| 08:23:25 | opendevreview | Radosław Piliszek proposed openstack/openstacksdk master: support notification vmoves for masakari https://review.opendev.org/c/openstack/openstacksdk/+/872080 | |
| 08:23:25 | opendevreview | Radosław Piliszek proposed openstack/openstacksdk master: support notification vmoves for masakari https://review.opendev.org/c/openstack/openstacksdk/+/872080 | |
| 08:23:41 | opendevreview | Radosław Piliszek proposed openstack/openstacksdk master: support notification vmoves for masakari https://review.opendev.org/c/openstack/openstacksdk/+/872080 | |
| 08:23:41 | opendevreview | Radosław Piliszek proposed openstack/openstacksdk master: support notification vmoves for masakari https://review.opendev.org/c/openstack/openstacksdk/+/872080 | |
| 10:45:39 | opendevreview | Radosław Piliszek proposed openstack/openstacksdk master: support notification vmoves for masakari https://review.opendev.org/c/openstack/openstacksdk/+/872080 | |
| 10:45:39 | opendevreview | Radosław Piliszek proposed openstack/openstacksdk master: support notification vmoves for masakari https://review.opendev.org/c/openstack/openstacksdk/+/872080 | |
| 11:25:08 | stephenfin | gtema: I'm going to propose 6.1.0 of OSC, if that's okay with you? In the interim, can you look at https://review.opendev.org/c/openstack/releases/+/870732 ? | |
| 11:27:04 | gtema | Yes, go for it | |
| 11:35:04 | stephenfin | lajoskatona: That had been on my list. Done! | |
| 11:35:50 | stephenfin | gtema: Actually, before we cut that we might merge https://review.opendev.org/q/project:openstack/python-openstackclient+topic:add-missing-cinderclient-commands for whoami-rajat ? | |
| 11:36:44 | gtema | looking on those | |
| 11:36:52 | whoami-rajat | stephenfin, we've 2 weeks for client release right? or am i missing something | |
| 11:37:24 | stephenfin | Yeah, but we're cycle with intermediary so we can cut effectively whenever so long as we have *a* release per-cycle | |
| 11:38:00 | stephenfin | there are a lot of changes queued up (especially for glance - coverage is looking sooo much better there now) so let's get the bulk of them out before the panic | |
| 11:38:13 | whoami-rajat | ok, I've 3 more commands to add and then cinder will be fully in sync with OSC, at least for the commands part | |
| 11:38:40 | whoami-rajat | so are we planning to release again then with other client releases? | |
| 11:38:50 | stephenfin | Perfect. Ping me if/when you've those up and I'll happily review them. | |
| 11:39:01 | stephenfin | Yeah. We can release whenever it suits us | |
| 11:39:17 | whoami-rajat | cool, I will work on them then, thanks! | |
| 11:39:21 | stephenfin | Let's aim for a 6.2.0 in the next few weeks if you can get cinder coverage closed out | |
| 11:39:48 | whoami-rajat | stephenfin, do you want me to update this? just noticed your comments https://review.opendev.org/c/openstack/python-openstackclient/+/869811 | |
| 11:40:03 | whoami-rajat | or better as a followup? | |
| 11:40:11 | stephenfin | follow-up would be better | |
| 11:40:23 | stephenfin | they're nits at best | |
| 11:41:00 | whoami-rajat | ok, sounds good | |
| 11:58:21 | opendevreview | suzhengwei proposed openstack/openstacksdk master: support notification vmoves for masakari https://review.opendev.org/c/openstack/openstacksdk/+/872080 | |
| 12:18:55 | lajoskatona | stephenfin, gtema: thanks | |
| 12:41:00 | opendevreview | Merged openstack/python-openstackclient master: Move network trunk commands from python-neutronclient https://review.opendev.org/c/openstack/python-openstackclient/+/869447 | |
| 12:43:34 | opendevreview | Merged openstack/python-openstackclient master: Add volume summary command https://review.opendev.org/c/openstack/python-openstackclient/+/869436 | |
| 12:48:44 | odyssey4me | hi folks - I see https://review.opendev.org/q/project:openstack/python-openstackclient+branch:stable/wallaby has ~10 patches after the last tagged release... is there an intent to release a new tag at some point soon? | |
| 13:42:10 | opendevreview | Mridula Joshi proposed openstack/openstacksdk master: Add support for glance cache list https://review.opendev.org/c/openstack/openstacksdk/+/869710 | |
| 14:10:10 | odyssey4me | never mind my query - wallaby is in extended maintenance, so I guess no more releases there | |
| 14:39:37 | stephenfin | odyssey4me: Yup, no more I'm afraid https://review.opendev.org/c/openstack/releases/+/847937 | |
| 14:40:16 | gtema | I would say, now we can have a real party - https://pypi.org/project/openstacksdk/1.0.0/ is there | |
| 14:44:03 | stephenfin | #success openstacksdk 1.0.0 is out 🎉 | |
| 14:44:03 | stephenfin | #success openstacksdk 1.0.0 is out 🎉 | |
| 14:44:06 | opendevstatus | stephenfin: Added success to Success page (https://wiki.openstack.org/wiki/Successes) | |
| 14:44:33 | odyssey4me | w00t! | |
| 14:45:07 | stephenfin | gtema: did you merge more patches for the container orchestration layer? | |
| 14:45:14 | gtema | :) | |
| 14:45:15 | gtema | yes | |
| 14:45:23 | gtema | coe is also complete | |
| 14:48:49 | opendevreview | Stephen Finucane proposed openstack/openstacksdk master: Update README to indicate COE resource/proxy support https://review.opendev.org/c/openstack/openstacksdk/+/872283 | |
| 14:49:15 | stephenfin | gtema: Probably want that so ^ | |
| 14:49:22 | stephenfin | it's trivial | |
| 14:49:59 | gtema | ah, there are too many pages not built from sources. This should be target for R2.0 ;-) | |
| 15:15:32 | opendevreview | Mridula Joshi proposed openstack/openstacksdk master: Add support for glance cache list https://review.opendev.org/c/openstack/openstacksdk/+/869710 | |
| 15:29:19 | opendevreview | Merged openstack/openstacksdk master: Update README to indicate COE resource/proxy support https://review.opendev.org/c/openstack/openstacksdk/+/872283 | |
| 15:58:51 | opendevreview | Alfredo Moralejo proposed openstack/python-openstackclient stable/wallaby: Replace assertItemsEqual with assertCountEqual https://review.opendev.org/c/openstack/python-openstackclient/+/872327 | |
| 16:46:52 | timburke | hi! i've got some concerns about the stable/xena openstacksdk-functional-devstack job: https://zuul.opendev.org/t/openstack/builds?job_name=openstacksdk-functional-devstack&branch=stable%2Fxena | |
| 16:48:12 | timburke | it looks like the recently-merged-to-master https://review.opendev.org/c/openstack/openstacksdk/+/865045 is getting picked up on the old stable branch (presumably because of https://github.com/openstack/openstacksdk/blob/master/.zuul.yaml#L34-L42) | |
| 16:49:59 | timburke | which is causing import errors down in python-openstackclient (which *is* using stable/xena) because it picked up an undeclared dependency on munch in https://opendev.org/openstack/python-openstackclient/commit/8b7a2c8d5931f15b69d1ef6baad994f4b9904579 | |
| 17:13:37 | gmann | yeah, I also noticed this in devstack fix on stable/wallaby and openstacksdk-functional-devstack job is failing 100% on <=stable/wallaby https://zuul.openstack.org/builds?job_name=openstacksdk-functional-devstack&branch=stable%2Fxena&branch=stable%2Fwallaby&skip=0 | |
| 17:14:06 | gmann | but If I am not wrong sdk master supposed to work for all supported stable branch ? | |
| 17:23:44 | gtema | gmann, the issue is apparently not the SDK itself, but rather old OSC which doesn't want to work good with new SDK. This looks bit weird for me | |
| 17:27:56 | gtema | installing munch lib there (with 5.6.1) helps to solve this, so most likely we need to extend requirements in old branches | |
| 17:29:47 | gmann | ok, so osc was relying on the munch being installed from sdks requirements.txt and with that removal from sdks it broke osc | |
| 17:30:01 | gmann | we should have that here https://opendev.org/openstack/python-openstackclient/src/branch/master/requirements.txt | |
| 17:30:01 | gtema | yes, apparently | |
| 17:30:11 | gmann | let me push change | |
| 17:30:36 | gtema | but only for xena, this is not required anywhere else | |
| 17:34:01 | gmann | right | |
| 17:34:46 | gtema | and interestingly stephenfin just today made release of OSC for xena, what a facepalm on a R1.0 day | |
| 17:35:12 | gmann | humm it worked there? | |
| 17:35:43 | gtema | well, as usual it all depend on the constellation | |
| 17:40:34 | opendevreview | Ghanshyam proposed openstack/python-openstackclient stable/xena: [stable-only] Add munch in requirements.txt https://review.opendev.org/c/openstack/python-openstackclient/+/872340 | |
| 17:40:56 | gmann | gtema: stephenfin: ^^ | |
| 17:41:06 | gtema | yes, I see. Thanks a lot gmann | |
| 17:41:18 | stephenfin | thanks | |
| 17:44:48 | opendevreview | Ghanshyam proposed openstack/python-openstackclient stable/wallaby: [stable-only] Add munch in requirements.txt https://review.opendev.org/c/openstack/python-openstackclient/+/872341 | |
| 18:51:23 | opendevreview | Jakob Meng proposed openstack/ansible-collections-openstack master: Added workaround for non-determinism in ansible-inventory output https://review.opendev.org/c/openstack/ansible-collections-openstack/+/872344 | |
| 18:52:09 | opendevreview | Jakob Meng proposed openstack/ansible-collections-openstack master: Bump minimum required openstacksdk release to 1.0.0 https://review.opendev.org/c/openstack/ansible-collections-openstack/+/872066 | |
| 18:52:27 | opendevreview | Jakob Meng proposed openstack/ansible-collections-openstack master: Refactored coe_cluster{,_template} modules again https://review.opendev.org/c/openstack/ansible-collections-openstack/+/872039 | |