| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-sdks - 2023-01-06 | |||
| 17:39:22 | whoami-rajat | I tried that before but did that with assertEqual | |
| 17:39:31 | whoami-rajat | in the examples i see assertCountEqual being used | |
| 17:39:54 | whoami-rajat | but I'm unsure if it compares the DictColumn ? | |
| 17:42:00 | stephenfin | can you rephrase the question? | |
| 17:43:55 | whoami-rajat | does the assertCountEqual method actually compare DictColumn? | |
| 17:45:17 | whoami-rajat | IIUC it takes frequency of elements and compares that, like Counter(list1) == Counter(list2) | |
| 17:45:43 | whoami-rajat | and that's what is used in tests to compare values with DictColumn in it | |
| 17:47:04 | whoami-rajat | like here https://github.com/openstack/python-openstackclient/blob/7985d496892635b70b71be552c52946824d73e9b/openstackclient/tests/unit/volume/v2/test_volume.py#L1125 | |
| 17:47:23 | whoami-rajat | stephenfin, ^ | |
| 17:49:23 | stephenfin | well you can check. Remove dictcolumn from one of the tests that has it and see if the test continues to pass | |
| 17:49:32 | stephenfin | but the answer is yes, it does compare as expected | |
| 17:50:21 | stephenfin | they're comparable because of this https://github.com/openstack/cliff/commit/c1c991045cece85dd55494f9d4670429e370e131 | |
| 17:51:05 | stephenfin | sorry, this https://github.com/openstack/cliff/commit/997e05fce6cf2267099f3d5f91116ba491495d7e | |
| 17:51:31 | stephenfin | (The first commit should have said "sortable", not "comparable") | |
| 17:55:39 | whoami-rajat | ok, i see it failing with a fake value, DictColumn(meta) != DictColumn({'fake':'dict'}) | |
| 17:55:43 | whoami-rajat | will update it | |
| 17:55:44 | whoami-rajat | thanks | |
| 18:18:22 | opendevreview | Rajat Dhasmana proposed openstack/python-openstackclient master: Add volume summary command https://review.opendev.org/c/openstack/python-openstackclient/+/869436 | |
| 19:11:02 | opendevreview | Corey Bryant proposed openstack/openstackclient master: Test to ensure tox is pinned for stable/zed https://review.opendev.org/c/openstack/openstackclient/+/869504 | |
| 19:11:50 | opendevreview | Jakob Meng proposed openstack/ansible-collections-openstack master: Added parameter for managing rules in security_group module https://review.opendev.org/c/openstack/ansible-collections-openstack/+/863208 | |
| 19:38:25 | opendevreview | Corey Bryant proposed openstack/python-openstackclient stable/zed: [DNM] Test to ensure tox is pinned for stable/zed https://review.opendev.org/c/openstack/python-openstackclient/+/869505 | |
| #openstack-sdks - 2023-01-09 | |||
| 11:22:53 | opendevreview | Polina Gubina proposed openstack/ansible-collections-openstack master: Volume module: - Add 'is_multiattach' parameter. When it is true, volume will be shareble https://review.opendev.org/c/openstack/ansible-collections-openstack/+/865477 | |
| 14:07:18 | opendevreview | Jakob Meng proposed openstack/ansible-collections-openstack master: Updated docs https://review.opendev.org/c/openstack/ansible-collections-openstack/+/868923 | |
| 14:10:34 | opendevreview | Jakob Meng proposed openstack/ansible-collections-openstack master: Updated docs https://review.opendev.org/c/openstack/ansible-collections-openstack/+/868923 | |
| 14:11:15 | opendevreview | Jakob Meng proposed openstack/ansible-collections-openstack master: Updated docs https://review.opendev.org/c/openstack/ansible-collections-openstack/+/868923 | |
| 14:12:01 | opendevreview | Jakob Meng proposed openstack/ansible-collections-openstack master: Updated docs https://review.opendev.org/c/openstack/ansible-collections-openstack/+/868923 | |
| 15:32:57 | opendevreview | Gaël THEROND proposed openstack/ansible-collections-openstack master: Add module to filter available volume services. https://review.opendev.org/c/openstack/ansible-collections-openstack/+/868480 | |
| 15:32:57 | opendevreview | Gaël THEROND proposed openstack/ansible-collections-openstack master: Add module to filter available volume services. https://review.opendev.org/c/openstack/ansible-collections-openstack/+/868480 | |
| 15:49:48 | opendevreview | Arnaud Morin proposed openstack/ansible-collections-openstack master: Add reboot and reboot_hard actions on server https://review.opendev.org/c/openstack/ansible-collections-openstack/+/866550 | |
| #openstack-sdks - 2023-01-10 | |||
| 08:08:15 | opendevreview | Jakob Meng proposed openstack/ansible-collections-openstack master: Volume module: - Add 'is_multiattach' parameter. When it is true, volume will be shareble https://review.opendev.org/c/openstack/ansible-collections-openstack/+/865477 | |
| 08:08:24 | opendevreview | Rajat Dhasmana proposed openstack/python-openstackclient master: Add volume revert snapshot command https://review.opendev.org/c/openstack/python-openstackclient/+/869654 | |
| 08:16:19 | opendevreview | Jakob Meng proposed openstack/ansible-collections-openstack master: Add reboot and reboot_hard actions on server https://review.opendev.org/c/openstack/ansible-collections-openstack/+/866550 | |
| 10:02:14 | opendevreview | Jakob Meng proposed openstack/ansible-collections-openstack master: Updated docs https://review.opendev.org/c/openstack/ansible-collections-openstack/+/868923 | |
| 10:07:25 | opendevreview | Jakob Meng proposed openstack/ansible-collections-openstack master: Updated docs https://review.opendev.org/c/openstack/ansible-collections-openstack/+/868923 | |
| 10:50:33 | opendevreview | Artem Goncharov proposed openstack/openstacksdk master: Drop _normalize class https://review.opendev.org/c/openstack/openstacksdk/+/865044 | |
| 12:11:02 | opendevreview | Merged openstack/ansible-collections-openstack master: Add reboot and reboot_hard actions on server https://review.opendev.org/c/openstack/ansible-collections-openstack/+/866550 | |
| 12:16:07 | opendevreview | Jakob Meng proposed openstack/ansible-collections-openstack master: Updated docs https://review.opendev.org/c/openstack/ansible-collections-openstack/+/868923 | |
| 12:34:06 | opendevreview | Jakob Meng proposed openstack/ansible-collections-openstack master: Added is_multiattach parameter to volume module https://review.opendev.org/c/openstack/ansible-collections-openstack/+/865477 | |
| 12:34:24 | eest | i dont know if people recall my problem where openstack-sdk did not allow me to create a server with some specific settings unless i configured compute_api_version: "2.79" in clouds.yaml. I have now discovered that while it fixes my call to create a server, it breaks my call to create a server_group: Additional properties are not allowed (u'policies' was unexpected). It seems that even if i have set | |
| 12:34:30 | eest | my expected API version the code will instead inspect its "session" to see what microversion is supported and since it is 2.1 it tries using the older "policies" field instead of "policy" that it should be using | |
| 12:35:38 | gtema | do you hardcode microversion now? It should not be required, since sdk tries to choose max supported by user and cloud | |
| 12:36:47 | eest | yeah, i set "compute_api_version" in clouds.yaml, it is a bit of a mystery why the automatic microversion stuff does not work for me... i have a hard time figuring out where in the code this is actually discovered, maybe i could find out why | |
| 12:38:15 | eest | not sure if it is the openstack server side stuff that is not reporting the actually supported microversion, or if it is somehow lost in openstacksdk for some reason (i am using application credential auth which incurs extra API lookups for instance) | |
| 12:38:18 | gtema | pls try to figure out which param exactly is causing you issues without specifying MV. Hardcoding it this way is something very tricky and not without consequences | |
| 12:38:39 | eest | btw, i am not setting the "default" microversion, i believe that is another setting | |
| 12:38:54 | eest | right | |
| 12:39:00 | gtema | you should normally not set any version at all | |
| 12:40:46 | opendevreview | Mridula Joshi proposed openstack/openstacksdk master: Add support for glance cache list https://review.opendev.org/c/openstack/openstacksdk/+/869710 | |
| 12:45:15 | opendevreview | Merged openstack/ansible-collections-openstack master: Updated docs https://review.opendev.org/c/openstack/ansible-collections-openstack/+/868923 | |
| 12:47:27 | eest | i have went so far as to checking compute/v2/server_group.py where it does "if utils.supports_microversion(session, '2.64'):" to figure out what policy thing to set, and inside supprts_microversion() it calls endpoint_data = adapter.get_endpoint_data(). printing endpoint_data i see: | |
| 12:47:46 | eest | EndpointData{api_version=(2, 1), catalog_url=https://url:port/v2.1/project-id, endpoint_id=someid, interface=public, major_version=None, max_microversion=None, min_microversion=None, next_min_version=None, not_before=None, raw_endpoint={'region_id': 'regionname', 'url': 'https://url:port/v2.1/project-id', 'region': 'regionname', 'interface': 'public', 'id': 'someid'}, region_name=regionname, | |
| 12:47:53 | eest | service_id=someid, service_name=nova, service_type=compute, service_url=None, url=https://url:port/v2.1/projectid} | |
| 12:48:31 | eest | where might the code try to figure out what should be supported? i obviously am able to do calls with a higher version than 2.1 (needed for my compute creation) yet it seems determined that my "session" is 2.1 | |
| 12:52:54 | opendevreview | Artem Goncharov proposed openstack/os-client-config master: Update tox to support v4 https://review.opendev.org/c/openstack/os-client-config/+/869712 | |
| 13:21:33 | opendevreview | Jakob Meng proposed openstack/ansible-collections-openstack stable/1.0.0: Updated docs https://review.opendev.org/c/openstack/ansible-collections-openstack/+/869717 | |
| 13:58:36 | opendevreview | Stephen Finucane proposed openstack/os-client-config master: Add support for tox 4 https://review.opendev.org/c/openstack/os-client-config/+/869723 | |
| 14:07:23 | stephenfin | gtema: Need that to unblock openstacksdk gates since the os-client-config-tox-py38-tips job is failing | |
| 14:07:46 | gtema | I know stephenfin | |
| 14:08:01 | stephenfin | Okay, cool :) | |
| 14:08:19 | gtema | I hope your change will pass, since my just failed | |
| 14:08:26 | gtema | but I gave your +2 already | |
| 14:08:47 | stephenfin | oh, I missed yours. Sorry /o\ | |
| 14:08:53 | gtema | np | |
| 14:20:20 | opendevreview | Jakob Meng proposed openstack/ansible-collections-openstack master: Fixed docs https://review.opendev.org/c/openstack/ansible-collections-openstack/+/869726 | |
| 14:55:40 | opendevreview | Merged openstack/ansible-collections-openstack master: Added is_multiattach parameter to volume module https://review.opendev.org/c/openstack/ansible-collections-openstack/+/865477 | |
| 14:55:41 | opendevreview | Merged openstack/ansible-collections-openstack stable/1.0.0: Updated docs https://review.opendev.org/c/openstack/ansible-collections-openstack/+/869717 | |
| 14:55:43 | opendevreview | Merged openstack/ansible-collections-openstack master: Fixed docs https://review.opendev.org/c/openstack/ansible-collections-openstack/+/869726 | |
| 15:13:40 | opendevreview | Jakob Meng proposed openstack/ansible-collections-openstack stable/1.0.0: Fixed docs https://review.opendev.org/c/openstack/ansible-collections-openstack/+/869737 | |
| 15:15:57 | opendevreview | Jakob Meng proposed openstack/ansible-collections-openstack master: Refactored loadbalancer module breaking backward compatibility https://review.opendev.org/c/openstack/ansible-collections-openstack/+/867558 | |
| 15:16:14 | opendevreview | Jakob Meng proposed openstack/ansible-collections-openstack master: Refactored lb_{health_monitor,listener,member,pool} modules https://review.opendev.org/c/openstack/ansible-collections-openstack/+/867560 | |
| 15:16:44 | opendevreview | Jakob Meng proposed openstack/ansible-collections-openstack master: Refactored coe_cluster{,_template} modules https://review.opendev.org/c/openstack/ansible-collections-openstack/+/866796 | |
| 15:32:53 | opendevreview | Merged openstack/ansible-collections-openstack stable/1.0.0: Fixed docs https://review.opendev.org/c/openstack/ansible-collections-openstack/+/869737 | |
| 15:38:25 | eest | hmm, might actually be closer to a solution, from the debug output i can actually see "No version document at..." errors which appears to be thrown by the keystone auth stuff | |
| 15:38:41 | eest | guessing this is the reason the client is not able to detect microversions, to be continued | |
| 15:40:38 | gtema | yes, this may be really a reason | |
| 16:50:07 | opendevreview | Merged openstack/os-client-config master: Add support for tox 4 https://review.opendev.org/c/openstack/os-client-config/+/869723 | |
| 17:52:19 | opendevreview | Tom Weininger proposed openstack/openstacksdk master: Add typing information and documentation https://review.opendev.org/c/openstack/openstacksdk/+/867968 | |
| 19:08:54 | opendevreview | Lajos Katona proposed openstack/openstacksdk master: Add BGP Speakers and Peers to SDK https://review.opendev.org/c/openstack/openstacksdk/+/869485 | |
| 21:39:02 | opendevreview | Merged openstack/openstacksdk master: Move _normalize_coe_* into _coe class https://review.opendev.org/c/openstack/openstacksdk/+/865043 | |
| 21:53:58 | opendevreview | Merged openstack/openstacksdk master: Allow passing more arguments to create_port https://review.opendev.org/c/openstack/openstacksdk/+/868106 | |
| #openstack-sdks - 2023-01-11 | |||
| 06:37:06 | opendevreview | Jakob Meng proposed openstack/ansible-collections-openstack master: Refactored security_group{,_info} modules https://review.opendev.org/c/openstack/ansible-collections-openstack/+/867740 | |
| 06:37:48 | opendevreview | Jakob Meng proposed openstack/ansible-collections-openstack master: Refactored security_group_rule{,_info} modules https://review.opendev.org/c/openstack/ansible-collections-openstack/+/869355 | |
| 06:38:15 | opendevreview | Jakob Meng proposed openstack/ansible-collections-openstack master: Added parameter for managing rules in security_group module https://review.opendev.org/c/openstack/ansible-collections-openstack/+/863208 | |
| 06:39:08 | opendevreview | Jakob Meng proposed openstack/ansible-collections-openstack master: Refactored compute_service_info module https://review.opendev.org/c/openstack/ansible-collections-openstack/+/869167 | |
| 06:39:41 | opendevreview | Jakob Meng proposed openstack/ansible-collections-openstack master: Refactored project{,_info} modules https://review.opendev.org/c/openstack/ansible-collections-openstack/+/869254 | |
| 07:35:27 | opendevreview | Artem Goncharov proposed openstack/openstacksdk master: Drop munch dependency https://review.opendev.org/c/openstack/openstacksdk/+/865045 | |
| 09:01:30 | opendevreview | Merged openstack/openstacksdk master: Drop _normalize class https://review.opendev.org/c/openstack/openstacksdk/+/865044 | |
| 09:11:51 | opendevreview | Merged openstack/openstacksdk master: baremetal: Add Node.inject_nmi method https://review.opendev.org/c/openstack/openstacksdk/+/866569 | |
| 10:03:06 | opendevreview | Merged openstack/ansible-collections-openstack master: Refactored loadbalancer module breaking backward compatibility https://review.opendev.org/c/openstack/ansible-collections-openstack/+/867558 | |
| 10:03:08 | opendevreview | Merged openstack/ansible-collections-openstack master: Refactored lb_{health_monitor,listener,member,pool} modules https://review.opendev.org/c/openstack/ansible-collections-openstack/+/867560 | |
| 10:03:10 | opendevreview | Merged openstack/ansible-collections-openstack master: Refactored coe_cluster{,_template} modules https://review.opendev.org/c/openstack/ansible-collections-openstack/+/866796 | |
| 10:03:12 | opendevreview | Merged openstack/ansible-collections-openstack master: Refactored security_group{,_info} modules https://review.opendev.org/c/openstack/ansible-collections-openstack/+/867740 | |
| 10:03:14 | opendevreview | Merged openstack/ansible-collections-openstack master: Refactored security_group_rule{,_info} modules https://review.opendev.org/c/openstack/ansible-collections-openstack/+/869355 | |
| 10:03:15 | opendevreview | Merged openstack/ansible-collections-openstack master: Added parameter for managing rules in security_group module https://review.opendev.org/c/openstack/ansible-collections-openstack/+/863208 | |
| 10:03:17 | opendevreview | Merged openstack/ansible-collections-openstack master: Refactored compute_service_info module https://review.opendev.org/c/openstack/ansible-collections-openstack/+/869167 | |
| 10:03:19 | opendevreview | Merged openstack/ansible-collections-openstack master: Refactored project{,_info} modules https://review.opendev.org/c/openstack/ansible-collections-openstack/+/869254 | |
| 10:30:55 | whoami-rajat | stephenfin, hey, I'm adding a new command which has the parameter '--prefix' but it's ignored by the doc builder, any reason why it's done that way and any workaround for that? https://github.com/openstack/python-openstackclient/blob/master/doc/source/conf.py#L264 | |
| 10:31:18 | whoami-rajat | I know i can write down the whole thing but if we could "not ignore" it for specific commands | |
| 10:45:24 | frickler | whoami-rajat: iiuc --prefix is a parameter already defined and used by cliff, so you would need to name your new parameter differently | |
| 10:46:12 | whoami-rajat | frickler, hmm, but in the context of my specific command, it shouldn't be an issue right? openstack volume service get log --prefix | |