| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-sdks - 2022-11-02 | |||
| 11:17:57 | opendevreview | PB proposed openstack/ansible-collections-openstack master: updated argument spec based on documentation example https://review.opendev.org/c/openstack/ansible-collections-openstack/+/863208 | |
| 11:39:47 | opendevreview | PB proposed openstack/ansible-collections-openstack master: updated argument spec based on documentation example https://review.opendev.org/c/openstack/ansible-collections-openstack/+/863208 | |
| 11:40:09 | opendevreview | PB proposed openstack/ansible-collections-openstack master: updated argument spec based on documentation example https://review.opendev.org/c/openstack/ansible-collections-openstack/+/863208 | |
| 12:10:39 | opendevreview | PB proposed openstack/ansible-collections-openstack master: updated argument spec based on documentation example https://review.opendev.org/c/openstack/ansible-collections-openstack/+/863208 | |
| 12:27:26 | opendevreview | PB proposed openstack/ansible-collections-openstack master: updated argument spec based on documentation example https://review.opendev.org/c/openstack/ansible-collections-openstack/+/863208 | |
| 13:08:27 | opendevreview | Jakob Meng proposed openstack/ansible-collections-openstack master: Existing images update name, visibility etc https://review.opendev.org/c/openstack/ansible-collections-openstack/+/862565 | |
| 13:20:43 | arddennis | jm1: regarding https://review.opendev.org/c/openstack/ansible-collections-openstack/+/862565 what is required from my side to do? Should I change script logic to use additional method to update properties instead of image.id usage? It seems that next steps are not clean for me. | |
| 13:21:15 | jm1 | arddennis: hey :) i just submitted an update for that patch :D | |
| 13:21:42 | jm1 | arddennis: you dont have to do anything. once ci has passed and you are happy with my changes, we just need another core to vote on that patch and then we can merge it | |
| 13:22:43 | arddennis | jm1: sounds good :) | |
| 13:23:08 | jm1 | arddennis: so please vote on the changes :D | |
| 13:30:58 | jm1 | arddennis: thanks and sshnaidm has voted too! so once ci has passed, we can merge :) | |
| 13:31:12 | opendevreview | Shnaidman Sagi (Sergey) proposed openstack/ansible-collections-openstack master: DNM test latest devel test https://review.opendev.org/c/openstack/ansible-collections-openstack/+/863267 | |
| 14:18:08 | opendevreview | PB proposed openstack/ansible-collections-openstack master: updated argument spec based on documentation example https://review.opendev.org/c/openstack/ansible-collections-openstack/+/863208 | |
| 14:20:57 | opendevreview | PB proposed openstack/ansible-collections-openstack master: Bulk creation of OpenStack SG rules https://review.opendev.org/c/openstack/ansible-collections-openstack/+/863208 | |
| 17:54:13 | opendevreview | Merged openstack/ansible-collections-openstack master: Existing images update name, visibility etc https://review.opendev.org/c/openstack/ansible-collections-openstack/+/862565 | |
| 18:48:10 | opendevreview | PB proposed openstack/ansible-collections-openstack master: Bulk creation of OpenStack SG rules https://review.opendev.org/c/openstack/ansible-collections-openstack/+/863431 | |
| 19:24:19 | opendevreview | Shnaidman Sagi (Sergey) proposed openstack/ansible-collections-openstack master: Fix documentation defaults for modules https://review.opendev.org/c/openstack/ansible-collections-openstack/+/863267 | |
| 19:24:41 | opendevreview | Shnaidman Sagi (Sergey) proposed openstack/ansible-collections-openstack master: Fix documentation defaults for modules https://review.opendev.org/c/openstack/ansible-collections-openstack/+/863267 | |
| 21:15:43 | opendevreview | Shnaidman Sagi (Sergey) proposed openstack/ansible-collections-openstack master: Fix documentation defaults for modules https://review.opendev.org/c/openstack/ansible-collections-openstack/+/863267 | |
| 21:19:04 | opendevreview | Shnaidman Sagi (Sergey) proposed openstack/ansible-collections-openstack master: Fix documentation defaults for modules https://review.opendev.org/c/openstack/ansible-collections-openstack/+/863267 | |
| #openstack-sdks - 2022-11-03 | |||
| 08:13:53 | opendevreview | Jakob Meng proposed openstack/ansible-collections-openstack master: Refactored volume_info module https://review.opendev.org/c/openstack/ansible-collections-openstack/+/863483 | |
| 08:35:58 | opendevreview | PB proposed openstack/ansible-collections-openstack master: Bulk creation of OpenStack SG rules https://review.opendev.org/c/openstack/ansible-collections-openstack/+/863208 | |
| 09:18:21 | opendevreview | Jakob Meng proposed openstack/ansible-collections-openstack master: Refactored volume_info module https://review.opendev.org/c/openstack/ansible-collections-openstack/+/863483 | |
| 09:27:37 | opendevreview | Jakob Meng proposed openstack/ansible-collections-openstack master: Refactored volume_backup{,_info} modules https://review.opendev.org/c/openstack/ansible-collections-openstack/+/863486 | |
| 09:32:11 | opendevreview | Jakob Meng proposed openstack/ansible-collections-openstack master: Refactored volume_info module https://review.opendev.org/c/openstack/ansible-collections-openstack/+/863483 | |
| 09:32:36 | opendevreview | Jakob Meng proposed openstack/ansible-collections-openstack master: Refactored volume_backup{,_info} modules https://review.opendev.org/c/openstack/ansible-collections-openstack/+/863486 | |
| 10:29:31 | opendevreview | Jakob Meng proposed openstack/ansible-collections-openstack master: Refactored volume_backup{,_info} modules https://review.opendev.org/c/openstack/ansible-collections-openstack/+/863486 | |
| 10:30:23 | opendevreview | Jakob Meng proposed openstack/ansible-collections-openstack master: Refactored volume_snapshot{,_info} modules https://review.opendev.org/c/openstack/ansible-collections-openstack/+/863498 | |
| 11:47:41 | opendevreview | Jakob Meng proposed openstack/ansible-collections-openstack master: Refactored config module https://review.opendev.org/c/openstack/ansible-collections-openstack/+/863512 | |
| 12:44:14 | opendevreview | Jakob Meng proposed openstack/ansible-collections-openstack master: Refactored config module https://review.opendev.org/c/openstack/ansible-collections-openstack/+/863512 | |
| 13:05:52 | opendevreview | Rafael Castillo proposed openstack/ansible-collections-openstack master: Updates server_metadata for 2.0.0 https://review.opendev.org/c/openstack/ansible-collections-openstack/+/863178 | |
| 13:19:46 | opendevreview | Rafael Castillo proposed openstack/ansible-collections-openstack master: Updates server action for 2.0.0 https://review.opendev.org/c/openstack/ansible-collections-openstack/+/857976 | |
| 13:19:55 | opendevreview | Rafael Castillo proposed openstack/ansible-collections-openstack master: Updates server_metadata for 2.0.0 https://review.opendev.org/c/openstack/ansible-collections-openstack/+/863178 | |
| 13:45:00 | rcastillo | gtema: hi, it'd be awesome if you could have a look at this patch when you get a chance https://review.opendev.org/c/openstack/openstacksdk/+/857947 | |
| 13:45:13 | gtema | ack | |
| 14:10:59 | opendevreview | TaeJun Jang proposed openstack/python-openstackclient master: title: Add image metadef namespace command https://review.opendev.org/c/openstack/python-openstackclient/+/863525 | |
| 14:35:43 | opendevreview | Jakob Meng proposed openstack/ansible-collections-openstack master: [DNM] Refactored volume_backup{,_info} modules https://review.opendev.org/c/openstack/ansible-collections-openstack/+/863486 | |
| 14:42:29 | opendevreview | Jakob Meng proposed openstack/ansible-collections-openstack master: Refactored integration test of openstacksdk logging feature https://review.opendev.org/c/openstack/ansible-collections-openstack/+/863529 | |
| 15:07:53 | opendevreview | Merged openstack/ansible-collections-openstack master: Refactored volume_info module https://review.opendev.org/c/openstack/ansible-collections-openstack/+/863483 | |
| 16:14:03 | servagem | Hello! Could someone review patch https://review.opendev.org/c/openstack/python-openstackclient/+/862513 ? Thank you | |
| 20:19:23 | opendevreview | Jakob Meng proposed openstack/ansible-collections-openstack master: [DNM] Refactored volume_backup{,_info} modules https://review.opendev.org/c/openstack/ansible-collections-openstack/+/863486 | |
| #openstack-sdks - 2022-11-04 | |||
| 08:54:53 | opendevreview | Merged openstack/ansible-collections-openstack master: Fix documentation defaults for modules https://review.opendev.org/c/openstack/ansible-collections-openstack/+/863267 | |
| 10:25:02 | opendevreview | Jakob Meng proposed openstack/ansible-collections-openstack master: Refactored volume_backup{,_info} modules https://review.opendev.org/c/openstack/ansible-collections-openstack/+/863486 | |
| 10:26:09 | opendevreview | Jakob Meng proposed openstack/ansible-collections-openstack master: Refactored volume_snapshot{,_info} modules https://review.opendev.org/c/openstack/ansible-collections-openstack/+/863498 | |
| 10:28:19 | opendevreview | Jakob Meng proposed openstack/ansible-collections-openstack master: Refactored config module https://review.opendev.org/c/openstack/ansible-collections-openstack/+/863512 | |
| 10:28:52 | opendevreview | Jakob Meng proposed openstack/ansible-collections-openstack master: Refactored integration test of openstacksdk logging feature https://review.opendev.org/c/openstack/ansible-collections-openstack/+/863529 | |
| 10:38:03 | opendevreview | Artem Goncharov proposed openstack/openstacksdk master: Fix backup metadata management https://review.opendev.org/c/openstack/openstacksdk/+/863634 | |
| 10:38:26 | gtema | jm1 - this is for you | |
| 10:39:11 | jm1 | gtema: uuuh nice :D thx! | |
| 10:39:51 | gtema | as usual - one line of code is causing heavy misbehave | |
| 10:41:55 | jm1 | gtema: this has never worked before, has it? wondering how people tested their code when they contributed it .. | |
| 10:42:40 | gtema | well, this is metadata. It is not a scope of SDK to test functionality of the service itself with all possible combinations | |
| 10:42:50 | gtema | in this case backup was copied from v2 | |
| 10:43:01 | jm1 | gtema: btw do we have to use 3.56 instead of 3.51 because of this? https://review.opendev.org/c/openstack/openstacksdk/+/863634/1/openstack/block_storage/v3/backup.py#84 | |
| 10:43:38 | gtema | no, max_microversion is something like: client support max 3.51 for this resource | |
| 10:44:04 | gtema | so we eventually downgrade server side just to be sure server doesn't send us back what we are not supporting | |
| 10:45:04 | jm1 | gtema: what microversion would be used without your patch? | |
| 10:45:12 | gtema | 3.51 | |
| 10:45:34 | gtema | because there is no changes to backup resource afterwards | |
| 10:46:01 | jm1 | gtema: so why do you set it to 3.51 if 3.51 would be used anyway? | |
| 10:46:23 | gtema | no, without that 3.0 is used | |
| 10:46:34 | jm1 | gtema: ah ok, so 3.0 is the default | |
| 10:46:36 | gtema | I misread the question, sorry | |
| 10:47:16 | gtema | SDK opts for max_microversion if set on the resource, otherwise not specify microver at all | |
| 10:47:27 | jm1 | gtema: but how are users supposed to use the user_id attribute if we set microversio to 3.51 instead of 3.56? | |
| 10:48:10 | gtema | where you get 3.56 from? | |
| 10:48:34 | gtema | ah, I missed to look at "get" response | |
| 10:48:43 | jm1 | "The UUID of the project owner. New in 3.56" < https://review.opendev.org/c/openstack/openstacksdk/+/863634/1/openstack/block_storage/v3/backup.py#84 | |
| 10:49:15 | opendevreview | Artem Goncharov proposed openstack/openstacksdk master: Fix backup metadata management https://review.opendev.org/c/openstack/openstacksdk/+/863634 | |
| 10:49:41 | jm1 | gtema: :D thank you | |
| 10:50:11 | gtema | now I see this is again not really correct, since in 3.64 also encryption_key_id is being added | |
| 10:50:51 | jm1 | gtema: one would think that cinder folks would add their new features to osc | |
| 10:50:55 | jm1 | ..and sdk | |
| 10:51:09 | gtema | yupp | |
| 10:57:38 | opendevreview | Artem Goncharov proposed openstack/openstacksdk master: Fix backup metadata management and update https://review.opendev.org/c/openstack/openstacksdk/+/863634 | |
| 12:44:38 | opendevreview | Jakob Meng proposed openstack/ansible-collections-openstack master: Refactored volume_backup{,_info} modules https://review.opendev.org/c/openstack/ansible-collections-openstack/+/863486 | |
| 12:45:07 | opendevreview | Jakob Meng proposed openstack/ansible-collections-openstack master: Refactored volume_snapshot{,_info} modules https://review.opendev.org/c/openstack/ansible-collections-openstack/+/863498 | |
| 12:45:30 | opendevreview | Jakob Meng proposed openstack/ansible-collections-openstack master: Refactored config module https://review.opendev.org/c/openstack/ansible-collections-openstack/+/863512 | |
| 12:45:52 | opendevreview | Jakob Meng proposed openstack/ansible-collections-openstack master: Refactored integration test of openstacksdk logging feature https://review.opendev.org/c/openstack/ansible-collections-openstack/+/863529 | |
| 12:51:46 | opendevreview | Merged openstack/openstacksdk master: image: Correct typo with 'get_import_info' proxy method https://review.opendev.org/c/openstack/openstacksdk/+/862177 | |
| 13:01:47 | opendevreview | Merged openstack/openstacksdk master: image: Correct typo https://review.opendev.org/c/openstack/openstacksdk/+/862178 | |
| 13:01:51 | opendevreview | Merged openstack/openstacksdk master: image: Allow listing detailed view of stores https://review.opendev.org/c/openstack/openstacksdk/+/862179 | |
| 13:01:54 | opendevreview | Merged openstack/openstacksdk master: image: Add 'store' argument to 'delete_image' proxy method https://review.opendev.org/c/openstack/openstacksdk/+/862180 | |
| 13:01:57 | opendevreview | Merged openstack/openstacksdk master: tests: Avoid potential aliasing of imports https://review.opendev.org/c/openstack/openstacksdk/+/862297 | |
| 13:48:37 | diablo_rojo_phone | gtema: should I join? I was driving my mom to work and am running late | |
| 13:48:55 | gtema | no problem, we are fine | |
| 13:55:10 | opendevreview | Eunyoung Kim proposed openstack/openstacksdk master: image: Add metadef resource type operations https://review.opendev.org/c/openstack/openstacksdk/+/861490 | |
| 14:38:01 | opendevreview | Artem Goncharov proposed openstack/openstacksdk master: Introduce resource_registry in the proxies https://review.opendev.org/c/openstack/openstacksdk/+/863658 | |
| 16:23:47 | opendevreview | Artem Goncharov proposed openstack/openstacksdk master: Implement unified search_resources method https://review.opendev.org/c/openstack/openstacksdk/+/859845 | |
| 16:48:50 | opendevreview | Merged openstack/openstacksdk master: Fix backup metadata management and update https://review.opendev.org/c/openstack/openstacksdk/+/863634 | |
| 16:48:53 | opendevreview | Merged openstack/openstacksdk master: Fix creation of protected image for old user code https://review.opendev.org/c/openstack/openstacksdk/+/838941 | |
| 19:06:58 | opendevreview | Jakob Meng proposed openstack/ansible-collections-openstack master: Refactored volume_backup{,_info} modules https://review.opendev.org/c/openstack/ansible-collections-openstack/+/863486 | |
| 19:09:05 | opendevreview | Jakob Meng proposed openstack/ansible-collections-openstack master: Refactored volume_snapshot{,_info} modules https://review.opendev.org/c/openstack/ansible-collections-openstack/+/863498 | |
| 19:09:29 | opendevreview | Jakob Meng proposed openstack/ansible-collections-openstack master: Refactored config module https://review.opendev.org/c/openstack/ansible-collections-openstack/+/863512 | |
| 19:09:49 | opendevreview | Jakob Meng proposed openstack/ansible-collections-openstack master: Refactored integration test of openstacksdk logging feature https://review.opendev.org/c/openstack/ansible-collections-openstack/+/863529 | |
| 19:10:16 | opendevreview | Jakob Meng proposed openstack/ansible-collections-openstack master: Refactored project_access module https://review.opendev.org/c/openstack/ansible-collections-openstack/+/863696 | |
| #openstack-sdks - 2022-11-05 | |||
| 00:34:14 | opendevreview | Huda Irshad proposed openstack/python-openstackclient master: after adding get_server_action and providing the necessary inputs the return from sever event show is a openstack error https://review.opendev.org/c/openstack/python-openstackclient/+/863718 | |
| 09:09:17 | opendevreview | Merged openstack/python-openstackclient master: quota: Allow showing project-specific quotas https://review.opendev.org/c/openstack/python-openstackclient/+/859957 | |
| 09:09:19 | opendevreview | Merged openstack/python-openstackclient master: quota: Deprecate 'quota show --class', 'quota set --class' arguments https://review.opendev.org/c/openstack/python-openstackclient/+/859958 | |