| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-sdks - 2022-08-25 | |||
| 13:16:33 | opendevreview | Merged openstack/ansible-collections-openstack stable/1.0.0: Release 1.9.0 version https://review.opendev.org/c/openstack/ansible-collections-openstack/+/854564 | |
| 14:54:47 | opendevreview | Shnaidman Sagi (Sergey) proposed openstack/ansible-collections-openstack stable/1.0.0: Fix release job https://review.opendev.org/c/openstack/ansible-collections-openstack/+/854634 | |
| 16:09:25 | opendevreview | Takashi Kajinami proposed openstack/python-openstackclient master: Fix missing closing brackets in metavar https://review.opendev.org/c/openstack/python-openstackclient/+/854462 | |
| 16:42:12 | frickler | slaweq: gtema: ralonsoh: via a merge conflict I found https://review.opendev.org/c/openstack/python-openstackclient/+/424733 and it does have a certain point. there are a lot of field that show "None" as value instead of an empty string, only some like description are really empty. my fix would likely go in the other direction though, like make an unset ipv4_address_scope or | |
| 16:42:18 | frickler | provider:segmentation_id field show an empty value instead of "None". what do you think? | |
| 17:18:34 | ralonsoh | frickler, for flat networks doesn't matter | |
| 17:18:49 | ralonsoh | maybe is better an empty string, rather than None | |
| 17:19:27 | ralonsoh | what other parameters could have this None parameter? | |
| 17:19:46 | ralonsoh | hold on, no, it is better to show "None" | |
| 17:19:58 | ralonsoh | empty string is a valid value, None is no value at all | |
| 17:20:08 | ralonsoh | and I've seen a problem related to the port binding because of this | |
| 17:20:25 | ralonsoh | converting a non-value to an empty string could hide this | |
| 17:46:56 | gtema | frickler: unset doesn't work for sure, since user has attribute access. None vs empty value is so terrible to differentiate once server doesn't return the field at all (/serves/details vs /servers). And even more troublesome to differentiate empty value (as None) from real empty value | |
| 17:47:33 | gtema | We have none in the interface and we need to live with it | |
| 20:23:36 | frickler | so you're telling me that the above patch is valid and I should rebase it and also apply it for the dns_domain field, o.k. | |
| #openstack-sdks - 2022-08-26 | |||
| 00:15:57 | opendevreview | yangjianfeng proposed openstack/python-openstackclient master: Add router ndp proxy commands https://review.opendev.org/c/openstack/python-openstackclient/+/749038 | |
| 06:47:55 | frickler | stephenfin: slaweq: gtema: ^^ I think this should be fine now | |
| 10:48:22 | slaweq | frickler +W | |
| 12:01:23 | opendevreview | Merged openstack/python-openstackclient master: Add router ndp proxy commands https://review.opendev.org/c/openstack/python-openstackclient/+/749038 | |
| 12:14:36 | frickler | \o/ | |
| 21:27:18 | opendevreview | Will Szumski proposed openstack/python-openstackclient master: Fix issue with with image creation when stdin is invalid https://review.opendev.org/c/openstack/python-openstackclient/+/854847 | |
| 23:09:57 | opendevreview | Shnaidman Sagi (Sergey) proposed openstack/ansible-collections-openstack stable/1.0.0: Fix release job https://review.opendev.org/c/openstack/ansible-collections-openstack/+/854634 | |
| #openstack-sdks - 2022-08-27 | |||
| 07:02:37 | opendevreview | Artem Goncharov proposed openstack/openstacksdk master: Fix incremental backups handling in project cleanup https://review.opendev.org/c/openstack/openstacksdk/+/852992 | |
| 07:06:47 | opendevreview | Artem Goncharov proposed openstack/openstacksdk master: Implement project cleanup for object-store https://review.opendev.org/c/openstack/openstacksdk/+/853015 | |
| 07:14:38 | opendevreview | Artem Goncharov proposed openstack/openstacksdk master: Implement project cleanup for object-store https://review.opendev.org/c/openstack/openstacksdk/+/853015 | |
| 07:27:38 | opendevreview | Ke Niu proposed openstack/os-client-config master: remove unicode prefix from code https://review.opendev.org/c/openstack/os-client-config/+/854580 | |
| 08:31:46 | opendevreview | Merged openstack/openstacksdk master: Allow passing explicit microversions to Resource methods https://review.opendev.org/c/openstack/openstacksdk/+/849394 | |
| 12:27:07 | opendevreview | Artem Goncharov proposed openstack/openstacksdk master: Improve tests for create_server https://review.opendev.org/c/openstack/openstacksdk/+/854868 | |
| 14:56:07 | opendevreview | Shnaidman Sagi (Sergey) proposed openstack/ansible-collections-openstack master: Fix release job https://review.opendev.org/c/openstack/ansible-collections-openstack/+/854890 | |
| #openstack-sdks - 2022-08-28 | |||
| 02:20:10 | opendevreview | Travis Holton proposed openstack/ansible-collections-openstack master: Add floating_ip_enabled flag to coe_cluster creation https://review.opendev.org/c/openstack/ansible-collections-openstack/+/854887 | |
| 09:39:04 | opendevreview | Shnaidman Sagi (Sergey) proposed openstack/ansible-collections-openstack master: WIP use python 3.9 for Ansible devel branch since 2.14 https://review.opendev.org/c/openstack/ansible-collections-openstack/+/852526 | |
| 22:21:19 | opendevreview | Shnaidman Sagi (Sergey) proposed openstack/ansible-collections-openstack master: WIP use python 3.9 for Ansible devel branch since 2.14 https://review.opendev.org/c/openstack/ansible-collections-openstack/+/852526 | |
| #openstack-sdks - 2022-08-29 | |||
| 06:50:14 | opendevreview | Ulrich Schwickerath proposed openstack/python-openstackclient master: Added "openstack image namespace list" command https://review.opendev.org/c/openstack/python-openstackclient/+/854557 | |
| 06:55:06 | opendevreview | Artem Goncharov proposed openstack/openstacksdk master: Improve tests for create_server https://review.opendev.org/c/openstack/openstacksdk/+/854868 | |
| 08:36:07 | opendevreview | Ulrich Schwickerath proposed openstack/python-openstackclient master: Added "openstack image namespace list" command https://review.opendev.org/c/openstack/python-openstackclient/+/854557 | |
| 08:45:26 | opendevreview | Ulrich Schwickerath proposed openstack/openstacksdk master: Bugfix for paginating for complex paths https://review.opendev.org/c/openstack/openstacksdk/+/853656 | |
| 08:49:48 | opendevreview | Ulrich Schwickerath proposed openstack/openstacksdk master: added api requirements for new "openstack image namespace list command" https://review.opendev.org/c/openstack/openstacksdk/+/854612 | |
| 10:50:08 | opendevreview | Ke Niu proposed openstack/osc-lib master: remove unicode prefix from code https://review.opendev.org/c/openstack/osc-lib/+/854961 | |
| 11:25:05 | opendevreview | Ulrich Schwickerath proposed openstack/python-openstackclient master: Added "openstack image namespace list" command https://review.opendev.org/c/openstack/python-openstackclient/+/854557 | |
| #openstack-sdks - 2022-08-30 | |||
| 05:37:19 | opendevreview | Ke Niu proposed openstack/osc-lib master: remove unicode prefix from code https://review.opendev.org/c/openstack/osc-lib/+/854961 | |
| 06:01:06 | opendevreview | Ke Niu proposed openstack/shade master: remove unicode prefix from code https://review.opendev.org/c/openstack/shade/+/854510 | |
| 06:31:26 | opendevreview | Yusuke Niimi proposed openstack/keystoneauth master: OAuth2.0 Client Credentials Grant Flow Support https://review.opendev.org/c/openstack/keystoneauth/+/830734 | |
| 08:40:54 | opendevreview | Spyros Trigazis proposed openstack/python-openstackclient master: Added "openstack image namespace list" command https://review.opendev.org/c/openstack/python-openstackclient/+/854557 | |
| 10:13:38 | tweining | Hi. Can you please review https://review.opendev.org/c/openstack/openstacksdk/+/828112 if you have time? | |
| 11:51:58 | frickler | tweining: commented | |
| 11:52:36 | tweining | frickler: thanks | |
| 12:07:23 | opendevreview | Tom Weininger proposed openstack/openstacksdk master: Add docstring to wait_for_load_balancer() method https://review.opendev.org/c/openstack/openstacksdk/+/828112 | |
| 13:09:22 | opendevreview | Merged openstack/openstacksdk master: Fix incremental backups handling in project cleanup https://review.opendev.org/c/openstack/openstacksdk/+/852992 | |
| 15:06:01 | opendevreview | Merged openstack/openstacksdk master: Add docstring to wait_for_load_balancer() method https://review.opendev.org/c/openstack/openstacksdk/+/828112 | |
| 21:45:53 | opendevreview | Rajat Dhasmana proposed openstack/python-openstackclient master: compute: Add support for microversion 2.94 https://review.opendev.org/c/openstack/python-openstackclient/+/831014 | |
| #openstack-sdks - 2022-08-31 | |||
| 02:18:13 | seongsoocho | Hi. Our mentee need one more core review . so please this patch. https://review.opendev.org/c/openstack/python-openstackclient/+/851678 | |
| 02:34:32 | opendevreview | Merged openstack/python-openstackclient master: Fix documents for replaced configuration name https://review.opendev.org/c/openstack/python-openstackclient/+/851678 | |
| 03:21:55 | seongsoocho | thank you :-) | |
| 12:11:26 | opendevreview | Takashi Natsume proposed openstack/python-openstackclient master: Replace assertItemsEqual with assertCountEqual https://review.opendev.org/c/openstack/python-openstackclient/+/853842 | |
| 13:23:26 | dtantsur | hey folks! could I get some reviews on https://review.opendev.org/c/openstack/openstacksdk/+/849505/ https://review.opendev.org/c/openstack/openstacksdk/+/849564/ please? I cannot proceed with register_machine refactoring without them. | |
| 18:06:23 | opendevreview | Rajat Dhasmana proposed openstack/python-openstackclient master: compute: Add support for microversion 2.93 https://review.opendev.org/c/openstack/python-openstackclient/+/831014 | |
| 20:11:42 | opendevreview | Rajat Dhasmana proposed openstack/python-openstackclient master: compute: Add support for microversion 2.93 https://review.opendev.org/c/openstack/python-openstackclient/+/831014 | |
| #openstack-sdks - 2022-09-01 | |||
| 06:20:47 | opendevreview | Ulrich Schwickerath proposed openstack/openstacksdk master: added api requirements for new "openstack image metadefs namespace list" command https://review.opendev.org/c/openstack/openstacksdk/+/854612 | |
| 08:19:39 | opendevreview | Ulrich Schwickerath proposed openstack/python-openstackclient master: Added "openstack image metadefs namespace list" command https://review.opendev.org/c/openstack/python-openstackclient/+/854557 | |
| 08:47:41 | opendevreview | Ulrich Schwickerath proposed openstack/openstacksdk master: added api requirements for new "openstack image metadefs namespace list" command https://review.opendev.org/c/openstack/openstacksdk/+/854612 | |
| 13:43:24 | opendevreview | Ulrich Schwickerath proposed openstack/openstacksdk master: added api requirements for new "openstack image metadefs namespace list" command https://review.opendev.org/c/openstack/openstacksdk/+/854612 | |
| 13:51:08 | opendevreview | Ulrich Schwickerath proposed openstack/openstacksdk master: added api requirements for new "openstack image metadefs namespace list" command https://review.opendev.org/c/openstack/openstacksdk/+/854612 | |
| 14:29:49 | opendevreview | Ulrich Schwickerath proposed openstack/openstacksdk master: added api requirements for new "openstack image metadefs namespace list" command https://review.opendev.org/c/openstack/openstacksdk/+/854612 | |
| 15:22:33 | opendevreview | Gregory Thiemonge proposed openstack/openstacksdk master: Add additional_vips parameter for Octavia load balancers https://review.opendev.org/c/openstack/openstacksdk/+/835175 | |
| 15:24:34 | stephenfin | gtema: Can you sanity check https://review.opendev.org/c/openstack/python-openstackclient/+/854363/ and the following patch? | |
| 15:24:57 | stephenfin | the novaclient 18.1.0 release was cut here https://review.opendev.org/c/openstack/releases/+/854362 | |
| 15:25:06 | gtema | yupp, looking | |
| 18:15:53 | opendevreview | Merged openstack/python-openstackclient master: Microversion 2.91: Support specifying destination host to unshelve https://review.opendev.org/c/openstack/python-openstackclient/+/831902 | |
| #openstack-sdks - 2022-09-02 | |||
| 09:45:01 | opendevreview | Ulrich Schwickerath proposed openstack/openstacksdk master: added api requirements for new "openstack image metadefs namespace list" command https://review.opendev.org/c/openstack/openstacksdk/+/854612 | |
| 12:02:38 | opendevreview | Ulrich Schwickerath proposed openstack/openstacksdk master: added api requirements for new "openstack image metadefs namespace list" command https://review.opendev.org/c/openstack/openstacksdk/+/854612 | |
| 13:51:20 | opendevreview | Ulrich Schwickerath proposed openstack/openstacksdk master: added api requirements for new "openstack image metadefs namespace list" command https://review.opendev.org/c/openstack/openstacksdk/+/854612 | |
| 17:22:45 | opendevreview | Merged openstack/keystoneauth master: OAuth2.0 Client Credentials Grant Flow Support https://review.opendev.org/c/openstack/keystoneauth/+/830734 | |
| 19:52:20 | opendevreview | hai wu proposed openstack/openstacksdk master: Add support for fault object per Server API https://review.opendev.org/c/openstack/openstacksdk/+/853703 | |
| #openstack-sdks - 2022-09-03 | |||
| 20:27:13 | opendevreview | Elod Illes proposed openstack/cliff master: DNM: dummy change to test gate health https://review.opendev.org/c/openstack/cliff/+/855726 | |
| 20:28:55 | opendevreview | Elod Illes proposed openstack/keystoneauth master: DNM: dummy change to test gate health https://review.opendev.org/c/openstack/keystoneauth/+/855729 | |
| 20:32:13 | opendevreview | Elod Illes proposed openstack/openstacksdk master: DNM: dummy change to test gate health https://review.opendev.org/c/openstack/openstacksdk/+/855739 | |
| 20:33:55 | opendevreview | Elod Illes proposed openstack/osc-lib master: DNM: dummy change to test gate health https://review.opendev.org/c/openstack/osc-lib/+/855744 | |
| #openstack-sdks - 2022-09-05 | |||
| 08:45:19 | opendevreview | Ulrich Schwickerath proposed openstack/openstacksdk master: added api requirements for new "openstack image metadefs namespace list" command https://review.opendev.org/c/openstack/openstacksdk/+/854612 | |
| 15:29:13 | opendevreview | Jan Hartkopf proposed openstack/python-openstackclient master: network: add tenant project filter for RBAC list https://review.opendev.org/c/openstack/python-openstackclient/+/834443 | |
| #openstack-sdks - 2022-09-06 | |||
| 06:46:49 | opendevreview | Ulrich Schwickerath proposed openstack/python-openstackclient master: Added "openstack image metadefs namespace list" command https://review.opendev.org/c/openstack/python-openstackclient/+/854557 | |
| 07:18:50 | opendevreview | Jakob Meng proposed openstack/ansible-collections-openstack master: Update quota for 2.0.0 https://review.opendev.org/c/openstack/ansible-collections-openstack/+/851483 | |
| 09:13:05 | opendevreview | Jakob Meng proposed openstack/ansible-collections-openstack master: Move keypair module to proxy layer https://review.opendev.org/c/openstack/ansible-collections-openstack/+/847960 | |
| 09:56:28 | opendevreview | Ulrich Schwickerath proposed openstack/openstacksdk master: added api requirements for new "openstack image metadefs namespace list" command https://review.opendev.org/c/openstack/openstacksdk/+/854612 | |
| 10:00:18 | opendevreview | Ulrich Schwickerath proposed openstack/python-openstackclient master: Added "openstack image metadefs namespace list" command https://review.opendev.org/c/openstack/python-openstackclient/+/854557 | |
| 11:07:27 | jm1 | gtema: hello :) coe in sdk is refering to magnum? https://docs.openstack.org/api-ref/container-infrastructure-management/ | |
| 11:07:49 | jm1 | gtema: there is no resource layer for coe, is it? | |
| 11:24:53 | gtema | jm1: right. There is no proper implementation for it | |
| 11:27:42 | jm1 | gtema: ack, thanks! | |
| 11:28:27 | opendevreview | Ananya proposed openstack/ansible-collections-openstack master: Makes stack module compatible with new sdk version https://review.opendev.org/c/openstack/ansible-collections-openstack/+/848266 | |
| 11:31:31 | jm1 | gtema: did you have time to look into the register_machine stuff? | |
| 11:31:44 | gtema | no, sorry. Completely forgot | |
| 11:32:19 | jm1 | gtema: ok np | |
| 11:32:31 | jm1 | gtema: you did have some rfc, didnt you? | |
| 11:32:45 | jm1 | gtema: filter patches and fip related | |
| 11:32:55 | jm1 | gtema: did you merge those? | |
| 11:33:04 | gtema | not yet | |
| 11:33:23 | gtema | oh, now there is even merge conflict (facepalm) | |
| 11:33:31 | gtema | https://review.opendev.org/c/openstack/openstacksdk/+/853052 | |
| 11:34:30 | jm1 | gtema: ah i already added comments ^^ | |
| 11:35:28 | gtema | this is a prerequisite more or less to address your comments. 1st it is required to implement general resource layer interface and then extend cloud layer functions to use it | |