| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-sdks - 2022-07-11 | |||
| 19:55:34 | opendevreview | Jakob Meng proposed openstack/ansible-collections-openstack master: Refactored server and server_info modules https://review.opendev.org/c/openstack/ansible-collections-openstack/+/849423 | |
| #openstack-sdks - 2022-07-12 | |||
| 05:54:09 | opendevreview | Jakob Meng proposed openstack/ansible-collections-openstack master: Refactored server and server_info modules https://review.opendev.org/c/openstack/ansible-collections-openstack/+/849423 | |
| 07:45:23 | opendevreview | mbu proposed openstack/python-openstackclient master: Wait for volume being available to set bootable or readonly https://review.opendev.org/c/openstack/python-openstackclient/+/845991 | |
| 07:56:12 | opendevreview | Arx Cruz proposed openstack/ansible-collections-openstack master: Update federation_mapping_info module to use proxy https://review.opendev.org/c/openstack/ansible-collections-openstack/+/849283 | |
| 08:01:59 | opendevreview | Jakob Meng proposed openstack/ansible-collections-openstack stable/1.0.0: Backport improvements to endpoint module https://review.opendev.org/c/openstack/ansible-collections-openstack/+/846250 | |
| 08:34:11 | opendevreview | Jakob Meng proposed openstack/ansible-collections-openstack stable/1.0.0: Backport improvements to endpoint module https://review.opendev.org/c/openstack/ansible-collections-openstack/+/846250 | |
| 08:43:33 | opendevreview | Jakob Meng proposed openstack/ansible-collections-openstack master: Added assertions on endpoint module results https://review.opendev.org/c/openstack/ansible-collections-openstack/+/849466 | |
| 09:10:52 | opendevreview | Arx Cruz proposed openstack/ansible-collections-openstack master: DNM - Update federation_mapping_info module to use proxy https://review.opendev.org/c/openstack/ansible-collections-openstack/+/849283 | |
| 09:11:41 | opendevreview | Dmitry Tantsur proposed openstack/openstacksdk master: Allow passing explicit microversions to Resource methods https://review.opendev.org/c/openstack/openstacksdk/+/849394 | |
| 09:16:40 | opendevreview | Dmitry Tantsur proposed openstack/openstacksdk master: [WIP] Migrate register_machine to use the proxy layer https://review.opendev.org/c/openstack/openstacksdk/+/849402 | |
| 12:12:40 | opendevreview | Jakob Meng proposed openstack/ansible-collections-openstack master: Update router for 2.0.0 https://review.opendev.org/c/openstack/ansible-collections-openstack/+/846446 | |
| 12:13:55 | opendevreview | Arx Cruz proposed openstack/ansible-collections-openstack master: Update federation_mapping_info module to use proxy https://review.opendev.org/c/openstack/ansible-collections-openstack/+/849283 | |
| 12:44:21 | opendevreview | Dmitry Tantsur proposed openstack/openstacksdk master: baremetal: rework node creation to be closer to the backend https://review.opendev.org/c/openstack/openstacksdk/+/849505 | |
| 12:46:19 | opendevreview | Dmitry Tantsur proposed openstack/openstacksdk master: baremetal: rework node creation to be closer to the backend https://review.opendev.org/c/openstack/openstacksdk/+/849505 | |
| 12:46:40 | opendevreview | Dmitry Tantsur proposed openstack/openstacksdk master: [WIP] Migrate register_machine to use the proxy layer https://review.opendev.org/c/openstack/openstacksdk/+/849402 | |
| 12:59:53 | opendevreview | Jakob Meng proposed openstack/ansible-collections-openstack master: Update router for 2.0.0 https://review.opendev.org/c/openstack/ansible-collections-openstack/+/846446 | |
| 13:01:06 | opendevreview | Jakob Meng proposed openstack/ansible-collections-openstack master: Update router for 2.0.0 https://review.opendev.org/c/openstack/ansible-collections-openstack/+/846446 | |
| 13:08:24 | opendevreview | Merged openstack/ansible-collections-openstack master: Added assertions on endpoint module results https://review.opendev.org/c/openstack/ansible-collections-openstack/+/849466 | |
| 13:12:10 | opendevreview | Jakob Meng proposed openstack/ansible-collections-openstack master: Update project module to be compatible with new sdk https://review.opendev.org/c/openstack/ansible-collections-openstack/+/839640 | |
| 15:56:41 | opendevreview | Merged openstack/ansible-collections-openstack master: Update project module to be compatible with new sdk https://review.opendev.org/c/openstack/ansible-collections-openstack/+/839640 | |
| 16:08:29 | opendevreview | Dmitry Tantsur proposed openstack/openstacksdk master: Actually use openstacksdk from source in the Bifrost job https://review.opendev.org/c/openstack/openstacksdk/+/849564 | |
| 16:08:46 | opendevreview | Dmitry Tantsur proposed openstack/openstacksdk master: [WIP] Migrate register_machine to use the proxy layer https://review.opendev.org/c/openstack/openstacksdk/+/849402 | |
| 16:26:15 | opendevreview | Rafael Castillo proposed openstack/ansible-collections-openstack master: Make build-test-packages build master openstacksdk https://review.opendev.org/c/openstack/ansible-collections-openstack/+/844859 | |
| 16:36:05 | opendevreview | Violet Kurtz proposed openstack/python-openstackclient master: Migrate server_groups to the new API https://review.opendev.org/c/openstack/python-openstackclient/+/837615 | |
| 17:24:39 | opendevreview | Merged openstack/ansible-collections-openstack stable/1.0.0: Backport improvements to endpoint module https://review.opendev.org/c/openstack/ansible-collections-openstack/+/846250 | |
| 20:06:16 | opendevreview | Violet Kurtz proposed openstack/python-openstackclient master: Migrate server_groups to the new API https://review.opendev.org/c/openstack/python-openstackclient/+/837615 | |
| #openstack-sdks - 2022-07-13 | |||
| 08:03:40 | matbu | Hey folks, is it possible to get another reviews on this one: https://review.opendev.org/c/openstack/python-openstackclient/+/845991 | |
| 08:03:52 | matbu | thank you | |
| 09:22:55 | opendevreview | Dmitry Tantsur proposed openstack/ansible-collections-openstack master: Add a wait argument to baremetal_node https://review.opendev.org/c/openstack/ansible-collections-openstack/+/849653 | |
| 10:13:31 | opendevreview | Jakob Meng proposed openstack/ansible-collections-openstack master: [DNM] Build and install latest RPM for openstacksdk in TripleO jobs https://review.opendev.org/c/openstack/ansible-collections-openstack/+/849657 | |
| 10:25:01 | opendevreview | Dmitry Tantsur proposed openstack/ansible-collections-openstack master: Add a wait argument to baremetal_node https://review.opendev.org/c/openstack/ansible-collections-openstack/+/849653 | |
| 10:55:19 | opendevreview | Dmitry Tantsur proposed openstack/openstacksdk master: [WIP] Migrate register_machine to use the proxy layer https://review.opendev.org/c/openstack/openstacksdk/+/849402 | |
| 11:51:51 | opendevreview | Dmitry Tantsur proposed openstack/ansible-collections-openstack master: Remove deprecated stuff from baremetal_node https://review.opendev.org/c/openstack/ansible-collections-openstack/+/849668 | |
| 12:13:21 | opendevreview | Pavlo Shchelokovskyy proposed openstack/python-openstackclient master: Add authorization_ttl for identity providers https://review.opendev.org/c/openstack/python-openstackclient/+/849669 | |
| 13:47:40 | opendevreview | Danila Balagansky proposed openstack/openstacksdk master: WIP: Cron Triggers proxy https://review.opendev.org/c/openstack/openstacksdk/+/848095 | |
| 14:05:00 | opendevreview | mbu proposed openstack/python-openstackclient master: Wait for volume being available to set bootable or readonly https://review.opendev.org/c/openstack/python-openstackclient/+/845991 | |
| 14:08:19 | opendevreview | Pavlo Shchelokovskyy proposed openstack/python-openstackclient master: Add authorization_ttl for identity providers https://review.opendev.org/c/openstack/python-openstackclient/+/849669 | |
| 14:37:35 | opendevreview | mbu proposed openstack/python-openstackclient master: Wait for volume being available to set bootable or readonly https://review.opendev.org/c/openstack/python-openstackclient/+/845991 | |
| 18:58:16 | opendevreview | Pavlo Shchelokovskyy proposed openstack/python-openstackclient master: Add authorization_ttl for identity providers https://review.opendev.org/c/openstack/python-openstackclient/+/849669 | |
| 19:28:17 | opendevreview | Pavlo Shchelokovskyy proposed openstack/python-openstackclient master: Add authorization_ttl for identity providers https://review.opendev.org/c/openstack/python-openstackclient/+/849669 | |
| 19:30:04 | opendevreview | Pedro Henrique Pereira Martins proposed openstack/python-openstackclient master: Add port ranges on floating ip portforwardings cli https://review.opendev.org/c/openstack/python-openstackclient/+/836870 | |
| #openstack-sdks - 2022-07-14 | |||
| 08:16:01 | opendevreview | Jakob Meng proposed openstack/ansible-collections-openstack master: Update router for 2.0.0 https://review.opendev.org/c/openstack/ansible-collections-openstack/+/846446 | |
| 08:27:38 | opendevreview | Jakob Meng proposed openstack/ansible-collections-openstack master: Refactored router module https://review.opendev.org/c/openstack/ansible-collections-openstack/+/849793 | |
| 08:46:44 | opendevreview | Arx Cruz proposed openstack/ansible-collections-openstack master: Update federation_idp_info module to use proxy layer https://review.opendev.org/c/openstack/ansible-collections-openstack/+/849282 | |
| 16:04:13 | opendevreview | Merged openstack/cliff master: requirements: Remove explicit pyparsing dependency https://review.opendev.org/c/openstack/cliff/+/842345 | |
| #openstack-sdks - 2022-07-15 | |||
| 07:12:56 | opendevreview | Jakob Meng proposed openstack/ansible-collections-openstack master: [DNM] Build and install latest RPM for openstacksdk in TripleO jobs https://review.opendev.org/c/openstack/ansible-collections-openstack/+/849657 | |
| 07:44:48 | opendevreview | Jakob Meng proposed openstack/ansible-collections-openstack master: Refactored server and server_info modules https://review.opendev.org/c/openstack/ansible-collections-openstack/+/849423 | |
| 08:38:07 | opendevreview | mbu proposed openstack/osc-lib stable/yoga: Do not output log on bash autocomplete generation https://review.opendev.org/c/openstack/osc-lib/+/849822 | |
| 08:38:18 | opendevreview | mbu proposed openstack/osc-lib stable/xena: Do not output log on bash autocomplete generation https://review.opendev.org/c/openstack/osc-lib/+/849823 | |
| 08:38:28 | opendevreview | mbu proposed openstack/osc-lib stable/wallaby: Do not output log on bash autocomplete generation https://review.opendev.org/c/openstack/osc-lib/+/849824 | |
| 09:03:25 | opendevreview | Jakob Meng proposed openstack/openstacksdk master: Reduce list_router_interfaces() to necessary API calls https://review.opendev.org/c/openstack/openstacksdk/+/849967 | |
| 09:27:59 | opendevreview | Jakob Meng proposed openstack/ansible-collections-openstack master: Refactored router module https://review.opendev.org/c/openstack/ansible-collections-openstack/+/849793 | |
| 09:56:15 | opendevreview | Jakob Meng proposed openstack/ansible-collections-openstack master: Replaced code in routers_info module with openstacksdk function https://review.opendev.org/c/openstack/ansible-collections-openstack/+/849975 | |
| 10:13:48 | opendevreview | Jakob Meng proposed openstack/ansible-collections-openstack master: Replaced code in routers_info module with openstacksdk function https://review.opendev.org/c/openstack/ansible-collections-openstack/+/849975 | |
| 10:16:54 | opendevreview | Jakob Meng proposed openstack/openstacksdk master: Reduce list_router_interfaces() to necessary API calls https://review.opendev.org/c/openstack/openstacksdk/+/849967 | |
| 10:17:33 | elodilles | gtema: hi, release team is approving zed-2 release patches and i remember that openstacksdk latest release was a bit 'bigger' than usual, so now that we generated the zed-2 release patch for it, it would be good if you could double check the release, before we merge it (deadline was yesterday): https://review.opendev.org/c/openstack/releases/+/849554 | |
| 10:18:49 | gtema | uhm, I somehow again missed the email, need to check spam rules. Looking now | |
| 10:20:19 | elodilles | this is the general countdown mail that contains the info about zed-2: https://lists.openstack.org/pipermail/openstack-discuss/2022-July/029465.html | |
| 10:20:47 | gtema | thks, approved | |
| 10:21:21 | elodilles | gtema: thanks \o/ | |
| 10:21:41 | elodilles | just a question: do you plan to release 1.0.0 @ zed-3? | |
| 10:24:16 | elodilles | or it is not planned yet / will be released in the next cycle after Zed? | |
| 10:25:06 | elodilles | (i'm just asking this out of curiosity, no official statement is needed or something like that [4~:)) | |
| 10:25:41 | gtema | I fear zed-3 will not be reachable - there are still lots of issues fron Ansible collections side | |
| 10:26:05 | opendevreview | Jakob Meng proposed openstack/openstacksdk master: Reduce list_router_interfaces() to necessary API calls https://review.opendev.org/c/openstack/openstacksdk/+/849967 | |
| 10:28:03 | elodilles | gtema: ack, i see, thanks! | |
| 10:34:46 | opendevreview | Jakob Meng proposed openstack/ansible-collections-openstack master: Replaced code in routers_info module with openstacksdk function https://review.opendev.org/c/openstack/ansible-collections-openstack/+/849975 | |
| 10:48:04 | jm1 | gtema: having issues with unit tests for this one here https://review.opendev.org/c/openstack/openstacksdk/+/849967 | |
| 10:48:19 | jm1 | gtema: any idea how to change the mock uris? https://291f4451bebc670e507b-a999ae1d5baedde86711d4f3bf719537.ssl.cf1.rackcdn.com/849967/3/check/openstack-tox-py38/863c9c3/job-output.txt | |
| 10:48:36 | jm1 | gtema: that is the error: requests_mock.exceptions.NoMockAddress: No mock address: GET https://network.example.com/v2.0/ports?device_id=57076620-dcfb-42ed-8ad6-79ccb4a79ed2 | |
| 10:49:31 | jm1 | gtema: this is the location where mock is created: https://opendev.org/openstack/openstacksdk/src/branch/master/openstack/tests/unit/cloud/test_router.py#L377 | |
| 10:50:17 | gtema | hehe, I admit I reworked how mocks are filled here | |
| 10:52:18 | gtema | why do you delete device_id filter? | |
| 10:53:59 | jm1 | gtema: i dont, do i? | |
| 10:54:40 | gtema | need to look deeper, but that should be the reason for mock not being recognized | |
| 10:55:10 | gtema | ah, this is vice versa, this is the only one remaining now | |
| 10:55:40 | gtema | i will update your change after lunch if you don't mind | |
| 10:55:48 | jm1 | gtema: yes, instead of doing 4 api calls with different device_owner's i am doing just a single one | |
| 10:57:29 | gtema | sure, makes sense. There are too many places to simplify - that is the whole sense of breaking ansible ;-) | |
| 10:59:30 | jm1 | gtema: maybe you can give me a hint on how to remove the device_owner from the mock url? | |
| 11:00:13 | gtema | https://opendev.org/openstack/openstacksdk/src/branch/master/openstack/tests/unit/cloud/test_router.py#L374 | |
| 11:01:15 | gtema | maybe extend the function _get_mock_dict to not to include it in the QS if param is empty | |
| 11:24:12 | opendevreview | Pavlo Shchelokovskyy proposed openstack/python-openstackclient master: Fix server evacuate command https://review.opendev.org/c/openstack/python-openstackclient/+/849990 | |
| 12:42:31 | jm1 | gtema: omg, of course 😂 wood and all those trees, you know.. | |
| 12:42:50 | gtema | yeah | |
| 12:46:11 | opendevreview | Jakob Meng proposed openstack/openstacksdk master: Reduce list_router_interfaces() to necessary API calls https://review.opendev.org/c/openstack/openstacksdk/+/849967 | |
| 12:54:23 | anskiy | gtema: hello! I've made this thing: https://review.opendev.org/c/openstack/openstacksdk/+/848095, it's not thoroughly tested (I'm using a bit less functionality: just basic create/delete/find and ...s(), without extensive filters and such), but it works as expected from what I can see now. Can you take a look and tell me what's left for it to be merged? | |
| 12:54:48 | gtema | ok, will try to get some time for that | |
| 12:56:02 | anskiy | I'm gonna remove the "WIP" in the heading, CI should be fine as those issues look temporary. Thank you! | |
| 12:58:18 | opendevreview | Danila Balagansky proposed openstack/openstacksdk master: Cron Triggers proxy https://review.opendev.org/c/openstack/openstacksdk/+/848095 | |
| 14:02:07 | opendevreview | Jakob Meng proposed openstack/openstacksdk master: Reduce list_router_interfaces() to necessary API calls https://review.opendev.org/c/openstack/openstacksdk/+/849967 | |
| 14:49:49 | opendevreview | Jakob Meng proposed openstack/openstacksdk master: Reduce list_router_interfaces() to necessary API calls https://review.opendev.org/c/openstack/openstacksdk/+/849967 | |
| 15:06:31 | opendevreview | Jakob Meng proposed openstack/openstacksdk master: Reduce list_router_interfaces() to necessary API calls https://review.opendev.org/c/openstack/openstacksdk/+/849967 | |
| 15:08:54 | opendevreview | Stephen Finucane proposed openstack/cliff master: Remove final use of pkg_resources https://review.opendev.org/c/openstack/cliff/+/842350 | |
| 15:14:01 | gtema | stephenfin, I feel nearly ashamed, but how have you found syntax from https://review.opendev.org/c/openstack/openstacksdk/+/846214/2/openstack/resource.py#1303? | |
| 15:14:28 | stephenfin | gtema: https://peps.python.org/pep-3102/ | |
| 15:14:45 | gtema | ugh | |
| 15:14:45 | stephenfin | that's for kwarg-only arguments | |
| 15:15:17 | gtema | I've never seen single "*" | |
| 15:15:20 | stephenfin | which I think make sense here. No one should ever be passing those args positionally. It also means we can opt to move things around down the line if we like | |