| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-sdks - 2022-05-22 | |||
| 14:18:35 | opendevreview | Takashi Kajinami proposed openstack/keystoneauth stable/yoga: stably-only: Fix wrong python job template https://review.opendev.org/c/openstack/keystoneauth/+/842886 | |
| 14:21:59 | opendevreview | Takashi Kajinami proposed openstack/keystoneauth master: Bump tox minversion to 3.18.0 https://review.opendev.org/c/openstack/keystoneauth/+/842870 | |
| 18:37:02 | eandersson | frickler: Looks like the same fix that I went with as well. We already had it in place, but kept an alternative for older versions. I still don’t get why the api returns an name as an id though | |
| 18:49:24 | frickler | the nova API does not return an id. the old sdk returned the API response 1:1 as a dict, the new sdk converts it to a Flavor object, which has an id field even if that is null | |
| 18:50:25 | frickler | to be clear, this is for the flavor field in the nova server API, not the flavor API | |
| 20:33:16 | eandersson | Yea - but if the id field was null that would be fine | |
| 20:41:29 | frickler | ah, right, now I remember, gtema made a weird (IMHO) patch that fills original_name into the id. I would agree to revert that. | |
| 20:43:09 | eandersson | Yea - that is what breaks it for us. | |
| 20:43:18 | frickler | https://review.opendev.org/c/openstack/openstacksdk/+/826924/4/openstack/compute/v2/flavor.py#69 | |
| 20:43:48 | eandersson | Our code checks if id is there, if not it gets it using the flavor call | |
| 20:44:14 | eandersson | but because id is not none it assumes that it does not need to get any additional data | |
| 20:44:22 | frickler | how do you handle deleted flavors? | |
| 20:44:45 | eandersson | I doubt this code is smart enough to handle that | |
| 20:45:16 | frickler | what do you need the flavor for? | |
| 20:46:03 | eandersson | It's used to handle scale in so creating vms | |
| 20:46:25 | eandersson | the problem is that I don't want to change the current behavior without digging in a lot further into how this works | |
| 20:46:55 | eandersson | But I don't really have the time and this is blocking the CI | |
| 20:48:22 | eandersson | This is all stored in the database, so it would probably break something to switch away from id | |
| 20:48:43 | eandersson | https://paste.openstack.org/show/bcAcLpv3GNnvdZWxvWtY/ | |
| 20:52:55 | eandersson | I guess I could change it to use name, throw in a release note and hope for the best :p | |
| 20:53:04 | eandersson | Pretty sure I am the last maintainer of this project | |
| 20:53:25 | frickler | hmm, I guess then I can only suggest to use a different attribute like "vcpus" as a proxy to decide whether the id is a real id or a name that needs converting, cf. https://review.opendev.org/c/zuul/nodepool/+/834152/2/nodepool/driver/openstack/provider.py#142 | |
| 20:58:21 | eandersson | Gonna try to go the simplest route. I remember going through this last time as well and I feel like it's just a ticking timebomb. | |
| 20:58:30 | eandersson | I just wish I understood these code paths better. | |
| 21:01:37 | eandersson | Any other project just testing against trunk openstacksdk? | |
| 21:01:52 | eandersson | Feel like Senlin should just have a job that does that to give an earlier headsup | |
| 21:04:10 | frickler | well osc obviously has one, and I think ansible-collection-openstack | |
| 21:04:34 | frickler | usually also we try not to break as much, but in this case it was necessary | |
| 21:20:05 | eandersson | Sounds good. Thanks for the help. | |
| #openstack-sdks - 2022-05-23 | |||
| 02:02:25 | eandersson | Got a simple patch up to fix the Senlin issue. | |
| 07:49:55 | opendevreview | Arx Cruz proposed openstack/ansible-collections-openstack master: Update routers_info for the new SDK https://review.opendev.org/c/openstack/ansible-collections-openstack/+/838489 | |
| 07:51:34 | opendevreview | Arx Cruz proposed openstack/ansible-collections-openstack master: Update project_info module to new sdk https://review.opendev.org/c/openstack/ansible-collections-openstack/+/837276 | |
| 08:06:12 | opendevreview | Arx Cruz proposed openstack/ansible-collections-openstack master: Update port info https://review.opendev.org/c/openstack/ansible-collections-openstack/+/833083 | |
| 08:21:21 | opendevreview | Arx Cruz proposed openstack/ansible-collections-openstack master: Update catalog service for the new sdk https://review.opendev.org/c/openstack/ansible-collections-openstack/+/839352 | |
| 08:25:45 | opendevreview | Arx Cruz proposed openstack/ansible-collections-openstack master: Update endpoint to new proxy layer https://review.opendev.org/c/openstack/ansible-collections-openstack/+/840640 | |
| 08:26:39 | opendevreview | Arx Cruz proposed openstack/ansible-collections-openstack master: Update endpoint to new proxy layer https://review.opendev.org/c/openstack/ansible-collections-openstack/+/840640 | |
| 09:30:24 | opendevreview | Merged openstack/microversion-parse master: Drop python3.6/3.7 support in testing runtime https://review.opendev.org/c/openstack/microversion-parse/+/840621 | |
| 12:05:00 | opendevreview | Jakob Meng proposed openstack/ansible-collections-openstack master: Updated pip constraints for release candidates of OpenStackSDK's first major release https://review.opendev.org/c/openstack/ansible-collections-openstack/+/842966 | |
| 12:07:49 | opendevreview | Jakob Meng proposed openstack/ansible-collections-openstack master: Updated pip constraints for release candidates of OpenStackSDK's first major release https://review.opendev.org/c/openstack/ansible-collections-openstack/+/842966 | |
| 12:22:19 | opendevreview | Dmitry Tantsur proposed openstack/openstacksdk master: Do not log to stdout by default https://review.opendev.org/c/openstack/openstacksdk/+/842967 | |
| 12:55:56 | dtantsur | even with this ^^^ the python's logging machinery logs everything in stdout, breaking any code that tries to parse a tool output | |
| 12:56:02 | dtantsur | I don't know what to do | |
| 13:18:16 | opendevreview | Rafael Castillo proposed openstack/ansible-collections-openstack master: Update recordset module to be compatible with new sdk https://review.opendev.org/c/openstack/ansible-collections-openstack/+/842575 | |
| 13:21:40 | opendevreview | Rafael Castillo proposed openstack/ansible-collections-openstack master: Adds recordset_info module https://review.opendev.org/c/openstack/ansible-collections-openstack/+/842550 | |
| 16:44:13 | opendevreview | Arx Cruz proposed openstack/ansible-collections-openstack master: Update catalog service for the new sdk https://review.opendev.org/c/openstack/ansible-collections-openstack/+/839352 | |
| #openstack-sdks - 2022-05-24 | |||
| 06:50:51 | opendevreview | Jiri Podivin proposed openstack/ansible-collections-openstack master: DNM testing override behavior https://review.opendev.org/c/openstack/ansible-collections-openstack/+/843106 | |
| 06:52:12 | opendevreview | Jiri Podivin proposed openstack/ansible-collections-openstack master: DNM testing override behavior https://review.opendev.org/c/openstack/ansible-collections-openstack/+/843106 | |
| 07:29:20 | opendevreview | Jiri Podivin proposed openstack/ansible-collections-openstack master: DNM testing override behavior https://review.opendev.org/c/openstack/ansible-collections-openstack/+/843106 | |
| 07:34:39 | opendevreview | Jiri Podivin proposed openstack/ansible-collections-openstack master: DNM testing override behavior https://review.opendev.org/c/openstack/ansible-collections-openstack/+/843110 | |
| 07:36:02 | opendevreview | Jiri Podivin proposed openstack/ansible-collections-openstack master: DNM testing override behavior https://review.opendev.org/c/openstack/ansible-collections-openstack/+/843106 | |
| 07:59:43 | opendevreview | Jiri Podivin proposed openstack/ansible-collections-openstack master: DNM testing override behavior https://review.opendev.org/c/openstack/ansible-collections-openstack/+/843106 | |
| 08:06:53 | opendevreview | Takashi Kajinami proposed openstack/python-openstackclient master: Replace Python 3.6 by Python 3.9 https://review.opendev.org/c/openstack/python-openstackclient/+/843115 | |
| 08:09:40 | opendevreview | Takashi Kajinami proposed openstack/python-openstackclient master: Bump minimum python version to 3.8 https://review.opendev.org/c/openstack/python-openstackclient/+/843115 | |
| 08:12:05 | tkajinam | stephenfin, may I ask you thoughts on this ? ^^^ this is currently blocking keystoneauth gate | |
| 08:14:03 | opendevreview | Takashi Kajinami proposed openstack/python-openstackclient master: Bump minimum python version to 3.8 https://review.opendev.org/c/openstack/python-openstackclient/+/843115 | |
| 08:30:26 | opendevreview | Merged openstack/ansible-collections-openstack master: Updated pip constraints for release candidates of OpenStackSDK's first major release https://review.opendev.org/c/openstack/ansible-collections-openstack/+/842966 | |
| 08:34:05 | opendevreview | Jakob Meng proposed openstack/ansible-collections-openstack stable/1.0.0: Updated pip constraints for release candidates of OpenStackSDK's first major release https://review.opendev.org/c/openstack/ansible-collections-openstack/+/842946 | |
| 08:37:22 | opendevreview | Jakob Meng proposed openstack/ansible-collections-openstack stable/1.0.0: Updated pip constraints for release candidates of OpenStackSDK's first major release https://review.opendev.org/c/openstack/ansible-collections-openstack/+/842946 | |
| 08:47:56 | opendevreview | Takashi Kajinami proposed openstack/python-openstackclient master: Migrate osc-tox-py3N-tips to Python 3.9 https://review.opendev.org/c/openstack/python-openstackclient/+/843115 | |
| 08:51:34 | opendevreview | Takashi Kajinami proposed openstack/cliff master: Migrate Python 3.6/7 jobs to Python 3.8 https://review.opendev.org/c/openstack/cliff/+/843123 | |
| 08:53:15 | opendevreview | Takashi Kajinami proposed openstack/cliff master: Migrate Python 3.6/7 jobs to Python 3.8 https://review.opendev.org/c/openstack/cliff/+/843123 | |
| 09:02:17 | opendevreview | Takashi Kajinami proposed openstack/python-openstackclient master: Migrate osc-tox-py3N-tips to Python 3.8 https://review.opendev.org/c/openstack/python-openstackclient/+/843115 | |
| 09:43:18 | opendevreview | Arx Cruz proposed openstack/ansible-collections-openstack master: Update endpoint to new proxy layer https://review.opendev.org/c/openstack/ansible-collections-openstack/+/840640 | |
| 09:46:37 | dtantsur | gtema: hey! can we please revert marking tenant_id as deprecated in neutron? it's all over devstack, somehow also ending up in stdout and breaking our tooling | |
| 09:46:57 | dtantsur | I don't think we should deprecate something we use so actively | |
| 09:47:19 | gtema | and if we ensure your change on fixing logging lands properly? | |
| 09:47:52 | opendevreview | Arx Cruz proposed openstack/ansible-collections-openstack master: Update port info https://review.opendev.org/c/openstack/ansible-collections-openstack/+/833083 | |
| 09:48:43 | dtantsur | gtema: so far I'm not 100% convinced it fixes the situation | |
| 09:48:57 | dtantsur | another option is to make devstack stop using tenant_id. which is arguably the correct option. | |
| 09:50:14 | dtantsur | although.. it seems like something is using this tenant_id? can it be openstacksdk itself? | |
| 09:50:18 | gtema | can you show me some logs pls, Actually we have not dropped tenant_id, but just marked it deprecated | |
| 09:50:42 | gtema | I actually also wanted to stop throwing log entry on using deprecating parameter - it is way too much | |
| 09:51:07 | dtantsur | gtema: scroll down to the bottom: https://258182c531e48106d788-8f200da8737017c5e7926809f5fe1643.ssl.cf2.rackcdn.com/843112/1/check/metalsmith-integration-glance-centos8-uefi/09eeb13/job-output.txt | |
| 09:51:17 | dtantsur | there is an openstacksdk warning that is messing with the JSON output of my tool | |
| 09:52:01 | gtema | ok, will look once current meeting ends | |
| 09:55:07 | dtantsur | thx! | |
| 09:59:51 | opendevreview | Dr. Jens Harbott proposed openstack/openstacksdk master: Fix python-dev reference in bindep https://review.opendev.org/c/openstack/openstacksdk/+/843124 | |
| 10:46:41 | gtema | dtantsur: is there a chance you can try whether https://review.opendev.org/c/openstack/openstacksdk/+/816790 helps? | |
| 10:47:01 | dtantsur | gtema: will try after the painful meeting I'm in.. | |
| 10:47:08 | gtema | :) | |
| 10:47:14 | gtema | a typical Tuesday | |
| 10:47:19 | dtantsur | I'll probably need some booze after it, dunno | |
| 10:48:14 | dtantsur | gtema: I wonder if line 180 should be changed too | |
| 10:48:38 | gtema | yeah, may be | |
| 10:57:40 | priteau | Hello. We've started to see failures uploading images to Glance through Ansible following the release of openstacksdk 0.99.0. It seems to be fixed with ansible-collections-openstack from master, but not with the latest release 1.8.0. | |
| 10:58:02 | priteau | 400 Bad Request\n\nProvided object does not match schema 'image': 'False' is not of type 'boolean' Failed validating 'type' in schema['properties']['protected']: {'description': 'If true, image will not be deletable.', 'type': 'boolean'} On instance['protected']: 'False'\n\n | |
| 10:58:11 | priteau | Is a new collection release planned? | |
| 10:58:40 | frickler | priteau: iiuc you need to cap openstacksdk<0.99 currently. new collection is being worked on, but not ready yet | |
| 10:58:47 | gtema | you should be asking this in another room #openstack-ansible-sig | |
| 10:59:02 | gtema | yes, there is a new collection version, but the work there is not complete | |
| 10:59:03 | priteau | Sorry, just noticed this is the wrong channel for htis | |
| 11:00:18 | frickler | oh, I didn't know about that channel either | |
| 12:08:23 | opendevreview | Arx Cruz proposed openstack/ansible-collections-openstack master: Update catalog service for the new sdk https://review.opendev.org/c/openstack/ansible-collections-openstack/+/839352 | |
| 12:18:04 | opendevreview | Arx Cruz proposed openstack/ansible-collections-openstack master: Update endpoint to new proxy layer https://review.opendev.org/c/openstack/ansible-collections-openstack/+/840640 | |
| 12:22:12 | frickler | os-client-config also needs a py38 fix https://zuul.opendev.org/t/openstack/build/caa6cdd3f37449178759671730329503 guess that's what we get for slacking so long | |
| 12:23:03 | gtema | the whole thing depresses. So many things broke at once | |
| 12:27:13 | frickler | yeah, maybe not the best timing with the sdk release. otoh fixing it all in one go isn't that bad, either | |
| 12:27:57 | gtema | I wouldnt say sdk release was bad timing. I mean so much things broke due to oslo.log + py36/37 drop | |
| 12:28:26 | gtema | and neither SDK nor OSC have real problems with py36 | |
| 12:28:45 | gtema | and we "should" stay backward compatible | |