| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-sdks - 2022-04-27 | |||
| 13:13:36 | jm1 | gtema: is this "pass all filters as query params and thus only allow valid query params as filters" a design decision which might be applied to other cloud functions such as search_users() later? | |
| 13:14:17 | jm1 | gtema: or is it the opposite, i.e. search_projects() has to be fixed to only pass filters which are valid query params to proxy functions? | |
| 13:49:39 | opendevreview | Jakob Meng proposed openstack/ansible-collections-openstack master: Temporarily run passing tests in our Zuul CI jobs only https://review.opendev.org/c/openstack/ansible-collections-openstack/+/839374 | |
| 13:57:04 | gtema | jm1: I would say cloud layer may need to be fixed to know what it can pass to API and filter rest. On the other side same might be applied in proxy directly. I wouldn't say there were very strict design decisions, except that proxy for now only supports what API will support (but we may rethink this) | |
| 14:12:01 | jm1 | gtema: afaik proxy layer is a slim python layer on top of the openstack rest api. hence its valid that it raises exceptions on unknown query parameters. QueryParameters and Resource classes have a allow_unknown_params flag which would allow users to force sdk to pass params to rest apis. In case of our cloud layer functions, we do not want to pass unknown params to openstack. instead we want to filter results in a postprocessing step by | |
| 14:12:02 | jm1 | parameters which are not supported as query params. | |
| 14:12:24 | jm1 | gtema: so imho cloud layer functions should only pass valid query params to proxy functions | |
| 14:13:05 | jm1 | gtema: since every resource already has a list of valid query params (_query_parameters), implementing a function to drop invalid params is kind of easy, isnt it? | |
| 14:13:26 | jm1 | gtema: then we could call this drop function from cloud layer functions such as search_projects | |
| 14:13:50 | jm1 | gtema: i am happy to help but i need some guidance on where to best add this kind of code | |
| 14:13:53 | jm1 | ..in the sdk | |
| 14:15:15 | gtema | well yes, it's not so complex, but we need then to implement it in every cloud layer function, and this is close to insanity again | |
| 14:15:43 | gtema | in proxy there is also possibility not to raise exception for unsupported query params | |
| 14:16:01 | jm1 | gtema: why insanity? we only have to add the drop function call to cloud functions which pass filters as query params | |
| 14:16:31 | gtema | so it would be possible to swap process that cloud layer passes everything possible, proxy uses only whatever supported and cloud filters again | |
| 14:16:56 | gtema | insanity because there are many cloud layer functions and we should have things working same everywhere | |
| 14:17:07 | gtema | means we need to invoke it from every list function | |
| 14:19:38 | jm1 | gtema: "in proxy there is also possibility not to raise exception for unsupported query params" => allow_unknown_params? | |
| 14:19:49 | gtema | yes | |
| 14:20:08 | gtema | but it is there primarily to allow special corner cases and need to be checked | |
| 14:21:17 | gtema | main case was that there are some APIs that do not return error if you pass unsupported query params and there are no ways to properly implement all of them (like fuzzy search), but other services might really return error if you try to pass unsupported QP | |
| 14:21:26 | gtema | so this requires some playing | |
| 14:21:59 | opendevreview | Rafael Castillo proposed openstack/ansible-collections-openstack master: Use proxy layer in identity_user_info https://review.opendev.org/c/openstack/ansible-collections-openstack/+/828539 | |
| 14:24:04 | jm1 | that is why i would not go this way. if we "simply" drop filters which are not query params, then we will never run into this issue, at the cost of openstack-api-might-return-more-than-requested | |
| 14:24:43 | gtema | sure, but then you need to implement this drop in every list function | |
| 14:25:23 | jm1 | not in any list function, only list functions which turn filters into query params like here: https://github.com/openstack/openstacksdk/blob/master/openstack/cloud/_identity.py#L54 | |
| 14:25:34 | gtema | for the sake of generalisation I would really consider implementing this deep in proxy list function (to only use what is known to work and ignore rest) | |
| 14:26:01 | jm1 | gtema: sure, do whatever fits the sdk best :) | |
| 14:26:02 | gtema | yeah, but ideally they all do this (at least that was initial idea with those filters) | |
| 14:26:49 | jm1 | gtema: ah ok. hmm.. | |
| 14:27:15 | jm1 | gtema: now i see why you prefer a generic approach | |
| 14:28:03 | gtema | that actually was the biggest point of whole R1 work - to generalize as much as possible to have same behavior across services/methods | |
| 14:29:45 | opendevreview | Rafael Castillo proposed openstack/ansible-collections-openstack master: Use proxy layer in identity_user module https://review.opendev.org/c/openstack/ansible-collections-openstack/+/828742 | |
| 14:30:09 | opendevreview | Ananya proposed openstack/ansible-collections-openstack master: WIP: Moves image_info from cloud to proxy object https://review.opendev.org/c/openstack/ansible-collections-openstack/+/828158 | |
| 14:50:04 | opendevreview | Rafael Castillo proposed openstack/ansible-collections-openstack master: Use proxy layer in identity_user module https://review.opendev.org/c/openstack/ansible-collections-openstack/+/828742 | |
| 14:52:33 | opendevreview | Rafael Castillo proposed openstack/ansible-collections-openstack master: Use proxy layer in identity_user module https://review.opendev.org/c/openstack/ansible-collections-openstack/+/828742 | |
| 15:03:28 | opendevreview | Rafael Castillo proposed openstack/ansible-collections-openstack master: Update identity_role_info for latest openstacksdk release https://review.opendev.org/c/openstack/ansible-collections-openstack/+/837751 | |
| 15:09:17 | opendevreview | Rafael Castillo proposed openstack/ansible-collections-openstack master: Use proxy layer in identity_user module https://review.opendev.org/c/openstack/ansible-collections-openstack/+/828742 | |
| 15:12:59 | opendevreview | Ananya proposed openstack/ansible-collections-openstack master: WIP: Moves image_info from cloud to proxy object https://review.opendev.org/c/openstack/ansible-collections-openstack/+/828158 | |
| 15:13:58 | jm1 | gtema: and its much better now! | |
| 15:14:34 | gtema | nice to hear | |
| 15:15:17 | jm1 | gtema: for now we will stick to cloud functions whenever we have code that passes filters. as long as users dont pass invalid query params they are fine. but it would be great if they could do the same as before ^^ | |
| 15:15:38 | gtema | ok, will think what and when to do | |
| 15:15:53 | jm1 | gtema: if you need help ping me | |
| 15:15:57 | opendevreview | Rafael Castillo proposed openstack/ansible-collections-openstack master: Update identity_role_info for latest openstacksdk release https://review.opendev.org/c/openstack/ansible-collections-openstack/+/837751 | |
| 15:16:02 | gtema | ok | |
| 15:17:27 | opendevreview | Rafael Castillo proposed openstack/ansible-collections-openstack master: Update identity_role_info for latest openstacksdk release https://review.opendev.org/c/openstack/ansible-collections-openstack/+/837751 | |
| 15:17:50 | opendevreview | Rafael Castillo proposed openstack/ansible-collections-openstack master: Update identity_role_info for latest openstacksdk release https://review.opendev.org/c/openstack/ansible-collections-openstack/+/837751 | |
| 15:20:47 | opendevreview | Rafael Castillo proposed openstack/ansible-collections-openstack master: Use proxy layer in identity_user_info https://review.opendev.org/c/openstack/ansible-collections-openstack/+/828539 | |
| 15:22:52 | opendevreview | Ananya proposed openstack/ansible-collections-openstack master: WIP: Moves image_info from cloud to proxy object https://review.opendev.org/c/openstack/ansible-collections-openstack/+/828158 | |
| 15:23:35 | opendevreview | Rafael Castillo proposed openstack/ansible-collections-openstack master: Use proxy layer in identity_user_info https://review.opendev.org/c/openstack/ansible-collections-openstack/+/828539 | |
| 15:30:53 | opendevreview | Rafael Castillo proposed openstack/ansible-collections-openstack master: Update identity_role to work with latest sdk https://review.opendev.org/c/openstack/ansible-collections-openstack/+/837772 | |
| 15:40:16 | opendevreview | Rafael Castillo proposed openstack/ansible-collections-openstack master: Update identity_domain_info to use proxy layer https://review.opendev.org/c/openstack/ansible-collections-openstack/+/839445 | |
| 15:47:04 | opendevreview | Merged openstack/ansible-collections-openstack stable/1.0.0: Added support for specifying a maximum version of the OpenStack SDK https://review.opendev.org/c/openstack/ansible-collections-openstack/+/839349 | |
| 15:51:54 | opendevreview | Ananya proposed openstack/ansible-collections-openstack master: WIP: Moves image_info from cloud to proxy object https://review.opendev.org/c/openstack/ansible-collections-openstack/+/828158 | |
| 16:14:30 | opendevreview | Rafael Castillo proposed openstack/ansible-collections-openstack master: Update identity_role to work with latest sdk https://review.opendev.org/c/openstack/ansible-collections-openstack/+/837772 | |
| 18:12:02 | opendevreview | Jakob Meng proposed openstack/ansible-collections-openstack stable/1.0.0: Removed object tags from ci role server https://review.opendev.org/c/openstack/ansible-collections-openstack/+/839545 | |
| 18:16:57 | opendevreview | Jakob Meng proposed openstack/ansible-collections-openstack master: Constrain filters in compute_service_info to SDK >= 0.53.0 https://review.opendev.org/c/openstack/ansible-collections-openstack/+/839546 | |
| 20:16:15 | opendevreview | Merged openstack/ansible-collections-openstack master: Constrain filters in compute_service_info to SDK >= 0.53.0 https://review.opendev.org/c/openstack/ansible-collections-openstack/+/839546 | |
| 20:51:42 | opendevreview | Merged openstack/ansible-collections-openstack stable/1.0.0: Removed object tags from ci role server https://review.opendev.org/c/openstack/ansible-collections-openstack/+/839545 | |
| 21:18:57 | opendevreview | Rafael Castillo proposed openstack/ansible-collections-openstack master: Update project module to be compatible with new sdk https://review.opendev.org/c/openstack/ansible-collections-openstack/+/839640 | |
| #openstack-sdks - 2022-04-28 | |||
| 05:49:48 | opendevreview | Jakob Meng proposed openstack/ansible-collections-openstack stable/1.0.0: Constrain filters in compute_service_info to SDK >= 0.53.0 https://review.opendev.org/c/openstack/ansible-collections-openstack/+/839322 | |
| 06:37:11 | opendevreview | Jakob Meng proposed openstack/ansible-collections-openstack master: Restricted galaxy-importer script to Python 3.6+ https://review.opendev.org/c/openstack/ansible-collections-openstack/+/839686 | |
| 06:39:04 | opendevreview | Jakob Meng proposed openstack/ansible-collections-openstack master: Removed Zuul CI job for OpenStack Queens https://review.opendev.org/c/openstack/ansible-collections-openstack/+/839687 | |
| 06:45:13 | opendevreview | Jakob Meng proposed openstack/ansible-collections-openstack master: Temporarily run passing tests in our Zuul CI jobs only https://review.opendev.org/c/openstack/ansible-collections-openstack/+/839374 | |
| 07:16:12 | opendevreview | Jakob Meng proposed openstack/ansible-collections-openstack master: Raise minimum OpenStack SDK version to 1.0.0 https://review.opendev.org/c/openstack/ansible-collections-openstack/+/839691 | |
| 07:24:02 | opendevreview | Jakob Meng proposed openstack/ansible-collections-openstack stable/1.0.0: Lowered maximum OpenStack SDK version to 0.x.x https://review.opendev.org/c/openstack/ansible-collections-openstack/+/839693 | |
| 07:42:46 | opendevreview | Shnaidman Sagi (Sergey) proposed openstack/ansible-collections-openstack master: Change network modules to work with new SDK https://review.opendev.org/c/openstack/ansible-collections-openstack/+/825291 | |
| 07:53:25 | opendevreview | Merged openstack/ansible-collections-openstack stable/1.0.0: Constrain filters in compute_service_info to SDK >= 0.53.0 https://review.opendev.org/c/openstack/ansible-collections-openstack/+/839322 | |
| 08:34:33 | opendevreview | Merged openstack/ansible-collections-openstack master: Restricted galaxy-importer script to Python 3.6+ https://review.opendev.org/c/openstack/ansible-collections-openstack/+/839686 | |
| 08:34:59 | opendevreview | Jakob Meng proposed openstack/ansible-collections-openstack stable/1.0.0: Restricted galaxy-importer script to Python 3.6+ https://review.opendev.org/c/openstack/ansible-collections-openstack/+/839666 | |
| 08:36:17 | opendevreview | Jakob Meng proposed openstack/ansible-collections-openstack master: Changed our Zuul CI *-octavia job to non-voting https://review.opendev.org/c/openstack/ansible-collections-openstack/+/839706 | |
| 10:40:51 | opendevreview | Merged openstack/ansible-collections-openstack master: Changed our Zuul CI *-octavia job to non-voting https://review.opendev.org/c/openstack/ansible-collections-openstack/+/839706 | |
| 10:42:03 | opendevreview | Arx Cruz proposed openstack/ansible-collections-openstack master: Update identity_group_info to new sdk https://review.opendev.org/c/openstack/ansible-collections-openstack/+/839365 | |
| 10:42:19 | arxcruz | jm1 filter is back ^ | |
| 11:07:55 | opendevreview | Merged openstack/ansible-collections-openstack stable/1.0.0: Restricted galaxy-importer script to Python 3.6+ https://review.opendev.org/c/openstack/ansible-collections-openstack/+/839666 | |
| 11:17:07 | opendevreview | Jakob Meng proposed openstack/ansible-collections-openstack stable/1.0.0: Changed our Zuul CI *-octavia job to non-voting https://review.opendev.org/c/openstack/ansible-collections-openstack/+/839735 | |
| 11:19:25 | opendevreview | Jakob Meng proposed openstack/ansible-collections-openstack master: Temporarily run passing tests in our Zuul CI jobs only https://review.opendev.org/c/openstack/ansible-collections-openstack/+/839374 | |
| 11:27:24 | jm1 | arxcruz: ack, thx :) | |
| 11:41:53 | opendevreview | Merged openstack/ansible-collections-openstack stable/1.0.0: Changed our Zuul CI *-octavia job to non-voting https://review.opendev.org/c/openstack/ansible-collections-openstack/+/839735 | |
| 13:00:48 | opendevreview | Shnaidman Sagi (Sergey) proposed openstack/ansible-collections-openstack master: Change network modules to work with new SDK https://review.opendev.org/c/openstack/ansible-collections-openstack/+/825291 | |
| 13:41:06 | opendevreview | Merged openstack/ansible-collections-openstack master: Temporarily run passing tests in our Zuul CI jobs only https://review.opendev.org/c/openstack/ansible-collections-openstack/+/839374 | |
| 13:46:07 | opendevreview | Jakob Meng proposed openstack/ansible-collections-openstack stable/1.0.0: Temporarily run passing tests in our Zuul CI jobs only https://review.opendev.org/c/openstack/ansible-collections-openstack/+/839736 | |
| 14:13:28 | opendevreview | Merged openstack/ansible-collections-openstack stable/1.0.0: Temporarily run passing tests in our Zuul CI jobs only https://review.opendev.org/c/openstack/ansible-collections-openstack/+/839736 | |
| 14:50:02 | opendevreview | Jan Horstmann proposed openstack/ansible-collections-openstack master: Return details in baremetal_node_info when iterating over all machines https://review.opendev.org/c/openstack/ansible-collections-openstack/+/839776 | |
| 15:04:21 | opendevreview | Merged openstack/openstacksdk master: Run nodepool job https://review.opendev.org/c/openstack/openstacksdk/+/826543 | |
| 15:20:21 | opendevreview | Shnaidman Sagi (Sergey) proposed openstack/ansible-collections-openstack master: Change network modules to work with new SDK https://review.opendev.org/c/openstack/ansible-collections-openstack/+/825291 | |
| 18:58:15 | opendevreview | Rafael Castillo proposed openstack/ansible-collections-openstack master: Update identity_role_info for latest openstacksdk release https://review.opendev.org/c/openstack/ansible-collections-openstack/+/837751 | |
| 19:08:26 | opendevreview | Rafael Castillo proposed openstack/ansible-collections-openstack master: Use proxy layer in identity_user module https://review.opendev.org/c/openstack/ansible-collections-openstack/+/828742 | |
| 19:09:52 | opendevreview | Rafael Castillo proposed openstack/ansible-collections-openstack master: Use proxy layer in identity_user_info https://review.opendev.org/c/openstack/ansible-collections-openstack/+/828539 | |
| 19:15:50 | opendevreview | Rafael Castillo proposed openstack/ansible-collections-openstack master: Update identity_role to work with latest sdk https://review.opendev.org/c/openstack/ansible-collections-openstack/+/837772 | |
| 19:32:21 | opendevreview | Rafael Castillo proposed openstack/ansible-collections-openstack master: Use proxy layer in identity_user module https://review.opendev.org/c/openstack/ansible-collections-openstack/+/828742 | |
| 19:35:35 | opendevreview | Rafael Castillo proposed openstack/ansible-collections-openstack master: Update identity_domain_info to use proxy layer https://review.opendev.org/c/openstack/ansible-collections-openstack/+/839445 | |
| 22:54:07 | opendevreview | Rafael Castillo proposed openstack/ansible-collections-openstack master: Update project module to be compatible with new sdk https://review.opendev.org/c/openstack/ansible-collections-openstack/+/839640 | |
| 23:48:01 | opendevreview | Rafael Castillo proposed openstack/ansible-collections-openstack master: Update project module to be compatible with new sdk https://review.opendev.org/c/openstack/ansible-collections-openstack/+/839640 | |
| #openstack-sdks - 2022-04-29 | |||
| 08:39:09 | opendevreview | Ananya proposed openstack/ansible-collections-openstack master: WIP: Moves image_info from cloud to proxy object https://review.opendev.org/c/openstack/ansible-collections-openstack/+/828158 | |
| 08:50:21 | opendevreview | Ananya proposed openstack/ansible-collections-openstack master: Moves keypair_info from cloud to proxy object https://review.opendev.org/c/openstack/ansible-collections-openstack/+/827274 | |
| 08:52:02 | opendevreview | Ananya proposed openstack/ansible-collections-openstack master: Moves image_info from cloud to proxy object https://review.opendev.org/c/openstack/ansible-collections-openstack/+/828158 | |
| 08:55:39 | opendevreview | Francesco Lombardo proposed openstack/ansible-collections-openstack master: Add 'parent_id' to project module https://review.opendev.org/c/openstack/ansible-collections-openstack/+/839879 | |
| 12:19:53 | opendevreview | Mamatisa Nurmatov proposed openstack/python-openstackclient master: Refactor network fakes to sdk properties PART 4 https://review.opendev.org/c/openstack/python-openstackclient/+/839936 | |