| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-sdks - 2021-10-26 | |||
| 12:16:33 | opendevreview | Thomas Bucaioni proposed openstack/openstacksdk master: Reindentation of the docstrings https://review.opendev.org/c/openstack/openstacksdk/+/815490 | |
| 12:17:35 | opendevreview | Thomas Bucaioni proposed openstack/openstacksdk master: Reindentation of the docstrings https://review.opendev.org/c/openstack/openstacksdk/+/815491 | |
| 12:18:27 | thomasb06 | This is it | |
| 12:42:41 | frickler | thomasb06: wasn't that supposed to go to the feature branch? | |
| 12:43:12 | thomasb06 | frickler: it's not feature/r1 ? | |
| 12:43:27 | frickler | thomasb06: the above msgs all state master | |
| 12:44:32 | thomasb06 | Arg... Usually, I'm on feature/r1. Maybe it's the rebase | |
| 12:45:01 | thomasb06 | Anyway, it's just the doc. Maybe it can go the master straightaway? | |
| 12:46:53 | frickler | gtema: ^^ I'm not sure what the thing with feature/r1 is exactly | |
| 12:47:53 | thomasb06 | the command `git branch` says `* master`. No idea how I landed there... | |
| 12:47:57 | gtema | well, it should go to feature/r1. It will be "soon" going to master, but we want those changes to happen in r1 branch. In gerrit Web UI you can "move change" | |
| 12:49:14 | thomasb06 | let me try | |
| 12:50:32 | thomasb06 | gtema: in `Move change to branch`, I write `feature/r1` only? | |
| 12:50:47 | gtema | yes, should be like that | |
| 12:51:33 | thomasb06 | The UI answers: `Could not perform action: move changes endpoint is disabled` | |
| 12:51:47 | gtema | hmm, it worked for me before | |
| 12:52:18 | thomasb06 | maybe origin/feature/r1 ? | |
| 12:52:27 | gtema | maybe with gerrit update it was disabled | |
| 12:53:46 | thomasb06 | Otherwise, I cancel them all and checkout the feature/r1 branch? | |
| 12:54:39 | gtema | then - cherry-pick it into r1 branch. Otherwise - abandon and create new this time checking carefully | |
| 12:55:20 | thomasb06 | let me check cherry-pick | |
| 12:59:27 | opendevreview | SEUNG TAE KIM proposed openstack/python-openstackclient master: Add "image task list" command https://review.opendev.org/c/openstack/python-openstackclient/+/813554 | |
| 13:03:11 | opendevreview | SEUNG TAE KIM proposed openstack/openstacksdk master: Add "limit" string in _query_mapping variable in task.py https://review.opendev.org/c/openstack/openstacksdk/+/814270 | |
| 13:07:07 | opendevreview | SEUNG TAE KIM proposed openstack/python-openstackclient master: Add "image task list" command https://review.opendev.org/c/openstack/python-openstackclient/+/813554 | |
| 13:08:43 | opendevreview | SEUNG TAE KIM proposed openstack/python-openstackclient master: Add "image task list" command https://review.opendev.org/c/openstack/python-openstackclient/+/813554 | |
| 13:09:32 | thomasb06 | gtema: solution 3) with 115 votes seems ok: https://stackoverflow.com/questions/2941517/how-to-fix-committing-to-the-wrong-git-branch ? | |
| 13:10:18 | gtema | do it in UI - chances to screw are much lower | |
| 13:10:47 | thomasb06 | ah, there's a cherry-pick in UI. Let me check | |
| 13:12:33 | thomasb06 | it says: `Cherry Pick failed! (merge conflicts). Please select "Continue" to continue with conflicts or select "cancel" to close the dialog.` | |
| 13:13:55 | gtema | argh - then just start new. It is not worth of effort | |
| 13:19:01 | thomasb06 | git branch says * (HEAD detached at origin/feature/r1) master | |
| 13:19:04 | thomasb06 | it's ok? | |
| 13:19:49 | gtema | hmm, why detached | |
| 13:20:25 | thomasb06 | because when I commit some change, I always rewind | |
| 13:21:35 | gtema | but you should rewind to feature/r1 and not land in detached state | |
| 13:22:11 | thomasb06 | then I check the log | |
| 13:22:22 | gtema | once you pushed one change `git reset --hard feature/r1 && git pull` | |
| 13:23:34 | thomasb06 | git pull asks a distant and branch so `git pull origin feature/r1` ? | |
| 13:25:53 | gtema | yes, maybe. I guess I set this in some settings for myself therefore it doesn't ask anymore | |
| 13:34:29 | thomasb06 | one to try: https://review.opendev.org/c/openstack/openstacksdk/+/815503 | |
| 13:51:00 | opendevreview | Rodolfo Alonso proposed openstack/python-openstackclient master: Add --security-group to port list https://review.opendev.org/c/openstack/python-openstackclient/+/815506 | |
| 13:59:49 | gtema | thomasb06, would you please also add service title in the commit message title | |
| 14:00:11 | thomasb06 | sure | |
| 14:00:36 | thomasb06 | so "Service title - Reindentation of the docstrings"? | |
| 14:04:35 | thomasb06 | done | |
| 14:07:28 | thomasb06 | in `def unmanage_volume`, there is an embedded docstring | |
| 14:07:44 | thomasb06 | my bad, no worries | |
| 14:48:23 | opendevreview | Diwei Zhu proposed openstack/python-openstackclient master: Switch server backup to sdk. https://review.opendev.org/c/openstack/python-openstackclient/+/814332 | |
| 15:00:46 | opendevreview | Cyril Roelandt proposed openstack/python-openstackclient master: Fix typos https://review.opendev.org/c/openstack/python-openstackclient/+/815510 | |
| #openstack-sdks - 2021-10-27 | |||
| 06:49:25 | thomasb06 | gtema: Hello. Is the commit message what you were expecting: https://review.opendev.org/c/openstack/openstacksdk/+/815503/1 ? | |
| 06:56:50 | gtema | In principle yes, but instead of "service title" there should be "block storage" | |
| 06:57:12 | gtema | And can you please do all versions of same service in single change | |
| 07:13:48 | thomasb06 | Sure, I correct this one with a commit --append | |
| 07:15:01 | thomasb06 | done | |
| 07:16:08 | thomasb06 | ah, there's a v3 for the block storage service... | |
| 07:16:56 | thomasb06 | I add the v3 to the commit now | |
| 07:48:54 | thomasb06 | gtema: at the moment, I'm trying to amend the file block_storage/v3/_proxy.py in the commit 815503, but it never shows in the UI. The procedure is to type `git commit --amend`, then `git add _proxy.py`, and finally `git review -y`? | |
| 07:55:22 | thomasb06 | when I type `git show 894b5450469de600c4a7c7c313c9766de6765fb6`, it looks ok... Let me know if the v3 is missing for you | |
| 07:55:50 | thomasb06 | (by the way, are my commit hash the same as for Gerrit?) | |
| 09:11:29 | opendevreview | Stephen Finucane proposed openstack/python-openstackclient master: Switch server backup to sdk. https://review.opendev.org/c/openstack/python-openstackclient/+/814332 | |
| 16:52:24 | opendevreview | Merged openstack/python-openstackclient master: Switch server backup to sdk. https://review.opendev.org/c/openstack/python-openstackclient/+/814332 | |
| 18:21:10 | opendevreview | Stephen Finucane proposed openstack/python-openstackclient master: volume: Add 'block storage cluster *' commands https://review.opendev.org/c/openstack/python-openstackclient/+/795829 | |
| 18:21:10 | opendevreview | Stephen Finucane proposed openstack/python-openstackclient master: volume: Add 'block storage resource filter list' command https://review.opendev.org/c/openstack/python-openstackclient/+/794645 | |
| 18:26:08 | opendevreview | Stephen Finucane proposed openstack/python-openstackclient master: volume: Add 'block storage resource filter list' command https://review.opendev.org/c/openstack/python-openstackclient/+/794645 | |
| #openstack-sdks - 2021-10-28 | |||
| 02:22:58 | opendevreview | Diwei Zhu proposed openstack/python-openstackclient master: Switch openstack server add port to using sdk. https://review.opendev.org/c/openstack/python-openstackclient/+/815769 | |
| 02:42:10 | opendevreview | Diwei Zhu proposed openstack/python-openstackclient master: Switch openstack server add port/network to using sdk. https://review.opendev.org/c/openstack/python-openstackclient/+/815769 | |
| 06:06:11 | opendevreview | SEUNG TAE KIM proposed openstack/openstacksdk master: Add "limit" string in _query_mapping variable in task.py https://review.opendev.org/c/openstack/openstacksdk/+/814270 | |
| 14:42:05 | thomasb06 | gtema: Hello. The Network service: https://review.opendev.org/c/openstack/openstacksdk/+/815852 | |
| 17:21:23 | gtema | Thomasb, I see those as emails in my inbox, you do not need to mention there except of pointing special attention or not getting review for some time | |
| 22:13:16 | opendevreview | Thrivikram Mudunuri proposed openstack/python-openstackclient master: Switch server image create to SDK. https://review.opendev.org/c/openstack/python-openstackclient/+/815913 | |
| 22:16:45 | opendevreview | Thrivikram Mudunuri proposed openstack/python-openstackclient master: Switch server image create to SDK. https://review.opendev.org/c/openstack/python-openstackclient/+/815913 | |
| 23:36:30 | opendevreview | Diwei Zhu proposed openstack/python-openstackclient master: Switch command server add volume to sdk. https://review.opendev.org/c/openstack/python-openstackclient/+/815919 | |
| 23:57:13 | opendevreview | Thrivikram Mudunuri proposed openstack/python-openstackclient master: Switch server image create to SDK. https://review.opendev.org/c/openstack/python-openstackclient/+/815913 | |
| #openstack-sdks - 2021-10-29 | |||
| 12:31:55 | thomasb06 | gtema: Hello. Clustering: https://review.opendev.org/c/openstack/openstacksdk/+/815957 | |
| 12:32:13 | thomasb06 | (in it's own branch) | |
| #openstack-sdks - 2021-11-01 | |||
| 09:57:10 | opendevreview | Merged openstack/ansible-collections-openstack master: Flavor properties are not deleted on changes and id will stay https://review.opendev.org/c/openstack/ansible-collections-openstack/+/811739 | |
| 11:28:56 | stephenfin | gtema: We're seeing a lot of failures with the nodepool-build-image-siblings job on openstacksdk changes | |
| 11:29:17 | stephenfin | due to an opensuse mirror issue, apparently | |
| 11:46:56 | stephenfin | gtema: Ah, it was fixed on Oct 28 via Ica62392ebf4a665a04cd65458dda9e0a7545ccc8 (nodepool) | |
| 12:16:31 | gtema | stephenfin, good. I'm off today (holiday here), thus will not participate in meeting later today | |
| #openstack-sdks - 2021-11-02 | |||
| 04:56:45 | opendevreview | Diwei Zhu proposed openstack/python-openstackclient master: Switch server dump create to using sdk https://review.opendev.org/c/openstack/python-openstackclient/+/816296 | |
| 08:47:55 | thomasb06 | gtema: Hello. Shared File System: https://review.opendev.org/c/openstack/openstacksdk/+/816307 | |
| 08:49:42 | thomasb06 | line 111, maybe it's `param` instead of `pram`? | |
| 08:54:53 | gtema | yes, right | |
| 09:01:42 | thomasb06 | ok, I correct it then | |
| 09:07:20 | thomasb06 | DNS: https://review.opendev.org/c/openstack/openstacksdk/+/816308 | |
| 09:43:13 | opendevreview | Shnaidman Sagi (Sergey) proposed openstack/ansible-collections-openstack master: Fix issue with same host and group names https://review.opendev.org/c/openstack/ansible-collections-openstack/+/816311 | |
| #openstack-sdks - 2021-11-03 | |||
| 10:31:43 | opendevreview | Stephen Finucane proposed openstack/python-openstackclient master: compute: Don't warn if disk overcommit params unset https://review.opendev.org/c/openstack/python-openstackclient/+/816448 | |
| 10:31:49 | opendevreview | Stephen Finucane proposed openstack/python-openstackclient master: compute: Use correct command class for 'show migration' https://review.opendev.org/c/openstack/python-openstackclient/+/816449 | |
| 11:57:52 | opendevreview | Stephen Finucane proposed openstack/python-openstackclient master: compute: Return details of attached volumes https://review.opendev.org/c/openstack/python-openstackclient/+/816491 | |
| 14:31:09 | opendevreview | Dr. Jens Harbott proposed openstack/openstacksdk master: Keep creating keystone admin endpoint for heat https://review.opendev.org/c/openstack/openstacksdk/+/777343 | |
| 14:34:13 | frickler | gtema: stephenfin: ^^ dependencies finally merged and I added a comment as yoctozepto suggested, please have another look | |
| 14:34:41 | gtema | noted | |
| 22:10:23 | opendevreview | Merged openstack/openstacksdk master: Keep creating keystone admin endpoint for heat https://review.opendev.org/c/openstack/openstacksdk/+/777343 | |
| #openstack-sdks - 2021-11-04 | |||
| 06:59:35 | thomasb06 | gtema: Hello. Object Store: https://review.opendev.org/c/openstack/openstacksdk/+/816619 | |
| 07:02:25 | thomasb06 | line 183 has dashes, does it take stars? | |
| 07:08:13 | gtema | Nope, dashes are correct | |
| 07:21:48 | thomasb06 | ok then | |
| 07:25:22 | thomasb06 | Compute: https://review.opendev.org/c/openstack/openstacksdk/+/816620 | |
| 08:02:24 | thomasb06 | The Compute commit seems to have a serious merge conflict | |