| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-sdks - 2021-09-23 | |||
| 07:51:31 | opendevreview | Przemyslaw Szczerbik proposed openstack/python-openstackclient master: Add support for CRUD operations for QoS minimum packet rate rule https://review.opendev.org/c/openstack/python-openstackclient/+/810559 | |
| 08:27:05 | seongsoocho | In Korea mentoring, We are trying to implement a command that is not implemented for each component command of openstackcli. ( I'm referencing this link. https://docs.openstack.org/python-openstackclient/wallaby/cli/decoder.html ) | |
| 08:27:12 | seongsoocho | Are there any special reasons for things that haven't been implemented yet? If not, we'll try. | |
| 08:29:09 | gtema | seongsoocho - mostly just because nobody has found time yet to do that, or even that the list is not up2date | |
| 08:30:13 | seongsoocho | great. I think It is a good starting point to contribute to the openstackcli . :-) | |
| 15:48:59 | diablo_rojo | gtema, still good to meet in ~12 min? | |
| 15:49:16 | gtema | yupp, can start even earlier if you are free | |
| 15:50:21 | diablo_rojo | Gimme like 3 min to make a cup of tea and get an etherpad up for notes and then I will poke you :) | |
| 15:51:06 | gtema | sure | |
| 15:52:37 | diablo_rojo | unless you already have an etherpad or doc started somewhere? | |
| 15:52:52 | gtema | actually nope | |
| 15:53:40 | diablo_rojo | kk | |
| 15:54:33 | diablo_rojo | https://etherpad.opendev.org/p/openstacksdk-docs | |
| #openstack-sdks - 2021-09-24 | |||
| 15:02:00 | thomasb06 | class `TestPlacementProxy: https://review.opendev.org/c/openstack/openstacksdk/+/810933 | |
| 15:15:33 | thomasb06 | This commit has only one file staged: https://review.opendev.org/c/openstack/openstacksdk/+/810936 | |
| 16:00:14 | opendevreview | Ryan Zimmerman proposed openstack/openstacksdk master: Add os-instance-actions API https://review.opendev.org/c/openstack/openstacksdk/+/797551 | |
| 16:07:58 | opendevreview | Ryan Zimmerman proposed openstack/openstacksdk master: Add os-instance-actions API https://review.opendev.org/c/openstack/openstacksdk/+/797551 | |
| #openstack-sdks - 2021-09-25 | |||
| 06:55:55 | opendevreview | SEUNG TAE KIM proposed openstack/python-openstackclient master: Fix bug that configuration show --mask cannot masking the password & token https://review.opendev.org/c/openstack/python-openstackclient/+/811005 | |
| 08:22:59 | opendevreview | JIHOJU proposed openstack/python-openstackclient master: Fix bug that readonly option doesn’t setup with volume create. https://review.opendev.org/c/openstack/python-openstackclient/+/811006 | |
| 09:11:19 | opendevreview | SEUNG TAE KIM proposed openstack/python-openstackclient master: Fix bug that configuration show --mask cannot masking the password & token https://review.opendev.org/c/openstack/python-openstackclient/+/811005 | |
| 09:23:36 | opendevreview | SEUNG TAE KIM proposed openstack/python-openstackclient master: Fix that the path of functional test https://review.opendev.org/c/openstack/python-openstackclient/+/811008 | |
| 09:25:04 | opendevreview | SEUNG TAE KIM proposed openstack/python-openstackclient master: Fix that the path of functional test https://review.opendev.org/c/openstack/python-openstackclient/+/811008 | |
| 12:35:18 | opendevreview | SEUNG TAE KIM proposed openstack/python-openstackclient master: Fix that the path of functional test https://review.opendev.org/c/openstack/python-openstackclient/+/811008 | |
| #openstack-sdks - 2021-09-28 | |||
| 08:07:29 | opendevreview | Lajos Katona proposed openstack/openstacksdk master: Add BFD monitor operations https://review.opendev.org/c/openstack/openstacksdk/+/810078 | |
| 08:38:08 | voondo | Hi all, here we have to deal with an old version of openstack (newton). I acknowledged the versions matrix of the various CLI https://releases.openstack.org/newton/index.html#library-projects but I cannot figure if we can use the unified cli or not https://pypi.org/project/python-openstackclient/ If yes, what version ? | |
| 08:38:56 | gtema | voondo - OSC is build to be backward compatible, so you should be able to use latest version of it on your installation | |
| 08:39:52 | gtema | the only exclusion from this rule is a current issue of relying on cinderclient that recently dropped support for v2, so if you still use v2 there - you need to manually force installation of a little bit older cinderclient | |
| 08:40:32 | voondo | ok so the latest python-openstackclient but mixed with the old novaclient, neutronclient & co. ? | |
| 08:40:51 | gtema | latest openstackclient with only older cinderclient | |
| 08:41:13 | gtema | we are going to work on that to drop this dependency, but at the moment this is not yet done | |
| 08:42:16 | voondo | what about the version matrix defined here https://releases.openstack.org/newton/index.html#library-projects ? eg. | |
| 08:42:17 | voondo | python-novaclient | |
| 08:42:19 | voondo | 3.4.0 | |
| 08:42:20 | voondo | 6.0.2 | |
| 08:42:54 | voondo | what about the version matrix defined here https://releases.openstack.org/newton/index.html#library-projects ? eg. python-novaclient >3.4.0 <6.0.2 | |
| 08:42:55 | gtema | latest osc is not relying on novaclient | |
| 08:43:07 | voondo | (oops sorry) | |
| 08:43:25 | gtema | if you want to use "nova ..." - sure, if you want to use "openstack server ..." - no dependency | |
| 08:43:40 | voondo | ah ok.... | |
| 08:46:59 | voondo | and what about https://pypi.org/project/openstacksdk ? does it depend on python-novaclient & co or only openstacksdk ? | |
| 08:47:44 | gtema | osc depends on openstacksdk | |
| 08:48:11 | gtema | and itself it only depend on keystoneauth lib | |
| 08:48:41 | voondo | ok, it makes sense, thanks a lot for the clarification ! | |
| 08:48:47 | gtema | I mean reasonable dependency, sure it depends on some other basic stuff, but no clients | |
| 08:49:01 | gtema | welcome | |
| 08:49:14 | voondo | yes of course, thanks !! | |
| 13:36:05 | thomasb06 | class SharedFileSystemStorageProxy: https://review.opendev.org/c/openstack/openstacksdk/+/811420 | |
| #openstack-sdks - 2021-09-29 | |||
| 07:51:34 | thomasb06 | gtema: Hello. It seems this is pretty much it for the unit directory. Would you have another series of refactoring for me? | |
| 07:51:58 | gtema | hi thomasb06. Yes | |
| 07:52:08 | gtema | this is also part of the bigger cleanup | |
| 07:52:32 | gtema | it's about fixing identation of the docstrings through the code | |
| 07:52:43 | thomasb06 | cool. Then, I can go on elsewhere | |
| 07:53:08 | gtema | https://opendev.org/openstack/openstacksdk/src/branch/master/openstack/block_storage/v3/_proxy.py#L574 - good example of docstring identation | |
| 07:53:18 | gtema | https://opendev.org/openstack/openstacksdk/src/branch/master/openstack/block_storage/v3/_proxy.py#L368 - bad example | |
| 07:54:06 | gtema | so overall I want our docstring to be properly idented (so that linebreak of the param description gets +4 chars identation and not something else | |
| 07:54:37 | thomasb06 | it's all in openstacksdk/openstack ? | |
| 07:55:02 | gtema | I would say it currently distracts in openstack///_proxy.py and openstack/cloud/**.py | |
| 07:55:20 | gtema | s//////* */* *// | |
| 07:55:57 | gtema | maybe same is also present in tons of other places (in the resource files themselves) and it should be also fixed there, but proxy files are the most disturbing ones | |
| 07:56:59 | thomasb06 | alright, then switch on indenting | |
| 07:57:10 | gtema | thks a lot | |
| 08:43:56 | thomasb06 | First attempt: https://review.opendev.org/c/openstack/openstacksdk/+/811658 | |
| 08:44:13 | thomasb06 | It seems it can be handled by a regexp script | |
| 08:47:10 | thomasb06 | the keywords are: `:param ?:`, `:returns:`, `:rtype:`, and `:raises:`. And there are second level indentation after a `*` | |
| 08:47:41 | thomasb06 | maybe I go for an awk script for a couple of days | |
| 09:04:22 | gtema | I doubt it can be very easy with regex | |
| 10:27:02 | gtema | stephenfin: I remember around a year ago we were discussing what to do with hypervisor statistics in OSC but I forgot what we actually agreed upon | |
| 10:27:42 | gtema | I try to rebase my hypervisor change now https://review.opendev.org/c/openstack/python-openstackclient/+/763414 and figure out it doesn't work really, cause in SDK there is no support for statistics | |
| 10:29:33 | stephenfin | Could you leave that using novaclient and simply deprecate it? | |
| 10:29:56 | stephenfin | The alternative to provide something like it by querying placement, but we haven't completed placement support in SDK yet either | |
| 10:30:18 | gtema | can be done. But then we can not get rid of dependency on novaclient (I was actually sure we do not have it, but we do) | |
| 10:30:42 | stephenfin | We can't do it this cycle, but we can do it in Z | |
| 10:30:47 | stephenfin | that's not that far away, tbf | |
| 10:31:15 | gtema | that's clear, I mean even overall | |
| 10:31:30 | gtema | what I can do actually is to use SDK for direct API call from OSC | |
| 10:31:38 | gtema | so that we do not need to implement it in SDK | |
| 10:32:00 | stephenfin | I didn't know that was an option. Sure, that works for me too | |
| 10:32:22 | gtema | ok, will do so. I actually used this few times in ansible modules already | |
| 13:23:37 | opendevreview | Artem Goncharov proposed openstack/python-openstackclient master: Switch hypervisor operations to SDK https://review.opendev.org/c/openstack/python-openstackclient/+/763414 | |
| 13:49:54 | opendevreview | Lajos Katona proposed openstack/python-openstackclient master: Add BFD monitor commands https://review.opendev.org/c/openstack/python-openstackclient/+/810286 | |
| 15:14:14 | opendevreview | Sven Anders proposed openstack/ansible-collections-openstack master: Flavor properties are not deleted on changes and id will stay https://review.opendev.org/c/openstack/ansible-collections-openstack/+/811739 | |
| 15:40:13 | opendevreview | Sven Anders proposed openstack/ansible-collections-openstack master: Flavor properties are not deleted on changes and id will stay https://review.opendev.org/c/openstack/ansible-collections-openstack/+/811739 | |
| #openstack-sdks - 2021-09-30 | |||
| 11:37:28 | opendevreview | Lajos Katona proposed openstack/python-openstackclient master: Add BFD monitor commands https://review.opendev.org/c/openstack/python-openstackclient/+/810286 | |
| 14:27:27 | opendevreview | Pavlo Shchelokovskyy proposed openstack/python-openstackclient master: Add --trusted-image-cert option for server create https://review.opendev.org/c/openstack/python-openstackclient/+/811981 | |
| 16:42:36 | opendevreview | Pavlo Shchelokovskyy proposed openstack/python-openstackclient master: Add --trusted-image-cert option for server create https://review.opendev.org/c/openstack/python-openstackclient/+/811981 | |
| 16:57:11 | opendevreview | Lajos Katona proposed openstack/python-openstackclient master: Add bfd_monitor as optional arg to route https://review.opendev.org/c/openstack/python-openstackclient/+/810370 | |
| #openstack-sdks - 2021-10-01 | |||
| 08:59:16 | opendevreview | Alexandru Verdes proposed openstack/ansible-collections-openstack master: Add client and member listener timeouts for persistence (Ex. SSH) https://review.opendev.org/c/openstack/ansible-collections-openstack/+/812110 | |
| 09:17:56 | opendevreview | Alexandru Verdes proposed openstack/ansible-collections-openstack master: Add client and member listener timeouts for persistence (Ex. SSH) https://review.opendev.org/c/openstack/ansible-collections-openstack/+/812110 | |
| 14:57:00 | noonedeadpunk | hey! I was wondering if there's any good way to import one of the commands to reuse code inside other one? I guess no? | |
| 14:57:20 | noonedeadpunk | regsarding openstackclient | |
| 14:58:35 | gtema | can you be please more precise with your example? what are you thinking of? | |
| 15:03:08 | noonedeadpunk | So, I'm trying to write host-evacuate command for openstackclient. And what I;d ove to do is re-use https://opendev.org/openstack/python-openstackclient/src/branch/master/openstackclient/compute/v2/server.py#L3458 | |
| 15:03:15 | noonedeadpunk | But I guess I can't do that? | |
| 15:03:52 | noonedeadpunk | so the way would be copy/pasting code? Which I'd hate doing... | |
| 15:04:47 | gtema | reuse in the sense of a complete copy or only parts? | |
| 15:05:05 | noonedeadpunk | I guess that was kind of reason why it hasn't been implemented yet... | |
| 15:05:44 | noonedeadpunk | complete copy but pass different parsed_args | |
| 15:06:13 | gtema | and what about the action itself? it currently invoke server.evacuate(xx) | |
| 15:07:09 | noonedeadpunk | yeah, it will be the same. So host evacuate is basically retrieves all servers for hypervisors and iterate on them | |
| 15:07:31 | noonedeadpunk | ie https://github.com/openstack/python-novaclient/blob/8066f8c745054caeb7bd66d4c2be15ab5fac1d1f/novaclient/v2/shell.py#L5190-L5199 | |