| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-sdks - 2021-08-13 | |||
| 12:31:44 | frickler | I bisected the issue down to this commit https://github.com/micheles/decorator/commit/04bb6454ac4f7560759ec1a3e15756a5485067ac and the docs update seems to indicate that this is an intentional change and we need to adopt our code | |
| 12:33:46 | frickler | the code in question was last touched by mordred and shrews it seems - stemming from shade almost completely - https://opendev.org/openstack/openstacksdk/src/branch/master/openstack/cloud/_utils.py#L387-L407 | |
| 12:43:00 | opendevreview | Elias Wimmer proposed openstack/ansible-collections-openstack master: Fix behaviour for already existing loadbalancer https://review.opendev.org/c/openstack/ansible-collections-openstack/+/804495 | |
| 14:37:50 | opendevreview | cenne proposed openstack/openstacksdk master: Add support for reading node's "boot_mode" and "secure_boot" fields https://review.opendev.org/c/openstack/openstacksdk/+/802101 | |
| 14:37:57 | opendevreview | cenne proposed openstack/openstacksdk master: Add support for changing baremetal node's boot_mode and secure_boot states https://review.opendev.org/c/openstack/openstacksdk/+/804529 | |
| 14:49:44 | opendevreview | Dr. Jens Harbott proposed openstack/openstacksdk master: Fix key generation for caching https://review.opendev.org/c/openstack/openstacksdk/+/804530 | |
| 14:50:22 | frickler | mordred: ^^ not sure if you saw my earlier ramblings, this fixes the unit tests for me, but I have no idea if it makes sense otherwise | |
| 16:22:56 | opendevreview | cenne proposed openstack/openstacksdk master: Add support for changing baremetal node's boot_mode and secure_boot states https://review.opendev.org/c/openstack/openstacksdk/+/804529 | |
| 16:34:40 | frickler | mordred: thanks for your +2 but after checking upon your comment, I'm not sure the patch is actually correct, maybe there's an actual bug in the caching to be uncovered. -W for now, will try to do more digging next week | |
| 16:50:21 | mordred | Nod. I'll also try to poke some if I can find some time | |
| #openstack-sdks - 2021-08-16 | |||
| 10:24:44 | opendevreview | Shnaidman Sagi (Sergey) proposed openstack/ansible-collections-openstack master: Add support check mode for all info modules https://review.opendev.org/c/openstack/ansible-collections-openstack/+/804692 | |
| 12:56:54 | opendevreview | Shnaidman Sagi (Sergey) proposed openstack/ansible-collections-openstack master: Add support check mode for all info modules https://review.opendev.org/c/openstack/ansible-collections-openstack/+/804692 | |
| 13:06:47 | opendevreview | Shnaidman Sagi (Sergey) proposed openstack/ansible-collections-openstack master: Remove tests directory from ansible-tests https://review.opendev.org/c/openstack/ansible-collections-openstack/+/804736 | |
| 17:14:22 | opendevreview | Merged openstack/ansible-collections-openstack master: Add support check mode for all info modules https://review.opendev.org/c/openstack/ansible-collections-openstack/+/804692 | |
| 17:14:24 | opendevreview | Merged openstack/ansible-collections-openstack master: Remove tests directory from ansible-tests https://review.opendev.org/c/openstack/ansible-collections-openstack/+/804736 | |
| #openstack-sdks - 2021-08-17 | |||
| 01:34:13 | opendevreview | melanie witt proposed openstack/python-openstackclient master: Show "Forced Down" compute service status with --long https://review.opendev.org/c/openstack/python-openstackclient/+/804465 | |
| 10:15:28 | opendevreview | Merged openstack/python-openstackclient master: Show "Forced Down" compute service status with --long https://review.opendev.org/c/openstack/python-openstackclient/+/804465 | |
| #openstack-sdks - 2021-08-18 | |||
| 09:51:26 | opendevreview | Johannes Kulik proposed openstack/openstacksdk master: Add "security_group_ids" to Port's query parameters https://review.opendev.org/c/openstack/openstacksdk/+/804979 | |
| 11:04:08 | opendevreview | Wenping Song proposed openstack/openstacksdk master: Add description args for device profile create https://review.opendev.org/c/openstack/openstacksdk/+/803888 | |
| 11:21:28 | opendevreview | chimeng proposed openstack/openstacksdk master: Fix "400 error when create image with protected parameter" https://review.opendev.org/c/openstack/openstacksdk/+/804987 | |
| 11:35:04 | opendevreview | Mamatisa Nurmatov proposed openstack/openstacksdk master: [WIP] Add neutron local IP CRUD https://review.opendev.org/c/openstack/openstacksdk/+/804988 | |
| 11:36:30 | opendevreview | Mamatisa Nurmatov proposed openstack/openstacksdk master: [WIP] Add neutron local IP CRUD https://review.opendev.org/c/openstack/openstacksdk/+/804988 | |
| 13:25:57 | opendevreview | cenne proposed openstack/openstacksdk master: Fix some docstrings, and a small bug https://review.opendev.org/c/openstack/openstacksdk/+/805020 | |
| 21:20:06 | priteau | Hi stephenfin. I was checking status of some old patches, would it be possible to merge https://review.opendev.org/c/openstack/python-openstackclient/+/779498? Thanks. | |
| #openstack-sdks - 2021-08-19 | |||
| 01:25:21 | opendevreview | chimeng proposed openstack/openstacksdk master: Fix "400 error when create image with protected parameter" https://review.opendev.org/c/openstack/openstacksdk/+/804987 | |
| 04:32:52 | opendevreview | Merged openstack/python-openstackclient master: Update volume create documentation https://review.opendev.org/c/openstack/python-openstackclient/+/779498 | |
| 05:55:59 | opendevreview | chimeng proposed openstack/openstacksdk stable/ussuri: Fix "400 error when create image with protected parameter" https://review.opendev.org/c/openstack/openstacksdk/+/805130 | |
| 05:57:07 | opendevreview | chimeng proposed openstack/openstacksdk stable/victoria: Fix "400 error when create image with protected parameter" https://review.opendev.org/c/openstack/openstacksdk/+/805131 | |
| 09:59:12 | opendevreview | chimeng proposed openstack/openstacksdk stable/wallaby: Fix "400 error when create image with protected parameter" https://review.opendev.org/c/openstack/openstacksdk/+/805136 | |
| 16:45:57 | opendevreview | Lee Yarwood proposed openstack/python-openstackclient master: compute: Add support for microversion 2.89 https://review.opendev.org/c/openstack/python-openstackclient/+/804377 | |
| 17:02:24 | gouthamr | gtema: welcome back o/ i see you W+1'ed frickler's change (https://review.opendev.org/c/openstack/openstacksdk/+/804530) | |
| 17:03:22 | gouthamr | frickler: probably needs you to remove the -1 - agree with gtema about the caching rework comment :) | |
| 17:04:25 | gouthamr | https://review.opendev.org/c/openstack/openstacksdk/+/805270 -- this is a cherry-pick of that change to the feature/r1 branch | |
| 17:05:49 | gouthamr | frickler: thanks for the change - it unblocks other work on the openstacksdk as gtema noted - kafilat and i'll be happy to see this merge | |
| #openstack-sdks - 2021-08-20 | |||
| 03:09:19 | opendevreview | chimeng proposed openstack/openstacksdk stable/ussuri: Add 'on_maintenance' to Masakari segment https://review.opendev.org/c/openstack/openstacksdk/+/805325 | |
| 05:29:16 | frickler | gouthamr: gtema: I'm not really convinced that I want to have my name on a patch that is so broken, even to fix the gate. what we could do is hardcode "arg_key=''" with a big todo note that this needs proper fixing, wdyt? | |
| 05:48:42 | gouthamr | frickler: ack, wfm if gtema thinks so | |
| 07:02:50 | gtema | frickler, why you say gate is not fixed by that? I was locally testing your patch and it seems absolutely reasonable and working (for local unittests). The alternative is now to drop caching at all and reimplement it freshly in a different way. But on practice - it was working properly earlier | |
| 07:36:47 | frickler | gtema: according to what I tested, the "if" part in my patch is actually never triggered. so IMO it would be cleaner to drop it. the solution that I consider more correct, using arg_key = ','.join(map(str, args)), leads to unit failures, so would need more investigation | |
| 07:37:25 | frickler | gtema: I'm not saying that gate isn't fixed by that patch, it's just misleading about the actual situation | |
| 07:37:26 | gtema | but that one clearly didn't work in my test with (perhaps with older decorator version) | |
| 07:38:13 | frickler | gtema: my assumption is that the unit tests may actually be broken (or maybe the caching code) and arg_key = ','.join(map(str, args)) uncovers that | |
| 07:38:47 | gtema | no, unittest actually creates in-memory cache and verifies communication, so it should be working | |
| 07:39:30 | gtema | I am sadly still not really convinced how the cache should be reimplemented - was poking already few days without anything really useful | |
| 07:40:51 | gtema | using decorator seems to easy, but - i never thought it can be broken that easily with new release | |
| 07:41:03 | gtema | * using decorator seems so easy, but - i never thought it can be broken that easily with new release | |
| 07:45:10 | opendevreview | Dr. Jens Harbott proposed openstack/openstacksdk master: Fix key generation for caching https://review.opendev.org/c/openstack/openstacksdk/+/804530 | |
| 07:46:29 | frickler | gtema: gouthamr: I would propose to go with ^^ for now to unblock. if you want something different, feel free to replace with your own ideas | |
| 07:47:25 | gtema | ok, no objections | |
| 14:03:40 | opendevreview | Mamatisa Nurmatov proposed openstack/openstacksdk master: [WIP] Add neutron local IP CRUD https://review.opendev.org/c/openstack/openstacksdk/+/804988 | |
| 14:09:57 | opendevreview | Mamatisa Nurmatov proposed openstack/openstacksdk master: [WIP] Add neutron local IP CRUD https://review.opendev.org/c/openstack/openstacksdk/+/804988 | |
| #openstack-sdks - 2021-08-21 | |||
| 00:35:23 | jameshyde | how to properly update some field inside nova_api.request_specs database table field for certain vm? there's no such API available? | |
| #openstack-sdks - 2021-08-22 | |||
| 19:07:47 | opendevreview | Daniel Speichert proposed openstack/ansible-collections-openstack master: Added missing warn() used in cloud.openstack.quota https://review.opendev.org/c/openstack/ansible-collections-openstack/+/805534 | |
| 19:11:14 | opendevreview | Daniel Speichert proposed openstack/ansible-collections-openstack master: Added missing warn() used in cloud.openstack.quota https://review.opendev.org/c/openstack/ansible-collections-openstack/+/805534 | |
| #openstack-sdks - 2021-08-23 | |||
| 08:23:10 | opendevreview | Wenping Song proposed openstack/openstacksdk master: Add description args for device profile create https://review.opendev.org/c/openstack/openstacksdk/+/803888 | |
| 11:44:19 | opendevreview | Mamatisa Nurmatov proposed openstack/python-openstackclient master: (wip) Support Neutron Local IP CRUD https://review.opendev.org/c/openstack/python-openstackclient/+/805618 | |
| 21:20:03 | opendevreview | Merged openstack/openstacksdk master: Fix key generation for caching https://review.opendev.org/c/openstack/openstacksdk/+/804530 | |
| 21:20:17 | opendevreview | Merged openstack/python-openstackclient master: Replace assertItemsEqual with assertCountEqual https://review.opendev.org/c/openstack/python-openstackclient/+/789410 | |
| #openstack-sdks - 2021-08-24 | |||
| 07:42:42 | opendevreview | Javier Peña proposed openstack/python-openstackclient stable/wallaby: Replace assertItemsEqual with assertCountEqual https://review.opendev.org/c/openstack/python-openstackclient/+/805790 | |
| 09:21:52 | opendevreview | Javier Peña proposed openstack/python-openstackclient stable/wallaby: Replace assertItemsEqual with assertCountEqual https://review.opendev.org/c/openstack/python-openstackclient/+/805790 | |
| 11:33:00 | opendevreview | Johannes Kulik proposed openstack/openstacksdk master: Add "security_group_ids" to Port's query parameters https://review.opendev.org/c/openstack/openstacksdk/+/804979 | |
| #openstack-sdks - 2021-08-25 | |||
| 01:28:51 | opendevreview | Wenping Song proposed openstack/openstacksdk master: Add description args for device profile create https://review.opendev.org/c/openstack/openstacksdk/+/803888 | |
| 08:41:58 | opendevreview | Slawek Kaplonski proposed openstack/python-openstackclient master: Add new job osc-functional-devstack-neutron-ovs https://review.opendev.org/c/openstack/python-openstackclient/+/793143 | |
| 15:37:46 | opendevreview | Rodolfo Alonso proposed openstack/python-openstackclient master: [WIP] Add network quota limit check https://review.opendev.org/c/openstack/python-openstackclient/+/806016 | |
| #openstack-sdks - 2021-08-26 | |||
| 08:00:41 | opendevreview | Merged openstack/python-openstackclient master: volume: Add missing 'volume list --offset' parameter https://review.opendev.org/c/openstack/python-openstackclient/+/802480 | |
| 08:02:35 | opendevreview | Merged openstack/python-openstackclient master: openstack image create: honor protection/visibility flags https://review.opendev.org/c/openstack/python-openstackclient/+/789649 | |
| 08:03:54 | opendevreview | Merged openstack/python-openstackclient master: volume: Add 'volume transfer request create --(no-)snapshots' option https://review.opendev.org/c/openstack/python-openstackclient/+/800715 | |
| 08:14:21 | opendevreview | Merged openstack/python-openstackclient stable/wallaby: Replace assertItemsEqual with assertCountEqual https://review.opendev.org/c/openstack/python-openstackclient/+/805790 | |
| 08:14:23 | opendevreview | Merged openstack/python-openstackclient master: L3 conntrack helper: Use singular name consistently https://review.opendev.org/c/openstack/python-openstackclient/+/795222 | |
| 16:30:33 | gtema | mordred, if you have a chance - please have a look at https://review.opendev.org/c/openstack/openstacksdk/+/805851. I started reworking caching to be as deep as possible and avoids our decorator issues | |
| 16:30:58 | gtema | in next PR I plan to drop old caching in the cloud layer while still keeping it working | |
| 17:23:30 | mordred | gtema: it looks good at first glance. we should get corvus to look too - I know nodepool is the primary user of the non-dogpile caches | |
| 17:24:52 | opendevreview | Rodolfo Alonso proposed openstack/openstacksdk master: Add "check_limit" to network Quota class https://review.opendev.org/c/openstack/openstacksdk/+/806254 | |
| 17:47:22 | gtema | Sure | |
| #openstack-sdks - 2021-08-27 | |||
| 12:11:07 | opendevreview | Mamatisa Nurmatov proposed openstack/openstacksdk master: [WIP] Add neutron local IP CRUD https://review.opendev.org/c/openstack/openstacksdk/+/804988 | |
| 14:08:22 | mordred | gtema: fwiw I pinged corvus about that patch | |
| 14:08:34 | gtema | thks mordred | |
| 14:08:58 | gtema | this is definitely not the final state, but I just want to get some feedback before continuing that | |
| 14:09:08 | mordred | yah - for sure | |
| 14:09:31 | mordred | I'm excited to see that - we've talked about going in that direction for a while | |
| 14:09:43 | gtema | yah | |
| 14:10:04 | gtema | nodepool fails due to that whatever is being currently discussed in zuul, isn't it? | |
| 14:10:41 | gtema | (Unable to locate package libffi6) | |
| 15:01:38 | opendevreview | Rodolfo Alonso proposed openstack/python-openstackclient master: Add network update quota "limit_check" parameter https://review.opendev.org/c/openstack/python-openstackclient/+/806016 | |
| 15:30:07 | opendevreview | Rodolfo Alonso proposed openstack/python-openstackclient master: Add network update quota "limit_check" parameter https://review.opendev.org/c/openstack/python-openstackclient/+/806016 | |
| 15:54:01 | opendevreview | Rodolfo Alonso proposed openstack/python-openstackclient master: Add network update quota "limit_check" parameter https://review.opendev.org/c/openstack/python-openstackclient/+/806016 | |
| #openstack-sdks - 2021-08-28 | |||
| 07:23:23 | opendevreview | LEE JAE YONG proposed openstack/python-openstackclient master: Fix typo error in listing server's column name https://review.opendev.org/c/openstack/python-openstackclient/+/806464 | |
| 07:36:56 | seongsoocho | ^ We just got a first patch in korea user group's mentorig program ! | |
| #openstack-sdks - 2021-08-29 | |||
| 12:10:25 | frigo | hi sdks! Fyi the openstack cli and rally (as installed with pip) is broken since a few hours, following a new release of importlib_metadata. I opened https://storyboard.openstack.org/#!/story/2009151 | |
| #openstack-sdks - 2021-08-30 | |||
| 10:17:27 | opendevreview | Mamatisa Nurmatov proposed openstack/python-openstackclient master: (wip) Support Neutron Local IP CRUD https://review.opendev.org/c/openstack/python-openstackclient/+/805618 | |
| 10:50:32 | opendevreview | Mamatisa Nurmatov proposed openstack/openstacksdk master: [WIP] Add neutron local IP CRUD https://review.opendev.org/c/openstack/openstacksdk/+/804988 | |
| 11:13:35 | opendevreview | Mamatisa Nurmatov proposed openstack/python-openstackclient master: (wip) Support Neutron Local IP CRUD https://review.opendev.org/c/openstack/python-openstackclient/+/805618 | |
| 11:49:16 | opendevreview | Mamatisa Nurmatov proposed openstack/python-openstackclient master: (wip) Support Neutron Local IP CRUD https://review.opendev.org/c/openstack/python-openstackclient/+/805618 | |
| 17:07:23 | opendevreview | Ghanshyam proposed openstack/openstackclient master: [community goal] Update contributor documentation https://review.opendev.org/c/openstack/openstackclient/+/806623 | |
| 17:07:28 | opendevreview | Ghanshyam proposed openstack/python-openstackclient master: [community goal] Update contributor documentation https://review.opendev.org/c/openstack/python-openstackclient/+/806624 | |
| 17:13:17 | opendevreview | Ghanshyam proposed openstack/python-openstackclient master: [community goal] Update contributor documentation https://review.opendev.org/c/openstack/python-openstackclient/+/806624 | |
| 17:15:36 | opendevreview | Ghanshyam proposed openstack/openstackclient master: [community goal] Update contributor documentation https://review.opendev.org/c/openstack/openstackclient/+/806623 | |
| #openstack-sdks - 2021-08-31 | |||
| 13:03:38 | opendevreview | Pavlo Shchelokovskyy proposed openstack/keystoneauth master: Enforce scope mutual exclusion for system https://review.opendev.org/c/openstack/keystoneauth/+/802683 | |
| 13:31:31 | opendevreview | Laurent Almeras proposed openstack/ansible-collections-openstack master: use idempotent behavior + diff https://review.opendev.org/c/openstack/ansible-collections-openstack/+/806745 | |
| 16:35:52 | opendevreview | Merged openstack/openstackclient master: [community goal] Update contributor documentation https://review.opendev.org/c/openstack/openstackclient/+/806623 | |