| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-sdks - 2021-07-09 | |||
| 16:42:32 | gouthamr | yes | |
| 16:42:59 | gouthamr | i'll ofcourse add the rest of you for that final +W too, if you've not already looked :) | |
| 16:44:08 | gouthamr | kafilat's internship ends in a few weeks; i'm hoping we can get her work in; and iterate - it's all going to have to be merged back from the feature/r1 branch into master anyway | |
| 16:44:39 | artom | gouthamr, hehe, I'm the wrong Art(e|o)m :) | |
| 16:44:58 | artom | (Not often I get to say that in a non-Russophone environment) | |
| 16:45:51 | gouthamr | so i'll help with that cherry-picking etc; but having patch dependencies (resources that have a fk dependency on other resources, "sub" resources etc) is hurting her productivity for now | |
| 16:47:39 | gouthamr | artom: :D i blame freenode chaos on my nick confusions | |
| 16:51:34 | gouthamr | also would be nice to see this one merged: https://review.opendev.org/c/openstack/project-config/+/799323 | |
| 16:55:14 | mordred | ++ to project cores | |
| 18:14:02 | gouthamr | \o/ | |
| 18:14:23 | gouthamr | i've a question regarding microversions in the API requests in the functional tests | |
| 18:15:45 | gouthamr | when i write a functional test, and set a min_version in the class, it only seems to be used for validating if the version is supported: https://opendev.org/openstack/openstacksdk/src/commit/9dc4a841145200583ac3f8c56df775a165e5f2f4/openstack/tests/functional/shared_file_system/test_availability_zone.py#L18 | |
| 18:16:16 | gouthamr | i'd like the request to be made with that microversion | |
| 18:17:12 | gouthamr | is there any way i can do that? i tried setting the user and operator cloud versions to a specific version, but that didn't seem to make a difference: https://review.opendev.org/c/openstack/openstacksdk/+/799208/2/openstack/tests/functional/shared_file_system/base.py | |
| #openstack-sdks - 2021-07-10 | |||
| 04:00:16 | opendevreview | Pete Zaitcev proposed openstack/python-openstackclient master: Allow to list containers of other accounts https://review.opendev.org/c/openstack/python-openstackclient/+/731395 | |
| 12:26:04 | mordred | gouthamr: well ... what you'll need to do is override the version discovery document: https://opendev.org/openstack/openstacksdk/src/branch/master/openstack/tests/unit/fixtures/shared-file-system.json | |
| 12:26:20 | mordred | sdk is always going to make requests based on version discovery negotiation | |
| 12:27:08 | mordred | so if you want to test that it's doing the right thing, you'd want, inthe setup of that test, to tell it to return a version discovery doc with an appropriate max microversion | |
| 12:27:29 | mordred | (there should totally be a base test class api for doing this easily - sorry about that) | |
| #openstack-sdks - 2021-07-11 | |||
| 04:19:12 | gouthamr | hi modred: thanks for the response; the unit test fixture is for the unit tests alone, no? i was looking to get the request made in the functional test to use a specific microversion | |
| 04:19:14 | gouthamr | mordred* | |
| 04:20:24 | gouthamr | i can do this locally by setting "shared_file_system_api_version" in the devstack-admin cloud profile in /etc/openstack/clouds.yaml - i was wondering if we can have that behavior occur in the tests | |
| #openstack-sdks - 2021-07-12 | |||
| 12:52:53 | opendevreview | Uemit Seren proposed openstack/ansible-collections-openstack master: Add subnet pool module https://review.opendev.org/c/openstack/ansible-collections-openstack/+/800463 | |
| 13:48:04 | opendevreview | Uemit Seren proposed openstack/ansible-collections-openstack master: Add subnet pool module https://review.opendev.org/c/openstack/ansible-collections-openstack/+/800463 | |
| 14:29:09 | opendevreview | Uemit Seren proposed openstack/ansible-collections-openstack master: Add subnet pool module https://review.opendev.org/c/openstack/ansible-collections-openstack/+/800463 | |
| 14:47:11 | opendevreview | Stephen Finucane proposed openstack/python-openstackclient stable/train: [stable-only] Cap bandit to 1.6.2, bump lower-constraints https://review.opendev.org/c/openstack/python-openstackclient/+/799690 | |
| 14:47:11 | opendevreview | Stephen Finucane proposed openstack/python-openstackclient stable/train: Fix reverted osc-lib interface change https://review.opendev.org/c/openstack/python-openstackclient/+/799662 | |
| 14:54:39 | opendevreview | Uemit Seren proposed openstack/ansible-collections-openstack master: Add extra_specs attribute to network and router https://review.opendev.org/c/openstack/ansible-collections-openstack/+/800492 | |
| 20:02:38 | opendevreview | Uemit Seren proposed openstack/ansible-collections-openstack master: Add subnet pool module https://review.opendev.org/c/openstack/ansible-collections-openstack/+/800463 | |
| 21:24:15 | opendevreview | Uemit Seren proposed openstack/ansible-collections-openstack master: Add subnet pool module https://review.opendev.org/c/openstack/ansible-collections-openstack/+/800463 | |
| #openstack-sdks - 2021-07-13 | |||
| 02:23:16 | opendevreview | Zane Bitter proposed openstack/cliff master: Colourise and automatically page help output https://review.opendev.org/c/openstack/cliff/+/799344 | |
| 02:23:17 | opendevreview | Zane Bitter proposed openstack/cliff master: Automatically page interactive root help output https://review.opendev.org/c/openstack/cliff/+/799345 | |
| 08:14:42 | opendevreview | Uemit Seren proposed openstack/ansible-collections-openstack master: Add subnet pool module https://review.opendev.org/c/openstack/ansible-collections-openstack/+/800463 | |
| 09:37:42 | opendevreview | Uemit Seren proposed openstack/ansible-collections-openstack master: Add subnet pool module https://review.opendev.org/c/openstack/ansible-collections-openstack/+/800463 | |
| 10:10:53 | stephenfin | diablo_rojo_phone: I totally forgot to send you stuff for students to work on. Sorry! /o\ I assume we're past that? | |
| 10:20:04 | stephenfin | gtema: Can you look at https://review.opendev.org/c/openstack/python-openstackclient/+/799662 and its predecessor (which fixes stable/train for OSC)? | |
| 10:20:14 | gtema | yupp | |
| 10:20:38 | stephenfin | gtema: Also, if you want another stable core on OSC/SDK then I'm happy to help out. I'm stable on oslo so I know the rules | |
| 10:20:51 | gtema | :) | |
| 10:20:56 | gtema | cool | |
| 10:21:23 | gtema | actually you should be, since currently all cores are maintainers if I remember correctly | |
| 10:21:34 | stephenfin | it doesn't appear so | |
| 10:21:41 | gtema | ok, will check | |
| 10:56:56 | diablo_rojo_phone | stephenfin: actually not. Thursday is the day of the event. | |
| 10:57:26 | stephenfin | diablo_rojo_phone: \o/ I can come up with some stuff after lunch if you still need it? | |
| 11:06:23 | diablo_rojo_phone | stephenfin: yes please! Works for me. | |
| 11:20:21 | opendevreview | Uemit Seren proposed openstack/ansible-collections-openstack master: Add subnet pool module https://review.opendev.org/c/openstack/ansible-collections-openstack/+/800463 | |
| 12:38:43 | opendevreview | Merged openstack/python-openstackclient stable/train: [stable-only] Cap bandit to 1.6.2, bump lower-constraints https://review.opendev.org/c/openstack/python-openstackclient/+/799690 | |
| 12:38:47 | opendevreview | Merged openstack/python-openstackclient stable/train: Fix reverted osc-lib interface change https://review.opendev.org/c/openstack/python-openstackclient/+/799662 | |
| 13:25:32 | opendevreview | Uemit Seren proposed openstack/ansible-collections-openstack master: Add subnet pool module https://review.opendev.org/c/openstack/ansible-collections-openstack/+/800463 | |
| 14:07:02 | opendevreview | Uemit Seren proposed openstack/ansible-collections-openstack master: Add subnet pool module https://review.opendev.org/c/openstack/ansible-collections-openstack/+/800463 | |
| 19:08:41 | stephenfin | diablo_rojo_phone: https://storyboard.openstack.org/#!/story/2009054 | |
| 19:15:22 | diablo_rojo_phone | stephenfin: thanks! | |
| 19:33:49 | opendevreview | Stephen Finucane proposed openstack/python-openstackclient master: volume: Add 'volume transfer request create --(no-)snapshots' option https://review.opendev.org/c/openstack/python-openstackclient/+/800715 | |
| #openstack-sdks - 2021-07-14 | |||
| 15:09:58 | gshippey | any possibility on getting feedback on https://review.opendev.org/c/openstack/openstacksdk/+/799508? Looking to add support for keystone service providers, first time contributing to this project | |
| 17:00:12 | gouthamr | gtema diablo_rojo_phone: have you folks had any further thoughts on adding one/more manila reviewers? | |
| 17:01:33 | gtema | Guys, you need to start reviewing patches yourself. If we add you as reviewers, but you do not review - why's that? | |
| 17:01:46 | gtema | From manilla patches only one was reviewed by you | |
| 17:03:22 | gouthamr | gtema: ? sorry, i perhaps missed review notifications | |
| 17:04:14 | gtema | From around 10 manila patches only one was finally approved by you. Others had some iterations, but are now not reviewed | |
| 17:04:20 | gouthamr | yes | |
| 17:04:47 | gtema | And this is normally a signal for me when I see you approve the patch | |
| 17:04:59 | gouthamr | i've been looking at these; i can add my comments there | |
| 17:08:35 | gouthamr | so if you see a +1 from one of us, you're looking to treat that as a +2? | |
| 17:09:24 | gouthamr | i'm okay with that - just want to know what the operating procedure should be around here :) | |
| 17:10:17 | gouthamr | i'd love to see https://review.opendev.org/c/openstack/openstacksdk/+/796040 merge for one - its been worked on for a while | |
| 17:41:04 | gouthamr | gtema: hey you might know the answer to my prior queries to this channel - i'd like to specify a microversion for a particular SDK call; is this possible today? | |
| 17:41:29 | gouthamr | i tried doing something like this: https://review.opendev.org/c/openstack/openstacksdk/+/799208/2/openstack/tests/functional/shared_file_system/base.py | |
| 17:41:34 | gouthamr | but it didn't seem to have an effect | |
| #openstack-sdks - 2021-07-15 | |||
| 11:33:08 | opendevreview | Takashi Kajinami proposed openstack/openstacksdk master: Replace deprecated inspect.getargspec https://review.opendev.org/c/openstack/openstacksdk/+/800918 | |
| 11:37:54 | opendevreview | Takashi Kajinami proposed openstack/openstacksdk master: Replace deprecated inspect.getargspec https://review.opendev.org/c/openstack/openstacksdk/+/800918 | |
| #openstack-sdks - 2021-07-17 | |||
| 03:14:52 | opendevreview | Cuong proposed openstack/ansible-collections-openstack master: Add protocol listener octavia https://review.opendev.org/c/openstack/ansible-collections-openstack/+/801176 | |
| #openstack-sdks - 2021-07-19 | |||
| 11:08:45 | opendevreview | Jesper Schmitz Mouridsen proposed openstack/ansible-collections-openstack master: Wait for pool to be active and online https://review.opendev.org/c/openstack/ansible-collections-openstack/+/801286 | |
| 13:28:45 | opendevreview | Merged openstack/ansible-collections-openstack master: Add protocol listener octavia https://review.opendev.org/c/openstack/ansible-collections-openstack/+/801176 | |
| 20:39:11 | opendevreview | Uemit Seren proposed openstack/ansible-collections-openstack master: Add extra_specs attribute to network and router https://review.opendev.org/c/openstack/ansible-collections-openstack/+/800492 | |
| #openstack-sdks - 2021-07-20 | |||
| 09:26:46 | opendevreview | Uemit Seren proposed openstack/ansible-collections-openstack master: Add extra_specs attribute to network and router https://review.opendev.org/c/openstack/ansible-collections-openstack/+/800492 | |
| 16:42:34 | mchlumsky | Hi! :) | |
| 16:42:34 | mchlumsky | I am using the openstacksdk and I am trying to list all the users in a particular group (in keystone). There's an endpoint for it (https://docs.openstack.org/api-ref/identity/v3/index.html?expanded=id627-detail#list-users-in-group) but I can't find an equivalent in the openstacksdk. Did I miss it somehow? | |
| 17:06:03 | gtema | mchlumsky sadly right now it's not implemented, but it is rather easy to do so. I'll look if I find time doing that shortly | |
| 17:06:26 | opendevreview | Merged openstack/cliff master: Add conflict_handler parameter as attribut in Command class https://review.opendev.org/c/openstack/cliff/+/794792 | |
| 17:33:47 | mchlumsky | gtema thank you! :) | |
| 21:17:53 | opendevreview | Uemit Seren proposed openstack/openstacksdk master: Add extra params to create_router & create_network https://review.opendev.org/c/openstack/openstacksdk/+/801535 | |
| #openstack-sdks - 2021-07-22 | |||
| 14:27:17 | opendevreview | Balazs Gibizer proposed openstack/openstacksdk master: Remove block storage v2 support https://review.opendev.org/c/openstack/openstacksdk/+/801864 | |
| 14:36:32 | opendevreview | Balazs Gibizer proposed openstack/openstacksdk master: Remove block storage v2 func tests https://review.opendev.org/c/openstack/openstacksdk/+/801864 | |
| 14:40:33 | gibi | hi! you might noticed the openstacksdk-functional-devstack job started to fail since cinder merged the v2 api removal in https://review.opendev.org/c/openstack/cinder/+/792299 | |
| 14:40:54 | gibi | I proposed the removal of the v2 func test from the job https://review.opendev.org/c/openstack/openstacksdk/+/801864 to unblock the gate | |
| 14:57:05 | gmann | gibi: also we should have test v2 as separate job and default jobs test to v3 only. that is how we did in tempest integration jobs | |
| 14:59:08 | gtema | SDK has a contract to work on older clouds (not only for OSC, but also ansible collections, Zuul, etc). Dropping v2 support is definitely not the way we will go. Dropping tests seems ok, but I will check for a possibility to check whether specific version is available (in some cases we have skipTest if service is not available) | |
| 15:01:46 | gibi | gtema: ack. I've limited experience in sdk so I follow any lead. I just wanted to unblock the gate | |
| 15:02:16 | gtema | clear. If I am not able to find alternative solution in 1-2 hours I will approve the patch | |
| 15:02:27 | gibi | gtema: thanks. I appreciate it! | |
| 15:02:35 | gtema | then we can revert the tests with some logic | |
| 15:06:35 | gmann | gtema: gibi we can skip in v2 test in job | |
| 15:06:45 | gmann | I can try after TC meeting | |
| 15:07:14 | gibi | gmann: feel free to take over my patch I will probably disappeare in a hour or so | |
| 15:07:41 | gmann | gibi: I can do in separate and then we can discuss best way to remove v2 in your patch ? | |
| 15:07:59 | gibi | that works for me too | |
| 15:41:43 | opendevreview | Ghanshyam proposed openstack/openstacksdk master: Skip block_storage.v2 test in functional job https://review.opendev.org/c/openstack/openstacksdk/+/801872 | |
| 15:42:57 | gmann | gtema: ^^ | |
| 16:01:57 | opendevreview | Artem Goncharov proposed openstack/openstacksdk master: Extend has_version function to accept version parameter https://review.opendev.org/c/openstack/openstacksdk/+/801900 | |