Earlier  
Later
New Search
Posted Nick Remark
#openstack-sdks - 2021-03-26
15:54:39 openstackgerrit Stephen Finucane proposed openstack/openstacksdk master: placement: Add support for resource providers https://review.opendev.org/c/openstack/openstacksdk/+/745375
15:54:40 openstackgerrit Stephen Finucane proposed openstack/openstacksdk master: placement: Add support for resource classes https://review.opendev.org/c/openstack/openstacksdk/+/783350
#openstack-sdks - 2021-03-28
19:49:53 openstackgerrit Ashley Rodriguez proposed openstack/openstacksdk master: Add share network subnet resource to shared file system https://review.opendev.org/c/openstack/openstacksdk/+/783582
19:56:26 openstackgerrit Ashley Rodriguez proposed openstack/openstacksdk master: Add share resource to shared file system https://review.opendev.org/c/openstack/openstacksdk/+/775707
21:38:53 openstackgerrit Ashley Rodriguez proposed openstack/openstacksdk master: Add share network subnet resource to shared file system https://review.opendev.org/c/openstack/openstacksdk/+/783582
#openstack-sdks - 2021-03-31
10:01:44 slaweq gtema: stephenfin and other sdk cores, can You take a look at https://review.opendev.org/c/openstack/openstacksdk/+/782870? thx in advance
10:25:23 stephenfin gtema: Can you look at https://review.opendev.org/c/openstack/openstacksdk/+/782870 again?
10:25:31 stephenfin I spotted one thing
10:25:32 stephenfin slaweq: ^
10:26:58 slaweq stephenfin: thx, checking
10:27:31 slaweq stephenfin: thx, I will address Your comments today
10:41:12 openstackgerrit Slawek Kaplonski proposed openstack/openstacksdk master: Add support for the Neutron L3 conntrack helper API https://review.opendev.org/c/openstack/openstacksdk/+/782870
10:42:50 slaweq stephenfin: gtema updated ^^
10:42:53 slaweq thx for review
10:43:22 slaweq according that "assert isinstance()" I changed that but there is a lot of other places where it is used in functional tests
10:43:31 slaweq do You think we should change it everywhere?
10:43:54 gtema generally yes, but not now. Part of R1.0 - would be cool
10:44:13 slaweq gtema: ok
10:56:11 stephenfin slaweq: Think you missed a test
11:03:48 openstackgerrit Slawek Kaplonski proposed openstack/openstacksdk master: Add support for the Neutron L3 conntrack helper API https://review.opendev.org/c/openstack/openstacksdk/+/782870
13:19:42 openstackgerrit David Hill proposed openstack/python-openstackclient master: Add rule parameter in openstackclient https://review.opendev.org/c/openstack/python-openstackclient/+/784100
13:28:06 noonedeadpunk I'm not sure, it feels like I missed to add some test, but wasn't able to find current one... And don't feel strength in writing proper one from scratch for https://review.opendev.org/c/openstack/openstacksdk/+/783849
14:03:15 openstackgerrit Stephen Finucane proposed openstack/python-openstackclient master: Add rule parameter in openstackclient https://review.opendev.org/c/openstack/python-openstackclient/+/784100
14:50:30 openstackgerrit Stephen Finucane proposed openstack/osc-lib master: parseractions: Make key validation reusable https://review.opendev.org/c/openstack/osc-lib/+/784110
16:27:29 openstackgerrit Ryan Zimmerman proposed openstack/openstacksdk master: Add compute microversion 2.57 https://review.opendev.org/c/openstack/openstacksdk/+/781131
16:44:07 stephenfin gtema: Can you take a look at https://review.opendev.org/c/openstack/python-openstackclient/+/773649 and https://review.opendev.org/c/openstack/python-openstackclient/+/780030 please?
16:44:17 gtema ok
16:47:00 gtema how should the pre-commit-hook work? I checked out your change, tried to add broken commit and nothing happened
17:09:28 stephenfin gtema: Did you install pre-commit?
17:09:57 gtema and how to do that? maybe this hints a release note is missing
17:10:14 stephenfin I didn't want to include a release note because it seemed too internal
17:10:19 stephenfin I could add docs though
17:10:36 gtema exactly, and that is therefore unclear how to use
17:11:18 gtema it's just every git is using their own way to use hooks and I never seen .pre-commit-config.yaml usage
17:19:41 openstackgerrit Stephen Finucane proposed openstack/python-openstackclient master: Add pre-commit https://review.opendev.org/c/openstack/python-openstackclient/+/780030
17:19:42 openstackgerrit Stephen Finucane proposed openstack/python-openstackclient master: hacking: Remove references to encoding https://review.opendev.org/c/openstack/python-openstackclient/+/784138
18:40:42 openstackgerrit Merged openstack/python-openstackclient master: network: Add support for vnic-type vdpa https://review.opendev.org/c/openstack/python-openstackclient/+/778571
20:12:00 openstackgerrit Ashley Rodriguez proposed openstack/openstacksdk master: Add share access rules resource to shared file system https://review.opendev.org/c/openstack/openstacksdk/+/784162
22:25:56 openstackgerrit Mark Tony proposed openstack/openstacksdk master: Add a share network resource to shared file system https://review.opendev.org/c/openstack/openstacksdk/+/784177
22:33:11 openstackgerrit Dylan Zapzalka proposed openstack/openstacksdk master: Added support for the GroupType resource https://review.opendev.org/c/openstack/openstacksdk/+/784178
22:33:59 openstackgerrit Dylan Zapzalka proposed openstack/openstacksdk master: WIP Added support for the GroupType resource https://review.opendev.org/c/openstack/openstacksdk/+/784178
#openstack-sdks - 2021-04-01
00:07:13 alpalka @diablo_rojo I had a question about how to implement the list/get method on my resource I am attempting to implement
00:07:16 alpalka ?
01:12:26 diablo_rojo alpalka, hit me with it :) Unless its what you also emailed about? I hadn't read the whole thing yet.
01:20:12 alpalka It is what I emailed about. I am not quite sure how to implement the list json vs the get json on the host extension resource. Also, I do not know how to implement the list on the proxy
01:20:16 alpalka Thank you!
01:21:45 diablo_rojo alpalka, let me see if I can find an example.. one sec
01:22:05 alpalka ok, messages was the one I was looking at, but in messages the json is the same.
01:26:33 diablo_rojo alpalka, ah alright, well let me see if I can find something more similar to the host extension
01:26:45 diablo_rojo do you have a link to the api handy?
01:34:58 alpalka https://docs.openstack.org/api-ref/block-storage/v3/index.html?expanded=list-attachments-detail,list-snapshots-and-details-detail,list-volume-transfers-and-details-detail,show-host-details-for-a-project-detail,list-all-hosts-for-a-project-detail,list-resource-filters-detail,list-messages-detail,show-message-details-detail#snapshot-actions-snapshots-action
01:42:14 alpalka diablo_rojo
01:53:21 diablo_rojo alpalka, I think I would model it after list volumes
01:53:33 alpalka gotcha
01:53:43 diablo_rojo The List accessible volumes with details
01:53:43 alpalka also my git is all sorts of messed up rn hahaha
01:54:09 diablo_rojo alpalka, lol do you have local changes that aren't pushed up that you need to save? Or can you just blow it all away?
01:54:27 alpalka Honestly I could just blow it all away
01:54:53 diablo_rojo alpalka, sometimes that is easier and waaay faster.
01:56:09 alpalka "You are currently editing a commit while rebasing branch 'ndsu-capstone' on 'fd0c9778'."
01:56:17 alpalka Is my git status message
01:56:32 alpalka diablo rojo
02:00:56 diablo_rojo Did you get stuck in the middle of a rebase?
02:01:06 diablo_rojo Were you cleaning up a merge conflict/
02:01:07 diablo_rojo ?
02:10:29 alpalka I was cleaning up a merge conflict
02:10:36 alpalka I just aborted my rebase
02:10:50 alpalka now I am trying to pull from the branch again but I can't figure out the syntax
02:21:25 diablo_rojo to pull again?
02:22:41 diablo_rojo alpalka, git fetch "https://review.opendev.org/openstack/openstacksdk" refs/changes/20/776320/8 && git checkout FETCH_HEAD
02:24:12 diablo_rojo or were you talking about re-cloning?
02:25:42 diablo_rojo In the gerrit interface, towards the top right, in the three dot menu, there is a download patch option. From there I copy the checkout syntax.
02:41:59 alpalka gotcha uhm im trying haha
02:54:02 alpalka diablo_rojo stephen commented on my patch and explained some stuff and your tip got my merge working, thanks!
05:24:58 openstackgerrit Alexander Wilcox proposed openstack/openstacksdk master: blockstorage: Add Host Resource https://review.opendev.org/c/openstack/openstacksdk/+/776320
09:55:02 openstackgerrit Merged openstack/openstacksdk master: Add support for the Neutron L3 conntrack helper API https://review.opendev.org/c/openstack/openstacksdk/+/782870
14:05:47 openstackgerrit Stephen Finucane proposed openstack/python-openstackclient master: Add pre-commit https://review.opendev.org/c/openstack/python-openstackclient/+/780030
14:16:25 openstackgerrit Stephen Finucane proposed openstack/python-openstackclient master: hacking: Remove references to encoding https://review.opendev.org/c/openstack/python-openstackclient/+/784138
15:04:00 openstackgerrit Hudson Dahly proposed openstack/openstacksdk master: Add support for Messages resource https://review.opendev.org/c/openstack/openstacksdk/+/777502
15:58:17 stephenfin gtema: diablo_rojo: I had a conflict with the meeting and totally forgot about it /o\
15:58:30 gtema no problem
16:00:26 diablo_rojo stephenfin, no worries :)
16:00:35 diablo_rojo stephenfin, next week you also won't be around right?
16:00:45 stephenfin Afraid not. I'm on PTO for the week
16:00:51 gtema ok
16:00:56 diablo_rojo stephenfin, oh nice! Doing anything fun?
16:01:56 stephenfin Stripping wallpaper and knocking walls /o\ I bought an old period house the tail end of last year and haven't been able to get near it until now due to COVID restrictions
16:02:14 gtema :)
16:02:41 gtema so familiar. But it is not better if you buy a new "not finished" house
16:03:00 gtema since 2 years I am in permanent "doing something"
16:05:00 stephenfin Oh, I suspect I'll be "doing something" forever
16:05:07 gtema true
16:05:15 stephenfin It's an ~1850s property, so you're never really done with those
16:05:32 gtema what? that's definitely a bit of work
16:09:15 stephenfin that's for sure :D
17:58:31 openstackgerrit Merged openstack/python-openstackclient master: Implements hide image https://review.opendev.org/c/openstack/python-openstackclient/+/773649
18:31:34 openstackgerrit Merged openstack/python-openstackclient master: Update master for stable/wallaby https://review.opendev.org/c/openstack/python-openstackclient/+/781959
18:31:41 openstackgerrit Merged openstack/python-openstackclient master: Add Python3 xena unit tests https://review.opendev.org/c/openstack/python-openstackclient/+/781960
19:05:03 openstackgerrit Merged openstack/python-openstackclient master: Add pre-commit https://review.opendev.org/c/openstack/python-openstackclient/+/780030
#openstack-sdks - 2021-04-02
10:52:27 openstackgerrit Jakob Meng proposed openstack/osc-lib master: Respect 'interface' key from clouds.yaml https://review.opendev.org/c/openstack/osc-lib/+/784559

Earlier   Later