Posted	Nick	Remark
#openstack-sdks - 2021-03-03
16:22:01	gtema	thanks
16:22:53	gtema	and do the review if you already touched it, please ;-)
16:35:10	mordred	corvus: ^^ you might also want to review
16:39:15	mordred	gtema: you say in a previous comment "What is clearly worth mentioning, that auth is cached on logout. OSC currently doesn't invoke it, thus not really having any use." - not sure what you mean by logout - and also, seems like a thing that would *really* be a nice thing to have OSC enable (if it's configured)
16:39:50	gtema	I have added a destructor for connection (not sure whether this helps really)
16:39:56	mordred	but +2 from me on the stuff you added :)
16:40:12	gtema	and there are changes in OSC and cliff (afair)
16:40:19	mordred	ah - cool
16:40:50	gtema	https://review.opendev.org/c/openstack/python-openstackclient/+/765652
16:41:01	gtema	didn't touch it for a while though
16:43:24	gtema	so osc_lib should is closing the connection causing SDK to save the token
16:43:34	gtema	s/is/be
17:01:28	openstackgerrit	Merged openstack/python-openstackclient master: Add 'address_group' type support to rbac commands https://review.opendev.org/c/openstack/python-openstackclient/+/775045
17:01:49	openstackgerrit	Merged openstack/python-openstackclient master: compute: Add 'server * --all-projects' option https://review.opendev.org/c/openstack/python-openstackclient/+/771687
17:01:58	openstackgerrit	Merged openstack/python-openstackclient master: compute: Add missing options for 'server group list' https://review.opendev.org/c/openstack/python-openstackclient/+/771688
20:22:35	openstackgerrit	sean mooney proposed openstack/python-openstackclient master: add support for vnic-type vdpa https://review.opendev.org/c/openstack/python-openstackclient/+/778571
21:35:56	twilit_dragon	Hey all, does anyone know what the '-n' option is for when running tox locally? Whenever I omit it I get an InvocationError from tox/stestr, but when I include it my tests pass.
21:39:05	openstackgerrit	James Palmer proposed openstack/openstacksdk master: Add support for Resource Filters https://review.opendev.org/c/openstack/openstacksdk/+/776271
21:39:11	openstackgerrit	Merged openstack/python-openstackclient stable/victoria: Validate 'server group create --policy' option https://review.opendev.org/c/openstack/python-openstackclient/+/770129
21:39:37	openstackgerrit	Merged openstack/openstacksdk master: Prevent the endless loop in resource listing https://review.opendev.org/c/openstack/openstacksdk/+/776203
#openstack-sdks - 2021-03-04
00:38:09	openstackgerrit	Dylan Zapzalka proposed openstack/openstacksdk master: Added support for the Limits resource https://review.opendev.org/c/openstack/openstacksdk/+/776318
01:51:24	openstackgerrit	sue proposed openstack/openstacksdk master: add masakari enabled to segment https://review.opendev.org/c/openstack/openstacksdk/+/777299
02:14:16	openstackgerrit	Merged openstack/openstackclient master: Remove karborclient - fix Zuul project definition https://review.opendev.org/c/openstack/openstackclient/+/778536
02:30:04	openstackgerrit	James Palmer proposed openstack/openstacksdk master: Add support for Resource Filters https://review.opendev.org/c/openstack/openstacksdk/+/776271
05:39:54	openstackgerrit	Alexander Wilcox proposed openstack/openstacksdk master: This is the Host Extension Resource, for capstone. https://review.opendev.org/c/openstack/openstacksdk/+/776320
05:45:06	openstackgerrit	Alexander Wilcox proposed openstack/openstacksdk master: This is the Host Extension Resource, for capstone. https://review.opendev.org/c/openstack/openstacksdk/+/776320
06:50:08	openstackgerrit	Hudson Dahly proposed openstack/openstacksdk master: Add support for Messages resource https://review.opendev.org/c/openstack/openstacksdk/+/777502
07:16:06	openstackgerrit	Artem Goncharov proposed openstack/openstacksdk master: Cache auth token in keyring https://review.opendev.org/c/openstack/openstacksdk/+/735352
07:57:06	openstackgerrit	Artem Goncharov proposed openstack/openstacksdk master: Stop sending tenant_id to Neutron https://review.opendev.org/c/openstack/openstacksdk/+/770952
08:24:07	openstackgerrit	Hudson Dahly proposed openstack/openstacksdk master: Add support for Messages resource https://review.opendev.org/c/openstack/openstacksdk/+/777502
08:28:08	openstackgerrit	Hudson Dahly proposed openstack/openstacksdk master: Add support for Messages resource https://review.opendev.org/c/openstack/openstacksdk/+/777502
10:07:18	openstackgerrit	Vladimir Ermakov proposed openstack/ansible-collections-openstack master: security_group_rule: add support ipv6-icmp https://review.opendev.org/c/openstack/ansible-collections-openstack/+/778627
13:20:30	openstackgerrit	Merged openstack/openstacksdk master: add masakari enabled to segment https://review.opendev.org/c/openstack/openstacksdk/+/777299
13:21:12	openstackgerrit	Merged openstack/python-openstackclient master: compute: Add missing options for 'server event list' https://review.opendev.org/c/openstack/python-openstackclient/+/771689
13:21:26	openstackgerrit	Merged openstack/python-openstackclient master: compute: Shuffle options for 'server create' https://review.opendev.org/c/openstack/python-openstackclient/+/771690
13:21:39	openstackgerrit	Merged openstack/python-openstackclient master: compute: Improve 'server create --nic' option parsing https://review.opendev.org/c/openstack/python-openstackclient/+/771691
16:11:28	openstackgerrit	Alexander Wilcox proposed openstack/openstacksdk master: This is the Host Extension Resource, for capstone. https://review.opendev.org/c/openstack/openstacksdk/+/776320
16:34:58	stephenfin	gtema: Thanks for all the reviews :)
16:35:07	gtema	welcome
16:37:01	openstackgerrit	Alexander Wilcox proposed openstack/openstacksdk master: This is the Host Extension Resource, for capstone. https://review.opendev.org/c/openstack/openstacksdk/+/776320
16:51:05	openstackgerrit	Merged openstack/python-openstackclient master: compute: Add support for 'server boot --nic ...,tag=' https://review.opendev.org/c/openstack/python-openstackclient/+/771692
16:51:29	openstackgerrit	Merged openstack/python-openstackclient master: Rename FakeServerMigration to FakeMigration https://review.opendev.org/c/openstack/python-openstackclient/+/771693
16:51:49	openstackgerrit	Merged openstack/python-openstackclient master: compute: Add 'server migration show' command https://review.opendev.org/c/openstack/python-openstackclient/+/771694
16:52:13	openstackgerrit	Merged openstack/python-openstackclient master: compute: Rename 'server migrate (confirm|revert)' https://review.opendev.org/c/openstack/python-openstackclient/+/771695
17:15:30	openstackgerrit	Artem Goncharov proposed openstack/openstacksdk master: Prepare separate block_storage v3 documentation https://review.opendev.org/c/openstack/openstacksdk/+/778754
17:33:42	openstackgerrit	Thiago Paiva Brito proposed openstack/openstacksdk master: Implement metadata operation support for Snapshots https://review.opendev.org/c/openstack/openstacksdk/+/778757
17:51:27	openstackgerrit	Thiago Paiva Brito proposed openstack/openstacksdk master: Add update capabilities to Snapshots https://review.opendev.org/c/openstack/openstacksdk/+/778760
18:38:21	openstackgerrit	Stephen Finucane proposed openstack/python-openstackclient master: compute: Add functional tests for --block-device https://review.opendev.org/c/openstack/python-openstackclient/+/778763
#openstack-sdks - 2021-03-05
07:24:24	frickler	the ansible-stable jobs seem to be hard broken, is someone planning on fixing them or could we drop/move to experimental? see e.g. https://zuul.opendev.org/t/openstack/builds?job_name=openstacksdk-ansible-stable-2.9-functional-devstack&project=openstack/openstacksdk
08:29:41	openstackgerrit	Merged openstack/python-openstackclient stable/ussuri: Fix reverted osc-lib interface change https://review.opendev.org/c/openstack/python-openstackclient/+/771408
09:41:42	openstackgerrit	Rico Lin proposed openstack/api-sig master: Change primary eamil for Rico Lin https://review.opendev.org/c/openstack/api-sig/+/778863
12:05:04	openstackgerrit	Stephen Finucane proposed openstack/python-openstackclient master: compute: Add functional tests for --block-device https://review.opendev.org/c/openstack/python-openstackclient/+/778763
12:05:43	openstackgerrit	Stephen Finucane proposed openstack/python-openstackclient master: compute: Add functional tests for --block-device https://review.opendev.org/c/openstack/python-openstackclient/+/778763
12:56:32	openstackgerrit	Bharat Kunwar proposed openstack/python-openstackclient master: network: Allow user to unset gateway for a subnet https://review.opendev.org/c/openstack/python-openstackclient/+/778906
12:58:38	openstackgerrit	Artem Goncharov proposed openstack/openstacksdk master: Switch networking function in cloud layer to proxy https://review.opendev.org/c/openstack/openstacksdk/+/766783
13:11:33	openstackgerrit	Stephen Finucane proposed openstack/python-openstackclient master: compute: Add functional tests for --block-device https://review.opendev.org/c/openstack/python-openstackclient/+/778763
13:11:34	openstackgerrit	Stephen Finucane proposed openstack/python-openstackclient master: compute: Add support for loading BDMs from files https://review.opendev.org/c/openstack/python-openstackclient/+/778910
13:18:07	stephenfin	gtema: You might like https://review.opendev.org/c/openstack/python-openstackclient/+/778910
13:18:23	gtema	;)
13:18:42	stephenfin	it's certainly a unique way of doing things, IMO :)
13:19:17	gtema	yeah
13:19:40	stephenfin	I have an open question on it that I think you would have good ideas on
13:19:50	stephenfin	(about what type of path we want to support)
13:20:12	stephenfin	I see some other examples in networking code that use plain paths, so I might be overcomplicating matters. idk
13:20:39	gtema	agree, also on swift we use FS paths
13:57:09	brtknr	mordred: frickler: Please take a look at https://review.opendev.org/c/openstack/python-openstackclient/+/778906
14:16:08	openstackgerrit	Bharat Kunwar proposed openstack/python-openstackclient master: network: Add missing subnet unset --gateway https://review.opendev.org/c/openstack/python-openstackclient/+/778906
14:54:45	openstackgerrit	Thiago Paiva Brito proposed openstack/openstacksdk master: Add update volume to image capability https://review.opendev.org/c/openstack/openstacksdk/+/778956
17:48:04	mordred	slaweq: heya - do floating ips support tags? (the sdk resource looks like they do)
19:52:21	slaweq	mordred: hi, let me check that
19:52:55	slaweq	mordred: yes, https://docs.openstack.org/api-ref/network/v2/?expanded=update-floating-ip-detail,show-floating-ip-details-detail#floating-ips-floatingips
19:54:23	mordred	slaweq: cool - but that's only if the cloud has the standard-attr-tag extension, yeah?
19:54:38	slaweq	mordred: yes
19:54:58	mordred	cool.
20:00:33	slaweq	I'm glad I could help :)
#openstack-sdks - 2021-03-06
11:41:30	openstackgerrit	Merged openstack/python-openstackclient master: Add reno for change Ic3c555226a220efd9b0f27edffccf6c4c95c2747 https://review.opendev.org/c/openstack/python-openstackclient/+/770128
13:57:30	openstackgerrit	Merged openstack/python-openstackclient master: network: Add missing subnet unset --gateway https://review.opendev.org/c/openstack/python-openstackclient/+/778906
#openstack-sdks - 2021-03-08
08:06:17	openstackgerrit	Dylan Zapzalka proposed openstack/openstacksdk master: Added support for the Default Volume Types resource https://review.opendev.org/c/openstack/openstacksdk/+/779172
12:08:14	openstackgerrit	Akihiro Motoki proposed openstack/openstackclient master: DNM: Test openstackclient-check-plugins job https://review.opendev.org/c/openstack/openstackclient/+/779240
15:52:25	openstackgerrit	Riccardo Pittau proposed openstack/openstacksdk master: Apply pep8 import order style https://review.opendev.org/c/openstack/openstacksdk/+/779288
#openstack-sdks - 2021-03-09
18:09:07	openstackgerrit	Radosław Piliszek proposed openstack/openstackclient master: osc-check-plugins job: Ensure OSC plugins from git https://review.opendev.org/c/openstack/openstackclient/+/779240
18:09:27	openstackgerrit	Radosław Piliszek proposed openstack/openstackclient master: Add python-masakariclient https://review.opendev.org/c/openstack/openstackclient/+/778542
18:10:07	openstackgerrit	Radosław Piliszek proposed openstack/openstackclient master: Add python-masakariclient https://review.opendev.org/c/openstack/openstackclient/+/778542
20:32:44	yoctozepto	I might have a dumb question
20:33:12	yoctozepto	but is not the 'type' in 'Body' meant to convert the values on create/update?
20:33:23	yoctozepto	I would assume it, but it is not what I am observing
20:33:47	yoctozepto	when trying to get masakari segment to update its is_enabled
20:34:00	yoctozepto	it just passes the string 'False' or 'True' through
20:34:10	yoctozepto	remaps the attribute name properly
20:34:16	yoctozepto	but not the value
21:05:06	mordred	yoctozepto: what you want is: type=format.BoolStr
21:05:47	mordred	yoctozepto: (grep for "format.BoolStr" and you can see examples of use
21:07:19	yoctozepto	mordred: thanks, will check this out tomorrow; a quick followup question: any downsides to this? i.e., when stick to 'bool'
21:08:45	yoctozepto	when to* stick to
21:09:58	mordred	yoctozepto: I don't think there are any downsides - the main thinng is that the conversion code needs a constructor
21:10:12	mordred	if it's not a list or dict (which need logic) - the conversion code does type(value)
21:10:22	mordred	and sadly bool('False') == True
21:11:11	mordred	I honestly can't think of a reason why special casing bool in _convert_type would be bad ...
21:11:51	mordred	but there might be a reason I'm not thinking of, and using format.BoolStr is safe enough until we could be happy of that
21:12:02	mordred	so - long story short - no, I can't think of many reasons to just use bool somewhere

Earlier   Later