| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-sdks - 2020-11-19 | |||
| 14:30:06 | gtema | something like spec might be required for the discussion we had with stephenfin yesterday | |
| 14:30:17 | gouthamr | ack - thanks; i'll not bother you with it then; the spec was more for project planning and some designing - if we write one, we'll keep it in manila-specs | |
| 14:30:19 | gtema | about what is better in OSC | |
| 14:30:40 | gtema | 'openstack aggregate cache image __aggregate__ __image1__ __image2__ ...' | |
| 14:30:42 | gouthamr | (we did write a spec for our osc work too - we can argue endlessly about subcommand naming) :D | |
| 14:31:01 | gtema | or 'openstack aggregate cache image __aggregate__ --image __image1__ --image __image2__ ...' | |
| 14:31:17 | gouthamr | (^ and things like that) | |
| 14:31:24 | gtema | there are 2 types currently used in different areas | |
| 14:31:43 | gtema | and we might need to agree what is the standard | |
| 14:31:46 | stephenfin | yes, this is a place where we're missing a BDFL (Benevolent Dictator For Life) to settle things for us | |
| 14:32:03 | stephenfin | In the absence of dtroyer, we should probably put together a style guide? | |
| 14:32:08 | gtema | hehe, I am not the one - tell you right now | |
| 14:32:22 | amotoki | it is a topic on how our CLI command should be composed. i think it can be discussed as a document change proposal in OSC | |
| 14:32:30 | stephenfin | Nonsense. All hail, gtema | |
| 14:32:31 | stephenfin | :P | |
| 14:32:47 | stephenfin | amotoki++ yeah, I think this would be a great addition to the docs | |
| 14:32:52 | gtema | amotoki - right. We should start perhaps one | |
| 14:33:09 | stephenfin | s/do // | |
| 14:33:23 | stephenfin | and then we can debate it on Gerrit | |
| 14:33:29 | diablo_rojo | I look forward to reviewing :) | |
| 14:33:30 | gtema | #action - start a style guide for osc | |
| 14:33:32 | amotoki | :) | |
| 14:34:13 | gouthamr | #link https://docs.openstack.org/python-openstackclient/latest/contributor/humaninterfaceguide.html | |
| 14:34:19 | gouthamr | ^ this one already exists, though | |
| 14:34:37 | gtema | right | |
| 14:34:47 | gtema | I new I was seeing this once, but completely forgot | |
| 14:34:55 | gouthamr | and specifically: https://docs.openstack.org/python-openstackclient/latest/contributor/command-options.html | |
| 14:35:55 | gtema | great, might need some extension | |
| 14:36:09 | amotoki | they are good starts. If there are something not covered, we can cover more cases. | |
| 14:36:17 | stephenfin | yes, good call. I didn't know that existed | |
| 14:36:31 | gouthamr | sometimes patterns there don't make sense in all situations; an optional parameter is really required: https://docs.openstack.org/python-openstackclient/latest/contributor/command-options.html#required-options | |
| 14:36:42 | gouthamr | "required options" :D | |
| 14:37:04 | stephenfin | bit on an oxymoron, yes /o\ | |
| 14:37:49 | gtema | okay, moving next | |
| 14:37:56 | gtema | #topic Status OSC to use SDK for nova part | |
| 14:38:18 | gtema | I think we are progressing with stephenfin quite good on that | |
| 14:38:38 | gtema | of course there is still lot to cover | |
| 14:39:01 | gtema | I am explicitly afraid of starting changing 'server' operations - that would be a challenge | |
| 14:39:32 | gtema | stephenfin, do you know whether this cycle we get something new from nova? | |
| 14:40:08 | stephenfin | it shouldn't be _too_ bad - most server actions are implemented by POSTing a simply JSON body to the server actions API | |
| 14:40:29 | stephenfin | gtema: There were no API changes in Victoria. There are only minor changes (to the os-hypervisors API) planned for Wallaby so far | |
| 14:40:38 | gtema | yes, it is always _easy_, until you start working on it | |
| 14:40:44 | stephenfin | True :) | |
| 14:40:46 | gtema | oh, changes in hypervisor? | |
| 14:40:57 | gtema | just working on switching it | |
| 14:41:06 | stephenfin | Yes, but I'm doing that so I'll handle the SDK changes when I do it | |
| 14:41:23 | gtema | with few cool things: until 2.53 you use 1 API to search, after - another | |
| 14:41:43 | stephenfin | oh, there's also a spec proposed to remove the final references to 'tenant_id' from the API, in favour of 'project_id'. It's not approved yet but it will be I suspect | |
| 14:41:50 | gtema | and then https://opendev.org/openstack/python-openstackclient/src/branch/master/openstackclient/compute/v2/hypervisor.py#L124 | |
| 14:42:09 | stephenfin | yeah, there's been a lot of that /o\ | |
| 14:42:12 | gtema | I guess tenant_id/project_id is not a big deal at all | |
| 14:42:45 | gtema | wrt this mentioned renaming I am currently thinking to return DictColumn instead of this renaming | |
| 14:43:10 | gtema | I do not think it is really useful to do this renaming, especially that it requires hacking | |
| 14:43:28 | gtema | what do you think? | |
| 14:43:36 | gtema | I agree this is a "breaking" change | |
| 14:44:04 | gtema | but we anyway plan to bump a major release after this rework is done | |
| 14:44:04 | stephenfin | no issues from me | |
| 14:44:15 | gtema | okay, great | |
| 14:44:17 | stephenfin | so long as we signal it with a major version bump, yes | |
| 14:44:28 | gtema | I hope OSC part will arrive today | |
| 14:44:53 | amotoki | from POV of consumers, it would be nice if both of project_id and tenant_id can be used transparently. | |
| 14:45:18 | gtema | I guess since very long time those are everywhere translated to project_id | |
| 14:45:19 | amotoki | I am not sure what part is discussed, nova API interaction or SDK abstraction? | |
| 14:45:48 | gtema | well - more about switching OSC to use SDK for nova part | |
| 14:46:22 | gtema | on the other hand stephenfin has also some UX improvents in head while we touch those | |
| 14:47:09 | gtema | stephenfin - do you have ideas in which order we should touch remaining things? | |
| 14:47:20 | gtema | I was thinking to leave server to be last | |
| 14:47:23 | gtema | since it is huge | |
| 14:47:40 | gtema | but might be better other way around | |
| 14:47:41 | stephenfin | No ideas, no. Whatever suits, really | |
| 14:47:56 | stephenfin | I'm planning to continue closing gaps with OSC and novaclient | |
| 14:48:15 | gtema | okay. For server I will be definitely create smaller patches switching individual commands of the server or server action | |
| 14:48:33 | gtema | since otherwise we will immediately get into some sort of long lock | |
| 14:49:12 | stephenfin | Makes sense | |
| 14:49:32 | stephenfin | I'll keep using the novaclient library to implement the CLIs until the necessary SDK bits are there to switch over | |
| 14:49:42 | gtema | ok | |
| 14:49:55 | stephenfin | because I don't yet understand SDK well enough /o\ | |
| 14:50:22 | gtema | I am not sure what is really better - do switch first and extend, or first extend and then switch to SDK | |
| 14:50:37 | gtema | SDK is a voodoo thanks to mordred ;-) | |
| 14:51:02 | stephenfin | extend and switch means we have a known baseline | |
| 14:51:10 | gtema | there are just few persons around the world probably who completely understand SDK | |
| 14:51:31 | gtema | agree on that, but | |
| 14:51:35 | stephenfin | i.e. I know novaclient works. I don't necessarily know new OSC changes works | |
| 14:51:53 | stephenfin | also, I'm adding missing options more so than missing commands | |
| 14:51:57 | gtema | before the switch I go to SDK and verify it can do everything what API provides | |
| 14:52:35 | gtema | so SDK should be supporting everything for OSC to be able to implement missing params | |
| 14:53:05 | gtema | okay | |
| 14:53:28 | gtema | diablo_rojo - do you have students already you were mentioning in PTG? | |
| 14:53:36 | gtema | the ones who can support this work | |
| 14:54:02 | diablo_rojo | Still working on the one from OSU. | |
| 14:54:17 | diablo_rojo | But the BU students are already working with gouthamr | |
| 14:54:32 | gtema | okay | |
| 14:55:06 | diablo_rojo | I just got the email calling for projects for NDSU students in the spring so I will start working on putting that together tomorrow probably. | |
| 14:55:20 | gtema | great | |
| 14:55:45 | gtema | I think we would be in time with the switch for nova command toward SDK this cycle - we are maybe 40% through currently | |
| 14:56:22 | gtema | maybe we can also start doing that for cinder as well, since I have a feeling those are now also a bit unhappy with OSC functionality | |
| 14:56:22 | openstackgerrit | Stephen Finucane proposed openstack/python-openstackclient master: Make use of comparable 'FormattableColumn' subclasses https://review.opendev.org/761447 | |
| 14:56:23 | openstackgerrit | Stephen Finucane proposed openstack/python-openstackclient master: compute: Fix 'server * -f yaml' output https://review.opendev.org/761205 | |
| 14:56:23 | openstackgerrit | Stephen Finucane proposed openstack/python-openstackclient master: compute: Fix 'usage * -f yaml' output https://review.opendev.org/761595 | |
| 14:56:24 | openstackgerrit | Stephen Finucane proposed openstack/python-openstackclient master: compute: Fix 'server group * -f yaml' output https://review.opendev.org/761596 | |