| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-sdks - 2020-07-15 | |||
| 07:44:43 | nightmare_unreal | yes amotoki | |
| 07:44:57 | nightmare_unreal | exactly | |
| 07:45:03 | amotoki | nightmare_unreal: yes for which one? | |
| 07:45:09 | nightmare_unreal | you got the point 1st point | |
| 07:45:22 | nightmare_unreal | "I thought something similar before. Is your point to specify a (non-default) field in -c option without --long option, right?" | |
| 07:45:25 | nightmare_unreal | this amotoki ^ | |
| 07:45:57 | amotoki | nightmare_unreal: thanks for clarification. It sounds a good improvement. | |
| 07:46:27 | nightmare_unreal | yeah, that's where I am stuck amotoki . I am not sure where to start | |
| 07:46:41 | nightmare_unreal | should I look into cliff because it shows output or the CLI server.py file | |
| 07:46:47 | nightmare_unreal | where the data is generated | |
| 07:48:11 | nightmare_unreal | i have submitted story here : https://storyboard.openstack.org/#!/story/2007925 | |
| 07:51:21 | amotoki | nightmare_unreal: IIRC fields aree filtered at https://opendev.org/openstack/python-openstackclient/src/branch/master/openstackclient/compute/v2/server.py#L1539 | |
| 07:52:58 | amotoki | nightmare_unreal: "columns" are defined conditionally based on --long option https://opendev.org/openstack/python-openstackclient/src/branch/master/openstackclient/compute/v2/server.py#L1381-L1445 | |
| 07:54:03 | nightmare_unreal | yeah that's where I am confused. If we don't specify --long option how can we even get the output for the columns .because "openstack server list" has limited output | |
| 07:56:03 | amotoki | perhaps it needs some refactoring so that columns specified in -c option are picked up (including a map between a real field name and a display name) | |
| 07:57:14 | amotoki | we also need to consider the consistency across commands.... | |
| 07:57:22 | nightmare_unreal | yeah that too | |
| 07:57:42 | nightmare_unreal | thing is -c option is parsed by cliff | |
| 07:58:09 | nightmare_unreal | https://opendev.org/openstack/cliff/src/branch/master/cliff/display.py#L69 | |
| 08:02:15 | amotoki | nightmare_unreal: so the question is whether cliff app (like OSC command) can access options defined in cliff. | |
| 08:03:00 | nightmare_unreal | yeah , because i don't think -c is handled/accessed by osc cli . ' | |
| 08:03:01 | amotoki | nightmare_unreal: another approach is that cliff provides a convenient function to handle columns. | |
| 08:04:39 | nightmare_unreal | amotoki: not sure this is right approach but can we add argument to parse (-c ) in server.py and search the result based on that ? | |
| 08:05:44 | amotoki | nightmare_unreal: -c option is already parsed. I think you can access the parsed result by parsed_args.columns, can't you? | |
| 08:08:06 | nightmare_unreal | True https://opendev.org/openstack/cliff/src/branch/master/cliff/display.py#L98 but if the column doesn't exist in "openstack server list" or any other command . it will output no recognized column | |
| 08:09:53 | amotoki | nightmare_unreal: I didn't get your point. I think you need to adjust 'columns' in ListServer in server.py to take into account parsed_args.columns. | |
| 08:11:03 | nightmare_unreal | got it amotoki . I understand now. I was assuming the parsed_args.column was not accessible in server.py but it is | |
| 08:11:07 | nightmare_unreal | that makes sense | |
| 08:19:39 | amotoki | nightmare_unreal: :) | |
| 08:19:58 | nightmare_unreal | Thanks :) | |
| 13:12:56 | openstackgerrit | jayaditya gupta proposed openstack/python-openstackclient master: Add a few selectable fields to the "openstack server list" output https://review.opendev.org/741181 | |
| 14:10:23 | openstackgerrit | Lance Bragstad proposed openstack/python-openstackclient master: Bypass user and group verification in RemoveRole https://review.opendev.org/740380 | |
| 18:13:45 | openstackgerrit | Artom Lifshitz proposed openstack/openstacksdk master: WIP: Test and record keypair max microversion https://review.opendev.org/741295 | |
| 19:41:02 | openstackgerrit | Artom Lifshitz proposed openstack/openstacksdk master: Add tests for compute microversion 2.2 and 2.10 https://review.opendev.org/741295 | |
| 19:48:39 | openstackgerrit | Artom Lifshitz proposed openstack/openstacksdk master: Add tests for compute microversion 2.2 and 2.10 https://review.opendev.org/741295 | |
| 19:49:40 | openstackgerrit | Artom Lifshitz proposed openstack/openstacksdk master: Add tests for compute microversion 2.2 and 2.10 https://review.opendev.org/741295 | |
| 21:30:12 | openstackgerrit | manasareddybethi proposed openstack/python-openstackclient master: Fix the functional tests that run example files https://review.opendev.org/741320 | |
| 23:59:11 | openstackgerrit | manasareddybethi proposed openstack/python-openstackclient master: Fix the testcases that try to delete already deleted volume snapshots https://review.opendev.org/741344 | |
| #openstack-sdks - 2020-07-16 | |||
| 12:33:06 | nightmare_unreal | yoctozepto: hey, i saw your comment on https://review.opendev.org/#/c/740455/ . I am not sure but when I pass a custom property it fails to find the image but works in test case | |
| 12:56:04 | yoctozepto | nightmare_unreal: hi, you mean when not patched? strange :S | |
| 12:56:44 | nightmare_unreal | yes, when it's not patched ( the change i submitted). it misses the image but it passes the test case | |
| 12:57:05 | nightmare_unreal | I have provided custom image property architecture=x86_64 to my image . | |
| 12:59:03 | nightmare_unreal | https://usercontent.irccloud-cdn.com/file/VgzQAeVs/image_miss.png | |
| 12:59:20 | nightmare_unreal | yoctozepto: I have uploaded screenshot https://usercontent.irccloud-cdn.com/file/VgzQAeVs/image_miss.png | |
| 13:04:30 | yoctozepto | nightmare_unreal: but have you made a specific test case to test this? | |
| 13:06:15 | nightmare_unreal | yoctozepto: yeah, I only copied the existing test case and just passed the property( arch) but it passes. | |
| 13:06:48 | nightmare_unreal | yoctozepto: here : https://pastebin.com/RKp5w3fd | |
| 13:32:20 | yoctozepto | nightmare_unreal: create another instance that does not have this property | |
| 13:32:25 | yoctozepto | as this is what you are fixing | |
| 13:32:31 | yoctozepto | the diverse instances case | |
| 13:33:48 | nightmare_unreal | okay yoctozepto . i will try and update the patch | |
| 14:19:03 | openstackgerrit | manasareddybethi proposed openstack/python-openstackclient master: Fix the functional tests that run example files https://review.opendev.org/741320 | |
| 14:54:27 | nightmare_unreal | yoctozepto: a stupid question but --property and --image-property are 2 different things right. I mean image has image-property and a sepearate properties right | |
| 15:00:11 | yoctozepto | nightmare_unreal: you mean the instance most likely; it has its own metadata as well as those from the chosen image | |
| 15:00:59 | nightmare_unreal | yoctozepto: so when user set "openstack image set --property " which properties he set ? image-property or user defined custom | |
| 15:01:29 | nightmare_unreal | yoctozepto: let's say i have a custom property "openstack image set --property easy_to_use=yes" | |
| 15:03:47 | yoctozepto | it's a property on the image | |
| 15:03:57 | yoctozepto | and you spin instances off this image | |
| 15:04:08 | yoctozepto | those instances have their own properties as well | |
| 15:04:16 | yoctozepto | hence why two names in there | |
| 15:04:53 | nightmare_unreal | makes sense | |
| 15:05:08 | nightmare_unreal | now I understand why I was facing issue | |
| 15:05:38 | nightmare_unreal | so openstack image create --image-property will only consider these properties : https://docs.openstack.org/glance/rocky/admin/useful-image-properties.html | |
| 15:33:49 | openstackgerrit | Artom Lifshitz proposed openstack/openstacksdk master: Add tests for compute microversion 2.2 and 2.10 https://review.opendev.org/741295 | |
| 16:05:43 | elmiko | API SIG office hour open (a little late) | |
| 16:07:56 | dtantsur | I came today just to quickly wave since I'm going to leave soon :) | |
| 16:08:33 | elmiko | nice to see you, if only briefly =) | |
| 16:08:55 | dtantsur | \o/ | |
| 16:09:02 | dtantsur | how is life? | |
| 16:18:18 | elmiko | not bad, mostly indoors these days XD | |
| 16:19:06 | elmiko | how's things over there? | |
| 16:28:08 | dtantsur | pretty calm, but doesn't feel stable | |
| 16:28:15 | dtantsur | covid-wise, at least | |
| 16:28:32 | dtantsur | otherwise, a nice cool summer (I don't like hot weather) | |
| 16:30:19 | elmiko | ugh, i've been really hopeful that europe was doing much better with covid. | |
| 16:30:41 | elmiko | i'm not a fan of hot weather either, maybe my russian ancestry showing? XD | |
| 16:30:46 | dtantsur | well, it IS going much better, but there is a firm feeling that it's not over | |
| 16:30:49 | dtantsur | heh, right | |
| 16:31:03 | dtantsur | it was actually pretty damn hot in Moscow in summer when I was a child | |
| 16:31:12 | dtantsur | like, up to +40C hot | |
| 16:31:15 | elmiko | whoa! | |
| 16:31:21 | elmiko | that's insane | |
| 16:32:02 | dtantsur | fortunately, the climate change played the other way in this aspect: summers became somewhat cooler and rainy, winters become warmer and rainy | |
| 16:32:18 | dtantsur | (which does not, of course, exclude snow in June) | |
| 16:37:52 | elmiko | wow, seriously, snow in june? | |
| 16:38:09 | dtantsur | yep, happened this year in Moscow | |
| 16:39:45 | elmiko | crazy | |
| 16:40:25 | dtantsur | Russia is all about craziness | |
| 16:40:36 | dtantsur | on this positive note I'll go fetch some dinner :) | |
| 16:40:48 | dtantsur|afk | see you elmiko | |
| 16:40:49 | elmiko | hahaha, enjoy o/ | |
| 16:52:24 | openstackgerrit | manasareddybethi proposed openstack/python-openstackclient master: Fix the testcases that try to delete already deleted volume snapshots https://review.opendev.org/741344 | |
| 17:05:53 | openstackgerrit | manasareddybethi proposed openstack/python-openstackclient master: Fix the functional tests that run example files https://review.opendev.org/741320 | |
| 18:13:22 | openstackgerrit | Artom Lifshitz proposed openstack/openstacksdk master: Add func test for compute microversion 2.3 https://review.opendev.org/741514 | |
| 18:23:28 | openstackgerrit | Artom Lifshitz proposed openstack/openstacksdk master: Add func test for compute microversion 2.3 https://review.opendev.org/741514 | |
| 21:27:35 | openstackgerrit | manasareddybethi proposed openstack/python-openstackclient master: Fix the functional tests that run example files https://review.opendev.org/741320 | |
| #openstack-sdks - 2020-07-17 | |||
| 07:55:55 | openstackgerrit | Hervé Beraud proposed openstack/openstacksdk master: Use unittest.mock instead of mock https://review.opendev.org/734455 | |
| 07:55:55 | openstackgerrit | Hervé Beraud proposed openstack/openstacksdk master: Use unittest.mock instead of mock https://review.opendev.org/734455 | |
| 08:40:47 | openstackgerrit | jayaditya gupta proposed openstack/python-openstackclient master: Fix for image property filter in OSC CLI https://review.opendev.org/740455 | |
| 11:03:10 | nightmare_unreal | can someone review this patch please : https://review.opendev.org/#/c/716960/ | |