Earlier  
Later
New Search
Posted Nick Remark
#openstack-sdks - 2020-06-18
14:25:44 shaohe_feng ^ mordred: what the get_sdk_adapter define
14:26:00 shaohe_feng so why it still use glanceclient ?
14:26:14 shaohe_feng I already change it to get_sdk_adapter
14:26:54 shaohe_feng something wrong when I change it to get_sdk_adapter ？
14:27:27 shaohe_feng mordred can you tell me what should I do?
14:28:02 mordred shaohe_feng: that looks fine - but there is still this: https://github.com/openstack/cyborg/blob/6dab512af226677c9065f85f264a691f3aeb6eab/cyborg/image/glance.py#L129
14:28:11 mordred shaohe_feng: let me look at the code a little more and see if I can make some suggestions
14:28:38 shaohe_feng mordred: thank you.
14:30:07 gtema shaone_feng - I guess you should be targeting dropping your cyborg/image/glance completely and modify cyborg/image/api to use SDK instead
14:31:19 mordred gtema: looking at the master branch, it looks like they're laready doing that
14:31:43 gtema oh, I was looking to the posted particular commit
14:31:45 mordred oh - wait
14:31:47 mordred eah
14:32:22 mordred ZOMG - the method is returning a GlanceClient and calling it a session
14:32:25 gtema even in master there is still from cyborg.image import glance
14:33:05 mordred yup.
14:33:13 mordred I was fooled by "session.delete()"
14:38:02 shaohe_feng gtema: mordred: I'm still use GlanceClient ?
14:39:45 mordred gtema: they're going to nerdsnipe me in to fixing cyborg aren't they?
14:42:46 gtema shaone_feng - you stacktrace exactly points into that
14:42:56 gtema mordred - right
14:42:59 shaohe_feng gtema: mordred: sorry, I'm offline just now. something wrong with my network.
14:43:11 shaohe_feng may I missing something?
14:43:40 gtema shaohe_feng - guess not
14:43:52 mordred shaohe_feng: cyborg.image.api.API._get_session_and_image_id is constructing a Glanceclient object
14:44:05 mordred shaohe_feng: which in turn is used in API.download
14:44:06 shaohe_feng good, so what should I change?
14:44:23 mordred probably the entire cyborg/image/glance.py file
14:44:31 shaohe_feng the FPGA need to download image
14:44:40 gtema yes - drop it and modify the cyborg/image/api
14:44:42 shaohe_feng we need to program the FPGA
14:44:53 shaohe_feng any example for it?
14:44:55 mordred shaohe_feng: I'm going to see if I can make a non-working example patch that can point you in the right direction
14:45:10 shaohe_feng mordred good. thanks.
14:45:34 mordred gtema: it's the same code as from nova, so if we fix it here for cyborg, we'll have a good example of how to fix it for nova too :)
14:45:49 gtema :)
16:02:45 elmiko API SIG office hour open
16:04:39 elmiko mordred: i haven't seen much more activity on the service discovery PRs, i'm going to move towards a freeze and asking for wider review if that sounds good to you?
16:07:31 mordred elmiko: ++
16:07:46 elmiko thank you sir =)
16:09:45 mordred thank you!
16:34:08 elmiko ok, frozen and email sent
16:51:00 dtantsur \o/
17:08:33 elmiko have a good weekend all, stay safe and healthy out there =) o/
22:06:32 openstackgerrit Merged openstack/keystoneauth stable/ussuri: Fix E741 pep8 failure https://review.opendev.org/731188
#openstack-sdks - 2020-06-19
01:41:33 openstackgerrit Lance Bragstad proposed openstack/keystoneauth stable/ussuri: Inject /v3 in token path for v3 plugins https://review.opendev.org/731519
07:30:21 openstackgerrit Artem Goncharov proposed openstack/openstacksdk master: Add support for filters into the project cleanup https://review.opendev.org/735336
07:42:02 openstackgerrit Sagi Shnaidman proposed openstack/ansible-collections-openstack master: New CI jobs configuration https://review.opendev.org/736946
07:46:34 openstackgerrit Sagi Shnaidman proposed openstack/ansible-collections-openstack master: New CI jobs configuration https://review.opendev.org/736946
07:47:55 openstackgerrit Sagi Shnaidman proposed openstack/ansible-collections-openstack master: New CI jobs configuration https://review.opendev.org/736946
07:53:25 openstackgerrit Sagi Shnaidman proposed openstack/ansible-collections-openstack master: New CI jobs configuration https://review.opendev.org/736946
08:32:42 openstackgerrit Artem Goncharov proposed openstack/ansible-collections-openstack master: Add more useful information from exception https://review.opendev.org/736953
10:46:17 openstackgerrit Jens Harbott (frickler) proposed openstack/python-openstackclient master: WIP: Allow more options when creating a router https://review.opendev.org/736973
12:45:51 openstackgerrit Artem Goncharov proposed openstack/openstacksdk master: Add support for filters into the project cleanup https://review.opendev.org/735336
15:56:05 AJaeger could I get a review for https://review.opendev.org/#/c/734852/ - updating docstheme for service-types-authority, please?
15:56:16 AJaeger mordred ^
15:58:06 mordred AJaeger: done
15:58:55 AJaeger thanks!
15:59:00 gtema_ mordred, do you remember what is this networking problem that blocks everything?
16:09:33 openstackgerrit Merged openstack/service-types-authority master: Switch to newer openstackdocstheme version https://review.opendev.org/734852
17:39:41 holser mordred Quick question. Why do we install python-dev on Ubuntu and don't install it for CentOS/RedHat? I am talking about https://opendev.org/zuul/zuul-jobs/src/branch/master/roles/ensure-python/tasks/main.yaml#L9
17:48:50 holser mordred opened https://storyboard.openstack.org/#!/story/2007838
18:35:19 openstackgerrit Sagi Shnaidman proposed openstack/ansible-collections-openstack master: New CI jobs configuration https://review.opendev.org/736946
21:16:09 openstackgerrit Sean McGinnis proposed openstack/openstacksdk stable/ussuri: Update docs to work with newer Sphinx https://review.opendev.org/737083
21:16:30 openstackgerrit Sean McGinnis proposed openstack/openstacksdk stable/ussuri: Don't error if clouds.yaml is not readable https://review.opendev.org/726962
21:17:00 openstackgerrit Sean McGinnis proposed openstack/openstacksdk stable/ussuri: Fix issues found by latest flake8 https://review.opendev.org/730332
21:17:14 openstackgerrit Sean McGinnis proposed openstack/openstacksdk stable/ussuri: Don't error if clouds.yaml is not readable https://review.opendev.org/726962
23:25:26 openstackgerrit Sagi Shnaidman proposed openstack/ansible-collections-openstack master: New CI jobs configuration https://review.opendev.org/736946
#openstack-sdks - 2020-06-20
00:03:15 openstackgerrit Sagi Shnaidman proposed openstack/ansible-collections-openstack master: New CI jobs configuration https://review.opendev.org/736946
00:26:50 mordred holser: I believe that's just a point-in-time thing - nobody has gotten around to doing it for not-debuntu. it would be perfectly appropriate for it to support rh distros too - and I think since it was written there is good unittesting support in zuul-jobs, so it should be easy enough to test that the addition of that support works
06:31:15 openstackgerrit Sagi Shnaidman proposed openstack/ansible-collections-openstack master: New CI jobs configuration https://review.opendev.org/736946
13:22:02 openstackgerrit Sean McGinnis proposed openstack/openstacksdk stable/ussuri: Update docs to work with newer Sphinx https://review.opendev.org/737083
15:33:41 openstackgerrit Monty Taylor proposed openstack/openstacksdk master: WIP Add support for verifying glance image signatures https://review.opendev.org/737135
17:02:22 openstackgerrit Takashi Kajinami proposed openstack/python-openstackclient master: DNM: Implement unit tests for the parent change https://review.opendev.org/737147
20:06:20 openstackgerrit Sagi Shnaidman proposed openstack/ansible-collections-openstack master: New CI jobs configuration https://review.opendev.org/736946
20:47:03 openstackgerrit Sagi Shnaidman proposed openstack/ansible-collections-openstack master: New CI jobs configuration https://review.opendev.org/736946
21:45:58 openstackgerrit Sagi Shnaidman proposed openstack/ansible-collections-openstack master: New CI jobs configuration https://review.opendev.org/736946
#openstack-sdks - 2020-06-21
04:25:46 openstackgerrit Sagi Shnaidman proposed openstack/ansible-collections-openstack master: New CI jobs configuration https://review.opendev.org/736946
06:37:16 openstackgerrit Takashi Kajinami proposed openstack/python-openstackclient master: DNM: Implement unit tests for the parent change https://review.opendev.org/737147
07:47:01 openstackgerrit Sagi Shnaidman proposed openstack/ansible-collections-openstack master: New CI jobs configuration https://review.opendev.org/736946
10:00:15 openstackgerrit Sagi Shnaidman proposed openstack/ansible-collections-openstack master: New CI jobs configuration https://review.opendev.org/736946
12:05:19 openstackgerrit Sagi Shnaidman proposed openstack/ansible-collections-openstack master: New CI jobs configuration https://review.opendev.org/736946
12:49:51 openstackgerrit Sagi Shnaidman proposed openstack/ansible-collections-openstack master: Add volume_info module https://review.opendev.org/735949
13:21:15 openstackgerrit Sagi Shnaidman proposed openstack/ansible-collections-openstack master: New CI jobs configuration https://review.opendev.org/736946
15:18:54 openstackgerrit Sagi Shnaidman proposed openstack/ansible-collections-openstack master: New CI jobs configuration https://review.opendev.org/736946
16:18:56 openstackgerrit Sagi Shnaidman proposed openstack/ansible-collections-openstack master: New CI jobs configuration https://review.opendev.org/736946
19:09:36 openstackgerrit Maysa de Macedo Souza proposed openstack/ansible-collections-openstack master: Add trunk module https://review.opendev.org/737190
#openstack-sdks - 2020-06-22
00:56:27 openstackgerrit Sagi Shnaidman proposed openstack/ansible-collections-openstack master: New CI jobs configuration https://review.opendev.org/736946
07:13:27 openstackgerrit Lewis Denny proposed openstack/python-openstackclient master: Add API check for server_groups.create https://review.opendev.org/736104
07:46:11 openstackgerrit Sagi Shnaidman proposed openstack/ansible-collections-openstack master: DNM test new CI https://review.opendev.org/737226
08:01:09 openstackgerrit jayaditya gupta proposed openstack/cliff master: Output correct json for security groups in 'openstack server show' https://review.opendev.org/735128
08:44:55 openstackgerrit Sagi Shnaidman proposed openstack/ansible-collections-openstack master: DNM test new CI https://review.opendev.org/737226
11:17:43 dtantsur mordred: hey, could you please check https://review.opendev.org/#/c/727562/ again when you have a minute?
13:15:49 mordred dtantsur: ooh, it's green!
13:15:59 dtantsur :)
13:16:03 dtantsur happens, yeah?
13:16:51 mordred :)
13:16:57 mordred I think that's a super cool patch
13:17:02 gtema what is green? everything? we can recheck? I don't believe - it's monday
13:19:35 mordred gtema: quick, just approve things while it lasts ;)

Earlier   Later