Earlier  
Later
New Search
Posted Nick Remark
#openstack-sdks - 2020-06-08
14:22:07 gtema agree
14:22:47 nightmare_unreal frickler: hey , if you get time. Can you read my comment here : https://review.opendev.org/#/c/733573/ . Basically it's regarding that it's cliff that handles the output formatting . So the problem is not in osc-client per se ( I think)
14:22:50 mordred gtema: and yes - the osc patch there updates the tips job to include cliff
14:23:35 gtema we need same for sdk, osc-lib and cliff
14:24:02 gtema we will have pretty much changes soon and it becomes madness
14:26:34 openstackgerrit Monty Taylor proposed openstack/python-openstackclient master: Add cliff to libs-from-git for devstack functional tips https://review.opendev.org/734095
14:26:35 openstackgerrit Monty Taylor proposed openstack/python-openstackclient master: Remove os-client-config references https://review.opendev.org/734097
14:27:22 mordred gtema: when you say "need same" - what do you mean? you mean updating the jobs there to make sure it's all good?
14:27:37 mordred also - there's a "fun" thing about osc and devstack jobs that I don't think we've fully captured in our test jobs yet
14:28:17 gtema oh, I missed definition of the functional-devstack-tips. I thought it was not taking libs from git, but only release ones
14:28:38 mordred we have "release vs src" - and we have that for both devstack/openstack itself, as well as the client stuff installed into the tox virtualenv
14:28:56 gtema yes, now I see
14:44:00 frickler nightmare_unreal: well if you think you can fix this in cliff, go ahead.
14:50:52 dtantsur mordred: hey, do you remember from the top of your head, if OS_AUTH_URL has /v3/ in the end, do we trim it in keystoneauth?
14:50:57 dtantsur this is re https://github.com/dtantsur/rust-openstack/issues/114
14:51:29 gtema in my case it has v3
14:51:53 mordred dtantsur: we don't trim it if we're looking for version 3
14:52:21 mordred dtantsur: I think the only time we trim it and use unversioned is if someone requests v2
14:52:29 dtantsur gotcha
14:52:39 mordred because /v3 should also contain a versioned discovery doc
14:53:48 dtantsur https://github.com/dtantsur/rust-osauth/blob/master/src/identity.rs#L226 doesn't account for a trailing slash #facepalm
14:54:06 mordred dtantsur: hah
14:54:15 dtantsur this project has a loong way ahead in terms of robustness
14:54:22 dtantsur on the other hand, people are using it \o/
14:54:25 mordred dtantsur: this comes back to the ptg discussion about trailing vs non-trailing in catalogs
14:54:27 mordred dtantsur: \o/
14:54:38 mordred I pinged sdague about that btw and he did not remember
14:55:08 dtantsur too much time has passed
14:55:48 mordred yah. I remember having a summit discussion at some summit. I mostly remember that the room was downstairs
14:55:59 mordred but I don't remember which city ... maybe it was atlanta?
14:56:17 mordred might have been paris
14:56:31 mordred or hong kong
14:56:47 gtema_ :D
15:33:06 openstackgerrit Merged openstack/ansible-collections-openstack master: Add setup.py for install with pip https://review.opendev.org/730400
15:34:47 openstackgerrit Monty Taylor proposed openstack/cliff master: Add load_plugins option https://review.opendev.org/733961
15:36:15 openstackgerrit Monty Taylor proposed openstack/osc-lib master: Remove commandmanager subclass https://review.opendev.org/734000
15:38:46 mordred gtema: sorry - I missed this one in the topic: https://review.opendev.org/#/c/733968/1
15:39:42 gtema done
15:39:57 gtema feel free to set +A yourself
15:40:26 mordred gtema: thansk!
15:41:38 mordred gtema: so - with the cliff patch, the idea is that in osc we'll have a file that has a ton of "commandmanager.add_command" calls pointing to the classes in-tree rather than registering our own plugins as entrypoints
15:42:00 mordred then, since cliff will first attempt to resolve those from what it knows before scanning entrypoints
15:42:23 mordred for the common case we can avoid the entrypoint cost- and only take that cost if someone asks for a command tha we don't know
15:42:36 gtema yupp, makes sense
16:20:38 openstackgerrit Monty Taylor proposed openstack/cliff master: Add load_plugins option https://review.opendev.org/733961
16:40:14 smcginnis mordred: Hey there. Doing a search on requirements, I can't find any repos that have shade declaring it as a dependency in their requirements files. Does that seem right?
16:40:43 mordred smcginnis: yeah - I don't think anything should be depending on shade at this point
16:40:58 mordred smcginnis: everything that used to should be depending on openstacksdk at this point
16:41:01 mordred smcginnis: same with os-client-config
16:41:09 smcginnis OK, great. Another one I can clean out of global reqs then.
16:41:28 mordred smcginnis: we're probably in a good place to change the release model for them now too
16:41:39 mordred smcginnis: maybe just to independent?
16:42:11 smcginnis mordred: If you think it will only need occasional releases from time to time, that may be better.
16:44:09 mordred smcginnis: yeah- the're mostly on life-support for backwards compat
16:44:17 mordred they definitely don't need cycle based releases
16:46:51 smcginnis mordred: cinder
16:46:57 smcginnis Darn clipboard.
16:47:01 smcginnis mordred: https://review.opendev.org/734149
17:18:40 openstackgerrit Merged openstack/cliff master: Remove python3.5 https://review.opendev.org/733968
17:18:40 openstackgerrit Merged openstack/cliff master: Migrate to stestr https://review.opendev.org/733969
17:18:41 openstackgerrit Merged openstack/cliff master: Remove unneeded tests https://review.opendev.org/733970
18:44:55 mordred mnaser, dtantsur|afk, smcginnis: if you get a sec, mind reviewing https://review.opendev.org/#/c/733964 ? It's mostly just moving code from osc-lib to cliff so that we can remove it from osc-lib and then do a followup which will let us optimize osc by skipping entrypoints loading for common cases
19:04:59 dmsimard hey o/ maybe I'm blind but I can't find an openstacksdk method that maps to keystone's /v3/users/{user_id}/projects ? https://docs.openstack.org/api-ref/identity/v3/?expanded=list-users-detail,list-projects-for-user-detail#list-projects-for-user
19:05:06 dmsimard looking at the openstacksdk docs from https://docs.openstack.org/openstacksdk/latest/user/proxies/identity_v3.html#user-operations
19:11:34 dmsimard I guess I found https://opendev.org/openstack/openstacksdk/src/branch/master/openstack/identity/v3/_proxy.py#L507-L520 but not seeing in the docs :p
19:33:39 mordred dmsimard: we might just not have it linked in the docs :(:
19:36:52 openstackgerrit Monty Taylor proposed openstack/openstacksdk master: Add user_projects method to docs index https://review.opendev.org/734183
19:37:08 openstackgerrit Monty Taylor proposed openstack/openstacksdk master: Add user_projects method to docs index https://review.opendev.org/734183
19:37:13 mordred dmsimard: ^^ thanks!
19:38:22 dmsimard \o/
21:18:06 openstackgerrit Monty Taylor proposed openstack/python-openstackclient master: Add cliff to libs-from-git for devstack functional tips https://review.opendev.org/734095
21:20:45 openstackgerrit Monty Taylor proposed openstack/python-openstackclient master: Remove os-client-config references https://review.opendev.org/734097
21:34:35 openstackgerrit Monty Taylor proposed openstack/python-openstackclient master: identity: autogenerate docs https://review.opendev.org/692931
21:34:35 openstackgerrit Monty Taylor proposed openstack/python-openstackclient master: image: autogenerate docs https://review.opendev.org/693025
21:49:24 mordred amotoki: if you get some time, would you mind reviewing https://review.opendev.org/#/c/733964/ ? the more important bits are the followup change which won't start working until https://review.opendev.org/#/c/734000/ is landed, but that won't start working until we release osc-lib with the first change :)
21:50:05 mordred then once all of that is in and happy, we can make an osc patch to register the in-tree plugins with add_command and skip the entrypoint scan cost for most of the commands
22:06:35 openstackgerrit Hervé Beraud proposed openstack/cliff master: drop mock from lower-constraints and requirements https://review.opendev.org/734326
22:58:27 openstackgerrit Merged openstack/osc-lib master: Add get_osc_show_columns_for_sdk_resource function https://review.opendev.org/698874
23:17:53 openstackgerrit Merged openstack/python-openstackclient master: Add OpenStack Client for Manila docs https://review.opendev.org/706252
23:18:22 openstackgerrit Hervé Beraud proposed openstack/keystoneauth master: drop mock from lower-constraints https://review.opendev.org/734359
23:40:27 openstackgerrit Merged openstack/openstacksdk master: Extend statistics reporting https://review.opendev.org/727097
#openstack-sdks - 2020-06-09
00:21:52 openstackgerrit Merged openstack/python-openstackclient stable/train: Resolve PEP8 https://review.opendev.org/732437
00:21:53 openstackgerrit Merged openstack/python-openstackclient master: Make container list --all work https://review.opendev.org/728366
01:05:03 openstackgerrit Gabriel Ramirez proposed openstack/python-openstackclient master: Allow openstack flavor set to update flavor description using name https://review.opendev.org/733688
01:17:27 openstackgerrit Gabriel Ramirez proposed openstack/python-openstackclient master: Allow openstack flavor set to update flavor description using name https://review.opendev.org/733688
02:10:28 openstackgerrit Merged openstack/python-openstackclient master: Add cliff to libs-from-git for devstack functional tips https://review.opendev.org/734095
02:10:30 openstackgerrit Merged openstack/python-openstackclient master: identity: autogenerate docs https://review.opendev.org/692931
02:10:31 openstackgerrit Merged openstack/python-openstackclient master: image: autogenerate docs https://review.opendev.org/693025
05:50:43 openstackgerrit Merged openstack/openstacksdk master: Add user_projects method to docs index https://review.opendev.org/734183
08:50:10 openstackgerrit Daniel Bengtsson proposed openstack/osc-lib master: Stop configuring install_command in tox and stop use pip. https://review.opendev.org/694510
08:52:11 openstackgerrit Hervé Beraud proposed openstack/openstacksdk master: Use unittest.mock instead of mock https://review.opendev.org/734455
09:43:10 openstackgerrit Artem Goncharov proposed openstack/python-openstackclient master: [POC] project cleanup https://review.opendev.org/734485
10:11:40 openstackgerrit Vishakha Agarwal proposed openstack/openstacksdk master: Add access rule CRUD support https://review.opendev.org/734549
10:12:27 openstackgerrit Hervé Beraud proposed openstack/shade master: Use unittest.mock instead of mock https://review.opendev.org/734552
10:13:57 openstackgerrit Sagi Shnaidman proposed openstack/ansible-collections-openstack master: Add notes to README about deps and versions https://review.opendev.org/734557
10:14:22 openstackgerrit Vishakha Agarwal proposed openstack/openstacksdk master: Add access rule CRUD support https://review.opendev.org/734549
10:16:00 openstackgerrit wu.chunyang proposed openstack/cliff master: remove mock from requirements https://review.opendev.org/734566
10:17:53 openstackgerrit Vishakha Agarwal proposed openstack/openstacksdk master: Add access rule CRUD support https://review.opendev.org/734549
11:10:52 openstackgerrit subham rai proposed openstack/openstacksdk master: baremetal: support for volume connectors API https://review.opendev.org/718746
12:09:13 openstackgerrit Sagi Shnaidman proposed openstack/ansible-collections-openstack master: Add notes to README about deps and versions https://review.opendev.org/734557

Earlier   Later