Earlier  
Later
New Search
Posted Nick Remark
#openstack-sdks - 2020-04-17
21:05:58 AJaeger sorry, enough on that - need to leave now...
21:10:25 smcginnis AJaeger: Have a good weekend!
21:11:15 smcginnis Maybe we can invoke Doug for more background. The concepts behind this were probably lost due to not having openstack-specs anymore. Or at least some other good place to write it all down.
21:37:39 openstackgerrit Merged openstack/python-openstackclient master: Use unittest.mock instead of third party mock https://review.opendev.org/717410
#openstack-sdks - 2020-04-18
21:17:09 openstackgerrit Sean McGinnis proposed openstack/keystoneauth master: Use unittest.mock instead of third party mock https://review.opendev.org/720925
#openstack-sdks - 2020-04-19
13:59:01 openstackgerrit Monty Taylor proposed openstack/keystoneauth master: Re-add python3.5 testing https://review.opendev.org/721084
14:05:09 openstackgerrit Merged openstack/keystoneauth master: Update master for stable/ussuri https://review.opendev.org/717030
15:23:37 mordred AJaeger: is there a reason for openstackdocstheme to be in test-requirements in addition to doc/requirements.txt?
15:26:45 openstackgerrit Monty Taylor proposed openstack/keystoneauth master: Re-add python3.5 testing https://review.opendev.org/721084
15:29:48 AJaeger mordred: yes - one I don't agree with ;) Let me give you apointer..
15:30:28 AJaeger more correct would be to only add reno, since when I removed it I got pointed to:
15:30:30 AJaeger https://docs.openstack.org/reno/latest/user/usage.html
15:30:36 AJaeger tox -e venv -- reno new slug-goes-here
15:30:48 AJaeger That's expected to work for many repos.
15:31:07 AJaeger So, I think we can remove docstheme and keep reno - but never checked that
15:31:19 openstackgerrit Monty Taylor proposed openstack/keystoneauth master: Re-add python3.5 testing https://review.opendev.org/721084
15:32:15 AJaeger so, try keeping reno in if you want
15:32:30 mordred AJaeger: ah - nod
15:32:44 mordred wow - people use tox -evenv to run the reno command?
15:32:56 AJaeger apparently
15:33:37 AJaeger mordred: but not every repo has in in test-requirements. Seems project specific
15:33:39 openstackgerrit Monty Taylor proposed openstack/keystoneauth master: Re-add python3.5 testing https://review.opendev.org/721084
15:34:20 mordred AJaeger: well - I don't feel strongly about removing reno :) -- I *do* need to remove openstackdocstheme because it doesn't support 3.5 - but we also don't need it there
15:35:16 AJaeger yeah, you can remove it or go to version 1.31.2 as well. Your change LGTM. Thanks for fixing!
15:36:04 mordred AJaeger: thanks!
#openstack-sdks - 2020-04-20
11:22:53 openstackgerrit Merged openstack/ansible-collections-openstack master: Moved openstack inventory script from community.general https://review.opendev.org/719429
15:50:28 nightmare_unreal quick question, If i want to add a new command to openstackclient where should I look into ? for e.g. openstack hypervisor list is an existing cmd. I want to add openstack migration list to it.
15:50:41 nightmare_unreal basically registering new command.
15:51:06 dtantsur nightmare_unreal: the commands are listed in setup.cfg
15:51:33 nightmare_unreal so during runtime openstackclient looks at setup.cfg ?
15:51:59 dtantsur nightmare_unreal: VERY roughly speaking, yes
15:52:16 dtantsur (it actually goes through the python's entry point mechanism)
15:52:28 nightmare_unreal hmm okay. Thanks :) .
15:52:56 dtantsur nightmare_unreal: check https://docs.openstack.org/stevedore/latest/user/index.html if you're curious
15:53:23 nightmare_unreal Thanks a lot :D
17:14:28 AJaeger cmurphy: could you review this keystoneauth change, please? https://review.opendev.org/720742
17:17:51 cmurphy AJaeger: done
17:18:34 AJaeger thanks, cmurphy
18:47:24 openstackgerrit Merged openstack/keystoneauth master: Cleanup py27 support https://review.opendev.org/720742
19:37:48 johnsom Is anyone else getting py36/py37 failures on the openstack.tests.unit.baremetal.v1.test_proxy.TestWaitForNodesProvisionState.test_timeout_and_failures_not_fail test for openstacksdk?
19:38:15 johnsom One of the students I am mentoring pointed out that master seems to have a problem with that test.
19:38:44 johnsom https://www.irccloud.com/pastebin/w06wGSwb/
19:42:07 smcginnis johnsom: Just ran py37 and it passes for me.
19:42:30 johnsom Hmm, how odd. I could reproduce the problem he was seeing.
19:42:50 johnsom (That paste above was from running local for me)
19:42:57 smcginnis Hmm, very odd.
19:43:22 smcginnis Double checked. I'm on master and up to date.
19:43:37 smcginnis py38 passed too. Don't think I have py36 on this machine.
19:44:09 smcginnis This is odd too: expected str instance, Mock found
19:44:32 smcginnis johnsom: What do you get with .tox/py37/bin/pip freeze | grep -i mock
19:45:03 johnsom $ .tox/py37/bin/pip freeze | grep -i mock
19:45:03 johnsom mock==3.0.5
19:45:03 johnsom requests-mock==1.7.0
19:45:23 smcginnis Hmm, same.
19:45:36 johnsom Yeah, mine is a fresh clone
19:46:09 smcginnis Trying "git clean -f; tox -re py37"
19:47:04 johnsom I will, but given it's a completely fresh directory/clone seems like it's already there.
19:47:21 smcginnis No, saying I was going to try that to see if it's something in mine. :)
19:47:27 johnsom Oh, I wonder if it pulled from github at that sync issue is at play. It's an old alias
19:47:33 smcginnis And no, that didn't make any difference. My local run still passed.
19:47:56 smcginnis What's the commit hash of HEAD?
19:48:01 johnsom Nope, it pulled from opendev
19:49:33 johnsom a53edeeaac286124f2e9a212ea95c8643a96f256
19:51:25 smcginnis OK, yep. That's what I'm at as well.
19:51:31 johnsom It is not the out-of-sync issue for sure, cloned from both, both bomb on 3.7
19:52:58 smcginnis johnsom: If you want to stare and compare for any other differences: http://paste.openstack.org/show/792433/
19:53:25 smcginnis Seems like it has to be an evironmental difference issue.
19:55:41 johnsom Yeah, no difference in the list other than you cloned from github
19:56:16 smcginnis Wow, must be an old one.
20:00:02 smcginnis Fresh clone from opendev.org into a new directory. Still passes for me.
20:00:09 smcginnis So something else different in the environment.
20:00:12 johnsom Hmm, the failure seems legit at a quick review. There is '3' in sequence, so I can see how a mock would be there.
20:03:56 johnsom Yeah, the '3' in the list does in fact cause a mock object to go into the remaining list which the debug tries to get an id from.
20:07:09 johnsom Hm, no, it's the ID which is an int
20:18:42 johnsom smcginnis Which python3 are you running? I have python3.7 3.7.5-2~18.04
20:21:06 johnsom Hmm, fails on my fedora host as well
20:33:41 smcginnis johnsom: Python 3.7.6
20:34:01 johnsom python3-3.7.6-2.fc31.x86_64 on fedora
20:34:21 smcginnis Yeah, that's probably exactly what I have on this machine.
20:35:06 johnsom This is so odd, I can do a for-in and print the id number fine, but if it's in the shorthand it blows up.
21:48:31 openstackgerrit Noah Mickus proposed openstack/openstacksdk master: Add cipher list support for octavia https://review.opendev.org/721351
#openstack-sdks - 2020-04-21
06:51:41 frickler johnsom: smcginnis: FYI that seems to be some weird test-case interaction. if I just run the one single brokenish test, it fails 100% for me.
06:51:58 frickler running "tox -e py37 -- openstack.tests.unit.baremetal.v1.test_proxy" fails about 20% of the time only
06:53:04 frickler so my intermediate conclusion is that the test is indeed broken, but some of the surrounding mocking is covering that up
06:54:49 frickler dtantsur|afk: ^^ seems you wrote most of that, see https://www.irccloud.com/pastebin/w06wGSwb/ for the failure occuring when you run just that single test
08:23:58 nightmare_unreal hello I am trying to add server-migration-list cmd of nova to openstackclient. I can't seem to figure out how to add it to openstackclient ( I don't mean implmentation)
08:24:25 nightmare_unreal for e.g. openstack server migrate is a valid cmd. I want to add openstack server migration-list (something like this)
08:30:05 openstackgerrit Masayuki Igawa proposed openstack/cliff master: Switch to use stestr https://review.opendev.org/721545
08:39:05 openstackgerrit Masayuki Igawa proposed openstack/cliff master: Switch to use stestr https://review.opendev.org/721545
08:46:56 openstackgerrit Masayuki Igawa proposed openstack/cliff master: Switch to use stestr https://review.opendev.org/721545
09:01:36 dtantsur frickler: hey, sure, will check
10:21:04 openstackgerrit Dmitry Tantsur proposed openstack/openstacksdk master: Fix an unstable bare metal unit test https://review.opendev.org/721566
10:21:05 dtantsur frickler, mordred ^^
10:55:21 frickler dtantsur: lgtm, thx
11:13:46 gtema lgtm as well, as soon as tests are there will put a vote
11:21:03 dtantsur also looking for a 2nd +2 on https://review.opendev.org/#/c/720701/
11:21:25 gtema will be there when tests arrive :D
11:22:49 dtantsur the 2nd one has passed CI quite a while ago, no?
11:27:09 openstackgerrit Sagi Shnaidman proposed openstack/ansible-collections-openstack master: Convert os_server_info to use OpenStackModule https://review.opendev.org/721580
12:13:11 gtema facepalm - you patch will not pass unless we fix our docs

Earlier   Later