Earlier  
Later
New Search
Posted Nick Remark
#openstack-sdks - 2020-03-30
13:04:20 openstackgerrit Merged openstack/os-api-ref master: Update hacking for Python3 https://review.opendev.org/715649
13:22:15 gtema|afk aren't we having "too much" jobs for SDK? I agree every single is required, but it grows and grows
13:30:30 mordred gtema: the list is definitely growing
13:31:32 mordred gtema: we might need to start thinking about applying file matchers to some of them - you know, run _everything_ when we touch proxy or resource or connection, but if we're only touching ironic files we can probably just run the ironic jobs, etc
13:31:45 gtema yupp - definitely
13:46:54 openstackgerrit Merged openstack/ansible-collections-openstack master: Add SDK version to tests conditions https://review.opendev.org/715620
13:53:39 openstackgerrit Merged openstack/openstacksdk master: Re-add nodepool functional test https://review.opendev.org/715245
14:20:03 openstackgerrit Bence Romsics proposed openstack/python-openstackclient master: Add command: router add/remove route --route https://review.opendev.org/674325
15:00:02 openstackgerrit Andreas Jaeger proposed openstack/openstackclient master: Update to hacking 3.0 https://review.opendev.org/715975
15:08:22 openstackgerrit Merged openstack/openstacksdk stable/train: Add ansible collection job to train branch https://review.opendev.org/714077
15:11:00 openstackgerrit Merged openstack/openstacksdk stable/train: Add tests for Ansible built-in modules in 2.8,2.9 https://review.opendev.org/714089
15:43:07 openstackgerrit Andreas Jaeger proposed openstack/osc-lib master: Update to hacking 3.0 https://review.opendev.org/715986
15:44:22 openstackgerrit Jeffrey Zhang proposed openstack/openstacksdk stable/train: Bump baremetal max_version from 1.52 to 1.58 https://review.opendev.org/715990
15:45:55 mordred dtantsur: ^^ ?
15:46:15 dtantsur looking
15:46:16 mordred dtantsur: seems fine to me - but you're smarter than I am
15:46:28 dtantsur unlikely, I'm better at pretending smart at best :)
15:47:58 dtantsur bloody microversions, they confuse the hell out of me all the time
15:48:15 dtantsur this may even work after the recent backports. but I need to think more.
15:54:55 mordred kk
17:09:26 openstackgerrit Mark Chappell proposed openstack/ansible-collections-openstack master: New module: os_keystone_mapping_info https://review.opendev.org/713686
17:09:27 openstackgerrit Mark Chappell proposed openstack/ansible-collections-openstack master: New Module: os_keystone_identity_provider https://review.opendev.org/714632
17:09:28 openstackgerrit Mark Chappell proposed openstack/ansible-collections-openstack master: New Module: os_keystone_identity_provider_info https://review.opendev.org/714633
17:09:29 openstackgerrit Mark Chappell proposed openstack/ansible-collections-openstack master: New Module: os_keystone_federation_protocol https://review.opendev.org/714991
17:09:30 openstackgerrit Mark Chappell proposed openstack/ansible-collections-openstack master: New Module: os_keystone_federation_protocol_info https://review.opendev.org/714992
17:18:46 sshnaidm dtantsur|afk, mordred can we please merge last job for stein? https://review.opendev.org/#/c/714087/
17:18:57 sshnaidm so we have all but rocky covered
17:36:35 openstackgerrit Pedro Henrique Pereira Martins proposed openstack/python-openstackclient master: Add description field to portforwarding NAT rules https://review.opendev.org/714512
18:00:57 openstackgerrit Andreas Jaeger proposed openstack/python-openstackclient master: Cleanup Python 2.7 support https://review.opendev.org/715446
18:30:15 openstackgerrit Vishakha Agarwal proposed openstack/python-openstackclient master: Add resource option immutable https://review.opendev.org/715269
18:38:19 openstackgerrit Vishakha Agarwal proposed openstack/python-openstackclient master: Add resource option immutable https://review.opendev.org/715269
19:26:28 openstackgerrit Merged openstack/openstacksdk stable/train: Bump baremetal max_version from 1.52 to 1.58 https://review.opendev.org/715990
19:55:36 openstackgerrit Slawek Kaplonski proposed openstack/python-openstackclient master: Add description field to portforwarding NAT rules https://review.opendev.org/714512
20:22:04 openstackgerrit Merged openstack/openstacksdk stable/stein: Add tests for Ansible built-in modules in 2.8,2.9 https://review.opendev.org/714087
22:03:35 openstackgerrit Slawek Kaplonski proposed openstack/python-openstackclient master: Add description field to portforwarding NAT rules https://review.opendev.org/714512
#openstack-sdks - 2020-03-31
07:52:09 openstackgerrit Lajos Katona proposed openstack/python-openstackclient master: Add description field to portforwarding NAT rules https://review.opendev.org/714512
10:04:24 openstackgerrit Merged openstack/openstackclient master: Update to hacking 3.0 https://review.opendev.org/715975
10:05:40 openstackgerrit Tom Stappaerts proposed openstack/python-openstackclient master: Support for stateless security groups https://review.opendev.org/711515
11:24:53 openstackgerrit Merged openstack/osc-lib master: Update to hacking 3.0 https://review.opendev.org/715986
11:44:12 openstackgerrit Andreas Jaeger proposed openstack/openstacksdk master: Update to hacking 3.0 https://review.opendev.org/716259
11:46:08 openstackgerrit Merged openstack/openstacksdk master: Fix the wrong doc use oslo_conf param https://review.opendev.org/683296
11:57:37 nightmare_unreal where can I find implementation for this : https://docs.openstack.org/nova/pike/admin/live-migration-usage.html
11:57:44 nightmare_unreal in python-openstackclient
12:03:31 nightmare_unreal found it nvm
12:06:53 openstackgerrit Pedro Henrique Pereira Martins proposed openstack/python-openstackclient master: Add description field to portforwarding NAT rules https://review.opendev.org/714512
14:04:40 openstackgerrit Pedro Henrique Pereira Martins proposed openstack/python-openstackclient master: Add description field to portforwarding NAT rules https://review.opendev.org/714512
14:11:49 nightmare_unreal I have a question. correct me If i am wrong openstackclient/compute/v2/server.py : https://github.com/openstack/python-openstackclient/blob/master/openstackclient/compute/v2/server.py
14:11:49 nightmare_unreal is calling https://github.com/openstack/python-novaclient/novaclient/v2/shell.py for all of it's migration operations right ?
15:11:50 openstackgerrit Andreas Jaeger proposed openstack/keystoneauth master: Update hacking for Python3 https://review.opendev.org/716334
15:18:02 openstackgerrit Merged openstack/openstacksdk master: Update to hacking 3.0 https://review.opendev.org/716259
15:31:23 mordred nightmare_unreal: yes
15:32:05 nightmare_unreal mordred: but how is it calling not sure, It's not in imported too
15:32:46 mordred nightmare_unreal: it's done as part of the ClientManager class - https://github.com/openstack/python-openstackclient/blob/master/openstackclient/compute/v2/server.py#L1703
15:33:01 mordred self.app.client_manager.compute is an instance of the novaclient.Client object
15:33:42 mordred nightmare_unreal: https://github.com/openstack/python-novaclient/blob/master/novaclient/v2/client.py#L47
15:33:48 nightmare_unreal Thanks :) , I will look into it
15:33:58 mordred so - actually I lied - it's not calling anything in novaclient shell.py - it's using Client in client.py
15:34:13 mordred (this is all going to change fwiw - but for now that is how it works ;) )
15:34:37 nightmare_unreal okay
15:35:46 nightmare_unreal understood, I wanted to implement some missing functionalities in openstack cli
15:35:52 nightmare_unreal that are in novaclient
15:49:03 mordred awesome!
15:55:10 nightmare_unreal :)
16:16:03 dtruong hi. can I get a review on this: https://review.opendev.org/#/c/715255/
16:38:44 smcginnis dtruong: Probably good to fix the test failures first.
17:08:33 mordred dtruong: yeah - it looks ok - other than the test failures :)
17:16:40 openstackgerrit Pedro Henrique Pereira Martins proposed openstack/python-openstackclient master: Add description field to portforwarding NAT rules https://review.opendev.org/714512
17:31:28 dtruong ok, thanks. The test failures seem to be unrelated to my changes. So just keep rechecking until it passes?
17:45:59 smcginnis dtruong: Yeah, unfortunately. If the failure comes back as the same thing consistently, then we probably have something that snuck in that needs to be fixed first.
18:02:36 mordred the previous failure has been fixed in devstack
18:02:44 mordred so this one shold be green
18:11:55 openstackgerrit Andreas Jaeger proposed openstack/keystoneauth master: Update hacking for Python3 https://review.opendev.org/716334
19:49:36 openstackgerrit Pedro Henrique Pereira Martins proposed openstack/python-openstackclient master: Add description field to portforwarding NAT rules https://review.opendev.org/714512
20:38:42 dtruong Ok, the test failures are gone. Thanks for the help. Appreciate any reviews on it: https://review.opendev.org/#/c/715255/
22:00:58 openstackgerrit Duc Truong proposed openstack/ansible-collections-openstack master: Add properties for os_project https://review.opendev.org/715266
22:06:46 openstackgerrit Duc Truong proposed openstack/ansible-collections-openstack master: Add properties for os_project https://review.opendev.org/715266
23:50:29 openstackgerrit Merged openstack/openstacksdk master: Remove kwargs validation for identity project updates https://review.opendev.org/715255
#openstack-sdks - 2020-04-01
00:54:19 openstackgerrit Duc Truong proposed openstack/ansible-collections-openstack master: Add properties for os_project https://review.opendev.org/715266
02:39:09 openstackgerrit Merged openstack/python-openstackclient master: Cleanup Python 2.7 support https://review.opendev.org/715446
03:47:33 openstackgerrit wangshenqiang proposed openstack/openstacksdk master: fixbug: error when import queue, supoort py2 & py3 at the same time. https://review.opendev.org/716479
07:19:09 openstackgerrit Merged openstack/keystoneauth master: Update hacking for Python3 https://review.opendev.org/716334
07:37:43 openstackgerrit Daniel Bengtsson proposed openstack/osc-lib master: Fix the requirement of keystoneauth1. https://review.opendev.org/695022
09:39:20 nightmare_unreal stephenfin: ping
09:45:08 AJaeger nightmare_unreal: please don't leave naked pings, see https://blogs.gnome.org/markmc/2014/02/20/naked-pings/
09:45:40 AJaeger nightmare_unreal: best to just leave a message and either stephenfin will answer later or somebody else might be able to help
09:45:57 nightmare_unreal okay , understood :)
09:48:57 nightmare_unreal can this be merged ? https://review.opendev.org/#/c/713881/ , it's code review is done too
09:51:27 gtema nightmare_unreal: I would really need to see a functional test for that in https://opendev.org/openstack/python-openstackclient/src/branch/master/openstackclient/tests/functional/common/test_quota.py
09:55:01 AJaeger nightmare_unreal: we need two +2s, so stephenfin would not merge it, another reviewer is needed to give a +2 and approve
09:55:44 AJaeger gtema: isn't there a test in https://review.opendev.org/#/c/713881/10/openstackclient/tests/unit/common/test_quota.py ?
09:55:56 gtema this is just unit test
09:55:59 nightmare_unreal okay I thought one just need +2 .
09:56:09 AJaeger gtema: Ah, unit vs functional
09:56:13 openstackgerrit Mark Chappell proposed openstack/ansible-collections-openstack master: New module: os_keystone_mapping_info https://review.opendev.org/713686
09:56:14 openstackgerrit Mark Chappell proposed openstack/ansible-collections-openstack master: New Module: os_keystone_identity_provider https://review.opendev.org/714632
09:56:16 openstackgerrit Mark Chappell proposed openstack/ansible-collections-openstack master: New Module: os_keystone_identity_provider_info https://review.opendev.org/714633
09:56:17 openstackgerrit Mark Chappell proposed openstack/ansible-collections-openstack master: New Module: os_keystone_federation_protocol https://review.opendev.org/714991
09:56:18 openstackgerrit Mark Chappell proposed openstack/ansible-collections-openstack master: New Module: os_keystone_federation_protocol_info https://review.opendev.org/714992
09:56:19 openstackgerrit Mark Chappell proposed openstack/ansible-collections-openstack master: os_keystone_mapping: fixup some minor nits found in followup reviews https://review.opendev.org/716537
09:56:31 gtema in the current situation with team merges I guess we should not trust on only unit, since there is still no big understanding

Earlier   Later