Earlier  
Later
New Search
Posted Nick Remark
#openstack-sdks - 2020-03-29
02:39:22 openstackgerrit Lichao Xue proposed openstack/openstacksdk master: Fix ImportError No module named queue in python2.7 env. https://review.opendev.org/715671
02:40:58 openstackgerrit Lichao Xue proposed openstack/openstacksdk master: Fix ImportError No module named queue in python2.7 env. https://review.opendev.org/715671
03:54:19 openstackgerrit Akihiro Motoki proposed openstack/os-api-ref master: Update sphinx-testing requirements to >=1.0.1 https://review.opendev.org/715673
04:19:26 openstackgerrit Lichao Xue proposed openstack/openstacksdk master: Fix ImportError No module named queue in python2.7 env. https://review.opendev.org/715671
04:52:45 openstackgerrit Lichao Xue proposed openstack/openstacksdk master: Fix ImportError No module named queue in python2.7 env. https://review.opendev.org/715671
07:51:35 openstackgerrit Lichao Xue proposed openstack/openstacksdk master: Fix ImportError No module named queue in python2.7 env. https://review.opendev.org/715671
10:23:57 openstackgerrit Andreas Jaeger proposed openstack/openstacksdk master: Update hacking for Python3 https://review.opendev.org/715684
13:00:26 openstackgerrit Andreas Jaeger proposed openstack/openstacksdk master: Raise hacking to 2.x https://review.opendev.org/715155
13:02:46 openstackgerrit Andreas Jaeger proposed openstack/openstacksdk master: Update local hacking checks https://review.opendev.org/715684
13:52:32 sshnaidm cores, please merge train patches: https://review.opendev.org/#/c/714770/ https://review.opendev.org/#/c/715192/
13:52:38 sshnaidm mordred, dtantsur|afk ^^
15:30:00 openstackgerrit Monty Taylor proposed openstack/openstacksdk master: Switch to unittest.mock from mock https://review.opendev.org/715706
15:30:00 openstackgerrit Monty Taylor proposed openstack/openstacksdk master: Remove some unneeded things from test-requirements https://review.opendev.org/715707
16:08:05 openstackgerrit Monty Taylor proposed openstack/openstacksdk master: Raise hacking to 2.x https://review.opendev.org/715155
16:08:05 openstackgerrit Monty Taylor proposed openstack/openstacksdk master: Update local hacking checks https://review.opendev.org/715684
16:08:06 openstackgerrit Monty Taylor proposed openstack/openstacksdk master: Switch to unittest.mock from mock https://review.opendev.org/715706
16:08:06 openstackgerrit Monty Taylor proposed openstack/openstacksdk master: Remove some unneeded things from test-requirements https://review.opendev.org/715707
16:08:07 openstackgerrit Monty Taylor proposed openstack/openstacksdk master: Remove uses of from six.moves https://review.opendev.org/715712
16:08:07 openstackgerrit Monty Taylor proposed openstack/openstacksdk master: Remove use of six https://review.opendev.org/715713
16:08:08 openstackgerrit Monty Taylor proposed openstack/openstacksdk master: Stop subclassing object https://review.opendev.org/715714
16:22:51 AJaeger mordred: spring cleaning? ;)
16:23:08 mordred AJaeger: yeah - your hacking patches made me think about those :)
16:23:33 AJaeger ;)
16:24:14 AJaeger yes, there're quite a few places to cleanup after dropping to python2 - and many repos didn't do so yet
16:25:08 AJaeger mordred: want to review https://review.opendev.org/715531 as well, please? that's another hacking change for osc-lib
16:25:11 mordred the six change might make backporting patches to stable slightly harder - but I don't think it'll actually be that bad
16:25:53 mordred AJaeger: done!
16:25:55 AJaeger often just a single line per file, so should be okish
16:25:55 mordred and thanks
16:25:56 AJaeger thanks
17:49:01 openstackgerrit Merged openstack/openstacksdk stable/train: Run fetch-subunit-output role conditionally https://review.opendev.org/714770
17:49:02 openstackgerrit Merged openstack/openstacksdk stable/train: [tests] Improve devstack/post playbook efficiency https://review.opendev.org/715192
17:52:30 openstackgerrit Monty Taylor proposed openstack/openstacksdk master: Switch to unittest.mock from mock https://review.opendev.org/715706
17:52:31 openstackgerrit Monty Taylor proposed openstack/openstacksdk master: Remove some unneeded things from test-requirements https://review.opendev.org/715707
17:52:31 openstackgerrit Monty Taylor proposed openstack/openstacksdk master: Remove uses of from six.moves https://review.opendev.org/715712
17:52:32 openstackgerrit Monty Taylor proposed openstack/openstacksdk master: Remove use of six https://review.opendev.org/715713
17:52:32 openstackgerrit Monty Taylor proposed openstack/openstacksdk master: Stop subclassing object https://review.opendev.org/715714
18:33:33 mnaser mordred: going over those patches, seems like the unittest.mock switch seems to have failed with some missing #assert_called_once
18:33:36 mnaser https://storage.gra.cloud.ovh.net/v1/AUTH_dcaab5e32b234d56b626f72581e3644c/zuul_opendev_logs_547/715706/3/check/openstack-tox-py35/5471868/testr_results.html
18:39:07 mordred mnaser: *awesome*
18:41:05 mordred mnaser: DOH
18:41:13 mordred mnaser: https://docs.python.org/3/library/unittest.mock.html#unittest.mock.Mock.assert_called_once ... added in 3.6
18:41:18 mordred sigh
18:42:03 mnaser hmm
18:42:10 mnaser not sure how you can use another combination of assertions to make it work
18:59:19 mordred yeah. I'm gonna have to ponder that one :)
19:02:37 mordred mnaser: got it :)
19:03:03 mnaser mordred: before you push, let me see if things further up the stack havent broken while they're still running :P
19:04:51 openstackgerrit Monty Taylor proposed openstack/openstacksdk master: Switch to unittest.mock from mock https://review.opendev.org/715706
19:04:53 mnaser mordred: yeah they all look good except for the py35 thing
19:04:59 openstackgerrit Monty Taylor proposed openstack/openstacksdk master: Remove some unneeded things from test-requirements https://review.opendev.org/715707
19:04:59 openstackgerrit Monty Taylor proposed openstack/openstacksdk master: Remove uses of from six.moves https://review.opendev.org/715712
19:05:00 openstackgerrit Monty Taylor proposed openstack/openstacksdk master: Remove use of six https://review.opendev.org/715713
19:05:00 openstackgerrit Monty Taylor proposed openstack/openstacksdk master: Stop subclassing object https://review.opendev.org/715714
19:05:04 mordred mnaser: oh - whoops
19:05:09 mordred mnaser: and yay!
19:05:21 mnaser mordred: perfect timing :P
19:05:49 mordred mnaser: tl;dr - foo.assert_called_once() == self.assertEqual(1, foo.call_count)
19:06:02 mnaser mordred: ahhh, yeah, that'll make sense
19:06:06 mnaser much better than what i was thinking
19:06:32 mnaser which was rewriting them to use assert_called_with which was going to be using assert_called_once_with
19:06:47 mordred yeah - that was the first thing I looked at - and then I didn't want to do that :)
19:06:50 mnaser err, i mean using assert_called_once_with instead of assert_called_with, but that's way cleaner andless work
19:06:54 mnaser haha yep
20:09:20 mnaser mordred: https://review.opendev.org/686592 can probably be abandoned cause it looks like we're already not running anything in py27 right?
20:15:01 mordred mnaser: totes
20:50:12 mnaser mordred: i'm going over a lot of reviews for sdk and found this https://review.opendev.org/602234 -- is that ok to land or probably too many things going on?
20:52:17 openstackgerrit Merged openstack/osc-lib master: Update hacking for Python3 https://review.opendev.org/715531
21:25:11 openstackgerrit Merged openstack/openstacksdk master: Add unit test for rackspace block-storage workaround https://review.opendev.org/715058
21:30:45 openstackgerrit Sagi Shnaidman proposed openstack/openstacksdk stable/train: Add tests for Ansible built-in modules in 2.8,2.9 https://review.opendev.org/714089
21:31:45 openstackgerrit Sagi Shnaidman proposed openstack/openstacksdk stable/train: Add tests for Ansible built-in modules in 2.8,2.9 https://review.opendev.org/714089
21:33:03 openstackgerrit Sagi Shnaidman proposed openstack/openstacksdk stable/stein: Add tests for Ansible built-in modules in 2.8,2.9 https://review.opendev.org/714087
21:33:49 openstackgerrit Sagi Shnaidman proposed openstack/openstacksdk stable/stein: Add tests for Ansible built-in modules in 2.8,2.9 https://review.opendev.org/714087
21:40:57 sshnaidm mordred, can we merge? https://review.opendev.org/#/c/714078/
21:42:31 sshnaidm mordred, please in your time, not sure it's best solution though https://review.opendev.org/#/c/715620/
21:50:38 mordred sshnaidm: I think that's a decent enough solution for now
21:51:03 mordred sshnaidm: I feel like there's something smarter we can do - because also testing that those properly fail on too old sdk is also valuable ... but let's not block progress waiting to figure that out :)
21:51:26 sshnaidm mordred, agree
21:51:43 sshnaidm maybe will figure out something for Tuesday mtg
21:52:02 mordred sshnaidm: I've got some other crazy thoughts - but they're more of a tuesday thing :)
21:52:13 sshnaidm all right :)
21:54:00 sshnaidm mordred, btw, today was ansible contributors mtg, minutes if you're interested: https://meetbot.fedoraproject.org/ansible-community/2020-03-29/ansible_contributor_summit_2020.2020-03-29-10.50.html
21:54:27 sshnaidm maybe I'll bring some highlights important for us to Tuesday
21:55:47 mordred cool
21:56:34 mordred one quick question - have you seen the stuff where they search PYTHONPATH for ansible_collection dirs? - do you happen to know what the precedence is between collections found that way and collections installed via ansible-galaxy collection install?
22:04:55 openstackgerrit Mohammed Naser proposed openstack/openstacksdk master: DNM Testing inline pep8 https://review.opendev.org/610744
22:14:48 openstackgerrit Mohammed Naser proposed openstack/openstacksdk master: DNM Testing inline pep8 https://review.opendev.org/610744
22:36:20 openstackgerrit Mohammed Naser proposed openstack/openstacksdk master: DNM Testing inline pep8 https://review.opendev.org/610744
23:20:31 openstackgerrit Merged openstack/openstacksdk stable/stein: Add ansible collection job to stein branch https://review.opendev.org/714078
23:48:07 openstackgerrit Merged openstack/openstacksdk master: Added missing {user, project}_domain_name in Api https://review.opendev.org/672740
23:56:18 openstackgerrit Mohammed Naser proposed openstack/openstacksdk master: DNM Testing inline pep8 https://review.opendev.org/610744
#openstack-sdks - 2020-03-30
08:44:59 openstackgerrit Merged openstack/openstacksdk master: Raise hacking to 2.x https://review.opendev.org/715155
08:48:14 openstackgerrit Merged openstack/openstacksdk master: Update local hacking checks https://review.opendev.org/715684
09:36:14 openstackgerrit Vishakha Agarwal proposed openstack/python-openstackclient master: Add resource option immutable https://review.opendev.org/715269
09:41:40 openstackgerrit Vishakha Agarwal proposed openstack/python-openstackclient master: Add resource option immutable https://review.opendev.org/715269
10:15:37 openstackgerrit Andreas Jaeger proposed openstack/os-api-ref master: Update hacking for Python3 https://review.opendev.org/715649
11:46:03 openstackgerrit Bence Romsics proposed openstack/python-openstackclient master: Add command: router add/remove route --route https://review.opendev.org/674325
12:01:53 openstackgerrit Andreas Jaeger proposed openstack/os-api-ref master: Update hacking for Python3 https://review.opendev.org/715649
12:56:20 sshnaidm cores, please merge https://review.opendev.org/#/c/714089/ https://review.opendev.org/#/c/714087/
12:58:49 openstackgerrit Monty Taylor proposed openstack/openstacksdk master: Switch to unittest.mock from mock https://review.opendev.org/715706

Earlier   Later