| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-sdks - 2020-03-25 | |||
| 11:54:05 | gtema | agree | |
| 11:55:16 | tremble | gtema, I'll get them cleaned up, if you guys are happy python will do the right thing then there's no reason to add my coding oddities to a shared code base. | |
| 12:19:25 | openstackgerrit | Mark Chappell proposed openstack/openstacksdk master: Add support for Federation Protocols https://review.opendev.org/714431 | |
| 12:33:40 | gtema | dtantsur, https://review.opendev.org/#/c/699416/ please | |
| 13:02:31 | dtantsur | gtema: you know that I'm not really on OSC core, right? | |
| 13:13:01 | mordred | frickler, dtantsur: I'm good backporting whichever pep8 patch makes sense ... the test-requirements seems fine since that's in master already | |
| 13:20:32 | gtema | dtantsur - sure, but your opinion as SDK dev | |
| 13:24:18 | dtantsur | okay, but I'm in a chain of meetings now | |
| 13:31:16 | openstackgerrit | jayaditya gupta proposed openstack/python-openstackclient master: Add '--force; parameter to 'openstack quota set' https://review.opendev.org/713881 | |
| 13:52:35 | openstackgerrit | Jens Harbott (frickler) proposed openstack/openstacksdk stable/stein: Move pep8 requirements in to test-requirements https://review.opendev.org/714946 | |
| 13:53:41 | frickler | mordred: dtantsur: sshnaidm: rpittau: ^^ that would be the backport, needed manual amending because the hacking factory seems to not be there, I don't think we would want to backport that, too, would we? | |
| 13:54:03 | dtantsur | I guess not.. | |
| 13:55:24 | mordred | frickler: wfm | |
| 13:55:46 | sshnaidm | frickler, actually my patch is a backport, but with conflicts resolved | |
| 13:55:53 | sshnaidm | I couldn't backport it automatically | |
| 13:56:42 | sshnaidm | frickler, mordred https://review.opendev.org/#/c/714899/ | |
| 14:35:25 | openstackgerrit | Vishakha Agarwal proposed openstack/python-openstackclient master: Adding options to user cli https://review.opendev.org/697444 | |
| 15:19:21 | openstackgerrit | Merged openstack/python-openstackclient master: Switch image to use SDK https://review.opendev.org/650374 | |
| 15:19:22 | openstackgerrit | Merged openstack/python-openstackclient master: Complete switch from glanceclient to SDK for image service https://review.opendev.org/699416 | |
| 15:35:27 | tremble | dtantsur ( gtema ), https://review.opendev.org/714431 now has your requested changes | |
| 15:35:56 | dtantsur | will check after the current meeting | |
| 15:36:03 | tremble | Sure thing | |
| 15:37:33 | tremble | mordred, was there a nominal date for the next SDK 'release' ? | |
| 15:39:59 | mordred | tremble: my current thinking is "as soon as your patches land" | |
| 15:40:07 | mordred | tremble: but - absolutely by the end of this week | |
| 15:40:16 | mordred | (so we need to get your patches landed by the end of this week at the latest) | |
| 15:41:14 | mordred | s/patches/patch | |
| 15:44:29 | tremble | Fair enough :) | |
| 15:44:41 | tremble | mordred, Well https://review.opendev.org/714431 is ready for review :) | |
| 15:49:33 | tremble | mordred, Dumb question - Do you need anything from me on the release notes side of things? I have no idea how reno works | |
| 15:50:41 | mordred | tremble: it's probably not a bad idea. to make one, you just run "reno some-name" - so like "reno added-federation-support" - it'll make a file in releasenotes and show you the path to it | |
| 15:51:07 | mordred | then you edit that file, remove sections that aren't relevant and put in content - so announcing the new feature - doesn't have to be a lot | |
| 15:51:17 | mordred | then git add the file and add it to the commit | |
| 15:52:04 | tremble | mordred, Most of the commits are merged already, should I just spawn a separate review? | |
| 15:52:22 | mordred | yeah - or you could add it to your latest patch there | |
| 15:52:58 | mordred | when we cut the release we'll pick up all of the notes from it - so they can be in a separate patch or in the same - whichever is easier for you will work for me :) | |
| 15:53:29 | tremble | I'll drop it as its own patch, I've been having issues with test flakes | |
| 15:54:26 | mordred | cool | |
| 16:00:33 | tremble | In theory there's a 'service_provider' interface that I've not added support for because we're not using it (we offload the relevant pieces to Apache) | |
| 16:38:46 | openstackgerrit | Mark Chappell proposed openstack/ansible-collections-openstack master: New Module: os_keystone_mapping https://review.opendev.org/713643 | |
| 16:38:47 | openstackgerrit | Mark Chappell proposed openstack/ansible-collections-openstack master: New module: os_keystone_mapping_info https://review.opendev.org/713686 | |
| 16:38:48 | openstackgerrit | Mark Chappell proposed openstack/ansible-collections-openstack master: New Module: os_keystone_identity_provider https://review.opendev.org/714632 | |
| 16:38:49 | openstackgerrit | Mark Chappell proposed openstack/ansible-collections-openstack master: New Module: os_keystone_identity_provider_info https://review.opendev.org/714633 | |
| 16:38:50 | openstackgerrit | Mark Chappell proposed openstack/ansible-collections-openstack master: New Module: os_keystone_federation_protocol https://review.opendev.org/714991 | |
| 16:38:51 | openstackgerrit | Mark Chappell proposed openstack/ansible-collections-openstack master: New Module: os_keystone_federation_protocol_info https://review.opendev.org/714992 | |
| 16:47:19 | openstackgerrit | Mark Chappell proposed openstack/openstacksdk master: Add Release notes entry for Identity v3 IDP, Mapping and Protocol https://review.opendev.org/714994 | |
| 17:50:14 | openstackgerrit | Akihiro Motoki proposed openstack/python-openstackclient master: Adding options to user cli https://review.opendev.org/697444 | |
| 19:27:34 | openstackgerrit | Merged openstack/openstacksdk master: Add support for Federation Protocols https://review.opendev.org/714431 | |
| 19:27:35 | openstackgerrit | Merged openstack/openstacksdk master: Add Release notes entry for Identity v3 IDP, Mapping and Protocol https://review.opendev.org/714994 | |
| 19:41:02 | sshnaidm | frickler, can we please revisit this patch again? https://review.opendev.org/#/c/714899/ it pass and fixes a lot of pep8 issues | |
| 19:41:39 | sshnaidm | seems like https://review.opendev.org/#/c/714911/ just ignores them.. also could be an option, of course | |
| 20:08:57 | openstackgerrit | Jesse Pretorius (odyssey4me) proposed openstack/openstacksdk master: [tests] Improve devstack/post playbook efficiency https://review.opendev.org/715052 | |
| 20:25:28 | openstackgerrit | Monty Taylor proposed openstack/openstacksdk master: Add unit test for rackspace block-storage workaround https://review.opendev.org/715058 | |
| 20:25:58 | mordred | dtantsur|afk: ^^ | |
| 20:28:07 | mordred | sshnaidm: just left a comment on your backports of the fetch-subunit-output - let's squash in odyssey4me's | |
| 20:28:28 | mordred | (since I think the two of them together will be a nice improvement for all the branches) | |
| 20:29:59 | sshnaidm | mordred, yeah, totally fine with that | |
| 20:30:02 | mordred | cool | |
| 20:30:37 | mordred | ianw: feel like a +A on https://review.opendev.org/#/c/714630/ ? | |
| 20:30:57 | mordred | ianw: (it'll let us revert the override setting in our own clouds.yamls) | |
| 20:40:24 | sshnaidm | any ideas about neutron tests fail in train? https://review.opendev.org/#/c/714770/ | |
| 20:46:01 | mordred | sshnaidm: I'm guessing you would not be happy with "train is old" as an answer ... | |
| 20:46:42 | mordred | sshnaidm: but seriously - no. maybe slaweq has an idea ? | |
| 20:47:37 | sshnaidm | slaweq, can you take a look in your time? devstack should work for train, maybe some settings miss ^ | |
| 20:48:22 | sshnaidm | I'm actually fine if it's blocked forever and no breaking patches can come in.. also an option :) | |
| 20:52:01 | mordred | haha | |
| 20:53:06 | slaweq | sshnaidm: mordred looking | |
| 20:54:38 | slaweq | mordred: sshnaidm the issue IMO is that it runs SDK from master branch on this patch | |
| 20:54:46 | slaweq | not train | |
| 20:54:57 | slaweq | and neutron is from train | |
| 20:55:15 | slaweq | where we don't have "description" field in port forwarding | |
| 20:55:24 | slaweq | as it was added just few weeks ago in Neutron master | |
| 20:55:37 | slaweq | that's why those tests are failing | |
| 20:55:47 | ianw | mordred: does https://review.opendev.org/#/c/714630/3/openstack/config/vendors/rackspace.json need a {projectid} on the end of it? | |
| 20:56:06 | slaweq | but I believe it should run tests on stable/train branch of sdk, not master, right? | |
| 20:57:37 | mordred | slaweq: well ... we should probably update something so that master sdk works with train and master of neutron | |
| 20:57:54 | mordred | that said - I agree, the purpose of the stable/train test in this case is to test stable/train of sdk - so that means the test is likely misconfigured | |
| 20:58:40 | sshnaidm | mordred, hmm https://github.com/openstack/openstacksdk/blob/stable/train/.zuul.yaml#L40:L40 | |
| 20:58:45 | mordred | ianw: it doesn't - we added a special logic workaround - projectid isn't available at the time substitutions are done | |
| 20:58:47 | slaweq | mordred: sdk will work | |
| 20:59:00 | ianw | mordred: yeah, ok seeing that | |
| 20:59:03 | slaweq | but test in master is always trying to send "description" attribute to neutron server | |
| 20:59:14 | slaweq | and neutron from train don't know this field so it fails | |
| 20:59:15 | mordred | ah - so it's just a test thing | |
| 20:59:26 | slaweq | yes | |
| 20:59:35 | slaweq | and no | |
| 20:59:59 | slaweq | basically test from train branch https://github.com/openstack/openstacksdk/blob/stable/train/openstack/tests/functional/network/v2/test_port_forwarding.py don't send description field | |
| 21:00:00 | mordred | sshnaidm: yeah - we might need to rethink that. the historical position has been "just install latest sdk" | |
| 21:00:20 | slaweq | but the same test from master https://github.com/openstack/openstacksdk/blob/master/openstack/tests/functional/network/v2/test_port_forwarding.py have this new field | |
| 21:00:27 | mordred | slaweq: nod | |
| 21:00:40 | mordred | cool. I think I at least understand the issue | |
| 21:00:49 | mordred | the correct solution on the other hand ... | |
| 21:01:03 | ianw | mordred: ahh, seems i'm only +1, but it LGTM. it's all tangled web, but i guess that's exactly what the SDK takes the burden of so you don't have to! | |
| 21:01:04 | slaweq | and this failure in functional jobs in https://review.opendev.org/#/c/714770/ are because there is run test from master branch (with description field) | |
| 21:02:12 | mordred | sshnaidm: let's remove that branch override from the stable/train sdk branch | |
| 21:02:25 | sshnaidm | mordred, ok | |
| 21:02:25 | mordred | sshnaidm: and see if things update themselves properly | |
| 21:02:40 | slaweq | I hope I helped a bit :) | |
| 21:02:46 | mordred | slaweq: yes - very much! | |
| 21:02:48 | sshnaidm | also os-client-config ? | |