Earlier  
Later
New Search
Posted Nick Remark
#openstack-sdks - 2020-03-04
18:02:39 mordred there are places with more explicit mv negotiation - live_migrate comes to mind
18:02:49 mordred and yeah
18:03:20 mordred so like I said - the GOAL is that you never have to do that - but we're obviously not 100% there on that goal
18:03:51 umbSublime Asside from debug log and reading the code, is there a programatic way to know what API version will be used by conn.compute.<method> ?
18:04:08 mordred that's an excellent question
18:04:17 umbSublime Well for me this clouds.yaml trick fixes a lot of headaches !!
18:04:35 mordred I'm gonna say - "no" ... but I think that's an excellent thing to want to know
18:04:48 mordred so I'll think about how we might accomplish that
18:06:37 umbSublime mordred, thanks a lot !
18:07:32 openstackgerrit Merged openstack/openstacksdk master: Replace assertItemsEqual with assertCountEqual https://review.opendev.org/711235
18:19:24 mordred slaweq: if you have a sec, https://review.opendev.org/#/c/710030/ is neutron related
18:20:01 mordred slaweq: as is https://review.opendev.org/#/c/710820/
18:47:36 mordred dtantsur|afk: whence you are back - I'm looking at switching to futurist ... we use concurrent.futures.as_completed currently - futurist seems to have wait_for_all and wait_for_any ... do you have a suggestion of the best way to accomplish a similar pattern to as_completed?
18:48:16 mordred dtantsur|afk: hrm. actually - looking at the code wait_for_all should still work
18:50:15 mordred dtantsur|afk: ACTUALLY - nothing shoudl stop us from using concurrent.futures.as_completed since futurist is using that as a base
18:56:12 openstackgerrit Monty Taylor proposed openstack/openstacksdk master: Switch to futurist for concurrency https://review.opendev.org/711301
19:29:28 umbSublime I just watched a talk from OS summit about the SDK. The speaker says a proxy object is created for every service_types_authority even if the target cloud doens't have the service in it's endpoints and even if no ressource objects are created (we should at least be able to get/put/post/delete). Has this been rolled back ? I have placement-api in my deployment but get and error with conn.placement. This is also something i've
19:29:28 umbSublime discussed here in the past (don't remembeer who). i had a work-around where I added a placement adapter to keystoneauth, but it was a bit dirty
19:30:46 mordred umbSublime: WELL - that was probably me, and you should always take anything I say with a grain of salt
19:31:39 mordred that said - I could expect conn.placement to exist and be a proxy - how ever, if you don't have placement in your service-catalog, it's not going to know how to configure that proxy to be able to talk to anything because it's not going to know where the placement endpoint is
19:32:12 mordred umbSublime: you can put placement_endpoint_override in your clouds.yaml with the placement endpoint and that should tell it where your placement service is
19:32:23 umbSublime I do see it with `openstack endpoint list`
19:32:30 mordred ok. so it is in your catalog
19:32:36 umbSublime yup
19:32:53 mordred in that case I fully expect conn.placement to give you a working proxy
19:33:26 umbSublime Any debug or things you want me to check (I assume there might be a bug)
19:33:45 umbSublime Great talk BTW :D
19:33:47 openstackgerrit James Denton proposed openstack/openstacksdk stable/stein: Add "name" filter in "list" call when retrieving a single register https://review.opendev.org/711314
19:37:06 umbSublime mordred, here is the stack-trace what the stacktrace looks like: https://hastebin.com/vizuhufiqi.rb
19:37:09 mordred umbSublime: can you run http://paste.openstack.org/show/790311/ (obviosly change the connect call if you need to) and paste the output?
19:37:30 mordred oh - hrm
19:37:45 mordred what version of keystoneauth - and do you know what version of placement?
19:38:29 umbSublime keystoneauth1.__version__ == '3.18.0
19:38:55 umbSublime :facepalm: I didn't install osc-placement in that venv. potential pebcak
19:39:17 mordred possibly - however ... are you setting a placement_api_version there?
19:40:09 umbSublime Ok so I get same stack-trace with osc-placement installed. And I have nothing related to placement in my clouds.yaml
19:41:13 mordred yeah - I think this is placement not returning a proper version discovery doc for some reason - which is a thing I thought we'd put in a workaround for before
19:41:36 mordred could you run that little script above? that should catch the full http trace
19:42:40 umbSublime being an private cloud do you mind If I just remove endpoint dict from the output i share with you ? (that's probably what you want to check :/ )
19:43:31 mordred nah - actually I thnk that's fine - I mostly want to see the payload returned from the root of your placement service
19:43:56 umbSublime After the token request i see a call on the endpoint with the port my placement-api is running on. This is the response: {"versions": [{"min_version": "1.0", "max_version": "1.17", "id": "v1.0"}]}
19:44:10 mordred sigh
19:44:44 mordred ok. so - that's a broken discovery dict - which I *think* we got fixed in upstream placement (I'll go check that next - it doesn't match my test fixture for placement)
19:44:51 umbSublime Is this correct response format?
19:44:53 mordred for now - set placement_endpoint_override
19:44:55 mordred yeah
19:44:58 mordred it's jst missing a status: field
19:45:04 umbSublime Ahh so then i'd need to update my placement-api service
19:45:18 mordred yeah - although I *also* want to see if I can't work around that in sdk too
19:45:25 mordred because that's a bad experience for people
19:45:33 mordred I thought we already had - but I see clearly we didn't
19:45:50 mordred but for now - if you set placement_endpoint_override to the base endpoint of the placement service it should work for you
19:45:53 umbSublime would be awesome. For newer clouds, I can update the version, but this legacy cloud will probably have to live with it's current placement version
19:45:58 mordred yah
19:46:00 umbSublime testing now
19:46:09 mordred and we aim to support older clouds too - so it's fair for us to deal with that
19:46:35 umbSublime I put the endpoint I get for `endpoint list` as a value right ?
19:46:43 mordred yeah
19:47:55 umbSublime \o/ print(conn.placement) -> <openstack.proxy.Proxy object at 0x7ffbdaf5a5c0>
19:47:58 mordred WOOT
19:48:17 mordred cool. I can work up a test case that has a broken old placement discovery dict and then figure out how to fix it :)
19:48:22 mordred thanks for helping track that down
19:48:27 umbSublime Man I'm going to get rid of so much hacky code today ^^
19:48:32 mordred \o/
19:48:40 mordred my main goal in life is facilitating the deletion of code
19:48:49 umbSublime thanks a bunch !!!
19:48:55 umbSublime hahaha it's working XD
20:05:45 openstackgerrit Merged openstack/openstacksdk master: Return uuid alias for coe_cluster in non strict mode https://review.opendev.org/710823
20:23:52 openstackgerrit Monty Taylor proposed openstack/openstacksdk master: Handle old status-less placement service https://review.opendev.org/711328
20:25:03 mordred umbSublime: ^^ that produces the same error - so there's that at leat
20:25:05 mordred least
20:28:40 umbSublime :)
20:29:29 umbSublime Do you want me to file a bug for this. I'm not sure if the fix has to be implemented in keystoneauth1 or the SDK directly
20:32:40 mordred umbSublime: nah - I'm working on it
20:33:03 mordred umbSublime: although I feel lke I'm going to need a shower when I'm done :)
20:33:04 umbSublime <3
21:04:27 umbSublime Say I wanted (one day) to try and tackle some low hanging fruit bugs on the SDK where are issues tracked. I don't see much stuff related to sdk in launchpad
21:06:28 mordred we're in storyboard ... https://storyboard.openstack.org/#!/project/openstack/openstacksdk
21:06:40 mordred I'm pretty bad about using it myself though (hides)
21:09:50 openstackgerrit Monty Taylor proposed openstack/openstacksdk master: Handle old status-less placement service https://review.opendev.org/711328
21:10:02 mordred umbSublime: and there's the workaround :)
21:10:40 mordred Shrews: I feel like it's been too long since you've had to review patches from me touching version discovery in the guts of SDK ^^
21:10:58 mordred efried: ^^ same story
21:13:01 efried mordred: can you link to the commit that corrected the missing status field in placement?
21:19:18 mordred efried: uh ... I was sort of hoping you just magically new ... let me go look
21:19:40 efried mordred: I could have gone and looked myself. <lazy>
21:19:55 efried I probably wrote that patch. Or at least reviewed it.
21:20:20 efried But I'm way behind memorizing the gerrit numbers and commit hashes of all the patches I've been involved in.
21:21:28 mordred efried: https://review.opendev.org/#/c/575117/
21:21:45 mordred efried: you want me to put a referene to that in the commit message?
21:21:54 efried mordred: yes please, but also one other comment...
21:22:57 efried mordred: ...posted
21:24:24 efried JSON doesn't allow comments???
21:24:56 efried I'll be back to +2 that in ~.5h
21:24:58 Shrews mordred: oh, i can't wait. really. no, seriously.
21:24:58 openstackgerrit Monty Taylor proposed openstack/openstacksdk master: Handle old status-less placement service https://review.opendev.org/711328
21:25:20 mordred efried: nope. that's one of teh nice things about yaml
21:25:32 umbSublime Thanks mordred !
21:25:40 mordred Shrews: well - no need to wait - there you are, all nice and ready for you
21:25:42 efried mordred: +2

Earlier   Later