Earlier  
Later
New Search
Posted Nick Remark
#openstack-sdks - 2020-02-27
16:02:45 gtema hi elmiko. So with PTG it's all clear, right?
16:03:23 dulek mordred, gtema: Alright, so here's my attempt to implement that thing with the simple plumbing: https://review.opendev.org/#/c/710030.
16:03:27 dulek Tell me what you think!
16:05:28 gtema dulek, will have a look, but unfort. not today - a total madness today
16:05:53 dulek gtema: Well, this thing isn't really urgent.
16:07:55 gtema that's good
16:09:16 elmiko gtema: is it?
16:09:55 gtema elmiko - it is, nobody cares. We do what we want
16:14:05 mordred dulek: that's looking good!
16:15:06 mordred elmiko, gtema: I requested a day from kendall for SDK/OSC/ansible-openstack - I think that could also easily include API ... basically a day we can divy up however
16:15:52 gtema yupp, thanks mordred. With additional 1/4 day dtantsur requested specifically for API we are absolutely ok
16:16:31 gtema and as Kendall confirmed per email - there is no procedure/deadline on how/whether we need to publish our planning
16:17:13 mordred cool
16:26:24 elmiko sorry got sig_meeting
16:35:47 elmiko mordred gtema , that sounds good to me. i won't be at the ptg, but i'm happy to help from afar however i can
16:35:59 gtema ack
18:56:20 tbarron 1
18:56:26 tbarron wrong window
18:56:28 tbarron sorry
18:56:52 tbarron mysecretbankpw42
18:57:34 tbarron https://bankofamerica.com/user=?/tbarron
19:16:35 mordred tbarron: I'm so rich now
19:38:32 tbarron mordred: nice
19:56:53 openstackgerrit Monty Taylor proposed openstack/ansible-collections-openstack master: Remove old artifacts when building new ones https://review.opendev.org/710293
19:56:54 openstackgerrit Monty Taylor proposed openstack/ansible-collections-openstack master: Run flake8 in linters https://review.opendev.org/710294
19:56:55 openstackgerrit Monty Taylor proposed openstack/ansible-collections-openstack master: Fix F841 and remove exclusion https://review.opendev.org/698063
19:56:56 openstackgerrit Monty Taylor proposed openstack/ansible-collections-openstack master: Remove F403 and F405 exclusions https://review.opendev.org/710295
19:56:57 openstackgerrit Monty Taylor proposed openstack/ansible-collections-openstack master: Fix E128 and remove exclusion https://review.opendev.org/698064
19:56:58 openstackgerrit Monty Taylor proposed openstack/ansible-collections-openstack master: Fix W504 and remove exclusion https://review.opendev.org/710296
19:56:59 openstackgerrit Monty Taylor proposed openstack/ansible-collections-openstack master: Fix F401 and remove exclusion https://review.opendev.org/698065
23:33:27 openstackgerrit Merged openstack/ansible-collections-openstack master: Add tests for os_user_role in multidomain context https://review.opendev.org/705719
23:38:06 openstackgerrit Merged openstack/ansible-collections-openstack master: fix constructed compose https://review.opendev.org/704582
#openstack-sdks - 2020-02-28
02:31:24 openstackgerrit Prashant Bhole proposed openstack/openstacksdk master: Fix: Set image name correctly if filename is not passed https://review.opendev.org/710368
10:52:16 openstackgerrit Michał Dulko proposed openstack/openstacksdk master: Implement If-Match support for Neutron resources https://review.opendev.org/710030
10:52:16 openstackgerrit Michał Dulko proposed openstack/openstacksdk master: Implement If-Match support for Neutron resources https://review.opendev.org/710030
14:20:17 openstackgerrit Adam Harwell proposed openstack/openstacksdk master: Add availability_zone param to load balancer https://review.opendev.org/710452
#openstack-sdks - 2020-02-29
14:50:45 openstackgerrit Merged openstack/ansible-collections-openstack master: Add a tool to build collections with pbr https://review.opendev.org/710047
#openstack-sdks - 2020-03-01
12:15:16 openstackgerrit Monty Taylor proposed openstack/ansible-collections-openstack master: Just use shutil.rmtree in build.py https://review.opendev.org/710640
12:31:38 openstackgerrit Monty Taylor proposed openstack/ansible-collections-openstack master: Just use shutil.rmtree in build.py https://review.opendev.org/710640
12:31:39 openstackgerrit Monty Taylor proposed openstack/ansible-collections-openstack master: Fix H236 and remove exclusion https://review.opendev.org/698066
12:31:40 openstackgerrit Monty Taylor proposed openstack/ansible-collections-openstack master: Remove from __future__ lines https://review.opendev.org/698067
12:31:41 openstackgerrit Monty Taylor proposed openstack/ansible-collections-openstack master: Test with and assert support for python3 https://review.opendev.org/710641
#openstack-sdks - 2020-03-02
12:53:59 larsks How does one pass all_tenants=true to the list_volumes method in python-openstacksdk?
13:27:50 openstackgerrit Merged openstack/ansible-collections-openstack master: Remove old artifacts when building new ones https://review.opendev.org/710293
13:31:33 openstackgerrit Merged openstack/ansible-collections-openstack master: Run flake8 in linters https://review.opendev.org/710294
13:31:34 openstackgerrit Merged openstack/ansible-collections-openstack master: Fix F841 and remove exclusion https://review.opendev.org/698063
13:31:35 openstackgerrit Merged openstack/ansible-collections-openstack master: Remove F403 and F405 exclusions https://review.opendev.org/710295
13:31:36 openstackgerrit Merged openstack/ansible-collections-openstack master: Fix E128 and remove exclusion https://review.opendev.org/698064
13:31:37 openstackgerrit Merged openstack/ansible-collections-openstack master: Fix W504 and remove exclusion https://review.opendev.org/710296
13:31:38 openstackgerrit Merged openstack/ansible-collections-openstack master: Fix F401 and remove exclusion https://review.opendev.org/698065
15:38:12 dtantsur mordred: http://lists.openstack.org/pipermail/openstack-discuss/2020-March/012928.html Oo
15:38:38 mordred dtantsur: uhm
15:39:05 brtknr mordred: since when did openstacksdk start to replace uuid keys with id?
15:39:10 brtknr dtantsur: ^
15:39:53 brtknr for get requests
15:43:39 mordred brtknr: since always. the REST interactions should use uuid as the key name if it needs to, and uuid _should_ be available as an alias - but it's a primary design of SDK that every object returned has an "id" field that is the id of the object
15:44:44 mordred dtantsur: I have also responded to the thread, possibly a bit tersely
15:45:01 dtantsur cool, that's what I expected :)
15:59:12 mordred dtantsur: if you get bored, I left a disagreement on https://review.opendev.org/#/c/700219/ - I think we should probably come to an agreement amongst ourselves
16:09:06 dtantsur mordred: I like the idea of a global executor and more or less okay with defaulting to threads as long as it can be completely overridden
16:10:33 tosky just to bring the discussion in the right place, one of the blocker raised by the cinder people was and is https://review.opendev.org/#/c/590807/
16:10:38 tosky and the lack of updates on it
16:10:44 tosky is there any update on it?
16:11:54 mordred dtantsur: cool!
16:12:03 mordred tosky: looking
16:15:45 mordred tosky: 3 things. a) I'd still prefer migrating to sdk there, since microversion support is solid and we use it in other places and all. HOWEVER b) I don't think we should block forward progress on that, we can certainly migrate later c) that patch should probably be fixed to pass tests - all of the previous blockers that existed at the time of that patch originally should not exist anymore
16:18:25 tosky mordred: that's good to hear (all of it) - could you please comment on the patch? :)
16:19:18 brtknr mordred: so uuid not being available too is possibly a bug?
16:20:33 mordred brtknr: yeah, possibly so. where are you seeing the issue?
16:20:56 brtknr for os_coe_cluster and os_coe_cluster_template modules, only id is returned, not uuid
16:21:24 brtknr looks like the corresponding ansible module expects to see uuid field which leads to issues with idempotency
16:21:41 mordred brtknr: that's super weird :)
16:21:46 brtknr sorry the get_coe_cluster and get_coe_cluster_template functions
16:22:42 mordred brtknr: oh - that's even weirder. that's teh cloud layer, becuase it's for ansible. I'm not sure that's _ever_ returned uuid - so I have no idea how those ansible modules worked? looking further though .,..
16:23:04 brtknr mordred: wait, only get_coe_cluster has this problem
16:23:15 brtknr get_coe_cluster_template seems to return uuid as an alias
16:24:09 mordred brtknr: yes - I agree with you
16:24:18 mordred cluster template adds it ba k
16:24:37 brtknr mordred: can you show me the code?
16:25:04 brtknr mordred: dont worry, i will try to find it myself, i should stop being lazy
16:25:09 mordred brtknr: https://opendev.org/openstack/openstacksdk/src/branch/master/openstack/cloud/_normalize.py#L1026-L1032 is where cluster_template adds it back if strict == False
16:25:30 mordred and you can see that https://opendev.org/openstack/openstacksdk/src/branch/master/openstack/cloud/_normalize.py#L971-L997 doens't do a similar thing
16:26:07 brtknr ouch
16:26:29 brtknr who'd like to propose a patch?
16:26:53 brtknr I'm happy to if people are busy :)
16:28:07 brtknr Actually I am not sure what this strict_mode is about
16:31:14 brtknr found the reno: https://github.com/openstack/openstacksdk/blob/master/releasenotes/notes/strict-mode-d493abc0c3e87945.yaml
16:35:53 mordred brtknr: the idea was that we'd have a consistent interface peopel could count on - as well as fallback values
16:36:28 mordred however - that concept pre-dates the merge of shade and sdk. with the sdk objects we have the opportunity to define aliases - and that seems to be a better long-term experience for users anyway
16:37:03 mordred we've been working on shifting the shade layer to using the sdk resource objects and getting rid of that normalize layer - but havne't made it to the coe methods yet
16:37:16 openstackgerrit Rodolfo Alonso Hernandez proposed openstack/openstacksdk master: Include "fields" to "SecurityGroup" query parameters https://review.opendev.org/710820
16:37:58 mordred brtknr: if you have a sec, you could probably just cargo-cult in an if not strict_mode: add back uuid patch to keep it simple for the time being - and we can see about migrating the methods as a followup
16:39:05 larsks mordred: Do you know if there is a particular reason that volume.volumes(details=True) doesn't return the user_id information from the remote response?
16:41:04 openstackgerrit Bharat Kunwar proposed openstack/openstacksdk master: Return uuid alias for coe_cluster in non strict mode https://review.opendev.org/710823
16:41:08 brtknr mordred: ^
16:41:36 mordred larsks: looking
16:42:09 mordred brtknr: looks great. it's possible a test mock will need to get updated as a result - but let's see how it goes
16:42:31 openstackgerrit Rodolfo Alonso Hernandez proposed openstack/python-openstackclient master: Add "fields" parameter to ListSecurityGroup query https://review.opendev.org/710825
16:43:34 mordred larsks: there is no mention of user_id in openstack/block_storage/v3/volume.py - so I think it's purely that it's missing and not anything on purpose
16:43:56 larsks mordred: thanks. I was just curious if the omission was intentional or not. I'll submit a change.

Earlier   Later