Earlier  
Later
New Search
Posted Nick Remark
#openstack-sdks - 2020-02-25
14:58:34 weust also, the openstack doc page shows are installable on Windows. Except it's very old. using python 2.7
14:59:34 weust /s/are/as
14:59:34 gtema netifaces need to be build also under linux, so this is more a general problem how to build/install that
15:00:10 weust I can see if it will build in my WSL Debian thingy
15:01:32 weust Except I have Pythong 3.7.something there
15:03:40 weust *sigh* debian install pythong 2.7 when installing python-dev and python-pip
15:06:08 weust well, apart from pyopenssl complaining about needing version 2.8 of higher, "but you'll have version older" blah, it seems to install
15:07:09 weust and it's still version 4.0.0 even though I installed with ==5.0.0
15:09:20 openstackgerrit Bharat Kunwar proposed openstack/ansible-collections-openstack master: os_coe_cluster: Retrive id/uuid correctly https://review.opendev.org/709734
19:07:37 umbSublime weust, yes most distros from 1+ year ago have python2 being the default /usr/bin/python, just make sure to install `python3 python3-dev python3-venv` then; python3 -m venv venv; source venv/bin/activate; pip install --upgrade pip; pip install python-openstackclient==5.0.0. version 5.0.0 is 3.6+ only hence why you got 4.0.0 when using python2
20:14:07 weust umbSublime: I was able to get it working on a Ubuntu 18.4 LTS WSL today using python 3.8. Will try your actions too in a new setup.
#openstack-sdks - 2020-02-26
13:12:09 openstackgerrit Michał Dulko proposed openstack/openstacksdk master: Implement If-Match support for Neutron resources https://review.opendev.org/710030
13:12:09 openstackgerrit Michał Dulko proposed openstack/openstacksdk master: Implement If-Match support for Neutron resources https://review.opendev.org/710030
13:17:33 dulek Folks, I could use some help with the above ^. I explained my concerns in the review.
13:23:00 openstackgerrit Rodolfo Alonso Hernandez proposed openstack/python-openstackclient master: Fix network segment range "_get_ranges" function https://review.opendev.org/710031
13:23:49 openstackgerrit Rodolfo Alonso Hernandez proposed openstack/python-openstackclient master: Fix network segment range "_get_ranges" function https://review.opendev.org/710031
14:10:03 stephenfin hberaud, smcginnis: Can one of you hit +W on this? https://review.opendev.org/#/c/705630/
14:41:37 openstackgerrit Monty Taylor proposed openstack/ansible-collections-openstack master: Add a tool to build collections with pbr https://review.opendev.org/710047
14:42:23 gtema mordred, would appreciate review on https://review.opendev.org/#/c/700219/
14:43:03 mordred gtema: yeah - sorry - I keep opening it and then getting scared
14:43:22 gtema why, it's so straight forward ;-)
14:44:07 gtema dtantsur is now happy with it (hopefully). Since he is AFK can't verify, but we had some discussions on that
14:46:11 mordred gtema: yeah - it's looking good to me as I read it - nice work
14:46:19 gtema thks
14:46:47 gtema when this lands wanted to raise discussion where to make an agreed OSC plugin
14:47:02 gtema but anyway wanted to have a session on PTG wrt that
14:47:35 mordred gtema: one quibble - in project_cleanup - you've got code to handle people who are for some reason biased against threads - and that's the default code path ... why not make it use a thread pool by default and make people who want to "avoid" threads do work? (we use threads for chunked uploads to swift whether a user wants them or not, so I'm personally not even convinced we need to support avoiding
14:47:36 mordred them at all)
14:48:14 gtema dtantsur was vomplaining a lot agains that
14:48:19 gtema complaining
14:48:38 mordred one sec - gotta step away for 5 mins...
14:48:40 gtema what you said was a 2nd approach, but he still didn't like it
14:48:43 gtema ok
14:54:30 mordred k. back
14:54:43 gtema good
14:54:46 mordred gtema: so what's the issue - he's opposed to threads for some reason?
14:55:04 mordred oh - I see - kemme read the comments on the patch
14:55:14 gtema yeah, he was agains having it used in the default path
14:56:49 mordred gtema: his original comment was just about allowing the possibilities to pass in a manager: https://review.opendev.org/#/c/700219/7/openstack/cloud/openstackcloud.py@796
14:57:07 gtema I think he was explaining me more concerns in the private chat, but I lost it and forgot
14:57:13 mordred nod
14:57:26 gtema and then he said - please avoid it completely
14:57:41 gtema we can wait for him then for details
14:57:56 mordred so - I completely agree about the greenlet concerns - because people using greenlet stuff are in a general world of compexity and pain as they have no clue what their code is doing at any time :)
14:58:05 mordred so definitely it's important to give those folks an out
14:58:11 gtema :D
14:58:35 mordred but - I think someone writing some straightforward code should not need to opt-in to what should be normal safe behavior
14:59:05 mordred they shold get the best experience out of the box just by running the cleanup method
14:59:08 gtema I share same opinion, so we are 2 against 1.
14:59:13 mordred and only need to do special things if they are in special circumstances
14:59:29 gtema then post a review to patch and we see what he says
14:59:40 mordred kk
15:00:00 mordred btw - the greenlet concern is good - we should maybe make sure we're providing a similar escape hatch for people for other uses of executors
15:00:10 mordred in fact- I _think_ you can pass an executor to Connection?
15:00:18 mordred one sec- lemme look
15:01:12 mordred nope. it's a TODO
15:01:29 mordred gtema: so - if you look in openstack/cloud/_object_store.py
15:01:49 mordred there's a TODO about making self.__pool_executor configurable - for the folks in the greenlet situation
15:02:13 mordred maybe we should just make that a proper Connection param- then we can use self.__pool_executor in your other code
15:02:33 mordred and it'll also be clear to people using sdk from services how to set up a connection safely
15:02:52 gtema a sec, have a call
15:02:53 mordred (maybe this is why we were considering switching to futurist at one point?)
15:02:59 mordred kk. I'll leave a review
15:06:06 gtema back.
15:06:09 gtema okay, great
15:06:12 gtema thanks
15:16:43 mordred gtema: done. +2 otherwise
15:16:52 gtema great, thanks a lot
15:16:59 mordred gtema: dude - thank you for writing that
15:17:09 gtema welcome
15:17:10 mordred sorry it's taken me so long to review :)
15:17:20 gtema I really need it myself in lots of my projects
15:17:33 gtema no problems, need only to ping people some time ;-)
15:17:39 gtema sometime be nasty
15:20:54 gtema hopefully Vancouver will not be that much affected by Corona
15:28:32 mordred gtema: we should probably review https://review.opendev.org/#/c/679914/ too
15:29:09 gtema oh yeah, I see I was even reviewing it already
16:00:49 dulek mordred: Hi! Can you take a look at https://review.opendev.org/710030 ? I'm not sure how to proceed with this in an openstacksdk'ish way there.
16:01:37 dulek Basically the issue is that in Neutron `If-Match: revision_number=1` is the correct form, so I'd need some header modification to make this thing useful.
16:01:57 dulek Also usage of that header should be restricted to PUT and DELETE calls.
16:03:13 mordred dulek: oh my - what a fun question ...
16:03:56 mordred dulek: I believe we're going to get to invent a new primitive on Resource!
16:04:54 dulek I always engage in fun stuff.
16:05:24 dulek mordred: But as openstacksdk beginner I could use some advice.
16:14:17 mordred dulek: totally. I'm in the "staring off into space looking like I'm doing nothing but actually pondering your issue" state. hopefully soon I'll transition to "looking like someone who has an idea"
16:16:20 dulek mordred: Sure, thanks!
16:17:24 openstackgerrit Merged openstack/python-openstackclient stable/train: Stop silently ignoring invalid 'server create --hint' options https://review.opendev.org/705630
16:25:33 openstackgerrit Merged openstack/ansible-collections-openstack master: Make an OpenStackModule base class https://review.opendev.org/698044
16:34:50 openstackgerrit Merged openstack/ansible-collections-openstack master: Cleanup unit test requirements https://review.opendev.org/709113
16:54:20 mordred dulek: would it be desirable do you think to have some amount of if-match happen automatically? like - if the user has a Network resource locally and goes to commit an update, should sdk automatically add an if_match="revision={current_object.revision}" if the user hasn't added one?
16:54:41 mordred or would that be super unexpected and unwelcome?
16:55:51 dulek mordred: I'd say that would be unwelcome. Neutron is not analyzing anything here, just comparing numbers and sometimes people don't care if somebody changed something in-between, they just want to rename.
16:55:58 mordred nod
16:56:20 dulek mordred: In our case we use it to make sure we won's lose an update when updating allowed_address_pairs.
16:56:30 mordred yah
17:10:39 mordred dulek: ok - so - I'm just gonna talk out loud here for a bit - this may be bong
17:14:18 mordred I think what you probably want to do is add an allow_if_match to openstack.resource.Resource (kind of like allow_create / allow_patch etc) ... then put some code in openstack.resource.Resource._prepare_request to add the if-match header to the headers dict if there is an if_match parameter and if allow_if_match is true ... which is then going to probably involve some annoying plumbing to allow people
17:14:20 mordred to pass if_match to resource.commit() and get it all the way to _prepare_request
17:14:59 mordred (as well as to openstack.proxy.Proxy._update)
17:15:12 mordred gtema: ^^ does that sound sane to you?

Earlier   Later