Posted	Nick	Remark
#openstack-sdks - 2020-01-27
11:06:10	frickler	dtantsur: looking again, maybe https://review.opendev.org/704243 was the real issue and 700897 wasn't even needed anymore after that
11:06:43	dtantsur	frickler: is it possible to try reverting it and have a job run with depends-on?
11:07:10	frickler	so that issue was running master openstacksdk against stable/stein keystoneauth1 if I traced it correctly
11:07:23	frickler	dtantsur: I guess I could do that, yes, give me a few
11:07:59	dtantsur	++ thx
11:08:26	openstackgerrit	Jens Harbott (frickler) proposed openstack/openstacksdk stable/stein: Revert "Add fake support for global_request_id" https://review.opendev.org/704305
11:12:20	frickler	dtantsur: let's see what the CI has to say about this one: https://review.opendev.org/704307 DNM: Test openstacksdk revert
11:13:05	dtantsur	frickler: ++ but zuul doesn't like something here
11:15:30	frickler	dtantsur: ah yes, thx, I was editing out the other jobs, but not enough of them
12:11:39	mordred	dtantsur, frickler: oh good - I didn't like backporting that either - let's fingers crossed that the revert works
12:19:51	frickler	lgtm http://zuul.openstack.org/stream/7e749006afc448498fe34e31844e3286?logfile=console.log
12:23:51	mordred	frickler: woot!
12:44:34	openstackgerrit	Daniel Bengtsson proposed openstack/python-openstackclient master: Stop configuring install_command in tox and stop use pip. https://review.opendev.org/694484
12:54:41	dtantsur	mordred: thx for checking! FYI https://review.opendev.org/#/c/704300/
12:58:11	mordred	dtantsur: woot
12:59:12	mordred	dtantsur: btw - I agree on a 1.0 - I've been hoping to get a minute to walk through and make sure we don't have any super gross things still laying around that need excising first. I'll try to do that next week when I'm properly back
13:06:22	mordred	oh - wait - it was frickler mentioning a 1.0 ...
13:12:48	frickler	crazy ideas I get in the morning ;)
13:26:35	sshnaidm	just a reminder, this patch needs some love from openstacksdk cores: https://review.opendev.org/#/c/703342/
13:34:40	mordred	sshnaidm, dtantsur: I left a question. also - I left a +2 but not a +A because I'm only partially here and not 100% caught up and dtantsur had a question.. so I'd like to make sure dtantsur is happy before pulling the trigger
14:32:07	dtantsur	++
14:33:02	frickler	sshnaidm: for the job failure, I think ansible-collections-openstack-functional-devstack is missing openstack/ansible-collections-openstack as required-project, making it fail when not running against itself
14:33:47	sshnaidm	frickler, I don't think you need it in required project, since it's defined in this project
14:33:56	sshnaidm	the job actually pass on collections repo
14:34:21	sshnaidm	seems like it's something weird in devstack post playbook, let's see the last run..
14:34:23	frickler	sshnaidm: yes, when running against the project itself, it is there, when running against other project, like openstacksdk, it is missing
14:34:44	frickler	FileNotFoundError: [Errno 2] No such file or directory: '/home/zuul/src/opendev.org/openstack/ansible-collections-openstack'
14:36:32	dtantsur	sshnaidm: the project where a job is defined in is not necessary added to required-projects
14:36:48	dtantsur	(e.g. for ironic we explicitly add ironic to all its jobs to make them reusable)
14:38:49	sshnaidm	hmm.. was sure it's smart enough, will check again
14:41:15	openstackgerrit	Sagi Shnaidman proposed openstack/ansible-collections-openstack master: Add colleciton repo to required projects https://review.opendev.org/704332
14:42:04	openstackgerrit	Sagi Shnaidman proposed openstack/openstacksdk master: Fail a job for ansible modules with message https://review.opendev.org/703342
14:42:11	sshnaidm	let's try ^
16:15:38	sshnaidm	ok, the job pass, you're welcome to vote: https://review.opendev.org/#/c/703342/
20:49:31	openstackgerrit	Keith Berger proposed openstack/python-openstackclient stable/rocky: Fix openstack server list --deleted --marker option https://review.opendev.org/704422
#openstack-sdks - 2020-01-28
01:22:40	openstackgerrit	Merged openstack/ansible-collections-openstack master: Add colleciton repo to required projects https://review.opendev.org/704332
01:22:41	openstackgerrit	Merged openstack/ansible-collections-openstack master: fix os_user_role for groups in multidomain context https://review.opendev.org/703930
01:22:43	openstackgerrit	Merged openstack/ansible-collections-openstack master: Fix argument spec for os_subnet and os_zone https://review.opendev.org/703554
05:53:39	openstackgerrit	Kendall Nelson proposed openstack/python-openstackclient master: Remove mention of Meetings from docs https://review.opendev.org/704494
05:54:24	openstackgerrit	Kendall Nelson proposed openstack/python-openstackclient master: Remove mention of meetings from docs https://review.opendev.org/704494
06:03:15	mordred	diablo_rojo: ++
06:55:33	openstackgerrit	Monty Taylor proposed openstack/python-openstackclient master: Stop testing python2 https://review.opendev.org/686590
07:19:45	openstackgerrit	Bram Verschueren proposed openstack/ansible-collections-openstack master: Add os_routers_info module https://review.opendev.org/703927
07:28:42	bverschueren	@sshnaidm: regarding https://review.opendev.org/#/c/703927/; shall I clear tests/unit/requirements.txt from unnecessary packages ?
07:30:36	bverschueren	those were copied during the migration from the ansible repo but I guess they're not used for openstack testing
07:34:04	sshnaidm	bverschueren, of course, if you see something unnecessary you can clean it, but in different patch please so we can manage this easily
07:35:40	sshnaidm	bverschueren, would be great if you make some functional test here for new role: https://github.com/openstack/ansible-collections-openstack/blob/master/ci/roles/router/tasks/main.yml
07:36:57	bverschueren	yes, I will have a look at it
07:37:29	bverschueren	need to figure out how to run locally as I hadn't worked with collections before
12:30:33	openstackgerrit	Merged openstack/openstacksdk master: Fail a job for ansible modules with message https://review.opendev.org/703342
12:43:10	openstackgerrit	Merged openstack/openstacksdk stable/stein: Revert "Add fake support for global_request_id" https://review.opendev.org/704305
12:48:37	openstackgerrit	Sagi Shnaidman proposed openstack/ansible-collections-openstack master: WIP: porting Openstack guidelines spec from Ansible https://review.opendev.org/704558
13:54:05	openstackgerrit	Bram Verschueren proposed openstack/ansible-collections-openstack master: Add os_routers_info module https://review.opendev.org/703927
14:25:49	openstackgerrit	Will Tome proposed openstack/ansible-collections-openstack master: fix constructed compose https://review.opendev.org/704582
14:58:01	openstackgerrit	Sagi Shnaidman proposed openstack/ansible-collections-openstack master: WIP: porting Openstack guidelines spec from Ansible https://review.opendev.org/704558
15:23:09	openstackgerrit	Sagi Shnaidman proposed openstack/ansible-collections-openstack master: Add rstcheck for ansible-test to lint RST files https://review.opendev.org/704590
15:46:27	openstackgerrit	Will Tome proposed openstack/ansible-collections-openstack master: fix constructed compose https://review.opendev.org/704582
17:05:15	pabelanger	hello
17:05:48	pabelanger	it was pointed out to me in #ansible, that with the migration of ansible 'openstack' content to openstack project, a CLA is now required: https://opendev.org/openstack/project-config/src/branch/master/gerrit/acls/openstack/ansible-collections-openstack.config#L23
17:05:55	pabelanger	Is this correct
17:06:24	pabelanger	mordred: sshnaidm ^
17:20:57	sshnaidm	pabelanger, yep, see discussion on #openstack-ansible-sig
17:21:19	sshnaidm	pabelanger, oh, you're not there, just asked mnaser about that
17:22:03	openstackgerrit	Merged openstack/ansible-collections-openstack master: Add rstcheck for ansible-test to lint RST files https://review.opendev.org/704590
17:38:03	openstackgerrit	Sagi Shnaidman proposed openstack/ansible-collections-openstack master: WIP: porting Openstack guidelines spec from Ansible https://review.opendev.org/704558
17:38:08	openstackgerrit	Sagi Shnaidman proposed openstack/ansible-collections-openstack master: WIP: porting Openstack guidelines spec from Ansible https://review.opendev.org/704558
22:52:23	openstackgerrit	Keith Berger proposed openstack/python-openstackclient stable/rocky: Fix functional tests for py3 https://review.opendev.org/703683
#openstack-sdks - 2020-01-29
06:27:56	openstackgerrit	Merged openstack/openstacksdk stable/stein: Keep connection backrefs with weakref.proxy https://review.opendev.org/696220
08:50:31	openstackgerrit	Bram Verschueren proposed openstack/ansible-collections-openstack master: Add os_routers_info module https://review.opendev.org/703927
13:45:43	openstackgerrit	Bram Verschueren proposed openstack/ansible-collections-openstack master: Add os_routers_info module https://review.opendev.org/703927
14:19:30	openstackgerrit	Shilpa Devharakar proposed openstack/openstacksdk master: Added new filter `host_name` to segment list https://review.opendev.org/704814
15:32:21	KeithMnemonic	I would really like to get a few rocky patches merged before EM but need some reviews to get things moving. is there anyone who can help? https://review.opendev.org/#/c/701299/ and https://review.opendev.org/#/c/702260/ have to get merged before i can get my rocky cherry pick
20:30:37	openstackgerrit	Radosław Piliszek proposed openstack/js-openstack-lib master: WIP: New nodejs jobs https://review.opendev.org/702132
20:30:37	openstackgerrit	Radosław Piliszek proposed openstack/js-openstack-lib master: WIP: New nodejs jobs https://review.opendev.org/702132
22:54:30	openstackgerrit	Sagi Shnaidman proposed openstack/ansible-collections-openstack master: WIP Make an OpenStackModule base class https://review.opendev.org/698044
#openstack-sdks - 2020-01-30
01:43:52	openstackgerrit	Shogo Saito proposed openstack/openstacksdk master: Adding basic implementation for Accelerator(Cyborg) https://review.opendev.org/679914
11:58:54	openstackgerrit	Shilpa Devharakar proposed openstack/openstacksdk master: Added new filter `host_name` to segment list https://review.opendev.org/704814
12:37:32	odyssey4me	hey folks - what do we think is the best way to resolve https://github.com/ansible/ansible/issues/64495 / https://github.com/ansible/ansible/issues/64841 / https://bugs.launchpad.net/tripleo/+bug/1860810
12:37:32	openstack	Launchpad bug 1860810 in tripleo "os_ansible_tempest fails w/ create_network() got an unexpected keyword argument 'dns_domain'" [High,Triaged]
12:40:06	odyssey4me	sshnaidm: ^ any thoughts?
12:42:33	sshnaidm	odyssey4me, seems like need to bump openstacksdk version?
12:43:11	odyssey4me	sshnaidm: sure, I'm pushing up a patch to do that, but changing upper-constraints in openstack for a break in ansible/openstacksdk seems a bit odd
12:43:45	openstackgerrit	Michał Dulko proposed openstack/openstacksdk master: Fix error handling on add/remove router iface calls https://review.opendev.org/704998
12:44:29	sshnaidm	odyssey4me, yeah, need to look how we can protect..
12:44:33	odyssey4me	It looks to me like the module code just takes the lead from openstacksdk, unless I'm misreading it or missing something... so it seems odd that suddenly the module behaviour changes with the same version of openstacksdk being used.
12:47:44	sshnaidm	odyssey4me, from my brief look seems like openstacksdk version is not compatible with openstack api, and os_network just pass everything as is
12:48:31	odyssey4me	sshnaidm: so you're thinking that the sdk is passing something to the API and the API is the one returning the fail?
12:50:42	sshnaidm	odyssey4me, hmm.. or not: https://github.com/ansible/ansible/blob/devel/lib/ansible/modules/cloud/openstack/os_network.py#L229-L237
12:50:59	sshnaidm	odyssey4me, so that sdk doesn't have this option
12:51:08	odyssey4me	sshnaidm: yes, that makes more sense
12:51:51	sshnaidm	https://github.com/ansible/ansible/commit/6c74e29618a6872bc0da66e4992cfcd9cebf6acc
12:52:08	sshnaidm	it was something new ^
12:52:22	odyssey4me	yeah, and with that the sdk minimum version should have been updated
12:52:42	odyssey4me	odd, though is that we're getting this error from ansible2.8
12:52:52	odyssey4me	lemme see if I can find abackport
12:53:38	odyssey4me	no, this has not been ported back
12:54:06	odyssey4me	ok - so that means that whatever we're getting that back from is actually running ansible 2.9 - not 2.8
12:54:23	odyssey4me	I'll push a patch up to ansible to update the minimum SDK version... thanks for the help!
12:54:35	sshnaidm	all version: devel (#56453) v2.9.4 v2.9.3 v2.9.2 v2.9.1 v2.9.0 v2.9.0rc5 v2.9.0rc4 v2.9.0rc3 v2.9.0rc2 v2.9.0rc1 v2.9.0b1 stable-2.9-branchpoint
12:55:23	sshnaidm	it's good point to think how can we avoid such failures, maybe all new sdk features should come with version check

Earlier   Later