Earlier  
Later
New Search
Posted Nick Remark
#openstack-sdks - 2020-01-06
21:31:35 efried mordred: yeah, I noted that. The month since that fix was posted has effectively been less than a week of work time.
21:31:36 mordred efried: I just +A'd neil's Edouard's patch - looking at KeithMnemonic's now
21:31:40 mordred yah
21:31:58 efried thanks mordred
21:32:02 mordred I mean - he's not wrong about the overall situation - but in this specific instance I'd say that patch isn't too long in the tooth
21:32:48 efried I don't know that greasing the squeaky wheel is going to help push the message that we need more corporate investment, but it's good community stewardship I guess :P
21:33:33 mordred yeah
21:34:00 mordred I'm tempted to just approve the KeithMnemonic patch - it had a +2 from mriedem already, looks fine, and since that +2 just had a comment updated to fix a nit
21:37:20 efried seems reasonable to me.
21:39:40 KeithMnemonic thanks all
22:52:45 openstackgerrit Sean McGinnis proposed openstack/openstackclient master: Constrain openstackclient-check-plugins run on master https://review.opendev.org/701293
22:54:05 openstackgerrit Sean McGinnis proposed openstack/openstackclient master: Constrain openstackclient-check-plugins run on master https://review.opendev.org/701293
23:15:06 openstackgerrit Eric Fried proposed openstack/openstackclient master: Update doc index links (for storyboard etc) https://review.opendev.org/691728
23:53:46 openstackgerrit Merged openstack/openstackclient master: Update doc index links (for storyboard etc) https://review.opendev.org/691728
#openstack-sdks - 2020-01-07
00:18:45 openstackgerrit Merged openstack/python-openstackclient master: Fix openstack server list --deleted --marker option https://review.opendev.org/691045
00:57:31 openstackgerrit Brin Zhang proposed openstack/python-openstackclient master: Add server migrate list CLI https://review.opendev.org/675304
03:16:27 openstackgerrit wayen proposed openstack/keystoneauth master: Make tests pass in 2020 https://review.opendev.org/701320
13:18:39 mordred amotoki: are you still around? if so, could you hit https://review.opendev.org/#/c/695427 ?
13:39:04 openstackgerrit Monty Taylor proposed openstack/openstacksdk master: Fix bug in object storage container creation setting metadata https://review.opendev.org/699904
13:43:15 openstackgerrit Merged openstack/python-openstackclient master: Fix router create/show if extraroute not supported https://review.opendev.org/697240
13:49:34 openstackgerrit Monty Taylor proposed openstack/openstacksdk master: Fix bug in object storage container creation setting metadata https://review.opendev.org/699904
13:49:47 mordred adriant: how's that as a fix for your fix? ^^
13:50:19 mordred (also, I think that test case was flat wrong)
14:10:21 amotoki mordred: looking at it now
14:23:09 openstackgerrit Monty Taylor proposed openstack/python-openstackclient master: Bump tox minversion https://review.opendev.org/701369
14:23:14 mordred amotoki: awesome, thanks! there's the tox bump
14:24:13 amotoki mordred: thanks for the follow-up so far :)
14:27:14 KeithMnemonic looking for some reviews to get this patch merged that solves issues with getting stable python-openstackclient patches to verify. https://review.opendev.org/#/c/701293/
14:57:17 KeithMnemonic this one as well please https://review.opendev.org/#/c/695645/
15:03:54 openstackgerrit Merged openstack/keystoneauth master: Switch to Ussuri jobs https://review.opendev.org/691233
15:06:06 openstackgerrit Merged openstack/osc-lib master: Drop python 2.7 support and testing https://review.opendev.org/700686
15:11:58 openstackgerrit Eric Fried proposed openstack/openstackclient master: Use python3 for openstackclient-check-plugins job https://review.opendev.org/701378
15:39:57 openstackgerrit Merged openstack/python-openstackclient master: Stop testing python 2 in tox and zuul. https://review.opendev.org/695427
15:56:43 openstackgerrit Eric Fried proposed openstack/openstackclient master: Use python3 for openstackclient-check-plugins job https://review.opendev.org/701378
16:32:08 stephenfin smcginnis: About? I've just looked at that cliff/openstacksdk docs issue
17:31:14 openstackgerrit Monty Taylor proposed openstack/keystoneauth master: [ussuri][goal] Drop python 2.7 support and testing https://review.opendev.org/699121
19:01:40 openstackgerrit Eric Fried proposed openstack/openstackclient master: Use python3 for openstackclient-check-plugins job https://review.opendev.org/701378
20:57:35 openstackgerrit Merged openstack/keystoneauth master: [ussuri][goal] Drop python 2.7 support and testing https://review.opendev.org/699121
21:52:50 openstackgerrit guang-yee proposed openstack/keystoneauth master: fix bandit complains https://review.opendev.org/701461
22:01:04 adriant mordred: that looks good to me
22:01:16 mordred adriant: woot!
22:01:36 adriant and I see you removed json body from the create entirely, which for containers makes perfect sense
22:02:14 mordred yeah - since we're already overriding that method anyway - seemed like the better thing to do
22:02:40 adriant mordred: I guess I shouldn't feel bad, because they need to be fixed, but I keep finding all the swift bugs in the SDK :P
22:02:57 mordred adriant: it's great! :)
22:03:08 mordred Shrews: if you have a sec, feel like a review of https://review.opendev.org/#/c/699904/ ?
22:03:25 mordred Shrews: adriant wrote the first version, then I updated it - so we're in murky core land
22:09:54 adriant I've +2'd it, but yeah someone else should look and merge as well
22:25:46 openstackgerrit Monty Taylor proposed openstack/openstacksdk master: Add support for object storage container policies https://review.opendev.org/699905
22:25:56 mordred rebased that one
22:29:36 Shrews mordred: done. trusting you that there's nothing in the body to send
22:38:14 mordred Shrews: yah - there is no body in either direction with swift container interactions
22:38:33 mordred Shrews: I'm also sure that just by saying the word swift, timburke would appear magically and tell us if we were wrong
22:43:29 timburke o/
22:43:35 timburke not wrong, on either count ;-)
22:43:54 timburke well, unless you want to talk bulk operations...
22:51:00 mordred timburke: let's just assume for now that I don't :)
23:45:00 openstackgerrit Merged openstack/openstacksdk master: Fix bug in object storage container creation setting metadata https://review.opendev.org/699904
#openstack-sdks - 2020-01-08
00:01:35 adriant lol, timburke, mordred, that's probably one of my next SDK patches :P
00:01:54 adriant Once I can convince our ops to actually enable bulk operations
00:54:06 timburke adriant, out of curiosity, what's driving their hesitation?
01:10:00 adriant timburke: at first just worries about performance, but we'll be watching that, now it's just issues with our deployment tooling
01:43:41 openstackgerrit Merged openstack/keystoneauth master: fix bandit complains https://review.opendev.org/701461
08:45:08 openstackgerrit Andreas Jaeger proposed openstack/js-openstack-lib master: Retire js-openstack-lib repository https://review.opendev.org/701512
09:54:30 openstackgerrit Daniel Bengtsson proposed openstack/python-openstackclient master: Stop configuring install_command in tox and stop use pip. https://review.opendev.org/694484
16:48:09 openstackgerrit Alex Katz proposed openstack/python-openstackclient master: Show correct name for resource with quota set to zero https://review.opendev.org/701110
17:36:01 openstackgerrit Bence Romsics proposed openstack/python-openstackclient master: Add command: router add/remove route --route https://review.opendev.org/674325
19:07:33 KeithMnemonic any chance someone can please look at this today to help get it merged? https://review.opendev.org/#/c/695645/ thanks in advance
19:08:14 efried mordred, dtroyer, amotoki: ^
19:08:39 efried um, assuming python-openstackclient doesn't have a separate core team for stable?
19:08:55 efried bleh, they do.
19:09:18 efried But dtroyer is on it, at least
19:18:26 KeithMnemonic thanks efried, hopefully he will look at it sooner than later, i have some other patches on stable branches that will need reviewed once all of the issues with the branches passing get fixed
19:19:50 efried Unclear what the fate of stable will be since its godfather has left openstack, and given dwindling maintainer numbers. Have you seen the ML thread on this topic?
19:20:47 efried http://lists.openstack.org/pipermail/openstack-discuss/2019-November/thread.html#10911
19:23:21 KeithMnemonic i have now, thanks!
19:41:47 cmurphy i'll add a plea for feedback on https://review.opendev.org/677857 (thanks frickler for doing so already)
19:51:54 mordred cmurphy: oh god. that first set of comments about the naming is hard
19:53:07 cmurphy mordred: yep this is where it would be nice for dean to weigh in :/
19:53:18 mordred ++
20:13:53 cmurphy thanks for the review mordred
20:14:06 mordred cmurphy: sure nuff!
20:19:49 mordred amotoki: if you get a moment, would you mind looking at cmurphy's patch ^^
23:14:41 openstackgerrit Merged openstack/python-openstackclient master: Bump tox minversion https://review.opendev.org/701369
23:44:44 openstackgerrit Colleen Murphy proposed openstack/python-openstackclient master: Add support for app cred access rules https://review.opendev.org/677857
#openstack-sdks - 2020-01-09
09:34:46 openstackgerrit Bence Romsics proposed openstack/python-openstackclient master: Add command: router add/remove route --route https://review.opendev.org/674325
09:42:36 openstackgerrit Akihiro Motoki proposed openstack/python-openstackclient master: Replace six.iteritems() with .items() https://review.opendev.org/481407
10:54:20 openstackgerrit Akihiro Motoki proposed openstack/openstacksdk master: Bump min version of decorator https://review.opendev.org/701706
12:23:11 openstackgerrit Daniel Bengtsson proposed openstack/python-openstackclient master: Stop configuring install_command in tox and stop use pip. https://review.opendev.org/694484
13:50:44 openstackgerrit Monty Taylor proposed openstack/openstacksdk master: Replace six.iteritems() with .items() https://review.opendev.org/701729
14:22:36 mordred smcginnis: wow. you found an old osc patch
14:31:49 smcginnis mordred: I like to scroll to the oldest once and awhile to see what's been getting really stale. ;)
14:32:18 mordred smcginnis: I tink it's neat that that change has a +1 from both Jenkins and Zuul
14:32:20 smcginnis I actually abandoned at least one from 2016 that wasn't really relevant anymore but was still sitting out there. Probably a lot that could get cleaned up by now.
14:32:28 smcginnis Haha, yeah!
14:43:40 mordred smcginnis: that made me curious - my oldest still-open change: https://review.opendev.org/#/c/119920/
14:44:40 smcginnis Nice! Any open patch that starts with a 1 is impressive. :)
15:17:08 openstackgerrit Merged openstack/openstacksdk master: Bump min version of decorator https://review.opendev.org/701706
15:23:58 openstackgerrit Merged openstack/python-openstackclient master: Replace six.iteritems() with .items() https://review.opendev.org/481407
15:57:35 sshnaidm hi all

Earlier   Later