| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-sdks - 2019-10-03 | |||
| 14:00:56 | mordred | I'm guessing I'd want to put something into the ServerGroup resource that controlled which mv it used when doing the creation call | |
| 14:08:11 | openstackgerrit | Monty Taylor proposed openstack/openstacksdk master: Fix server for later microversion https://review.opendev.org/685999 | |
| 14:10:41 | mordred | dtantsur|afk: neverind - mriedem tells me that in this case it's easy - old mv never actually supported a list | |
| 14:11:10 | mriedem | child's play | |
| 14:19:33 | openstackgerrit | Pierre Prinetti proposed openstack/python-openstackclient master: versions: Fix 'versions show' help message https://review.opendev.org/686408 | |
| 14:23:19 | openstackgerrit | Pierre Prinetti proposed openstack/python-openstackclient master: versions: Fix 'versions show' help message https://review.opendev.org/686408 | |
| 15:33:45 | openstackgerrit | Pierre Prinetti proposed openstack/python-openstackclient master: versions: Fix 'versions show' help message https://review.opendev.org/686408 | |
| 15:37:32 | openstackgerrit | Matt Riedemann proposed openstack/python-openstackclient master: versions: Fix 'versions show' help message https://review.opendev.org/686408 | |
| 15:46:11 | openstackgerrit | Pierre Prinetti proposed openstack/python-openstackclient master: versions: Fix 'versions show' help message https://review.opendev.org/686408 | |
| 15:56:33 | openstackgerrit | Tristan Cacqueray proposed openstack/openstacksdk master: WIP: annotate some swift function used by the zuul_registry https://review.opendev.org/686433 | |
| 15:59:43 | openstackgerrit | Matt Riedemann proposed openstack/python-openstackclient master: versions: Fix 'versions show' help message https://review.opendev.org/686408 | |
| 16:00:49 | elmiko | API SIG office hour is now open | |
| 23:59:14 | openstackgerrit | Brin Zhang proposed openstack/python-openstackclient master: Add server migrate list CLI https://review.opendev.org/675304 | |
| #openstack-sdks - 2019-10-04 | |||
| 06:51:36 | openstackgerrit | Monty Taylor proposed openstack/openstacksdk master: Fix server for later microversion https://review.opendev.org/685999 | |
| 06:52:29 | openstackgerrit | Monty Taylor proposed openstack/openstacksdk master: Fix server for later microversion https://review.opendev.org/685999 | |
| 06:53:16 | openstackgerrit | Monty Taylor proposed openstack/keystoneauth master: Fetch discovery documents with auth when needed https://review.opendev.org/685042 | |
| 06:56:04 | mordred | efried, cmurphy, kmalloc, Shrews: https://review.opendev.org/#/q/topic:fix-auth-discovery <-- assuming all three are green, I believe that is now the stack with the right depends-on to fix the issue and that the tests jobs properly validate the issue. the sdk patches should show that the needed sdk fixes work without the ksa fix, then the sdk test jobs on the ksa patch show that they continue to work | |
| 06:56:06 | mordred | with the fix added | |
| 06:56:46 | mordred | which should make it safe to land the openstacksdk patches, cut a release, then land the ksa patch and cut a release. | |
| 06:57:48 | mordred | of course, I *think* what we need here (correct me if I'm wrong efried) is that we need to land the patches, then backport to stable/train, then cut a stable release on train - first for sdk then for ksa | |
| 08:09:08 | openstackgerrit | Monty Taylor proposed openstack/openstacksdk master: WIP Start supporting type info https://review.opendev.org/686397 | |
| 08:09:09 | openstackgerrit | Monty Taylor proposed openstack/openstacksdk master: Use generated list of services instead of metaclass https://review.opendev.org/686542 | |
| 09:05:29 | openstackgerrit | Monty Taylor proposed openstack/openstacksdk master: Use generated list of services instead of metaclass https://review.opendev.org/686542 | |
| 10:57:35 | mordred | gtema: https://review.opendev.org/#/c/686542/ if you get a sec | |
| 11:09:34 | openstackgerrit | Monty Taylor proposed openstack/openstacksdk master: Start supporting type info https://review.opendev.org/686397 | |
| 11:27:35 | mordred | Shrews, cmurphy, efried, kmalloc: woot! all green! | |
| 11:58:40 | bverschueren_ | if anyone has a moment to look at https://review.opendev.org/#/c/682909/ ? thx | |
| 12:23:00 | mordred | gtema, efried: incidentally - the ksa patch also fixes a thing that sdk was doing but we weren't noticing - which is making a failed call to discovery before *every* nova call -- because it failed, it didn't cache a discovery document | |
| 12:23:22 | gtema | really? cool | |
| 12:23:26 | mordred | I only noticed it was happing debugging a different issue | |
| 12:23:27 | mordred | yeah | |
| 12:24:04 | gtema | ok. I do not see this in my cloud, so perhaps some additional Nova change is there, but cool that it fixes things generally | |
| 12:28:38 | gtema | nom, you are totally right - I simply haven't noticed that | |
| 12:39:21 | openstackgerrit | Monty Taylor proposed openstack/os-client-config master: Stop testing python2.7 https://review.opendev.org/686589 | |
| 12:43:56 | openstackgerrit | Monty Taylor proposed openstack/python-openstackclient master: Stop testing python2 https://review.opendev.org/686590 | |
| 12:48:24 | openstackgerrit | Monty Taylor proposed openstack/openstacksdk master: Stop testing python2 https://review.opendev.org/686592 | |
| 12:56:27 | openstackgerrit | Monty Taylor proposed openstack/openstacksdk master: Fix server for later microversion https://review.opendev.org/685999 | |
| 12:57:02 | mordred | gtema: ^^ I added a release note (was going to backport to stable/train, but noticed there was no release note explaining why the patch was important) | |
| 13:06:20 | openstackgerrit | OpenStack Release Bot proposed openstack/python-openstackclient master: Update master for stable/train https://review.opendev.org/686607 | |
| 13:12:55 | gtema | mordred: +2-ed | |
| 13:15:55 | mordred | gtema: thanks! | |
| 13:30:05 | efried | mordred: I concur with your assessment. Were you thinking we would get those stable/train releases into train's requirements before the release? | |
| 13:30:32 | openstackgerrit | Merged openstack/python-openstackclient master: Update master for stable/train https://review.opendev.org/686607 | |
| 13:41:39 | mordred | efried: I don't know if it's possible to - but I figured cutting a small point release on top of train shortly after the release could also work, yeah/ | |
| 13:41:41 | mordred | ? | |
| 13:42:51 | efried | mordred: the difference being that we cannot update e.g. nova's lower-constraints after the release, so we can't rely on the new behavior in train in that case. | |
| 13:44:30 | mordred | hrm. maybe it's worth going and talking to our release friends | |
| 13:51:33 | openstackgerrit | Monty Taylor proposed openstack/keystoneauth master: Fetch discovery documents with auth when needed https://review.opendev.org/685042 | |
| 13:54:45 | openstackgerrit | Monty Taylor proposed openstack/keystoneauth master: Fetch discovery documents with auth when needed https://review.opendev.org/685042 | |
| 14:26:24 | mordred | dtroyer: is this https://762ea4c4c4fb203eceec-1a0f674a3837e35101e72ddbc77fd8ba.ssl.cf2.rackcdn.com/686589/1/check/osc-functional-devstack-tips/de578de/testr_results.html.gz | |
| 14:26:33 | mordred | something we should be worried about and/or know about already? | |
| 14:37:49 | dtroyer | mordred: I do not recall seeing that before. volume tests are historically timing sensitive but we've eliminated most of them (I think). Thats a compute test but volumes are involved. Have you seen more than one of these? | |
| 14:43:29 | mordred | dtroyer: no - I should probably just recheck then | |
| 15:02:44 | efried | mordred: reviewing that test change, I wonder if has_service ought to return the endpoint(_data) so we don't wind up duplicating calls... | |
| 15:03:49 | mordred | efried: well - the reason to change to has_service is that we don't actually need to do the full endpoint_data call (which results in a discovery api call) in a lot of cases | |
| 15:04:03 | openstackgerrit | Merged openstack/os-client-config master: Update the constraints url https://review.opendev.org/685581 | |
| 15:04:04 | efried | yah, I get that | |
| 15:04:11 | mordred | oh - but ... maybe make has_service also take a mv arg? | |
| 15:04:33 | efried | I'm looking for usages of has_service to see if any of the are directly followed by something that does discovery | |
| 15:04:42 | efried | I would think that in most cases the discovery is cached already one way or another. | |
| 15:04:43 | mordred | nod | |
| 15:04:48 | mordred | yeah | |
| 15:04:54 | mordred | once it's done - it should be cached | |
| 15:05:25 | efried | yeah, nothing jumps out. Probably n/a then. Ignore me. | |
| 15:15:34 | efried | mordred: I think the dep chain might be busted. Care to join me in -requirements ? | |
| 15:30:12 | openstackgerrit | Monty Taylor proposed openstack/keystoneauth master: Fetch discovery documents with auth when needed https://review.opendev.org/685042 | |
| 15:40:21 | openstackgerrit | Monty Taylor proposed openstack/keystoneauth master: Fetch discovery documents with auth when needed https://review.opendev.org/685042 | |
| 15:40:45 | efried | wfm, thanks mordred | |
| 15:42:32 | efried | dangit, where tf is the cloud data sdk tests with? | |
| 15:43:57 | efried | k, found the discovery documents. Looking for the flavors it loads up... | |
| 15:44:10 | mordred | efried: right there! | |
| 15:45:41 | efried | mordred: Sorry, help please, still not seeing where flavor data comes from | |
| 15:45:54 | efried | i.e. self.flavor here https://review.opendev.org/#/c/685999/7/openstack/tests/functional/cloud/test_inventory.py | |
| 15:47:38 | efried | mebbe openstack.tests.fakes.make_fake_flavor ? | |
| 15:47:52 | mordred | no - that's a functional test | |
| 15:48:03 | mordred | it's the flavor that we get find from devstack | |
| 15:48:22 | mordred | efried: from openstack.tests.functional.cloud.util import pick_flavor | |
| 15:48:42 | efried | ...from devstack? | |
| 15:49:09 | efried | Are these "functional" tests running in a devstack?? | |
| 15:49:43 | mordred | efried: yes. that's how the sdk functional tests work. | |
| 15:49:45 | mordred | https://opendev.org/openstack/openstacksdk/src/branch/master/openstack/tests/functional/cloud/util.py#L23-L43 | |
| 15:50:01 | mordred | efried: the idea is that we point sdk at the devstack and then we use that devstack as a remote cloud | |
| 15:50:09 | efried | whoah. | |
| 15:50:14 | efried | I mean, cool, but... whoah. | |
| 15:50:22 | mordred | :) | |
| 15:50:28 | mordred | it's a fun set of tests | |
| 15:50:35 | efried | so what I don't get is why the deltas in that file are necessary/appropriate. | |
| 15:51:19 | mordred | because what the ksa patch fixed was microversion detection - so we now correctly detect the available microversion, which means we're now fetching Server at the mv declared in the server resource | |
| 15:51:26 | mordred | which means we get the new form of flavor now | |
| 15:51:39 | mordred | this change SHOULD have gone into the change last april that bumped our microversion | |
| 15:51:59 | efried | okay, the test is way more magic than I was seeing | |
| 15:52:01 | efried | thanks. | |
| 15:52:02 | mordred | but we didn;t notice a that point that the behavior changed because the mv discovery was silently broke | |
| 15:52:46 | mordred | it's actually super un-magic- it's just actually creating a server on an openstack and checking that it works. easy peasy right? | |
| 15:54:05 | efried | mordred: next point of confusion... | |
| 15:54:12 | efried | the references to 'host' in this test code... | |
| 15:54:18 | efried | are those actualy *instances*?? | |
| 15:54:36 | efried | based on OpenStackInventory.list_hosts, it... kinda looks like they might be | |
| 15:54:49 | efried | because that's doing compute.list_servers | |
| 15:55:43 | mordred | yes indeed | |