| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-sdks - 2019-09-26 | |||
| 11:41:45 | mordred | yay for enjoyment! :) | |
| 13:42:08 | efried | mordred: Thanks! I'll take a look at that very soon. | |
| 13:42:32 | efried | mordred: were you planning to cut another Train release? | |
| 13:43:09 | efried | I guess that's a backportable bugfix in any case. (Is SDK on a cycle release model anyway?) | |
| 15:01:47 | brtknr | mordred: would you mind blessing this: https://github.com/ansible/ansible/pull/62874 | |
| 15:02:28 | brtknr | or anyone else for that matter | |
| 15:54:32 | efried | mordred: Do we have a doc somewhere containing the edict that discovery endpoints should not require auth? | |
| 15:55:06 | efried | elmiko: perhaps that's something you would also know? | |
| 16:01:00 | cdent | it may be in that discovery doc that languished without merging for so long | |
| 16:01:00 | elmiko | API SIG office hour is now starting | |
| 16:01:08 | cdent | not sure if it ever did | |
| 16:01:41 | elmiko | efried: i feel like there /may/ be some guidance about that, but iirc it is in the languishing doc that cdent is referring to | |
| 16:01:52 | elmiko | at the least, i think it came up for discussion | |
| 16:02:19 | elmiko | i have been reviewing these open pull requests, but it has been slow going | |
| 16:05:08 | elmiko | efried: it /might/ be burried in here https://review.opendev.org/#/c/459405/ | |
| 16:07:14 | elmiko | efried: this document certainly seems to imply that they should be public | |
| 16:07:17 | elmiko | http://specs.openstack.org/openstack/api-sig/guidelines/discoverability.html | |
| 16:08:25 | efried | thanks | |
| 16:09:47 | efried | I'm going to open a bug against nova for not doing that (for the versioned disc endpoint) | |
| 16:09:53 | efried | ...once this meeting is done | |
| 16:10:17 | elmiko | ok, i am working to try and get the rest of these version discovery docs merged. it will probably take another few weeks though | |
| 16:10:37 | elmiko | and they might have some warts, but hopefully we can file them down ;) | |
| 16:15:02 | efried | https://bugs.launchpad.net/nova/+bug/1845530 for now, will update once I find that doc... | |
| 16:15:02 | openstack | Launchpad bug 1845530 in OpenStack Compute (nova) "Versioned discovery endpoint should not require authentication" [Undecided,New] | |
| 16:22:47 | elmiko | efried: so, are we talking about just service discovery? | |
| 16:29:03 | elmiko | i just want to point this out, http://specs.openstack.org/openstack/api-sig/guidelines/consuming-catalog.html#discovery-algorithm | |
| 16:29:29 | elmiko | the "basic process" described there seems to indicate that a user /should/ authenticate to get the service endpoints | |
| 16:29:36 | elmiko | but i'm not sure if this is the same topic | |
| 16:30:07 | elmiko | oh yeah, disregard. i just re-read your bug | |
| 16:33:32 | elmiko | efried: found it | |
| 16:33:35 | elmiko | https://review.opendev.org/#/c/459710/17/guidelines/discoverability.rst | |
| 16:33:40 | elmiko | look at line 93 | |
| 16:33:47 | elmiko | i'll add a comment on the bug you made | |
| 17:05:22 | efried | elmiko: thanks for that add, much appreciated. | |
| 17:37:24 | openstackgerrit | Colleen Murphy proposed openstack/keystoneauth master: Follow the PTI for docs https://review.opendev.org/685138 | |
| 17:39:26 | kmalloc | hm... guang is not here | |
| 17:40:02 | kmalloc | cmurphy: https://review.opendev.org/#/c/677239/ this review is going to need to be watched. i removed my -2 on it, but this is absolutely not the fix. | |
| 17:40:10 | cmurphy | kmalloc: he's in -keystone | |
| 17:40:17 | kmalloc | ah wait. damn wrong channel | |
| 18:13:34 | openstackgerrit | Colleen Murphy proposed openstack/keystoneauth master: Follow the PTI for docs https://review.opendev.org/685138 | |
| 18:41:09 | openstackgerrit | guang-yee proposed openstack/keystoneauth master: Generate pdf documentation https://review.opendev.org/682272 | |
| 21:55:19 | efried | mordred, elmiko: FYI: https://review.opendev.org/#/q/topic:bug/1845530+(status:open+OR+status:merged) | |
| 21:55:40 | efried | I'm too dumb to figure out api-paste.ini | |
| 22:00:29 | elmiko | efried: ack, tnx | |
| #openstack-sdks - 2019-09-27 | |||
| 05:06:24 | openstackgerrit | Shogo Saito proposed openstack/openstacksdk master: Adding basic implementation for Accelerator(Cyborg) https://review.opendev.org/679914 | |
| 06:14:01 | openstackgerrit | Merged openstack/openstacksdk master: Make proxy honor raise_exc in REST primitives https://review.opendev.org/684433 | |
| 07:28:40 | openstackgerrit | Vishakha Agarwal proposed openstack/keystoneauth master: Generate pdf documentation https://review.opendev.org/682272 | |
| 07:46:29 | openstackgerrit | Shogo Saito proposed openstack/openstacksdk master: Adding basic implementation for Accelerator(Cyborg) https://review.opendev.org/679914 | |
| 08:45:21 | openstackgerrit | Bernhard M. Wiedemann proposed openstack/keystoneauth master: Make tests pass in 2020 https://review.opendev.org/681103 | |
| 10:24:32 | openstackgerrit | Neil Jerram proposed openstack/python-openstackclient master: Allow for router resource without 'routes' attribute https://review.opendev.org/685312 | |
| 10:49:10 | mordred | efried: cool. I'd be happy to backport to train. need to see what cmurphy thinks about backporting the ksa patch | |
| 10:49:23 | openstackgerrit | Monty Taylor proposed openstack/keystoneauth master: Add support for authenticated endpoint_data https://review.opendev.org/685042 | |
| 11:40:09 | mordred | cmurphy, kmalloc: ^^ re that - I was just thinking - instead of that approach - what if we made the discovery call do try: request(auth=False) except 401: request(auth=True) - so that we'll still work with auth-needing discovery docs, but we'll gradually go back to the general noauth case as projects stop requiring it? | |
| 11:40:37 | mordred | it's a little less efficient for the auth requiring case, due to 2 calls | |
| 11:51:54 | efried | mordred: I think that's a reasonable idea. Log a shame warning for the service to unauth their discovery endpoints. Should happen just once per client conn, so hopefully not too intrusive, nah? | |
| 11:52:26 | efried | hacking in new kwargs, we kinda have to support them forever-ish, which is :( | |
| 11:59:13 | openstackgerrit | Bernhard M. Wiedemann proposed openstack/keystoneauth master: Make tests pass in 2020 https://review.opendev.org/681103 | |
| 12:02:09 | openstackgerrit | Stephen Finucane proposed openstack/osc-lib master: Add KeyValueAppendAction to osc-lib https://review.opendev.org/685328 | |
| 12:03:30 | openstackgerrit | Stephen Finucane proposed openstack/python-openstackclient master: Stop silently ignoring invalid 'server create --hint' options https://review.opendev.org/685329 | |
| 12:03:30 | openstackgerrit | Stephen Finucane proposed openstack/python-openstackclient master: Use 'KeyValueAppendAction' from osc-lib https://review.opendev.org/685330 | |
| 14:09:54 | openstackgerrit | Stephen Finucane proposed openstack/python-openstackclient master: Stop silently ignoring invalid 'server create --hint' options https://review.opendev.org/685329 | |
| 14:09:57 | openstackgerrit | Stephen Finucane proposed openstack/python-openstackclient master: Use 'KeyValueAppendAction' from osc-lib https://review.opendev.org/685330 | |
| 14:11:28 | openstackgerrit | Stephen Finucane proposed openstack/osc-lib master: Add KeyValueAppendAction to osc-lib https://review.opendev.org/685359 | |
| 14:12:36 | openstackgerrit | Dmitry Tantsur proposed openstack/openstacksdk master: Add a non-voting ironic-inspector job https://review.opendev.org/684729 | |
| 14:13:35 | openstackgerrit | Dmitry Tantsur proposed openstack/openstacksdk master: DNM try breaking ironic-inspector https://review.opendev.org/685360 | |
| 14:23:27 | stephenfin | dtroyer, dtantsur: Could I have you folks look at https://review.opendev.org/#/c/685329/, please? | |
| 14:43:03 | dtantsur | stephenfin: I don't have +2 rights there, so will be of little help | |
| 14:43:22 | stephenfin | dtantsur: Ah, pity. No problem | |
| 16:05:57 | cmurphy | mordred: it's adding a feature so i think it's a no-go on backporting | |
| 16:36:43 | efried | cmurphy: what about the auto-fallback-on-401 option? | |
| 16:47:07 | cmurphy | efried: that might be fine | |
| 20:08:20 | efried | mordred, elmiko: I think I did it https://review.opendev.org/685181 | |
| 20:55:00 | elmiko | \o/ | |
| #openstack-sdks - 2019-09-28 | |||
| 02:38:31 | openstackgerrit | Merged openstack/keystoneauth master: Follow the PTI for docs https://review.opendev.org/685138 | |
| 02:40:11 | openstackgerrit | Merged openstack/keystoneauth master: Generate pdf documentation https://review.opendev.org/682272 | |
| #openstack-sdks - 2019-09-29 | |||
| 02:26:03 | openstackgerrit | pengyuesheng proposed openstack/os-service-types master: Update the constraints url https://review.opendev.org/685556 | |
| 06:59:32 | openstackgerrit | pengyuesheng proposed openstack/os-client-config master: Update the constraints url https://review.opendev.org/685581 | |
| #openstack-sdks - 2019-09-30 | |||
| 16:39:41 | mordred | efried: I'm just now back in sweden and having fun with timezone shifts, so I'm useless atm. however, when I wake up, I'm going to redo the keystoneauth patch to do the 401 retry | |
| 16:39:55 | efried | mordred: ack, ++ | |
| 16:40:26 | efried | mordred: I've clearly got some more work to do getting nova to allow versioned discovery unauth, but I think I've got it on the run. | |
| 21:10:29 | rm_work | with the SDK when I do: `user_cloud = admin_cloud.connect_as_project(user_project)`, and try to access `user_cloud.identity`, it fails because it can't determine the identity api version, but `admin_cloud.identity` works fine. is something not getting copied over correctly? | |
| 21:10:51 | rm_work | ^^ looking into whether domain isn't getting set properly -- though it's weird that it works on one but not the other | |
| 21:11:36 | efried | rm_work: stack trace or log msg? | |
| 21:12:02 | rm_work | yeah sec, it's via another app using it so i'll dig out the exact response | |
| 21:13:11 | rm_work | trying to trace in | |
| 21:13:56 | rm_work | the high level response is: `NotSupported('The identity service for : exists but does not have any supported versions.',)` | |
| 21:14:59 | rm_work | ok well i did actually find out that i was wrong | |
| 21:15:04 | rm_work | it didn't work on admin_cloud either | |
| 21:15:08 | rm_work | so that makes more sense | |
| 21:15:28 | rm_work | and means it's not an issue with copying something, so much as just not being able to set the version correctly | |
| 21:15:56 | rm_work | which PROBABLY means that I just need to have some other arg set in the config when I pass it to the connection | |
| 21:16:06 | efried | wanna show me your connection init? | |
| 21:16:25 | rm_work | finding it | |
| 21:17:14 | rm_work | it's done via `connection.Connection(config=config.get_one(argparse=options))` | |
| 21:17:56 | rm_work | `config` is an os_client_config.config.OpenStackConfig object | |
| 21:18:13 | rm_work | so, probably "options" needs to have an identity-version set | |
| 21:19:25 | efried | Gotta run for ~20 mins, will check back... | |
| 21:31:43 | rm_work | yeah ok so basically there needs to be a way to specify "--os-identity-api-version" in the argparser that's passed in to the config that's then passed to the SDK | |
| 21:32:07 | rm_work | which wasn't happening (that isn't apparently part of the os_client_config arguments or the auth-module options :/ | |
| 21:32:30 | rm_work | which ... seems like maybe a bug there but for now i'll just add that arg explicitly in the app and that does it | |