| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-sdks - 2019-09-18 | |||
| 15:59:27 | dtroyer | mriedem: follow-up is fine, the usual worry is it never getting done, I trust you will see to that :) | |
| 15:59:38 | mriedem | i've got the patch locally, pushing | |
| 15:59:39 | dtroyer | er, see to it getting done | |
| 16:01:10 | openstackgerrit | Matt Riedemann proposed openstack/python-openstackclient master: Provide stderr in exception when check_parser fails https://review.opendev.org/682939 | |
| 16:06:37 | openstackgerrit | Artem Goncharov proposed openstack/python-openstackclient master: WIP: Switch image to use SDK https://review.opendev.org/650374 | |
| 17:24:35 | openstackgerrit | Merged openstack/openstacksdk master: baremetal-introspection: add manage_boot argument to start_introspection https://review.opendev.org/681225 | |
| #openstack-sdks - 2019-09-19 | |||
| 11:57:17 | openstackgerrit | Andreas Florath proposed openstack/python-openstackclient master: Fix osc-lib interface change: catch osc-lib Forbidden https://review.opendev.org/683118 | |
| 11:58:52 | openstackgerrit | Andreas Florath proposed openstack/osc-lib master: Fix osc-lib interface change: throw osc-lib Forbidden https://review.opendev.org/683119 | |
| 11:59:43 | openstackgerrit | Andreas Florath proposed openstack/python-openstackclient master: Fix osc-lib interface change: catch osc-lib Forbidden https://review.opendev.org/683118 | |
| 16:00:10 | elmiko | API SIG office hour is now starting | |
| 16:00:25 | mordred | you're an office hour | |
| 16:01:09 | elmiko | haha | |
| 16:04:39 | dtantsur | o/ | |
| 16:04:52 | dtantsur | I'm here for a short time since I'm still on a crazy post-relocation schedule | |
| 16:05:37 | mordred | dtantsur: I have missed things - where did you relocation? | |
| 16:05:50 | dtantsur | mordred: Düsseldorf (west Germany) | |
| 16:06:03 | mordred | dtantsur: oh wow | |
| 16:06:13 | elmiko | dtantsur: ack, hope the move/post-move are going well | |
| 16:06:40 | dtantsur | it goes so-so :) finding a flat is never fun in Germany | |
| 16:06:44 | elmiko | by way of business, i did start triaging our backlog of reviews | |
| 16:06:52 | mordred | dtantsur: one of these days I really want to come see the hanging train next door to you in Wuppertal | |
| 16:06:57 | elmiko | it's slow moving, but i think i can make some progress over the next few weeks | |
| 16:07:10 | dtantsur | mordred: come and see :) I haven't seen it as well yet | |
| 16:07:17 | dtantsur | great job elmiko! | |
| 16:07:23 | elmiko | hanging train sounds fun | |
| 16:07:41 | dtantsur | https://en.wikipedia.org/wiki/Wuppertal_Suspension_Railway | |
| 16:08:07 | elmiko | neat | |
| 16:43:44 | openstackgerrit | Michael Johnson proposed openstack/python-openstackclient master: Switch to using osc_lib.utils.tags https://review.opendev.org/662864 | |
| 17:01:16 | elmiko | take care all o/ | |
| #openstack-sdks - 2019-09-20 | |||
| 06:46:47 | openstackgerrit | zhurong proposed openstack/openstacksdk master: Fix the wrong doc use oslo_conf param https://review.opendev.org/683296 | |
| 16:26:49 | openstackgerrit | OpenStack Release Bot proposed openstack/openstacksdk master: Update master for stable/train https://review.opendev.org/683478 | |
| 16:27:21 | openstackgerrit | OpenStack Release Bot proposed openstack/os-client-config master: Update master for stable/train https://review.opendev.org/683481 | |
| 16:28:58 | openstackgerrit | OpenStack Release Bot proposed openstack/osc-lib master: Update master for stable/train https://review.opendev.org/683493 | |
| #openstack-sdks - 2019-09-23 | |||
| 03:48:50 | openstackgerrit | Steve Baker proposed openstack/openstacksdk master: Support vendor data in configdrive building https://review.opendev.org/683842 | |
| 05:22:05 | openstackgerrit | Steve Baker proposed openstack/openstacksdk master: Support vendor data in configdrive building https://review.opendev.org/683842 | |
| 08:10:27 | openstackgerrit | pengyuesheng proposed openstack/openstacksdk master: Update the constraints url https://review.opendev.org/683862 | |
| 08:15:13 | openstackgerrit | pengyuesheng proposed openstack/osc-lib master: Update the constraints url https://review.opendev.org/683865 | |
| 12:13:28 | openstackgerrit | Merged openstack/openstacksdk master: Update master for stable/train https://review.opendev.org/683478 | |
| 12:35:41 | openstackgerrit | Dmitry Tantsur proposed openstack/openstacksdk master: Make the bifrost job non-voting https://review.opendev.org/683946 | |
| 12:36:01 | dtantsur | mordred: pretty urgent ^^ | |
| 12:54:11 | enriquetaso | dtroyer, o/ Cinder team would like to use the current cinder-pythonclient plugin inside the OSC. is any chance that the OSC support multiversion or accept some work in this area to support this approach. | |
| 12:55:02 | dtantsur | enriquetaso: not quite the answer to your question, but you can look at the ironicclient plugin, it does support microversion | |
| 12:55:21 | dtantsur | we've also made the mistakes you're probably about to make (like requiring explicit OS_VOLUME_API_MICROVERSION) | |
| 12:56:33 | frickler | dtantsur: do you have an example for that bifrost failure? | |
| 12:56:48 | enriquetaso | dtantsur++ | |
| 12:57:15 | enriquetaso | dtantsur: Great, with this information I'll start working on the plugin | |
| 12:57:19 | dtantsur | frickler: any patch on SDK, I think. | |
| 12:57:29 | dtantsur | frickler: https://zuul.opendev.org/t/openstack/build/ce636fd8f50d4998ab2a5e838949fb39 | |
| 13:00:44 | frickler | dtantsur: ah, thx, I didn't look closely enough. +3 | |
| 13:06:04 | enriquetaso | mordred o/ ^ any thoughts? :) | |
| 13:29:46 | dtroyer | enriquetaso: I'm not sure exactly what you are asking, OSC _does_ use the current python-cinderclient, however any changes should consider switching to the SDK and using that to support microversions properly. Now if we just had a stable 1.0 release… /me ducks | |
| 13:32:03 | dtantsur | heh | |
| 13:33:44 | enriquetaso | dtroyer, oh | |
| 13:52:53 | enriquetaso | thanks dtroyer | |
| 15:38:01 | openstackgerrit | Merged openstack/cliff master: Stop wildcard importing argparse https://review.opendev.org/611889 | |
| 16:53:03 | openstackgerrit | Merged openstack/openstacksdk master: Make the bifrost job non-voting https://review.opendev.org/683946 | |
| #openstack-sdks - 2019-09-24 | |||
| 09:16:36 | openstackgerrit | Vishakha Agarwal proposed openstack/keystoneauth master: Generate pdf documentation https://review.opendev.org/682272 | |
| 11:38:46 | mordred | enriquetaso: I think dtroyer got you - but I agree with dtantsur and dtroyer - and I think the best outcome would be switching to sdk | |
| 11:42:09 | enriquetaso | mordred, thanks for answering me. This is my first time working with openstacksdk. Is openstack cli going to deprecate? | |
| 11:53:26 | mordred | oh no - openstack cli is the future. sdk is what we want to use for REST interactions with services instead of the per-service python-*client libraries | |
| 11:54:36 | mordred | but the idea is that we put shared needed logic for things into sdk - then it's available to python users, as well as other sdk consumers like ansible and salt, and we can build the osc commands from that same logic | |
| 11:55:13 | mordred | *AND* - nova is starting to use sdk to talk to services - so the same logic can be reused for service-to-service interactions... but we don't have to maintain 30 different libraries | |
| 11:56:21 | enriquetaso | mordred++ | |
| 11:56:25 | enriquetaso | thanks! | |
| 14:18:42 | mriedem | dtroyer: got a question about an osc-placement patch proposed to stable/train b/c of an osc 4.0.0 change to remove support for --os-url and replace it with --os-endpoint https://review.opendev.org/#/c/684292/1 | |
| 14:18:55 | mriedem | cdent says that if you have python-openstackclient < 4.0 that won't work | |
| 14:19:17 | mriedem | but #14 on https://docs.openstack.org/python-openstackclient/latest/cli/backwards-incompatible.html makes it sound like that was a long-standing thing that we should have just not been using | |
| 14:19:49 | cdent | I made it not work by only changing python-openstackclient, not osc-lib at the same time, so that may have been a factor | |
| 14:20:02 | mriedem | so we're trying to figure out if we need to bump the minimum required version of osc to >= 4.0.0 in osc-placement's test-requirements | |
| 14:21:01 | dtroyer | I'd have to refresh my memory, but —os-endpoint did not change, only the removal of —os-url. The plugin I took out basically just aliased the option names | |
| 14:21:25 | mriedem | cdent: ok so maybe you have to downgrade osc-lib to stein level and see if it works | |
| 14:21:40 | cdent | one mo | |
| 14:21:47 | mriedem | osc-lib 1.12.1 i guess? | |
| 14:21:47 | dtroyer | I do not recall making the sorts of changes to osc-lib that would affect this going backward, only to support taking things out of osc4 itself | |
| 14:22:19 | dtroyer | but then my head went back to stx-land so who knows what I recall now… ;) | |
| 14:22:34 | mriedem | so --os-endpoint should work with osc 3.19.0 | |
| 14:23:56 | cdent | if I downgrade just python-openstackclient it fails | |
| 14:24:32 | cdent | if I downgrade also osc-lib it still fails | |
| 14:24:55 | cdent | osc-lib 1.12.1 and p-osc 3.19.0 | |
| 14:25:31 | dtroyer | I want to say osc-lib should not be a factor here | |
| 14:26:08 | cdent | dtroyer: as you may recall, this is from the weird stuff that osc-placement is doing for its functional tests where it is sending an explicit token ("admin") to a defined url/endpoint | |
| 14:26:44 | cdent | the change that "fixes it" just replaces the use of --os-url with --os-endpoint in a call to shell.run() | |
| 14:31:11 | dtroyer | some of the logic for deducing the proper auth-type has been removed from osc to make it compatible with sdk/ksa, that included changing os-url to os-endpoint to specifically set —os-auth-type to 'admin_token' | |
| 14:31:24 | dtroyer | https://review.opendev.org/#/c/677795/4/openstackclient/shell.py | |
| 14:32:10 | dtroyer | I can't imagine that ksa has changed in this area at all recently, that should not be a factor | |
| 14:34:21 | dtroyer | cdent: look at the comment in https://review.opendev.org/#/c/678059/1/openstackclient/tests/functional/base.py and see if that applies to what you are doing | |
| 14:35:01 | dtroyer | it is about setting —os-auth-type in some cases and letting it default in others | |
| 14:40:19 | cdent | dtroyer: what the osc-p functional tests are doing is shell.OpenStackShell().run(list_of_args) without setting --os-cloud or --os-auth-type. Solely: --os-endpoint, --os-token, --os-placement-api-version (if asked), -f json, and then whatever the command being tested happens to be | |
| 14:41:29 | cdent | things work correctly like that in 4.0.0 | |
| 14:41:39 | cdent | and when it was --os-url they worked correctly in < 4.0.0 | |
| 14:42:06 | cdent | If I'm hearing you properly, what might be going on is that the os-endpoint support in < 4.0.0 needed an explicit --os-auth-type when --os-url did not? | |
| 14:43:22 | dtroyer | yes, the check in osc was only on —os-url to set os-auth-type to 'token_endpoint'. We never did a default for —os-endpoint before 4.0 | |
| 14:44:16 | mriedem | ah, so cdent - if you specify --os-auth-type in the functional test maybe we don't need to bump the required version of osc | |
| 14:47:52 | cdent | how should I orchestrate that patch wise? | |
| 14:47:55 | cdent | just do it on train? | |
| 14:48:01 | cdent | do it on both and backport | |
| 14:48:05 | cdent | something else? | |
| 14:48:06 | mriedem | do it on both and backport | |
| 14:48:14 | mriedem | if we want to require osc>=4.0 we should do that on master only | |
| 14:48:19 | mriedem | but i'm not sure it's necessary anymore | |