Earlier  
Later
New Search
Posted Nick Remark
#openstack-sdks - 2019-08-30
13:33:42 gtema so there need to be a "apply dict formatter to any munch", and then in the network you can additionally hide location
13:34:46 mordred gtema: yeah. s/munch/resource or munch/
13:35:19 gtema it's following us in multiple contexts :)
13:36:09 mordred gtema: maybe it's not terrible to hide it for now then do a followup patch that unhides it as a placeholder to remind us t deal with it?
13:36:47 gtema beah, I am afraid it would be immediately forgotten
13:37:30 gtema but ok, let us then have a fat TODO/NOTE for that
14:06:11 openstackgerrit Merged openstack/openstacksdk master: Volume.Backup restore fixes https://review.opendev.org/665110
15:54:58 dtroyer so the column formatting is exactly what we added in osc_lib.format_columns, to produce useful output rather than python-formatted strings. We need to either treat Munch as a dict and use DictColumn() or make a MunchColumn() to handle those. I am assuming that type is predictable per column?
16:06:39 mordred dtroyer: yeah. I think treating Munch as a dict type is likely the right choice
16:14:13 mordred hrm. or - maybe a MunchColumn type woudl be right - that way we could run toDict() on it
16:14:19 openstackgerrit Monty Taylor proposed openstack/osc-lib master: Add a MunchColumn type https://review.opendev.org/679474
16:14:29 mordred dtroyer, frickler: ^^ something liek that perhaps
16:19:41 dtroyer mordred: see, I knew if I had lunch first… :) That approach works, is there enough difference to not just use DictColumn()? Other than having to call to_dict(). I am trying to decide if developers should know (or care) if they have a Much or a dict
16:20:48 mordred dtroyer: no - it _should_ behave just the same
16:21:39 mordred oh - yeah - actually - format_dict should totally work perfectly well with either Munch or Resource objects
16:22:06 dtroyer so we really just need to apply the DictColum calls to them… am trying that now
16:22:51 mordred ++
16:25:15 dtroyer \o/ I needed to make a pass through output one more time to catch columns added since the original work was done, that gets it
16:25:34 dtroyer now, nested Munch/dicts :)
16:26:33 dtroyer I am not sure how to represent those in the prettytable output
16:26:52 mordred dtroyer: maybe just as emoji
16:27:21 mordred dtroyer: or, more seriously, maybe with dotted notation ...
16:27:30 mordred do like project.name=foo
16:27:45 dtroyer that would be the cleanest visually
16:27:50 mordred for location = { project: { name: "foo" }}
16:28:35 mordred I mean - I say that - it's probably not really that hard as a recursive call
16:28:36 dtroyer I don't recall if other dicts we processed are nested, I didn't notice that location was before now
16:29:03 mordred I made it nested just to make life harder
16:29:17 dtroyer I would also totally buy doing that in a follow-up
16:30:37 mordred ++
16:32:12 dtroyer I think that could be limited to osc_lib format_dict(), so we'd pick it up when it that gets released
16:34:20 dtroyer mordred: off-topic: do you have a preferred ansible role to run Gerrit? I have not found one that seems to be an obvious choice that seems actively maintained...
16:35:50 mordred funny story - we're working on making one of those right now :)
16:36:01 mordred dtroyer: so ask me that again in couple of weeks
16:36:31 dtroyer heh, wish I could wait… to be part of windmill?
16:37:31 mordred dtroyer: for opendev - we're aiming to switch from puppet to ansible-driven-docker
16:38:22 mordred dtroyer: that said - we install gerrit from upstream docker containers in the zuul docker-compose file and there's ansible around that to set it up ... maybe there's enough there to be helpful?
16:38:59 mordred https://opendev.org/zuul/zuul/src/branch/master/doc/source/admin/examples/docker-compose.yaml
16:39:04 dtroyer is that the QuickStart? I've been down that path and am trying to generalize it a bit
16:39:25 mordred yeah
16:39:40 dtroyer I'm using windmill for the rest and was headed in that direction, sounds like you are too
16:40:36 dtroyer kk, thanks. we can return to our regularly scheduled client-ish topics
16:41:34 mordred dtroyer: https://review.opendev.org/#/c/630406 is the beginning of the change - it's very WIP and needs a bunch more - but that's my current infra task
16:41:52 dtroyer I'll take a peek, thanks
16:41:54 mordred (after a week of Gerrit User Summit though I've finally got the docker images all building solidly :) )
16:47:25 openstackgerrit Monty Taylor proposed openstack/osc-lib master: Handle nested dicts https://review.opendev.org/679474
16:47:40 mordred dtroyer: ^^ that almost works - but seems to have an off-by-one for some reason
16:58:36 dtroyer so ps2 looks good there at first glance
17:54:46 openstackgerrit Dean Troyer proposed openstack/python-openstackclient master: Format location columns in network commands https://review.opendev.org/679490
17:55:36 dtroyer mordred, frickler: ^^ is formatting the network location columns. There may be other network columns that need addressing, this puts the mechanism in place to handle those easily
19:12:40 lifeless win 84
20:27:05 openstackgerrit Dean Troyer proposed openstack/python-openstackclient master: Bump min osc-lib to 1.14.0 https://review.opendev.org/679182
21:29:28 openstackgerrit Merged openstack/openstackclient master: Add Python 3 Train unit tests https://review.opendev.org/637739
#openstack-sdks - 2019-08-31
05:04:30 openstackgerrit Dean Troyer proposed openstack/osc-lib master: Handle nested dicts in format_dict() https://review.opendev.org/679474
05:05:12 dtroyer mordred: ^^ fixes the off-by-one and adds a test
05:11:02 mordred dtroyer: aha! nice
05:24:44 openstackgerrit Monty Taylor proposed openstack/openstacksdk master: Strip two more accept headers from object-storage https://review.opendev.org/679532
07:05:51 openstackgerrit Merged openstack/openstacksdk master: Remove Accept header with empty value for HEAD and DELETE requests https://review.opendev.org/679383
14:04:33 openstackgerrit Dean Troyer proposed openstack/python-openstackclient master: Remove races in floating ip functional tests https://review.opendev.org/679541
17:53:45 openstackgerrit Merged openstack/python-openstackclient master: Bump min osc-lib to 1.14.0 https://review.opendev.org/679182
19:43:15 openstackgerrit Merged openstack/python-openstackclient master: Remove races in floating ip functional tests https://review.opendev.org/679541
19:46:15 openstackgerrit Merged openstack/osc-lib master: Handle nested dicts in format_dict() https://review.opendev.org/679474
#openstack-sdks - 2019-09-01
22:36:35 openstackgerrit Hongbin Lu proposed openstack/python-openstackclient master: Bump lower constraint of python-zunclient https://review.opendev.org/679578
#openstack-sdks - 2019-09-02
00:02:42 openstackgerrit Takashi Kajinami proposed openstack/python-openstackclient master: Add parent project filter for listing projects https://review.opendev.org/677103
00:05:44 openstackgerrit Takashi Kajinami proposed openstack/python-openstackclient master: Add parent project filter for listing projects https://review.opendev.org/677103
07:13:00 openstackgerrit Artem Goncharov proposed openstack/openstacksdk master: Strip two more accept headers from object-storage https://review.opendev.org/679532
13:02:45 openstackgerrit Bence Romsics proposed openstack/openstacksdk master: Add router add/remove route operations https://review.opendev.org/674324
14:45:24 openstackgerrit Dean Troyer proposed openstack/osc-lib master: format_dict() returns no value for None https://review.opendev.org/679660
14:55:25 dtroyer frickler: ^^^ proposes a solution to None becoming 'None' in format_dict().
15:26:16 openstackgerrit Merged openstack/python-openstackclient master: Bump lower constraint of python-zunclient https://review.opendev.org/679578
20:27:42 openstackgerrit Jens Harbott (frickler) proposed openstack/cliff master: Pin cmd2 back to <0.9 on all versions https://review.opendev.org/629283
20:48:09 openstackgerrit Jens Harbott (frickler) proposed openstack/cliff master: Pin cmd2 back to <0.9 on all versions https://review.opendev.org/629283
#openstack-sdks - 2019-09-03
02:34:56 openstackgerrit Merged openstack/openstacksdk master: Add a fields meta_data to result of Senlin API https://review.opendev.org/678585
08:50:26 openstackgerrit Jens Harbott (frickler) proposed openstack/cliff master: Pin cmd2 back to <0.9 on all versions https://review.opendev.org/629283
08:55:06 openstackgerrit Jens Harbott (frickler) proposed openstack/cliff master: Pin cmd2 back to <0.9 on all versions https://review.opendev.org/629283
08:58:39 openstackgerrit Jens Harbott (frickler) proposed openstack/cliff master: Pin cmd2 back to <0.9 on all versions https://review.opendev.org/629283
09:51:51 openstackgerrit Qitao proposed openstack/shade master: Fix code specification with pep8 https://review.opendev.org/679736
09:53:50 openstackgerrit Qitao proposed openstack/shade master: Fix code specification with pep8 https://review.opendev.org/679736
09:54:39 openstackgerrit Qitao proposed openstack/shade master: Fix code specification with pep8 https://review.opendev.org/679736
09:58:41 openstackgerrit Qitao proposed openstack/shade master: Use requests replace request https://review.opendev.org/679738
10:08:08 openstackgerrit Qitao proposed openstack/shade master: Update base64 encodebytes replace encodestring https://review.opendev.org/679740
15:01:57 openstackgerrit Bence Romsics proposed openstack/python-openstackclient master: Add command: router add/remove route --route https://review.opendev.org/674325
17:36:12 openstackgerrit Jens Harbott (frickler) proposed openstack/openstacksdk master: Add dns_publish_fixed_ip attribute to subnets https://review.opendev.org/679833
17:38:30 openstackgerrit Jens Harbott (frickler) proposed openstack/python-openstackclient master: Add dns_publish_fixed_ip attribute to subnets https://review.opendev.org/679834
21:38:44 openstackgerrit Matt Riedemann proposed openstack/python-openstackclient master: Microversion 2.77: Support Specifying AZ to unshelve https://review.opendev.org/665336
22:49:59 efried dtroyer: please remind: what's the env var to set (specifically placement) default microversion, so I don't have to say --os-placement-api-version every time?
22:50:56 efried nm, https://docs.openstack.org/python-openstackclient/pike/cli/man/openstack.html#options
#openstack-sdks - 2019-09-04
05:06:12 openstackgerrit Andreas Jaeger proposed openstack/openstacksdk master: DNM - Start building pdfs of docs https://review.opendev.org/601659
05:15:18 openstackgerrit Andreas Jaeger proposed openstack/openstacksdk master: Build PDF docs https://review.opendev.org/601659
05:15:19 openstackgerrit Andreas Jaeger proposed openstack/openstacksdk master: Cleanup doc/source/conf.py https://review.opendev.org/679910
06:05:21 openstackgerrit Shogo Saito proposed openstack/openstacksdk master: Adding basic implementation for Accelerator (Cyborg) component. Firstly, let the client can work with some cyborg APIs. This patch supports some cyborg APIs below. https://review.opendev.org/679914
06:14:04 openstackgerrit Shogo Saito proposed openstack/openstacksdk master: Adding basic implementation for Accelerator (Cyborg) component https://review.opendev.org/679914
15:59:01 openstackgerrit Merged openstack/api-sig master: Update to opendev https://review.opendev.org/654746
18:37:52 mriedem https://review.opendev.org/#/c/665336/14 for compute api 2.77 should be good to go in osc land
18:38:11 mriedem dtroyer: you were +2 on that before ^
18:59:50 dtroyer mriedem: +W
19:00:06 mriedem thanks
20:45:20 openstackgerrit Merged openstack/python-openstackclient master: Microversion 2.77: Support Specifying AZ to unshelve https://review.opendev.org/665336
22:04:16 openstackgerrit Lance Bragstad proposed openstack/keystoneauth master: Allow initializing session with connection retries https://review.opendev.org/676648
#openstack-sdks - 2019-09-05
03:06:41 openstackgerrit Brin Zhang proposed openstack/python-openstackclient master: Microversion 2.78: Add delete_on_termination to volume-attach API https://review.opendev.org/673725

Earlier   Later