Earlier  
Later
New Search
Posted Nick Remark
#openstack-sdks - 2019-07-11
16:18:34 openstackgerrit Merged openstack/openstacksdk master: Add Python 3 Train unit tests https://review.opendev.org/669449
16:19:29 cmurphy When those options are unconfigured, one of the APIs can't work and to date we've been raising a 500 to indicate the server is misconfigured
16:19:40 cmurphy With this change, there will no longer be any chance for that API to work since the server is effectively always misconfigured
16:19:51 cmurphy So the question is, do we keep raising the 500 consistent with how it worked before, or do we change the response to a 410 Gone to be a little more honest about the fact that this API just doesn't work any more
16:19:59 cmurphy keeping in mind that keystone doesn't do microversions
16:20:48 elmiko so, off the top of my head if that api is no longer supported i would expect some 4xx error as opposed to 5xx since the client is in error here
16:21:28 elmiko i'm not sure if 410 is the proper status or not, i'd have to do a little more reading
16:22:21 cmurphy okay, yeah someone else made the point that a 4XX at least indicates that retrying isn't going to do any good
16:22:48 elmiko right, imo 4xx means the client needs to do something different. which in this case means don't call those apis anymore XD
16:23:48 elmiko are you leaving the routes in for backward compatibility? like, how come you don't just return 404 for those?
16:23:58 edleafe cmurphy: Since you don't provide access to the old API behavior, it would be my preference to have keystone handle this case more gracefully. IOW, if it can do what it needs to do without those config settings, just do that
16:24:34 elmiko ++ good question edleafe
16:25:28 cmurphy elmiko: yes we wanted to leave the route there to maintain some kind of backwards compatibility even though that's not really achievable in this case
16:25:58 elmiko ack
16:26:22 cmurphy edleafe: there's no way to have keystone do the same thing without those config settings, the config setting just set a location of a CA cert file that was read and returned by that GET API
16:26:44 edleafe cmurphy: you *do* realize that mordred will hunt you down and punish you, right? :)
16:26:52 cmurphy yes >.>
16:26:54 elmiko haha
16:27:35 edleafe cmurphy: So you're making what amounts to a major version change, without leaving the old version in place. Is that correct?
16:29:18 cmurphy I don't think it's that drastic, the API was already badly designed because it depended on the operator generating this file and configuring this parameter, we're just cementing in the behavior it had if the operator failed to do that
16:30:06 cmurphy and since PKI tokens are not in use 99% of clouds will already have this behavior
16:30:56 edleafe By a "major version change" I meant one where a request that worked before can no longer work the same way.
16:31:19 edleafe If it's a case of "no one uses it anyway", then that's a practical matter
16:32:13 edleafe In that case, I think that 410 Gone is the proper response
16:33:15 cmurphy okay
16:33:43 cmurphy I'll take this back to the team, maybe we can find a way to handle this more gracefully, otherwise we'll go with a 410
16:34:57 cmurphy thanks for the advice edleafe elmiko
16:35:03 elmiko gladly cmurphy =)
16:36:04 edleafe That's what we're here for! :)
16:38:33 elmiko speaking of that, i have to leave a little early edleafe
16:38:46 edleafe Awww, I'll miss you!
16:38:49 elmiko <3
16:38:58 elmiko catch you next week if not sonner o/
16:39:05 elmiko er even sooner!
16:39:23 edleafe I'll be here (for a while, at least!)
17:33:54 cmurphy mordred: could you ack https://review.opendev.org/670136
17:57:50 mordred cmurphy: ack
18:00:39 cmurphy ty
21:30:10 openstackgerrit Merged openstack/keystoneauth master: Add a per-request global_request_id https://review.opendev.org/670341
21:48:41 openstackgerrit Eric Fried proposed openstack/keystoneauth master: reno: per-request global_request_id https://review.opendev.org/670399
22:16:06 openstackgerrit Merged openstack/keystoneauth master: reno: per-request global_request_id https://review.opendev.org/670399
#openstack-sdks - 2019-07-12
06:26:07 openstackgerrit ZhaoBo proposed openstack/openstacksdk master: force specify project_id during create Sg_rule may cause issue https://review.opendev.org/667261
08:08:32 openstackgerrit Grégoire Unbekandt proposed openstack/openstacksdk master: Specify store when importing an image https://review.opendev.org/670309
13:45:05 openstackgerrit Matt Riedemann proposed openstack/python-openstackclient master: Add host and hypervisor_hostname to create servers https://review.opendev.org/669609
14:30:32 elmiko edleafe: dtantsur|afk , i'm trying to get some info for the ptg response. did we do a meetup in denver, and if so how many folks showed up?
15:05:42 edleafe elmiko: Yes, we did 2 of them, and there were about 12 people at the Forum meeting, and only about 6 at the PTG meeting.
15:05:52 elmiko awesome, thanks!
#openstack-sdks - 2019-07-15
14:35:38 stingrayza hey folks. I'm trying to help shepherd in a PR in ansible for a new os_ module (os_group_info) if any reviewers could take a look, that'd be great, thanks! (Apologies if you've seen me cross-post this too many times)
14:35:39 stingrayza https://github.com/ansible/ansible/pull/57120
15:28:08 mordred stingrayza: lgtm
15:31:39 stingrayza thanks mordred :)
15:50:52 stingrayza and thanks gtema :)
#openstack-sdks - 2019-07-16
00:13:27 openstackgerrit Merged openstack/python-openstackclient master: Add Python 3 Train unit tests https://review.opendev.org/669447
00:19:37 openstackgerrit Merged openstack/osc-lib master: Add Python 3 Train unit tests https://review.opendev.org/669446
02:36:45 openstackgerrit Brian Haley proposed openstack/python-openstackclient master: Support IPv6 addresses better https://review.opendev.org/524420
06:08:47 openstackgerrit Qiu Fossen proposed openstack/cliff master: Add Python 3 Train unit tests https://review.opendev.org/670954
08:11:59 openstackgerrit Grégoire Unbekandt proposed openstack/openstacksdk master: Specify store when importing an image https://review.opendev.org/670309
11:49:04 openstackgerrit Merged openstack/python-openstackclient master: docs: clarify compute service --service option https://review.opendev.org/668550
13:47:45 ITD27M01_ mordred: Hello! We have added the version_added key to https://github.com/ansible/ansible/pull/51401 Could you check and review.
15:20:10 openstackgerrit Merged openstack/os-service-types master: Add Python 3 Train unit tests https://review.opendev.org/669451
16:20:43 openstackgerrit Dmitry Tantsur proposed openstack/openstacksdk master: Correct endpoint_override discovery for service with dashes in their type https://review.opendev.org/671104
16:20:53 dtantsur mordred: I think I've figured out what causes troubles with inspector ^^
16:22:51 mordred dtantsur: headdesk
16:43:08 dtantsur yep
22:41:13 openstackgerrit Merged openstack/cliff master: Add Python 3 Train unit tests https://review.opendev.org/669445
#openstack-sdks - 2019-07-17
08:45:12 dtantsur gtema: morning, could you check https://review.opendev.org/#/c/671104/ please?
08:45:40 gtema dtantsur: morgen. Sure
08:45:45 gtema how was your exam?
08:47:03 gtema dtantsur: I would ask also you to do a review for me - https://review.opendev.org/#/c/659841/
08:47:52 dtantsur gtema: subjectively went well, still no results (takes 4-6 weeks)
08:48:03 gtema cool
09:05:58 stingrayza gtema, would you mind re-checking https://github.com/ansible/ansible/pull/57120 please? there's been an update since your last shipit :)
09:06:32 stingrayza mordred: you too please :) ^^
10:07:37 openstackgerrit Merged openstack/openstacksdk master: Correct endpoint_override discovery for service with dashes in their type https://review.opendev.org/671104
10:11:02 dtantsur mordred: could you make a release with ^^ please?
11:23:36 priteau Hi mordred. You approved an Ansible bugfix two weeks ago (https://github.com/ansible/ansible/pull/57364), I've now created pull requests for backports to 2.8 and 2.7
11:23:39 priteau https://github.com/ansible/ansible/pull/59107
11:23:41 priteau https://github.com/ansible/ansible/pull/59108
11:39:37 mordred dtantsur: remote: https://review.opendev.org/671244 Release 0.31.2 of openstacksdk
11:39:47 dtantsur thx!
12:23:27 ITD27M01_ mordred: Hello! We have added the version_added key to https://github.com/ansible/ansible/pull/51401 Could you check and review? If you have a minute for this.
12:38:47 mordred ITD27M01_: done. Shrews - wanna re-look?
12:39:33 Shrews sure
12:40:19 mordred Shrews: something something "approve changes" click click scroll click scroll click click emoji
12:42:44 Shrews mordred: have i ever mentioned how much i loathe GH interface?
12:43:24 mordred Shrews: it's so hard to use
12:48:31 Shrews mordred: that reminds me, i dont think sdk has an ansible test for the inventory plugin
12:48:51 Shrews or probably any of the newer modules
12:49:20 Shrews we should probably start requesting those for new modules
12:49:59 Shrews i can look at doing the inventory one when i have a second arm again
12:51:06 mordred Shrews: have you considered a robot arm?
12:51:07 Shrews (which im hoping is this evening after the dr appt)
12:53:39 Shrews if we arent requesting tests for new modules, then we may as well not have any
12:56:29 Shrews but i dont know how that workflow should go. cant have a test w/o the module. but adding an untested module before the test can also be bad
13:02:04 Shrews i guess a proper depends-on would work there
13:47:22 mordred Shrews: I think maybe we should finally figure out how to put the tests themselves into the ansible repo (we can make ansible-test tests that require a certain set of creds so the normal ansible runs won't try to run them) - and then update the devstack job in zuul to run ansible-test feeding it the devstack login information
13:47:38 mordred Shrews: there's enough work there that I haven't actually dug in to doing it yet
#openstack-sdks - 2019-07-18
16:00:10 edleafe Welcome to the API-SIG Office Hour!
16:01:00 elmiko \o/
16:01:27 edleafe elmiko: did you bring the balloons and party hats?

Earlier   Later