Earlier  
Later
New Search
Posted Nick Remark
#openstack-sdks - 2019-07-05
11:28:30 openstackgerrit Vishakha Agarwal proposed openstack/openstacksdk master: [WIP] Add application credential CRUD support https://review.opendev.org/669331
15:46:09 openstackgerrit Rodolfo Alonso Hernandez proposed openstack/openstacksdk master: Increase randomness in ZONE creation https://review.opendev.org/669377
16:27:21 openstackgerrit Merged openstack/shade master: Mailing lists change openstack-dev to openstack-discuss https://review.opendev.org/668438
17:43:31 openstackgerrit Merged openstack/openstacksdk master: Fix invalid assert state https://review.opendev.org/668794
17:43:32 openstackgerrit Merged openstack/openstacksdk master: Allow deeper levels of nesting for pdf builds https://review.opendev.org/667114
18:17:16 openstackgerrit Corey Bryant proposed openstack/cliff master: Add Python 3 Train unit tests https://review.opendev.org/669445
18:18:41 openstackgerrit Corey Bryant proposed openstack/openstackclient master: Add Python 3 Train unit tests https://review.opendev.org/637739
18:20:00 openstackgerrit Corey Bryant proposed openstack/osc-lib master: Add Python 3 Train unit tests https://review.opendev.org/669446
18:33:44 openstackgerrit Corey Bryant proposed openstack/python-openstackclient master: Add Python 3 Train unit tests https://review.opendev.org/669447
18:34:51 openstackgerrit Corey Bryant proposed openstack/openstacksdk master: Add Python 3 Train unit tests https://review.opendev.org/669449
18:35:40 openstackgerrit Corey Bryant proposed openstack/os-client-config master: Add Python 3 Train unit tests https://review.opendev.org/669450
18:36:10 openstackgerrit Corey Bryant proposed openstack/os-service-types master: Add Python 3 Train unit tests https://review.opendev.org/669451
18:36:53 openstackgerrit Corey Bryant proposed openstack/shade master: Add Python 3 Train unit tests https://review.opendev.org/669452
19:01:36 openstackgerrit Merged openstack/openstacksdk master: Increase randomness in ZONE creation https://review.opendev.org/669377
#openstack-sdks - 2019-07-06
12:11:04 openstackgerrit Yuval Shalev proposed openstack/openstacksdk master: Added all-projects headers to dns service. https://review.opendev.org/669547
19:13:10 openstackgerrit Yuval Shalev proposed openstack/openstacksdk master: Added all-projects headers option to dns proxy. https://review.opendev.org/669547
#openstack-sdks - 2019-07-08
06:52:27 openstackgerrit Boxiang Zhu proposed openstack/python-openstackclient master: Add host and hypervisor_hostname to create servers https://review.opendev.org/669609
13:14:18 openstackgerrit Romil Gupta proposed openstack/openstacksdk master: Fix typo for subnet.py This 'slacc' should be 'slaac' https://review.opendev.org/669661
#openstack-sdks - 2019-07-09
06:18:27 openstackgerrit Boxiang Zhu proposed openstack/python-openstackclient master: Add host and hypervisor_hostname to create servers https://review.opendev.org/669609
06:56:19 openstackgerrit zhangqing proposed openstack/python-openstackclient master: Use cliff formattable columns in compute commands https://review.opendev.org/669304
09:20:24 openstackgerrit Vishakha Agarwal proposed openstack/openstacksdk master: Add application credential CRUD support https://review.opendev.org/669331
09:42:10 openstackgerrit Vishakha Agarwal proposed openstack/openstacksdk master: Add application credential CRUD support https://review.opendev.org/669331
12:11:50 openstackgerrit Monty Taylor proposed openstack/openstacksdk master: Use resource layer for compute flavors https://review.opendev.org/650903
12:11:50 openstackgerrit Monty Taylor proposed openstack/openstacksdk master: Push sort_key down to server for flavor filtering https://review.opendev.org/669857
12:12:30 mordred gtema: addressed a couple of review comments from dtantsur in the compute flavors patch ^^ and then added a followup.
12:13:20 gtema super mordred. Wanted already to remind about the whole batch, but you was faster than I had time to switch context :-)
12:14:20 gtema btw, I would also need attention to the "rework monitoring" change, but I have found another case where metric name is not generated properly, so will do another PS shortly
12:17:20 mordred cool - will look at that too
12:17:25 gtema thks
12:26:57 gtema mordred, do you remember about project cleanup tasks we took with you? We need to start doing that, since that is also I need in my project
12:30:10 mordred gtema: funny - I was *just* talking about that a little in #openstack-infra :)
12:30:48 mordred gtema: I probably can't get that done this week, but probably can next week
12:31:20 gtema no hurry, it's just a reminder, that we took that on us
12:43:47 openstackgerrit Merged openstack/shade master: Add Python 3 Train unit tests https://review.opendev.org/669452
12:46:40 mordred gtema: ++
12:53:02 mgariepy can i please have some review on : https://review.opendev.org/#/c/668017/ and https://review.opendev.org/#/c/668018/
12:57:02 Shrews mordred: https://review.opendev.org/666905 is fyi. i haven't looked to see if latest sdk handles that yet
13:01:13 mordred Shrews: it's *supposed* to - maybe we're missing a guard somewhere
13:02:52 mordred Shrews: oh - hrm. looking at the nodepool patch itself (not just the commit message) - nodepool is calling list_ports directly not just getting to it via create_server
13:03:30 mordred I think in that case we're almost *Certainly* missing a guard - we should put a if not self.has_service('network'): return [] at the top or something similar
13:03:43 Shrews yeah, for port cleanup iirc
13:04:08 Shrews yes, agreed
13:06:30 mordred Shrews: I'll make a patch so you can review
13:06:45 openstackgerrit Merged openstack/openstacksdk master: Fix typo for subnet.py This 'slacc' should be 'slaac' https://review.opendev.org/669661
13:06:54 Shrews k
13:11:30 openstackgerrit Merged openstack/openstacksdk master: Switch cloud layer to use proxy for DNS https://review.opendev.org/665435
13:13:23 openstackgerrit Merged openstack/openstacksdk master: Use Resource layer in cloud for SecurityGroups of server https://review.opendev.org/662998
13:21:04 openstackgerrit Merged openstack/openstacksdk master: Use Resource layer for next compute methods https://review.opendev.org/663064
13:22:04 openstackgerrit Monty Taylor proposed openstack/openstacksdk master: Return empty lists for resources if neutron doesn't exist https://review.opendev.org/669869
13:24:04 mordred Shrews: ^^
13:49:36 ITD27M01 mordred: Hello! I am in the way to catch you! Could you please leave a comment in this PR: https://github.com/ansible/ansible/pull/51401
13:50:20 ITD27M01 mordred: If you have a second for this :)
13:52:36 mordred ITD27M01: Shrews left some comments on that about needing to add self.templare.template() call which someone else also mentioned - can you either fix that or respond that you've verified it's not needed?
13:57:02 openstackgerrit Corey Bryant proposed openstack/openstackclient master: Add Python 3 Train unit tests https://review.opendev.org/637739
13:57:20 ITD27M01 mordred: Thank you, I just wanted to make sure you knew. I am not an author and will try to contact the developer to continue working.
14:00:33 mordred ah - ok, cool. maybe I'll leave that same comment on the PR
14:00:44 mordred (and sorry - my IRC to github user mapping is incomplete)
14:02:09 Shrews looks like the latest commit addresses the template thing
14:02:51 mordred yeah.
14:02:53 Shrews but not version_added
14:03:09 mordred the way these comments get displayed is very confusing to me
14:03:15 Shrews god i hate gh
14:03:23 Shrews yes, same
14:10:35 Shrews mordred: that comment from me on that PR had me questioning my sanity b/c that call is clearly there now
14:18:41 Shrews i almost want to send my response to your response directly to GH higher ups, but i doubt they'd care
14:51:34 dtantsur folks, do we bypass major version detection when endpoint_override is used?
15:05:29 mordred dtantsur: uhm ...
15:05:51 mordred dtantsur: I know that if you provide api_version _and_ endpoint_override we completely trust you
15:05:57 dtantsur I'm seeing ironic-inspector in bifrost accessed without /v1
15:06:03 dtantsur but I don't think we provide api_version
15:06:20 mordred oh - yeah - if you give endpoint_override it should be the versioned endpoint
15:07:18 mordred endpoint_override says "use this endpoint exactly" - discovery to find a new endpoint will never happen. in some cases we might hit the discovery url to get the document so we can see microversion info
15:07:46 mordred but we won't look in to it to find a versioned endpoint if an unversioned endpoint was given
15:09:16 mordred dtantsur: unfortunately, the base system has a two-layer system for finding the url to use - the keystone catalog and then service version discovery
15:09:55 mordred thinking about it now - it seems like having 2 different possible endpoint_override parameters would actually make more complete sense
15:10:19 mordred so you could say something like "catalog_endpoint_override" or "service_endpoint_override" (but with better names)
15:11:21 mordred dtantsur: for more context - we also have to have people give both endpoint_override and api_version sometimes just to tell us what the api version is because the discovery documents are broken on their cloud
15:11:31 dtantsur huh
15:11:52 dtantsur I think I feel a bit uneasy about putting versioned endpoints to configuration files
15:12:38 mordred but - maybe we could apply the heuritstic that if you provide an endpoint_override and an api_version and the endpoint you supply does not contain "v{api_version}" that we should attempt to do a discovery lookup - and if it fails just assume you gave us a versioned endpoint and that the api version you supplied is correct
15:13:22 mordred although I think we'd need a new option for that, since it would be a behavior change
15:13:45 mordred dtantsur: I agree with all of your uneasiness
15:15:04 dtantsur the practical question for me is whether to update openstacksdk or hack endpoint_override inside ironic
15:23:13 mordred dtantsur: well - this logic is actually all in keystoneauth
15:36:04 openstackgerrit Monty Taylor proposed openstack/openstacksdk master: Return empty lists for resources if neutron doesn't exist https://review.opendev.org/669869
17:54:58 Shrews mordred: gtema: fyi, looks like the openstacksdk-functional-devstack-magnum and openstacksdk-functional-devstack-masakari check jobs have been consistently failing since https://review.opendev.org/662743
17:55:50 Shrews i was unable to find any earlier change with those failures (though it may exist)
17:59:36 mordred Shrews: oh - we should fix that then
18:00:14 mordred Shrews: looks like it's just failing the has_service Magnum check
18:00:21 Shrews i cant access the logs from this coffee shop. my vpn blocks logs.o.o for some reason
18:00:35 mordred maybe it's incidental and something changed in devstack
18:01:09 Shrews thats an odd check to fail in a magnum specific test :)
18:02:28 mordred Shrews: yah
18:02:42 mordred Shrews: also - I guess it's good that we have that check
18:02:55 Shrews ++
18:08:28 Shrews heading back to the house. thought i could work from here just to get out of the house, but much too uncomfortable here. biab
#openstack-sdks - 2019-07-10
10:23:31 openstackgerrit Bin Lu proposed openstack/python-openstackclient master: add optional argument metric to set metric for routes https://review.opendev.org/637658
14:00:42 mordred slaweq: I fixed https://review.opendev.org/#/c/669869/ yesterday - have a moment to reapply your +2 ?
14:01:46 slaweq mordred: done
14:08:48 mordred slaweq: thanks!

Earlier   Later