| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-sdks - 2019-06-03 | |||
| 12:34:30 | openstackgerrit | Artem Goncharov proposed openstack/openstacksdk master: Use Resource layer for compute KeyPairs https://review.opendev.org/662729 | |
| 14:06:46 | Shrews | mordred: when you return, I left comments on that PR ITD27M01 was asking about, but you should also have a look I think | |
| 15:09:41 | openstackgerrit | Michael McCune proposed openstack/keystoneauth master: add handling for multiple error returns https://review.opendev.org/662281 | |
| 17:23:42 | mordred | Shrews: nod, thanks | |
| 19:16:10 | openstackgerrit | Eric Fried proposed openstack/openstacksdk master: Make factory for a CloudRegion from CONF objects https://review.opendev.org/643601 | |
| 19:16:29 | efried | mordred: Fixed (again) ^ | |
| 20:09:12 | openstackgerrit | Brian Haley proposed openstack/python-openstackclient master: Support IPv6 addresses better https://review.opendev.org/524420 | |
| 21:28:22 | openstackgerrit | Michael Johnson proposed openstack/osc-lib master: Move the _tag module from OSC to osc-lib https://review.opendev.org/662859 | |
| 21:40:40 | openstackgerrit | Michael Johnson proposed openstack/python-openstackclient master: Switch to using osc_lib.utils.tags https://review.opendev.org/662864 | |
| 21:58:23 | openstackgerrit | Eric Fried proposed openstack/openstacksdk master: Support Proxy-specific region_name https://review.opendev.org/662865 | |
| 21:58:55 | efried | mordred, dustinc: Predictably intrusive fixup for region_name ^ | |
| 21:59:16 | efried | mordred: It's entirely possible I violated a principal principle of "region" here. | |
| 22:04:56 | openstackgerrit | Eric Fried proposed openstack/openstacksdk master: Support Proxy-specific region_name https://review.opendev.org/662865 | |
| 22:26:25 | mordred | efried: well, we're all about violating principles. I find the idea of a CloudRegion with region_name='tokyo' with a compute_region_name='newyork' and pity the poor soul who has done this to themselves | |
| 22:26:32 | mordred | but - such is life :) | |
| 22:27:09 | efried | mordred: Duly noted. Perhaps once everything is clouds.yaml, we can get rid of from_conf and go back to a single region | |
| 22:27:37 | mordred | \o/ | |
| 23:06:01 | openstackgerrit | Merged openstack/keystoneauth master: add handling for multiple error returns https://review.opendev.org/662281 | |
| #openstack-sdks - 2019-06-04 | |||
| 01:49:53 | openstackgerrit | Eric Fried proposed openstack/openstacksdk master: Support Proxy-specific region_name https://review.opendev.org/662865 | |
| 07:34:31 | openstackgerrit | Artem Goncharov proposed openstack/openstacksdk master: Use Resource layer for network SecurityGroups https://review.opendev.org/662724 | |
| 07:44:40 | openstackgerrit | Artem Goncharov proposed openstack/openstacksdk master: Use Resource layer for compute KeyPairs https://review.opendev.org/662729 | |
| 10:15:54 | openstackgerrit | Artem Goncharov proposed openstack/openstacksdk master: Use Resource layer in cloud for SecurityGroups of server https://review.opendev.org/662998 | |
| 10:16:36 | openstackgerrit | Artem Goncharov proposed openstack/openstacksdk master: Use Resource layer for the compute Hypervsors and Images https://review.opendev.org/662743 | |
| 13:36:32 | openstackgerrit | Monty Taylor proposed openstack/openstacksdk master: Make factory for a CloudRegion from CONF objects https://review.opendev.org/643601 | |
| 13:37:02 | mordred | gtema, Shrews, dtantsur, slaweq: ^^ is ready for review when y'all get a spare minute. this is the needed feature for shifting nova to sdk and off of python-*client | |
| 13:37:24 | mordred | efried: I just added a release note in that latest patchset - tests look great, thanks! | |
| 13:37:50 | efried | mordred: Nice. What more to get it merged? | |
| 13:38:02 | mordred | efried: just need to convince people to review it now :) | |
| 13:38:04 | efried | oh, I see previous alert | |
| 13:38:07 | efried | yes, cool. | |
| 13:38:18 | openstackgerrit | Monty Taylor proposed openstack/openstacksdk master: Support Proxy-specific region_name https://review.opendev.org/662865 | |
| 13:38:30 | gtema | ok, got it | |
| 13:38:50 | efried | mordred: region_name thing sane enough to fly, you think? | |
| 13:39:47 | gtema | yeah, was looking at both today morning. Looked ok for me. If mordred also thinks ok - great | |
| 13:40:00 | mordred | efried: reading that now | |
| 13:41:03 | efried | mordred: One tweak in the reno, I'll fix that up quick if you agree. | |
| 13:41:49 | mordred | efried: I'm sure I do - looking | |
| 13:42:38 | efried | I mean, yes, you're using the CloudRegion to create a Connection, not sure if a CloudRegion is good for anything else, so maybe this is a distinction without a difference. | |
| 13:42:39 | mordred | efried: yes. also - maybe it should be Connection or CloudRegion - because while you're right the primary thing is the CloudRegion- we also added a parameter to the Connection contructor | |
| 13:43:01 | mordred | who knows what people are using CloudRegions for :) | |
| 13:44:12 | efried | oh, sorry, you're right. Forest for the trees and all that. The primary use case would be Connection I guess, wouldn't it. | |
| 13:45:22 | mordred | yeah. I could go either way ... | |
| 13:45:45 | mordred | efried: what does "ddt this" mean? | |
| 13:45:46 | efried | I'll leave it alone, since we've got gtema's +2 now :) | |
| 13:46:02 | gtema | I can put another one - no problem | |
| 13:46:03 | mordred | :) | |
| 13:46:16 | efried | mordred: ddt does the same thing as testscenarios | |
| 13:46:44 | mordred | ah. is it more pleasant to use? | |
| 13:46:54 | gtema | but guys, what have you done with "/os-server-groups" with respect to microversions - all the finest things at once | |
| 13:47:17 | efried | mordred: That's probably in the eye of the beholder. Let me dig up an example quick... | |
| 13:47:32 | efried | mordred: I don't know if testscenarios works on a per-method basis; ddt does. | |
| 13:47:44 | mordred | efried: cool - I like testscenarios - but I always have to go look at previous code I wrote to figure out how to use it | |
| 13:47:54 | mordred | ah - no - testscenarios is purely class based | |
| 13:47:55 | efried | ditto ddt | |
| 13:47:56 | gtema | ++ - same for me | |
| 13:48:49 | mordred | I like the concept of putting test data into a file too | |
| 13:49:24 | efried | mordred: https://opendev.org/openstack/nova/src/branch/master/nova/tests/unit/test_nova_manage.py#L1339 | |
| 13:49:54 | efried | The data gets passed to the method as params | |
| 13:49:59 | mordred | I like that | |
| 13:50:15 | mordred | that's nicer than class attributes, which I think is a bit too magical | |
| 13:50:29 | efried | vs testscenarios where they're instance vars, but of course that difference makes sense when it's per-test | |
| 13:51:04 | efried | yeah, but it would be just as magical if they were method params, set up from the class level, wouldn't it? | |
| 13:51:21 | efried | like using a @mock.patch decorator on your class, all your methods now get a new param. | |
| 13:51:49 | mordred | oh - I don't think I've ever used mock.patch on a class :) | |
| 13:52:19 | mordred | I guess I like that in ddt the magic is localized to the method you're looking at ... but yeah, still some magic | |
| 13:52:47 | efried | I usually don't (use mock.patch on a class). If I need it to apply to all my tests, I'll useFixture(fixtures.MockPatch()) in setUp - and if I need the mock, I'll create an instance attribute :) | |
| 13:52:49 | mordred | I *really* like the file_data - I've done a few testscenarios with a BUNCH of scenarios and it quickly becomes hard to read | |
| 13:52:57 | efried | ^ manual testscenarios :) | |
| 13:53:05 | mordred | ++ to useFixture in setUp | |
| 13:54:42 | efried | ahem, "guitar" | |
| 13:54:58 | mordred | yes yes. "guitar". sorry | |
| 13:55:09 | efried | but the point of the comment was: dedup this repetitive code | |
| 13:55:21 | efried | I don't care if it's ddt or testscenarios or a helper method, whatevs. | |
| 14:00:01 | mordred | ++ | |
| 14:05:50 | openstackgerrit | Eric Fried proposed openstack/openstacksdk master: Get rid of unused _OpenStackCloudMixin.get_region https://review.opendev.org/663038 | |
| 14:20:07 | gtema | mordred: I forgot a bit about ver discovery. In the service catalog endpoint contains project_id at the end, but version info is available under compute/v2.1 | |
| 14:20:23 | gtema | the proxy is not able to discover supported microversion | |
| 14:21:11 | mordred | gtema: version discovery should be able to handle project_id at the end of endpoint | |
| 14:21:51 | gtema | well, in the small script it is not working properly | |
| 14:22:44 | gtema | wait a sec, posting | |
| 14:24:03 | gtema | mordred: http://paste.openstack.org/show/752487/ | |
| 14:24:43 | mordred | oh - you have a broken compute endpoint. it's requiring auth for version discovery | |
| 14:25:04 | mordred | see that first GET with the 401 | |
| 14:25:20 | gtema | oh, indeed | |
| 14:26:05 | mordred | I think we've got it written down somewhere that people should not auth-protect service version discovery - I don't remember where though | |
| 14:26:50 | efried | I remember this ^ but not sure if it's written | |
| 14:26:55 | gtema | hmm, ok then. Will start alerting internally on all available channels | |
| 14:27:08 | efried | It's written in IRC :) | |
| 14:27:12 | mordred | efried: :) | |
| 14:27:16 | gtema | life is great ;-/ | |
| 14:28:21 | mordred | gtema: let me know if I can be helpful in corroborating that this should not be auth-protected. | |
| 14:28:30 | mordred | s/should/must/ | |
| 14:29:40 | gtema | we probably should add it into https://opendev.org/openstack/api-sig/src/branch/master/guidelines/microversion_specification.rst | |
| 14:31:05 | mordred | gtema: yah. it's possible it's mentioned in https://review.opendev.org/#/c/459405/ - looking | |
| 14:31:18 | efried | ++. I was looking for it in the keystoneauth docs, but that's the consuming side, so probably not the right place anyway. | |
| 14:32:33 | mordred | https://review.opendev.org/#/c/459405/ | |
| 14:32:52 | mordred | https://review.opendev.org/#/c/459710/17/guidelines/discoverability.rst@93 | |
| 14:33:38 | gtema | hmm, 'it is recommended' is confusing. It is definitely not working at all otherwise | |
| 14:35:18 | efried | it's possible to make it work, I suppose. "strongly recommended"? ;P | |
| 14:35:32 | gtema | :D | |