Earlier  
Later
New Search
Posted Nick Remark
#openstack-sdks - 2019-05-29
02:30:15 openstackgerrit jacky06 proposed openstack/keystoneauth master: Replace git.openstack.org URLs with opendev.org URLs https://review.opendev.org/655016
08:39:51 openstackgerrit Andreas Jaeger proposed openstack/openstackclient master: Remove pbrx https://review.opendev.org/661914
11:55:19 openstackgerrit Akihiro Motoki proposed openstack/openstackclient master: Update sphinx dependency for python 2.7 https://review.opendev.org/661947
12:40:24 AJaeger mordred: for fixing openstackclient, you need to fix sphinx first - see https://review.opendev.org/#/c/661947/ and then the py27 bug in there ;(
12:56:14 AJaeger amotoki, mordred, I pushed a change on top of 661947. Interesting, you do not publish docs - is that intentional?
13:02:55 openstackgerrit Andreas Jaeger proposed openstack/openstackclient master: Update sphinx dependency for python 2.7 https://review.opendev.org/661947
13:02:55 openstackgerrit Andreas Jaeger proposed openstack/openstackclient master: Switch to openstackdocstheme https://review.opendev.org/661974
13:03:06 AJaeger amotoki: updated your change
13:08:10 elmiko cmurphy: in answer to your last question, when i went to look back through the comments on the initial guideline proposal, it /looked/ lke someone had posted an example of returning multiple errors to a single call. outside of that though, i don't have an example at the ready.
13:23:43 openstackgerrit Andreas Jaeger proposed openstack/openstackclient master: Update sphinx dependency for python 2.7 https://review.opendev.org/661947
13:23:44 openstackgerrit Andreas Jaeger proposed openstack/openstackclient master: Switch to openstackdocstheme https://review.opendev.org/661974
13:57:05 AJaeger mordred, dtroyer, so https://review.opendev.org/661947 fixes all the failures that openstackclient currently has and is the next change you need to merge...
13:59:17 amotoki AJaeger: thanks for the update. As you pointed, we need to check the necessity of doc dependency and I will check it, but it looks good to merge 661947 first as it affects various changes.
14:00:42 AJaeger amotoki: yes, we can discuss 661974 separately. Please discuss whether you want to publish docs, only build them - or just take the change without jobs to install less packages ;)
14:50:30 cmurphy elmiko: what i still find strange is that this would all be stuffed into the body of a single response, while the actual http response would only have one error code
14:51:13 cmurphy it looks like rfc 7230 says that multiple responses could be returned for a single request but that's not how i read the guideline
15:23:15 elmiko cmurphy: i think you are right that it does seem odd for the http request to return a single error, but the body could express multiple internal errors
15:23:43 elmiko and i would imagine in most cases the error in the body would reflect a single error about the return code
15:24:15 elmiko if memory serves me correctly, and it might not, i think the idea was that a 500 error could expose more internal detail through this mechanism
15:24:28 elmiko obviously for something like 404 it doesn't make much sense
15:25:14 elmiko and yeah, i think the intent in 7230 is different than what we are describing in the guideline
16:01:06 cdent cmurphy, elmiko: the goal, as I remember, is to encapsulate the fact that there could be a suite of several system errors that led up to a particular http error, and knowing both is desirable, thus the sepraration between and status and code
16:01:14 cdent and yeah 7230 is something else
16:01:33 cdent not that I'm trying to defend the guideline. I've always thought it a bit weird, just trying to dredge up the reasons
16:02:39 openstackgerrit Clark Boylan proposed openstack/python-openstackclient master: Replace pkg_resources with importlib-metadata https://review.opendev.org/661856
16:09:47 cmurphy as i said in the thread i don't mind patching keystoneauth to conform to the guideline, i just think the guideline is weird
16:18:26 elmiko cmurphy cdent, for clarity sake, i'm not trying to defend the guideline either, and it may in fact be weird.
16:18:51 elmiko this does provide an excellent opportunity to reflect on how we might change things when turn out to not make sense
16:19:23 elmiko i'm curious if we need to re-open that guideline and discuss it again if it turns out that a majority think it's weird and will probably never implement it
16:20:06 cdent i suspect, unfortunately, that now that implementations of multiple styles are lose in the wild, we need to support them both forever
16:20:33 cdent because though we've been willing to say that message in errors are okay to change whenever, changing their structure probably less so
16:59:00 openstackgerrit Merged openstack/keystoneauth master: Resolves a typo in a link to use Application Credentials https://review.opendev.org/660886
18:45:09 openstackgerrit Merged openstack/keystoneauth master: Replace git.openstack.org URLs with opendev.org URLs https://review.opendev.org/655016
18:50:20 mordred if cdent was here, I'd say "of course, there are multiple forms of error payloads, so some things, like openstacksdk for instance, just do a shotgun approach and try their best to find some structure that might have error information in it"
#openstack-sdks - 2019-05-30
14:01:31 ITD27M01 mordred: I really need your attention. If you have a minute, look at the https://github.com/ansible/ansible/pull/51401
16:00:03 elmiko API SIG office hour is now open! \o/
16:00:03 edleafe Welcome to the API-SIG Office Hour!
16:00:08 elmiko jinx!
16:00:11 edleafe Heh, you beat me!
16:00:25 elmiko it was like simultaneous on my end lol
16:01:34 edleafe Mine got recorded first here: https://leafe.com/timeline-middle/%23openstack-sdks/2019-05-30T16:00:03
16:01:41 edleafe So we both win!
16:01:52 elmiko hahaha, amazing
16:15:23 cdent I lost track, did the errors guidelines discussion go anywhere?
16:15:56 edleafe There was a little async back-and-forth in this channel, but it didn't really go anywhere
16:16:09 elmiko ++
16:16:12 cmurphy o/
16:16:39 cmurphy i don't think there's much more to discuss, it is what it is
16:16:56 edleafe cdent: Starting here: https://leafe.com/timeline-middle/%23openstack-sdks/2019-05-23T20:34:53
16:18:53 cdent is there a next step?
16:19:17 elmiko unless we are going to rewrite the guideline, i don't think so
16:19:32 cdent potentially a patch to keystoneauth?
16:19:38 elmiko that might be nice
16:19:58 elmiko i have some time, i could take a look at patching it
16:20:17 cdent you have time? I guess that's what happens when you work on something oher than openstack ;)
16:20:34 elmiko yeah... plus when weird things happen to your group internally ;)
16:27:19 nwilburn I found an issue with the add_ip_list function in opestack/cloud/openstackcloud.py. Basically nat_destination is not being passed to the _attach_ip_to_server function which causes issues with Ansible's os_floating_ip module (and probably other things). The immediate "fix" that I can see is to simply add a parameter "nat_destination" for add_ip_list, but this probably isn't the right way of doing
16:27:25 nwilburn things.
16:27:27 nwilburn Where is the best place to submit a bug report for this?
16:30:35 nwilburn Apologies, it now lives in openstack/cloud/_floating_ip.py
16:33:52 elmiko nwilburn: is that part of the sdk package?
16:35:03 nwilburn It is
16:35:20 elmiko hmm, maybe mordred knows
16:35:50 elmiko at a guess, i would think here https://opendev.org/openstack/openstacksdk
16:35:54 elmiko but i'm not 100% sure on that
16:36:11 nwilburn Ok thanks
16:36:21 elmiko don't quote me on that though ;)
16:40:58 elmiko edleafe: it's been awhile since i've made pr's to openstack projects, do i want to be cloning from opendev and the using the standard `git review` mechanics?
16:46:54 Shrews nwilburn: are you setting nat_destination in your cloud.yaml file?
16:46:54 edleafe elmiko: I clone from github, and then use `git review`
16:47:04 elmiko ack, thanks!
16:47:55 nwilburn Shrews: nat_destination is being passed in via the os_floating_ip ansible module. It does make it to the function which calls add_ip_list, but add_ip_list doesn't take a parameter of nat_destination
16:48:38 Shrews nwilburn: ah, well that does sound like a bug
16:49:08 nwilburn So openstacksdk tries to be smart about discovering what the nat_destination should be and it goes through a list of openstack networks looking for the last one which is attached to the public network. When the ansible module is being ran with admin credentials this results in a network being found which isn't even in the project that the server is in. Super strange
16:49:42 Shrews indeed. floating ips and the surrounding logic is ... hard
16:50:18 nwilburn So I added nat_destination to add_ip_list and changes up the function args for the calls. Things worked but this isn't the right way of doing things since the list of floating ips you want to attach may need differenation nat_destinations. Maybe the ip_list should actually be a list of dicts with ip:nat_destination?
17:01:19 elmiko have a good weekend edleafe, i'm gonna take a look into patching keystoneauth o/
17:04:23 edleafe elmiko: \o
18:19:14 openstackgerrit Michael McCune proposed openstack/keystoneauth master: add handling for multiple error returns https://review.opendev.org/662281
18:26:55 openstackgerrit Michael McCune proposed openstack/keystoneauth master: add handling for multiple error returns https://review.opendev.org/662281
18:29:04 elmiko cmurphy: just a heads up ^^
18:30:17 cmurphy thanks elmiko
19:25:55 dtroyer elmiko: This doesn't affect what you are doing now, but cloning from Github has some dark corner-cases now that not everything is mirrored there from the current opendev repos. That will affect everything that moved out of the official openstack/ namespace but has not been moved in Github yet..
19:26:32 dtroyer All official project repos are unaffected by that AFAIK
19:44:06 elmiko dtroyer: ack, tyvm for the explanation. i defaulted to cloning from opendev =)
20:04:15 nwilburn So I added nat_destination to add_ip_list and changes up the function args for the calls. Things worked but this isn't the right way of doing things since the list of floating ips you want to attach may need differenation nat_destinations. Maybe the ip_list should actually be a list of dicts with ip:nat_destination?
20:04:23 nwilburn Oops sorry. Wrong window
20:15:38 elmiko we'll forgive you /this time/ nwilburn XD
21:36:18 openstackgerrit Michael McCune proposed openstack/keystoneauth master: add handling for multiple error returns https://review.opendev.org/662281
23:03:07 openstackgerrit Michael McCune proposed openstack/keystoneauth master: add handling for multiple error returns https://review.opendev.org/662281
23:03:39 openstackgerrit Michael McCune proposed openstack/keystoneauth master: add handling for multiple error returns https://review.opendev.org/662281
#openstack-sdks - 2019-05-31
05:39:29 openstackgerrit Brin Zhang proposed openstack/python-openstackclient master: Add changes-before attribute to server list https://review.opendev.org/657373
06:11:55 dtantsur mordred: hi! could you release the sdk in the near future?
07:35:14 ITD27M01 gtema: Hello! Are you online? Have you a few seconds for me?
07:35:36 gtema Hi, I am online, but pretty busy in next hour
07:36:32 ITD27M01 gtema: Well, just take a note to see the PR: https://github.com/ansible/ansible/pull/51401
07:36:42 gtema ok
07:36:47 ITD27M01 gtema: I really need your and mordred attention
07:36:53 gtema ok
10:18:42 openstackgerrit Artem Goncharov proposed openstack/openstacksdk master: Rework statistics reporting https://review.opendev.org/659841

Earlier   Later