| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-sdks - 2019-05-14 | |||
| 13:26:43 | efried | dustinc: If you're looking for more information on what the json payload should look like, I would start with the corresponding baremetal API: https://developer.openstack.org/api-ref/baremetal/?expanded=update-node-detail#update-node | |
| 13:27:16 | mordred | gtema: 3 of us is perfect :) | |
| 13:27:28 | gtema | we are nearly almighty | |
| 13:27:34 | mordred | nearly | |
| 13:27:35 | gtema | :D | |
| 13:27:38 | efried | (which, mordred/dtantsur/gtema, would be a good thing to link from any of these proxy methods) | |
| 13:27:49 | efried | (especially the ones that have **kwargs) | |
| 13:27:51 | gtema | for baremetal its dtantsur | |
| 13:27:53 | mordred | efried: I agree - that's not a ba idea at all | |
| 13:29:27 | efried | prolly not | |
| 13:29:38 | efried | since it's in another repo | |
| 13:29:48 | efried | I was thinking of the :oslo.config:`group.option` role | |
| 13:30:02 | efried | but that only works in same repo | |
| 13:31:26 | mordred | yeah - there's ways to do fancy sphinx stuff with multi-repo external links and stuff - and connecting that with zuul for multi-repo source might be neat - but it's also probably easier to just put the links in for now | |
| 13:31:51 | mordred | I could see us easily getting so clever we don't understand how to write docs anymore | |
| 13:32:52 | gtema | ++ | |
| 13:33:10 | efried | I thought we had already passed that point. | |
| 13:33:23 | efried | only stephenfin knows how to write docs | |
| 13:33:26 | efried | job security | |
| 13:33:50 | stephenfin | /o/ | |
| 13:33:53 | stephenfin | \o\ | |
| 13:34:30 | mordred | efried: does that mean stephenfin will write all my docs for me? neat! | |
| 13:34:47 | stephenfin | efried: It could be done by building on top of intersphinx | |
| 13:35:00 | stephenfin | but whether it's important enough is another matter | |
| 13:37:10 | efried | considering we should ideally do it for every proxy method, and probably a bunch of the others, it would be nice if it happened automatically without any input. Like introspected something about the method. Like if we (already) had decorators on the methods indicating which operation they invoke. But we don't. So we'd have to add something to each method anyway. Or something more convoluted like a centralized mapping. | |
| 13:37:23 | efried | so if we're going to do something manual to each method anyway, might as well be adding the actual link. | |
| 13:37:32 | efried | except... | |
| 13:37:38 | dustinc | efried mordred thanks I’m in and out next couple hours but will check that out. | |
| 13:37:40 | efried | stephenfin: how do I noqa a docstring? | |
| 13:39:52 | dustinc | And by spec I meant blueprint so I could use it to find the change so all is good. Thanks! | |
| 13:40:36 | efried | dustinc: You can use some git tricks to find the change, lmk if you want to go over that. | |
| 13:40:56 | stephenfin | """Some string. | |
| 13:40:57 | stephenfin | ||
| 13:41:00 | stephenfin | More stuff. | |
| 13:41:03 | stephenfin | """ # noqa | |
| 13:41:08 | stephenfin | ^ efried (I think) | |
| 13:41:11 | efried | ah, /me tries... | |
| 13:42:06 | gtema | efried, dustinc, do you need placement support in sdk? | |
| 13:42:07 | efried | stephenfin: nope :( | |
| 13:42:20 | efried | gtema: It's already there, proxy-wise. | |
| 13:42:39 | efried | gtema: Other than something broken in the dep chain, this works: https://review.opendev.org/656023 | |
| 13:42:39 | stephenfin | Then I have no idea, I'm afraid. I assume it's the line length thing that's causing issues? | |
| 13:42:55 | efried | stephenfin: Yes, I have a hyperlink in the docstring and the hyperlink is >80c by itself. | |
| 13:43:13 | stephenfin | You could manually wrap inside the docstring. It would make for uglier code but keep flake8 happy | |
| 13:43:19 | stephenfin | Otherwise, use a URL shortner? | |
| 13:43:22 | efried | backslash? | |
| 13:43:23 | gtema | efried: I mean in a normal sdk way (with resources and refular proxy methods) | |
| 13:43:34 | gtema | s/refular/regular/ | |
| 13:43:53 | efried | gtema: I think we've talked about it before and decided it's not worth it, at least for now. | |
| 13:44:04 | gtema | ok, thks | |
| 13:44:17 | efried | gtema: It could be kinda neat, but the straight up APIs are pretty easy to use as is. | |
| 13:44:40 | gtema | that's good | |
| 13:44:59 | efried | Feel like if people have that kind of time, there's more important things to be done :) | |
| 13:45:13 | efried | like figuring out how to put long hyperlinks into the docstrings | |
| 13:45:15 | gtema | :) | |
| 13:46:54 | efried | stephenfin: backslash-wrapping works, and isn't *too* hideous. Thanks. | |
| 13:48:15 | efried | ahcrap. The pep8 error I was getting, it wasn't even in the docstring I was messing with. | |
| 13:48:40 | mordred | efried: BOW DOWN TO THE PEP8 GODS | |
| 13:51:36 | openstackgerrit | Eric Fried proposed openstack/openstacksdk master: Link to baremetal API reference from patch_node https://review.opendev.org/659068 | |
| 13:51:45 | efried | mordred, gtema, dtantsur: Toe in the water ^ | |
| 13:52:03 | efried | if that flies, more can be done | |
| 13:54:18 | mordred | efried: ++ | |
| 13:54:57 | gtema | efried: ++ from me as well | |
| 13:55:00 | efried | stephenfin: there was no pep8 error on long link in docstring. I was seeing things. | |
| 13:55:11 | efried | and it's not because we're ignoring H4 either. | |
| 13:55:31 | efried | Perhaps it's just smart enough to realize that a link doesn't count. | |
| 16:49:39 | openstackgerrit | Surya Seetharaman proposed openstack/python-openstackclient master: Microversion 2.73: Support adding the reason behind a server lock https://review.opendev.org/659124 | |
| 20:42:03 | cdent | mordred: we talked about this for and I've managed to forget: you added a command somewhere to list the versions of all the apis configured in the catalog. I've forgotten where you put it. | |
| #openstack-sdks - 2019-05-15 | |||
| 04:17:30 | adriant | mordred: when are we likely to get a 0.28.0 SDK release? | |
| 08:36:14 | dtantsur | adriant: it has been requested, waiting for the release team to catch up | |
| 09:01:45 | mordred | adriant: what dtantsur said | |
| 09:28:36 | openstackgerrit | Surya Seetharaman proposed openstack/python-openstackclient master: Microversion 2.73: Support adding the reason behind a server lock https://review.opendev.org/659124 | |
| 12:14:05 | openstackgerrit | Natal Ngétal proposed openstack/python-openstackclient master: Update sphinx requirement. https://review.opendev.org/659279 | |
| 16:07:01 | mordred | cdent: did you get my tweet answer to your question? | |
| 16:08:00 | cdent | mordred: yes, thanks for that. I had also figured it out in the interim by doing some searching of my sent email. the initial struggle was not being sure how/what to search that wasn't going to return many results. In the end it was found by searching on the person it was sent to. | |
| 16:08:35 | mordred | \o/ | |
| 16:08:41 | mordred | humans are the problem - and the solution | |
| 16:10:58 | cdent | amazing that... | |
| 16:20:21 | openstackgerrit | Merged openstack/openstacksdk master: Link to baremetal API reference from patch_node https://review.opendev.org/659068 | |
| 17:23:00 | openstackgerrit | Surya Seetharaman proposed openstack/python-openstackclient master: Microversion 2.73: Support adding the reason behind a server lock https://review.opendev.org/659124 | |
| 19:26:02 | openstackgerrit | Raimund Hook (stingrayza) proposed openstack/openstacksdk master: Adding dns_domain parameter into create_network https://review.opendev.org/659366 | |
| 20:55:35 | mriedem | dtroyer: how does one go about deprecation an option in osc? are there examples? is it just something in the help text of the option and dump something to the console if it's used? | |
| 21:02:04 | dtroyer | mriedem: deprecating options is mostly a manual bit, here is an example from volume transfer request: https://opendev.org/openstack/python-openstackclient/src/branch/master/openstackclient/volume/v2/volume_transfer_request.py#L69 | |
| 21:03:10 | dtroyer | (for completeness) deprecating commands is more built-in, example from the old volume backup: https://opendev.org/openstack/python-openstackclient/src/branch/master/openstackclient/volume/v2/backup.py#L162 | |
| 21:03:47 | dtroyer | That one specifically is how we renamed a command | |
| 21:14:29 | mriedem | ok i'll crank this out and see what i can do | |
| 22:04:02 | openstackgerrit | Matt Riedemann proposed openstack/python-openstackclient master: WIP: Deprecate openstack server migrate --host option https://review.opendev.org/659382 | |
| 22:04:40 | mriedem | dtroyer: stephenfin: mordred: ok ^ is my stab at a fix for the live migration kerfuffle - needs tests but that's my idea anyway | |
| 22:18:23 | mriedem | i think https://review.opendev.org/#/c/460059/ can be abandoned now | |
| 22:49:05 | openstackgerrit | Merged openstack/python-openstackclient master: Stop leaving temp files after unit test runs https://review.opendev.org/658190 | |
| #openstack-sdks - 2019-05-16 | |||
| 00:35:30 | openstackgerrit | Dean Troyer proposed openstack/python-openstackclient master: Remove deprecated stuff - Volume https://review.opendev.org/659399 | |
| 00:35:31 | openstackgerrit | Dean Troyer proposed openstack/python-openstackclient master: Remove deprecated stuff - Network https://review.opendev.org/659400 | |
| 01:23:52 | openstackgerrit | Xuan Yandong proposed openstack-dev/os-http master: Change the author-email openstack-dev to openstack-discuss https://review.opendev.org/659403 | |
| 01:43:45 | openstackgerrit | ZhouHeng proposed openstack/python-openstackclient master: openstack port create support --extra-dhcp-option https://review.opendev.org/657519 | |
| 01:53:22 | openstackgerrit | Dean Troyer proposed openstack/python-openstackclient master: Remove deprecated stuff - Network https://review.opendev.org/659400 | |
| 01:53:22 | openstackgerrit | Dean Troyer proposed openstack/python-openstackclient master: Remove deprecated stuff - Volume https://review.opendev.org/659399 | |
| 01:53:23 | openstackgerrit | Dean Troyer proposed openstack/python-openstackclient master: Remove deprecated stuff - Compute https://review.opendev.org/659416 | |
| 01:55:57 | openstackgerrit | Dean Troyer proposed openstack/python-openstackclient master: Remove deprecated stuff - Compute https://review.opendev.org/659416 | |
| 01:55:57 | openstackgerrit | Dean Troyer proposed openstack/python-openstackclient master: Remove deprecated stuff - Network https://review.opendev.org/659400 | |
| 01:55:58 | openstackgerrit | Dean Troyer proposed openstack/python-openstackclient master: Remove deprecated stuff - Volume https://review.opendev.org/659399 | |